Revision 5c5d87f...

Go back to digest for 3rd November 2013

Optimization in KDE Base

Frank Reininghaus committed changes in [kde-baseapps] /src:

Store the selected items in a more efficient way

Since Dolphin 2.0, we have stored the selected items in a QSet<int>,
which is neither space-efficient nor particularly fast when inserting
many items which are in a consecutive range.

This commit replaces the QSet<int> by a new class "KItemSet", which
stores the items in a sorted list of ranges. For each range, we only
store the first index and the length of the range, so we need a lot
less memory for most common selection patterns, and we also save quite
a few CPU cycles in many situations, because adding an item to the
KItemSet will in many cases not need a memory allocation at all, and
it's particularly easy when inserting sorted items into the KItemSet in
a row.

KItemSet contains a minimal subset of QSet's API which makes it
suitable as a drop-in replacement for our needs. It also has iterators,
such that the items can be iterated through easily, also with foreach.
One advantage of KItemSet compared to QSet<int> is that the items are
always iterated through in ascending order.

REVIEW: 113488

File Changes

Added 3 files
  • /src
  •   dolphin/kitemviews/kitemset.cpp
  •   dolphin/kitemviews/kitemset.h
  •   dolphin/tests/kitemsettest.cpp
Modified 23 files
  • /src
  •   dolphin/CMakeLists.txt
  •   dolphin/kitemviews/kfileitemlistview.cpp
  •   dolphin/kitemviews/kfileitemlistview.h
  •   dolphin/kitemviews/kfileitemmodel.cpp
  •   dolphin/kitemviews/kfileitemmodel.h
  •   dolphin/kitemviews/kitemlistcontroller.cpp
  •   dolphin/kitemviews/kitemlistcontroller.h
  •   dolphin/kitemviews/kitemlistselectionmanager.cpp
  •   dolphin/kitemviews/kitemlistselectionmanager.h
  •   dolphin/kitemviews/kitemlistview.cpp
  •   dolphin/kitemviews/kitemlistview.h
  •   dolphin/kitemviews/kitemlistviewaccessible.cpp
  •   dolphin/kitemviews/kitemmodelbase.cpp
  •   dolphin/kitemviews/kitemmodelbase.h
  •   dolphin/kitemviews/kstandarditemmodel.cpp
  •   dolphin/kitemviews/kstandarditemmodel.h
  •   dolphin/tests/CMakeLists.txt
  •   dolphin/tests/kitemlistcontrollertest.cpp
  •   dolphin/tests/kitemlistselectionmanagertest.cpp
  •   dolphin/views/dolphinview.cpp
  •   dolphin/views/dolphinview.h
  •   dolphin/panels/places/placesitemmodel.cpp
  •   dolphin/panels/places/placesitemmodel.h
26 files changed in total