Revision 5f9c3a8...

Go back to digest for 15th December 2013

Features in KDE Base

Martin Gräßlin committed changes in [kde-workspace] /:

[kwin/tabbox] Use a QmlComponent instead of a QQuickView for TabBox

By not using a QQuickView it becomes possible to just use a
PlasmaCore.Dialog or a Quick.Window in the TabBox qml and thus it's
possible to simplify the qml code.

To support this a new SwitcherItem is introduced and exported to QML.
It's a simple QObject providing all the properties which used to be
exported to the root context. A declarative TabBox is expected to
use one of these items. The C++ side finds the Switcher and for that
supports the case that the SwitcherItem is the rootItem or a child

A declarative TabBox has also to create a QQuickWindow, e.g. a
PlasmaCore.Dialog. The visibility of that window should be controlled
through the visible property on the SwitcherItem. The underlying C++
implementation assumes that a TabBox only uses one window (it needs to
get destroyed once it's hidden and included in highlight windows).

Thanks to this change it's no longer needed to reload the TabBox
whenever it gets shown or the alternative TabBox gets shown. Instead
the same QML script can get reused. Other created switchers are ignored
as the visible property won't be changed to true.

File Changes

Added 2 files
  • /tabbox
  •   kwin/switcheritem.cpp
  •   kwin/switcheritem.h
Modified 2 files
  •   kwin/CMakeLists.txt
  •   kwin/tabbox/tabboxhandler.cpp
4 files changed in total