Revision 43246c5...

Go back to digest for 5th January 2014

Features in Graphics

Albert Astals Cid committed changes in [okular] /:

Viewport transition refinements for Find and Undo/Redo actions

REVIEW: 114060

This patch introduces viewport transitions for undo/redo actions on annotations and forms. When an annotation/form action is undone/redone but the associated annotation/form is not currently visible, the viewport is updated to center on the undo/redo action. If the annotation/form is visible, the viewport is not updated.

The viewport transitions for the Find action have also been updated to this same algorithm. Previously the viewport was moved to center on each matching search term even if the search term was already visible in the viewport. This lead to unnecessary viewport transitions if the search term matched several items in a single paragraph for example.

These proposed changes to the viewport transition behavior are consistent with the find and undo behavior of many existing applications including Kate, Open Office, and Foxit PDF Reader.

File Changes

Modified 7 files
  •   core/document.cpp
  •   core/document_p.h
  •   core/documentcommands.cpp
  •   core/documentcommands_p.h
  •   core/page.cpp
  •   core/utils.cpp
  •   core/utils_p.h
7 files changed in total