Revision 9adbd05...

Go back to digest for 12th January 2014

Bug Fixes in Graphics

Albert Astals Cid committed changes in [okular/KDE/4.12] core/document.cpp:

Do not resetSearch if we're closing down

It's useless as it will be reset anyway on the close down procedure
and it will cause a crash if you are unlucky.

* In the document observers qset pageview comes before
* We are closing and notifySetup with an empty vector
* pageview empties its vector in notifySetip
* part sees the notifySetup and resets the search
* resetting the search calls another notifySetup with the non empty page vector
that will be deleted asap when we go back to the first notifySetup

There are another billion ways to fix this:
* Don't allow nested notifySetup
* Clear the running searches before sending the first notifySetup
* Empty the pagesVector before sending the first notifySetup
* etc

But i feel this is the less invasive one (even if it may not be the most technically correct)

FIXED-IN: 4.12.1

File Changes

Modified 1 files
  • core/document.cpp
1 files changed in total