Issue 333
30th March 2014 by KDE Commit-Digest TeamContributors
Marta Rybczynska
Alex Fikl
Giacomo Barazzetti
Danny Allen
This Week...
Statistics
Commits | 2257 by 161 developers |
Open Bugs | 21915 |
Open Wishes | 16045 |
Bugs Opened | 305 in the last 7 days |
Bugs Closed | 194 in the last 7 days |
Commit Summary
Module | Commits |
/trunk/l10n-kde4 |
201
|
/trunk/l10n-support |
88
|
/branches/stable |
65
|
/tags/KDE |
63
|
/src/Messages.sh |
49
|
/trunk/www |
20
|
/src/part |
19
|
/src/file |
16
|
/plasma-workspace/applets |
11
|
/src/lib |
10
|
Files | Developer | Commits |
315
|
Christophe Giboudeaux |
125
|
258
|
Laurent Montel |
113
|
282
|
David Faure |
95
|
237
|
Albert Astals Cid |
84
|
231
|
Alex Fiestas |
81
|
231
|
Alex Merry |
80
|
210
|
Aurélien Gâteau |
70
|
144
|
Vishesh Handa |
50
|
132
|
Marco Martin |
46
|
135
|
Burkhard Lück |
45
|
Internationalization (i18n) Status
Language | Percentage Complete |
Polish (pl) |
100%
|
Ukrainian (uk) |
100%
|
Swedish (sv) |
99%
|
Brazilian Portuguese (pt_BR) |
99%
|
German (de) |
99%
|
French (fr) |
97%
|
Dutch (nl) |
97%
|
Spanish (es) |
96%
|
Bosnian (bs) |
94%
|
Italian (it) |
91%
|
Bug Killers
Person | Bugs Closed |
Christoph Feck |
25
|
Marco Martin |
14
|
David Edmundson |
12
|
Jekyll Wu |
11
|
Bhushan Shah |
9
|
Martin Gräßlin |
8
|
Harald Sitter |
7
|
Dmitry Kazakov |
6
|
Thomas Lübking |
6
|
Vishesh Handa |
6
|
Commit Countries
Commit Demographics
Sex
Age
Contents
Bug Fixes | Features | Optimization | Security | Other | |
---|---|---|---|---|---|
Accessibility | |||||
Development Tools | [] | ||||
Educational | [] | [] | [] | [] | |
Graphics | [] | ||||
KDE Base | [] | [] | [] | [] | |
KDE-PIM | [] | [] | [] | ||
Office | [] | [] | [] | ||
Konqueror | |||||
Multimedia | [] | ||||
Networking Tools | [] | [] | |||
User Interface | [] | [] | [] | ||
Utilities | |||||
Games | [] | [] | |||
Other | [] | [] |
There are 74 selections this week
Bug Fixes
Educational
Do not filter mouse press/release events.
This reverts c4e0678. Please test for possible regressions, especially
the one noted in bug 242414 (when using oxygen, dragging the map moves
the whole window).
KDE Base
Do not use WId in KCookieServer
KCookieServer is exposed over DBus and DBus does not know about WId. This
prevents the methods using WId arguments from being exposed, breaking khtml
build.
REVIEW: 117107
When you open a new tab while the search mode is enabled, the
newly opened tab also starts the same search (Because new tab is opened with
the current view url), but the search box is in read-only mode. So you cannot
close the search bar nor edit the search text.
This patch fixes this by parsing the search url. The value of the "search"
parameter is used as search text and the value of the "url" parameter is used
for the search path ("root" folder for the search when "Search from here" mode
is enabled).
In case of Baloo search urls, we use Baloo::Query::fromSearchUrl.
Removed everything related to read only mode in DolphinSearchBox, not needed
anymore.
REVIEW: 111968
FIXED-IN: 4.13.0
Show device notifier only when device is present.
Avoid unnecessary automounting in KDiskFreeSpaceInfo::freeSpaceInfo
Previously, all unmounted autofs mountpoints were always mounted
by krunner/plasma-desktop on startup, defeating the purpose of
automounting. Let's ignore the unmounted filesystems instead when
gathering free space stats, just like the "df" utility does.
Everything still gets mounted properly on first real access.
v2: Use directory size instead of hardcoded "autofs" type
REVIEW:117044
Stop the slider's timer when the applet is hidden
When the applet gets shown again, we query the player again for the
current position and set the slider to that
Make installation of theme packages work
Hook up q QProcess plasmapkg2 with the file dialog. With this commit, I
can reliably install a theme from the desktop theme KCM.
Fix minimum size on the Applet Handle
- center align the noBackgroundHandle and obey the minimumHeight
- made the mouse event listener that controls whether to show the
handle separate from the size of the applet, so we can still reach the
controls when the applet is smaller than the handle
setup desktopgrid for screencount change
prevents segfaults..
REVIEW: 117067
vimode: fixed crash when joining lines that do not fit a static word wrap.
REVIEW: 117029
Fix process list to start already sorted
FIXED-IN: 4.11.8
REVIEW: 113931
Fix the initial size of the KCMs
Both KCMs had a hard coded default which is obviously bad. Instead we
now calculate a useable implicitWidth and implicitHeight and use this
as the minimum size for the KCM. Which means we need also track changes
to these two root object properties and update the QWidget container
accordingly.
REVIEW: 117079
Don't include xkbcommon/xkbcommon.h in input.h, forward-declare instead
Some systems (e.g. openSuSE) don't install the xkbcommon header into
/usr/include/xkbcommon/xkbcommon.h (which is always in the include path),
but instead into a subdirectory, which is in the openSuSE case
/usr/include/pkg/libxkbcommon/xkbcommon/xkbcommon.h. This means that e.g.
kcm_kwinrules will not compile there since it includes input.h
REVIEW: 117069
KDE-PIM
IMAP: allow ']' when parsing an astring
The IMAP code would by mistake reject tokens that contain a resp-special
character ']' when asked for parsing astrings. This was because the of the rule:
ATOM-CHAR = <any CHAR except atom-specials> rule
...which confused me enough so that I ignored an explicit allowance for the
resp-specials earlier in the ASTRING-CHAR rule.
Thanks to Miguel (DeviantPeer on IRC) for reporting this.
Sorry for the trouble.
REVIEW: 117105
Fix 327549 hide encrypted.asc from Thunderbird encrypted messages.
simply thunderbird names the attachment, that is actually the encrypted
message filename=encrypted.asc; kmail names it msg.asc.
FIXED-IN: 4.12.5
REVIEW: 117163
Fix Bug 325565 - There is no way to quick search messages by status (new / unread / etc) without mouse
Fix 329269: Inline OpenPGP uses decryptMessage.
* Add tests
REVIEW: 117153
FIXED-IN:: 4.13.1
Avoid setting the Agent online if it needs network but there is none.
Without this patch an agent is online initially and only reacts to subsequent,
online status changes. This cause for example the imap resource to go online
when started without network connection (resulting in a wrong initial status),
and as the imap resource tried to connect and failed, it set itself to offline,
resulting in it not reacting to the network becoming available.
With this patch all network detection code can be removed from the imap resource
and it properly reacts to network changes.
REVIEW: 117008
IMAP-Resource: cancelTask on error and deferTask on connection error.
This way the resource retries if there was a temporary connection
problem and reports the problem instead of silently going offline.
Office
sketch: Rework new/open handling so things work correctly again
The new/open pages and components are now completely stateless, simply
emitting a signal with the file to open or the options for creating a
file. The WelcomePage and MainPage now completely handle what happens
when a new/open file action is triggered, with the MainPage being able
to show the modified dialog before we do anything.
Crash fix loading SignalWidget instance with empty text.
Do not change empty multiplicity values of associations on opening property dialog without request.
FIXED-IN:4.12.5
(cherry picked from commit 990970911bb5b08a5f435e562f46cb8f1d77b742)
Crash fix loading SignalWidget instance with empty text.
FIXED-IN:4.12.5
(cherry picked from commit 3fe88cb10c6e687a231bd20403efa32913ba673a)
Fix resetting the slider spinbox when double clicking on it
Double Click event must also generate a usual press event
Networking Tools
Do not spam the log with single download requests of metadata pieces
Each download request of metadata pieces was being registered
in the log, trashing it completely when the metadata size was big
enough (because it can mean the logging of thousands of lines).
Now, we only register the total number of metadata pieces that are being
requested.
User Interface
when the controller is open, force panel mode
force to "Windows can cover" when the controller is open: it's the least dangerous mode.
this also disables the struts while the controller is open, this makes panel resize faster
Means the behavior of struts disabling is *INTENDED*
Games
Fix a crash that happened when repeating the Game->Restart action.
Features
Educational
Using a much longer list of "small words"
as found on an OCLC site; those small words are
supposed to be removed from titles if the user
wishes so.
Add a KML tour for the moon which can be started from the legend
REVIEW: 116964
Graphics
Added feature to show imported image for comparison
KDE Base
IndexScheduler: Update everything when the config changes
During the nepomuk days doing an update was very expensive and we
therefore tried to update the minimum possible. This was hard to do and
was not perfect.
With Baloo we're fast enough to do a full scan on config changes.
Additionally the configuration does not really change very often.
Make the desktop scripting activity aware:
adapt the desktop scripting from the time when Containment == activity to creating actual activities
* activities() -> desktops()
* activityById() -> desktopById()
* activityForScreen() -> desktopForScreen()
To create a new activity, there is the new global function
createActivity(activtyName, containmentPlugin (optional))
when you want to access the actual containments created by the activity, you do
Array[containments] = desktopsForActivity(activityId)
Introduce a Baloo::XapianDatabase class
This is a light wrapper over the Xapian::Database class which add some
nice features such as combining a writable + read only db and adds many
convenience functions.
It also tries to catch all exceptions.
vimode: implemented the z., z<return>, zt, z-, zb commands.
REVIEW: 117130
KDE-PIM
IMAP-Resource: Async dialogs.
Async password request dialog that is aborted after disconnecting.
This properly aborts the dialog after the connection attempt is no longer relevant,
and avoids the stacking of dialogs.
The configuration dialog is also made async to avoid similar problems.
With this change the dialog appears at most once, and vanishes if the network is disconnected again.
Office
Add synchronous message support to collaboration diagrams.
(cherry picked from commit 31857d900a8b42626f0ec54561717d2aabdf9c15)
Add synchronous message support to collaboration diagrams.
Added support for the 'evdev' tablets
There are two complications:
1) In each event 'evdev' reports not all the axes preset, but
only recently changed ones, so we need to keep the state of all
the axes internally.
2) 'aiptek' tablet reports that it is a keyboard. Well, let us not
disappoit it that it is not. Now we just check whether this nice
"keyboard" supports xinput motion and proximity events.
,331572,329641
Move export to pdf to the export section instead of the print section
Yes, technically exporting to pdf is printing, but to the user it's
exporting, it's even called 'export'. This also makes the position conform
to libreoffice.
Add currently selected color indicator to popup palette
Patch by Koushik S. Thanks!
Add options to enable/disable double buffering and vsync
These options are hidden by default. Set showAdvancedOpenGLSettings to
true in the krita config file to see them. Disabling vsync and/or
double buffering causes crashes with some ATI cards, so these options
exist to experiment with those cards/driver combinations.
feature: Better date filtering in operation page
Make it possible to set slide effect on all slides
Multimedia
Fetch Artist, Album, Duration and Title metadata for music files
Networking Tools
KTp KDED Module: Implemented groups caching.
Implemented in most simple and short way. I hope, there is no significant flaws.
REVIEW: 116707
Read notifications ticker text from extras Bundle.
Many Apps don't set a useful ticker text. On Android version KitKat or
newer, the title and text of a notification is stored in the extras Bundle.
This patch make use of it, to provide a better ticker text.
User Interface
New default theme: welcome Breeze!
I for one welcome out new design overlords!
Games
Add say correct words feature.
Patch by Debjit Mondal
Add a new option to speak correct words.
New option is enabled by default.
If enabled correctly typed words are spoken by playing the associated sound file.
Reveal word also plays the sound file associated with a word.
Also some whitespace fixes in the changed files.
TODO: Add text to speech for words that don't have sound files associated with them.
REVIEW: 116771
Other
Add ECMCreateQmFromPoFiles.cmake
Simplifies translation handling for frameworks using Qt translation system.
REVIEW: 117052
Optimization
Educational
Rewriting WorldCat OCLC search to use SRW interface
which provides more information than the "open search"
KDE Base
It doesn't make sense to have these pam demo files anymore
Pam files are different for each distribution and we do not install
them so it makes little sense to continue having outdated files around
that might even confuse people.
Autostart Baloo in GNOME, Unity and XFCE
Baloo should always be running otherwise it will not pick up file
changes, specially moves.
sqlite: Enable WAL journaling mode
This decreases the number of writes we're doing by about half. With
about 11k files it goes down from 200mb to about 100mb.
This can be checked by running the basicindexingqueue test
Cleaner: Do faster mimetype detection
Otherwise we consume just way too much io
Stop re-loading values inside KCoreConfigSkeleton::save().
The extra load of values in KCoreConfigSkeleton is not documented anywhere
that it happens, and in normal circumstances re-loading new values isn't
expecterd during a save operation.
Update various mentions of readConfig/writeConfig to read/save.
Update documentation to match the new names of functions.
Rename writeConfig() to save() and usrWriteConfig() to usrSave()
Rename functions to match the new naming conventions. Also create old deprecated
instances of both functions to ensure that old code continues to operate
correctly. Also make save() non-virtual, for the same reasons read() is
now non-virtual.
Rename usrReadConfig to usrRead, to be consistent with the new name for readConfig.
Rename usrReadConfig to usrRead, and mark the former as deprecated. To maintain
compatibility, usrRead still calls usrReadConfig in its default implementation.
usrReadConfig remains empty.
REVIEW: 117010
BasicIndxingQueue: Determine the mimetype without looking into the file
Baloo indexing happens in two phases - Phase 1 (Basic) and Phase 2
(File). During phase 1 only the basic stat info + mimetype + xattr are
stored. During phase 2 the file's contents are indexed.
Currently phase 1 was also looking into the contents of the file to
determine the mimetype. This was causing very high IO usage during the
inital indexing. We now determine the mimetype only using the url, and
do a proper mimetype analysis in Phase 2.
DIGEST: Reduce io usage during initial indexing
FileMap Db: Do not set the id as auto-increment
When a column is set as auto-increment an additional table
sqlite_sequence is created which stores the highest rowid. From that
point a rowid < that number is not accepted. We do not care that the
rowids be always increasing. We just need them to be unique and that is
guarenteed.
This saves us a about 16 mb when running through the
basicindexingqueuetest for 11k files.
KCM: Remove developer mode
This also means that source code is now always indexed. A normal user
typically won't have any source code and the developers can always
exclude that folder from the list of excluded folder. It's way way more
efficient. Mimetype filtering is expensive.
This speeds up the first level indexing.
KDE-PIM
Don't load the whole calendar when displaying an attachment.
ItemFetchJob now can fetch by UID, so we don't need to load all
events and search for the incidence.
Saves memory and cpu.
Make PersonData monitor for merge/unmerges
Cope better with Akonadi failing to start
When Akonadi fails to start, we can detect it by watching for
org.freedesktop.Akonadi.Control.Lock service disappearing from DBus,
which means that akonadi_control has terminated and thus something
went wrong.
As a next step, we must abort all pending jobs, otherwise client
applications waiting for the job to finish will get stuck forever,
because the job will be waiting in Session for reply from the server.
REVIEW: 117144
ItemSync: Only fetch the items that are actually required.
ItemSync used to fetch *all* items during *every* sync, which is in most cases
completely unnecessary (at least for incremental sync). This patch delays the
fetch of items until we know which ones we need, and then only fetches the
required ones (usually none), resulting in an IMAP sync going from 10s 100%,
to a couple of seconds 1% cpu.
REVIEW: 117140
Handle Akonadi::Job errors in AllContactsMonitor
This patch will check for errors from Akonadi jobs and adds bool argument to
emitInitialFetchComplete() method to say whether the initial fetch was
successful, or a Job failed.
REVIEW: 117141
Office
Do not change empty multiplicity values of associations on opening property dialog without request.
Keep auto increment sequence support of collaboration diagrams in sync with sequence diagrams.
Other
Remove jobStarted() and jobDone() signals from Thread.
If progress tracking like that is needed, it can be added by using
decorators. Sending the signals from the threads run() loop has shown to
be a serious performance bottleneck.
Other
Development Tools
Set manpage plugin to be disabled by default
I have heard from several people now that it's insanely slow, the same
experience I had. This is fault of both the broken man KIO and the manpage
plugin, which uses the man KIO synchroneously and blocks the UI while it
is working. Until somebody fixes it, let's not load it by default because
it is hard to figure out what causes the slowness if it happens for a user.
Educational
Export 3D plots into X3D files
Makes it possible to use the X3D format for exporting surfaces.
KDE Base
Remove InternetGateway and UPnP backends
Nobody is using InternetGateway and all our upnp backends have been
broken. It is sad but it is what it is.
If somebody wants to work un upnp again (has not happened since
KDE 4.7 or so) is free to checkout the kdelibs version and rebase.
Add KIOPrivate::isProcessAlive() and KIOPrivate::sendTerminateSignal()
kill() does not work on Windows, therefore a WIN32 implementation is needed
in order to compile slave.cpp
KPasswdServer was moved to KIO
Remove Krunner
A new QML based runner exists in kde-workspace/krunner
Port kdesu away from KDE4Support
This way it can go together with the KF5::Su framework.
User Interface
Formats are now part of KDeclarative repo