Revision 697333a...

Go back to digest for 6th April 2014

Features in KDE-PIM

Jan Kundrát committed changes in [trojita] /Gui:

GUI: expand previewable attachments upon first click on the attachment icon

The motivation is to make expanding of previewable attachments smooth, but at
the same time do not interfere with the way how the button has worked so far too

When an attachment cannot be previewed, nothing changes and everything works as
it used to work before.

When a preview can be shown, however, clicking on the icon of the attachment at
the time the preview is collapsed will simply show the preview. When the preview
is shown, however, clicking any part of the icon will still bring up the menu as
it used to work previously.

This is an alternative implementation to review #117068.

v2: Use another approach for determining what action to take based on the actual
state of the preview in order to prevent duplicate connections. Thanks to Thomas
Lübking for pointing out a possible problem here.

REVIEW: 117295

File Changes

Modified 2 files
  • /Gui
  •   src/AttachmentView.cpp
  •   src/AttachmentView.h
2 files changed in total