Revision 4230a0d...

Go back to digest for 20th April 2014

Other in KDE Base

Martin Gräßlin committed changes in [kwin] /:

[effects] Get xcb_connection_t* and rootWindow through EffectsHandler API

So far the effects could just use the connection() and rootWindow()
provided by kwinglobals. Thus an internal detail from KWin core is
accessed directly.

To be more consistent with the rest of the API it's wrapped through the
EffectsHandler and with a convenient method in Effect.

The connection() is provided as xcbConnection() to free the very generic
name connection which could create confusion once we provide a wayland
connection to the Effects.

The rootWindow() is provided as x11RootWindow() to indicate that it is
for the X11 world.

REVIEW: 117597

File Changes

Modified 18 files
  •   effects.h
  •   autotests/mock_effectshandler.h
  •   libkwineffects/kwineffects.cpp
  •   libkwineffects/kwineffects.h
  •   effects/glide/glide.cpp
  •   effects/kscreen/kscreen.cpp
  •   effects/logout/logout.cpp
  •   effects/magnifier/magnifier.cpp
  •   effects/mouseclick/mouseclick.cpp
  •   effects/mousemark/mousemark.cpp
  •   effects/resize/resize.cpp
  •   effects/screenedge/screenedgeeffect.cpp
  •   effects/screenshot/screenshot.cpp
  •   effects/showfps/showfps.cpp
  •   effects/showpaint/showpaint.cpp
  •   effects/snaphelper/snaphelper.cpp
  •   effects/trackmouse/trackmouse.cpp
  •   effects/zoom/zoom.cpp
18 files changed in total