Revision 4b4cbf5...

Go back to digest for 8th June 2014

Bug Fixes in KDE Base

Frank Reininghaus committed changes in [kde-baseapps/KDE/4.13] /src:

Fix possible crash if a kioslave adds multiple items with the same URL

When opening the URL "man:", there are multiple items with the same
name (for example, _exit is shown twice here). When opening a new tab,
the kioslave reports some items as deleted (I have not quite understood
why). The problem is that it reports some of the duplicate items twice
in the list of deleted items. This confused KFileItemModel and
corrupted the internal data structures, and finally, caused a crash.

The fix is to remove all duplicates from
KItemRangeList::fromSortedContainer(const Container& container).

New unit tests included.

REVIEW: 118507
FIXED-IN: 4.13.2

File Changes

Added 1 files
  • dolphin/src/tests/kitemrangetest.cpp
Modified 4 files
  • /src
  •   dolphin/kitemviews/kfileitemmodel.cpp
  •   dolphin/kitemviews/kitemrange.h
  •   dolphin/tests/CMakeLists.txt
  •   dolphin/tests/kfileitemmodeltest.cpp
5 files changed in total