Revision 688514

Go back to digest for 22nd July 2007

Other in KDE Base

Dirk Mueller committed changes in /trunk/KDE/kdelibs/knewstuff/knewstuff2/ui:

- rewrite the download dialog to not use KHTML.
Using KHTML is bad here because:
- It is a heavy dependency, which is then introduced for all applications that want to use knewstuff2
- KHTML is still full of KDE3 support and it might take until webkit to get rid of that
- using KHTML is dangerous here because it renders arbitrary HTML, Javascript and plugins, so bad providers could easily remote-execute code on the local machine. In addition none of the rendering code actually took care of properly escaping things.
- KHTML wasn't build to be used in hundreds of little parts

The code was pretty bad, it forgot parent parameters everywhere so it caused hundreds of toplevel windows to pop up temporarily on the desktop when it was launched. it also had a way too complex layout with many unnecessary widgets.

the dialog does not quite look that good anymore. but this can be fixed later

File Changes

Modified 2 files
  • /trunk/KDE/kdelibs/knewstuff/knewstuff2/ui
  •   /downloaddialog.cpp
  •   /downloaddialog.h
2 files changed in total