Issue 98

Fixed usability issues. Not only was valuable space being wasted, it was too easy to forget to press connect because it was out of the visual and moust path. Corrected, and current button placement still suggests usage.

Fix a kate crash when closing it and having loaded the kate's symbols viewer plugin.

The problem was that there was a nasty casting from KatePluginSymbolViewerView to Kate::PluginView, but KatePluginSymbolViewerView didn't inherit Kate::PluginView; so that when Kate::PluginView::writeSessionConfig() was called, the method was not found and kate crashed.

I tried first to just make KatePluginSymbolViewerView inherit from Kate::PluginView, but that doesn't work because that would be inheriting from two QObject subclasses (it inherits from KXMLGUIClient already) and that's not allowed by Qt.

So the solution was just creating a KatePluginSymbolViewerView2 and having KatePluginSymbolViewerView as a delegate. Can I backport this fix to KDE 4.0?

I've noticed that in KDE4, the "Find in Files" kate plugin doesn't have directory completion anymore for the "Folder:" combo box.

In the code I see cmbDir->completionObject()->setMode(KUrlCompletion::DirCompletion);. So in theory, it does have directory completion. I looked at the code in the Filesystem Browser to see how does it get completion working, and it seems that they manually create the completion object. I've done that, and it works.

Looking at the code of KCompletion* KCompletionBase::completionObject(), it's quite clear to me that what was happening is that completionObject() created a KCompletion object intead of a KUrlCompletion object.

Fix issue with integer overflow and some cleaning.

We have found a number of places where integer overflow occured due to squaring of the radius. The radius can potentially be very big (it measures the current radius of the earth in pixels, which can get big in high zoom levels) and squaring it can cause overflow.

This patch fixes all instances that I could find by using either 64 bit integers or doubles.

Fixed the kio_strigi kioslave. It was just nice to finish porting and debugging it.
I just did it for fun... when I made it work again they (#kde-devel) told me commit.
Here it is.
Waiting for webkit now?

Currently when the general font of KDE has been changed, the used fonts for the view in Dolphin have not been changed.

This has been fixed by differing between a "Use system font" setting (= default) or a "Use custom font" setting.

TODO: if the general font of KDE is changed during Dolphin is open, no update is done yet

Fix applet from crashing. This is the beginning of where Qt 4.4 layouts will be used

o don't delete the used style manager as it can be a shared style manager created and owned by the application
o don't create a style manager for the text shape if there is none.

This fixes crashes due to deleting the style manager of the application.

This also means that if an application wants to use a style manager it has to provide one. Otherwise no style manager is used. I think there is still some code that needs to be updated so that it can work that way also e.g KoTextShapeData::saveOdf.

I found another little crash problem, and I just fixed it.
Hope this little fixes without asking are not a problem :-)
I'm trying to use kile to write my PhD thesis.
This is why I'm fixing some crashes.

Add missing null character, this fixes photo downloading from offcial MSN client.

generate user-icons in other sizes too. they are used in kopete. fixes problem with unsharp status icons

Color blindness simulation for kmag... not so useful for people with color blindness, but good for designing accessible interfaces (also makes a fun toy in its own right).

Several algorithms are implemented (the preprocessor selects one at compile time), so some of the evolution is visible. I'd like to get the "non-simple" algorithm working, but the paper is missing most of the crucial variables. For now the "simple" algorithm with coefficients derived from Visolve is used.

TODO: make gamma configurable, re-add 'invert colors', add modes to actually help people with color blindness in addition to the simulation modes... UI probably needs more work to make this practical, the simple menu-with-list-of-exclusive-options doesn't really cut it.

PUI file defining Lancelot's layout (beginnings of switching to PUI)

Upload Plugin for KDevPlatform.
It's a complete rewrite - and for now has less features compared with Quanta3.
- define upload-profiles in project-settings
- upload files to a upload-profile from the project-manager
- browse upload-profile in a new dock
- stores time of last upload in project-developer-settings (and uploads only changed files)

basic TMX (Translation Memory eXchange) import functionality

PUIC additions and architecture changes

First steps to make use of the spectrumparser

use the svg for layouting, limit to two translations
scale the font, yay!
let the engine spit out the translations individually

First shot at the new projection classes

Control the Sun settings in the KDE GUI.

Patch by Christian Banik. Thanks!

Add the support in the core library and in the user interface for button form fields (ie, push button, check boxes and radio buttons).

Optionally, read the "button" form fields from poppler.
Enable the support for them only if the poppler version is recent enough (atm, git master of around 9 hours ago).

Kooka:

Improve "Save Assistant" dialogue and file format help
Option to show only recommended image formats (default true)
If SANE error when starting scanning, report it
img_saver.{cpp,h} -> imgsaver.* to correspond with class name
formatdialog.{cpp,h} split out from there into its own file

libkscan:

Increment library version, no chance of it being BC
Added "reset" buttons to scan parameter sliders
Properly implement the virtual scanner support (with device "pnm") and SANE testing options
Better layout in scan parameters widget
Combo box for list of resolutions, much easier to use than a slider (hoping that nobody will ever want to scan at 437dpi :-)
Added "Bit Depth" option, if the scanner supports it (don't select 16-bit, it doesn't work yet!)
Better messages to distinguish the two cases "Gallery mode" and "Scanner problem"
kscanslider.{h,cpp} -> kscancontrols.* to better reflect contents
New controls for Resolution (combo box) and File (KURLRequester)

New 'sanedump' utility to display all SANE scanner parameters. Hopefully useful for bug reporting.

kipi-plugins from trunk (KDE4) :

- Handle non jpeg files to save GPS position. If you use digiKam for KDE4, GPS position is now saved in database for all files, including read-only file formats.
This is want mean than you can geo-tagging your RAW files for example !
- Do not refresh thumbs from digiKam Album GUI interface when something is change in metadata. KDE4 version is more robust and detect automaticly wicth view must be updated in this case...

digiKam from trunk : new root right sidebar tab named "Geolocation" to display GPS info of current image.

introduction of altitude service in geolocator

Kooka: Some polishing on OCR and preferences

Simplify "Preferences - OCR" dialogue, show information about selected engine
Fix the "OCR engine has changed..." message always shown even when it hasn't
Use KStandardDirs::findExe() to search for OCR command
class KookaPreferences -> KookaPrefs
class KSANEOCR -> KSaneOcr
Don't change anything if "Select Scan Device" dialogue cancelled
Change "About Kooka" message to include the other supported OCR engines

Add support for encrypted ODF documents.

This is a bit experimental, but it does (mostly :-)) work for me.

Note that the KWallet integration should be interoperable with KWord, so if you enter the password in one application, you shouldn't be prompted for the password in the other (as long as the document path is the same - it won't work if you move the document).

Started to add back "browse with mouse wheel".

Configurable mouse wheel behavior.
One can choose between scrolling and browsing now.

Added a filter bar similar to Dolphin. Patch by Ilya Konkov.

kio-giobridge: extend Solid with VfsHalUnionManager to list and unmount GVFS network mounts

Created basic cmake support for Plasma UI Compiler

Added configuration support (the user can change the hemisphere).

* allow restoring from applet itself (something i've wanted to to do for a while, have it all in corona isn't a good idea)
* restore lock status
* save/restore zorder
* allow "raising" and applet (increase zorder above all others)
* some layout fixes for next monday's big layout fix patch

To change Lock/Logout applet layout direction depending on form factor and size.

Experiment: eject (with solid) cds and unmount drives when they are dropped on the trashcan

Provide the dolphinpart view modes (Icons, Details, Columns) in konqueror's View Modes menu.
(this is done using a Q_PROPERTY in the dolphin part and a signal; the available view modes for creating the menu in the first place are listed in dolphinpart.desktop)
Konqueror: cleaned up the old (complex) handling of view modes as N toolbar buttons from M services grouped by library.
Dolphin: moved view mode handling to DolphinViewActionHandler, removes duplication between part and mainwindow.

Allow to unmount multiple devices at once

enable dragging from desktop to panel

note: there's no visual feedback before you release the mouse button, and there's no way to drag back to the desktop.

Conflicts:
workspace/libs/plasma/containment.cpp

Commit George Goldberg's second KWallet integration patch.

* enable proper dropping on desktop files that contain paths to directories (also works for, e.g. trash:/)
* plug several memory leaks

ruphy: this is a good candidate for backporting. no strings, numerous bug fixes.

- Rework conversion descriptors again. New version gives me nice inline conversions, which are used both for immediate conversion adjustment and for tiles. Autogenerated conversion code for inline arguments.

- Rework the cost model to make sense. Inline conversions inside tiles have cost, at codegen are free, and register/outline conversions have a different cost. Also, give impls a base cost --- since different impls of the same operation may cost differently; a cost of a tile is hence the base cost of the impl plus the cost of any conversions inlined into tile. This is stashed inside the opcode descriptor, of course.

- Start sketching out the actual code generator, and stop, realizing I still need register management infrastructure. Not sure what the mostrobust way of doing it yet.

kio-giobridge: implement kiogiobridge-unmount-gvfs executable

Add support for GPLv3/LGPLv3 to KAboutData

qt-copy is now Qt 4.4 which is GPLv3 so I added GPLv3 and LGPLv3 to KAboutData. I also changed the name of LGPL from Library GPL to Lesser GPL, which is now the new official name.

kio-giobridge: kded module to monitor mounts and update remote:/

Adding Akonadi resource working on a KABC resource as its "remote" side

Adding basic implementation for the Akonadi->KCal bridge

Make Sign/Encrypt Files functionality accessible from menu, too.

Add a kcm for the configuration of the imaplib resources. Adjust Mailody to use this kcm in the settings.

The kcm is not yet finished. just a start.

Basic implementation. Show the resources, make it possible to add and delete them. I'm doing something wrong with converting the identifier to the display name, but that's for later...

Add systemsettings module for managing emoticons theme

Add GUI to switch between flat and hierarchical certificate lists - per tab

Add a KCM to akonadi, which can be used to manage the resources which are capable of displaying rfc822 messages. This has the exact same layout as the transport KCM,

Add a boolean operation to do exlusion of two paths.

Add outline for plugins for shape animations and page effects Add outline for plugins for shape animations and page effects & make the the page effect registry load plugins. make the the page effect registry load plugins.

A quick little hack to scratch my own itch. Add a line edit and a button at the bottom of the last.fm service to quiclky launch custom 'similar artist' streams by just yping in an artist name and clicking 'go'. I am pretty sure that we will come up with something much more clever than this before release

allow DND from the file browser (or an external application) to the playlist.

that was probably the easiest feature i've ever added :)

Change Volume (up/down) shortcuts implemented

- configuration window!
- user can choose to eject the cd at the end of the cd
- user can change the color of the panel

initial work on a capability which supports removal of tracks

show a progress bar when scanning the collection.
it's not very accurate, but at least it shows that a scan is in progress

Full implementation of XEP-0016 "Privacy Lists"
This is not well tested, I am assuming that most servers behave well with it

A BIG thanks to the Psi guys, whose code I ripped off!

Allow for quoting of messages through history plugin
This exposed a bug in ChatTextEditPart, which is also fixed in this commit

First version of upnp API

UPnp integration of the protocol msn

Slim-glow theme for plasma desktop

This is the first version that supports dropping files in the plasmoid to send them out to a remote.

Added: first approach to a piecetable structure, pretty Leichtwasser-matrosig (works, but has some flaws).

What is a "Piece table":
stores both original data and a buffer with all new input, current data is defined by a list of pieces pointing to offsets in one of the buffers and some length. Changes are done by appending to the input buffer if any and manipulating the list of pieces.
In use by Abiword, Qt 4 QTextDocument and others.

And it is an Alpha version of the code, to get things at least working, don't judge too quickly, please. Help is welcome :)

It was tried to have it to be ignorant of the supported data structure, only dependencies so far are primitive utility classes KSection and Co, no used knowledge of KAbstractByteArrayModel or else, cmp. namespace KHE vs. namespace KHECore.
So other interested parties might try to make use of this code, too. They are welcomed.

But the undo/redo stuff, aka revertable changes, seems to force one to finally use structures from the basic data model, e.g. otherwise a list of piecetable changes would have to been transformed into a list of bytearray changes.
And no, currently I do not want to rely the KAbstractByteArrayModel on the piecetable library, neither. Perhaps a common usage can be done by turning the piecetable lib into template code...

added: bytearraymodel implementation which uses a revertable piecetable, so offers endless undo/redo

New application icon extracted from Eugene's default theme.

adding a KPokerSceneControl class, which takes all "input" from the gameengine instead of the KPokerScene class. KPokerSceneControl forwards the input asynchronously, which will make animations much easier

Kalzium is now using KPixmapCache for the SVG-icons.

This makes Kalzium start up in half the time or better with a warm cache. David claims he measured a 5.5s to 1.5s improvement. Not bad :-)

Patch provided by David Benjamin.

Much faster implementation of ChildCountRole. Peter tested it and said:
"Previously it took around 2 seconds until my test folders appeared, now the folder is shown immediately (at least I can see no performance difference in comparison with a folder having no sub directories)."

Make the Magnatune service download a .bz2 file ( that I just generated on the Magnatune site ) instead of the plain .xml file when updating the database. This reduces the size of the download by a factor of more than 20 ( from ~10Mb to ~410Kb )

Disable the notifications by transfers that have changed to their group, until we'll really use this information. This saves some CPU when running downloads.

* Another optimization. Store the gradient background pixmap in a static variable so that we don't have to recalculate the gradient every paint event. This makes repaint events weight more than 1/10 less than before
* Make sure the pixmap gets updated when the palette change.

Begginging of a tool to convert xml plasma user interface definition to C++ code

Do not show things in the UI just because you can, aka don't map you code 1-1 to the UI: simplify the interface by removing the recursive check box, I guess a ping command would be simpler for non recursive...

* Add smokeplasma and ruby plasma bindings.

* Started rename puic -> puck (danny's suggestion)* Added support for Plasma::Label and WidgetPositioner

a place to experiment with kommander kde4

* initial import of mirrors, smoke browser

The new icon_utils acts as a gateway for all the icons in umbrello. The icons are identified with an enum and are all created with KIcon and KIconLoader. Duplicated code and different icon creation should now be removed. Some icons have to be renamed due to KIconLoader search strategy.

change the interface to get a project item for a url. This implementation is a lot slower than the old one, however the old one was incorrect in two ways:

- it assumed there's only 1 project item for a given url, thats wrong as a file might be part of multiple targets
- it assumed that the project item for a given url is inside the subtree that has the same path, which might not be the case

In the cause of this, the function now returns a list of items, that is all these items have the same url, but different parents. The language support parts probably want to do something more sensible than just taking the first one.

Add the two last projections:
- Equirectangular
- Mercator

Activate the projection classes!

This is the first time when they are actually used, and it works, which is a huge improvement.

Many small changes to satisfy krazy2
(KSaneWidgetPriv is renamed KSaneWidgetPrivate to make krazy2 happy -> users need to recompile)

With this commit I think libksane is ready for the first release.

version 0.1 of the epub plugin for okular

User interface cleanup for the image gallery:

Correctly handle action text/enable for gallery folders versus files
New preferences option to enable/disable click-to-rename in gallery
New action and menu option "Rename" for when that is disabled
Show what is being deleted in the confirmation dialogue

Mimick Dolphin filter behavior:
- Set focus on line edit when shown- Disable filter when hidden

Branch for my take on bytecode in KJS. First will have to merge up with JSC a bit to prevent divergence from getting critical; some changes also help things (while some are done much better w/bytecode, anyway)

Merge ExecState and Context. This follows similar JSC changes, but is done differently / by hand, since I don't like the multiple protected ExecState ctors corresponding to subclasses, and since I want to untangle Apple's version of my locals work (and their latter improvements on it) before dealing with some of the MM and ownership changes.

This commit also includes r26914, r27001 which streamline exception handling.
This got tangled up due to a mistake of mine, and it's too much effort to split them.

- Merge in data structures for Apple's version of my local variable code.
It seems to be about 2.5% or so slower, but I want to reduce divergence, and some of the refactorings are needed; plus it's probably fixable with some profiling
- Merge DeclaredFunctionImp and FunctionImp

Last commit before switching to xml defined UI...

be more smart with creating widgets for the tweets. Now the number of widgets is adopted when the configuration was changed, instead of always just deleting and creating all of them.

A slight redesign based on ideas from the KDE-PIM meeting.
The most important result is that itemsviews can now be updated when the data changes.

Moving to kdereview

copied here from playground for review and eventual move to kdepim or kdenetwork.

Minor stuff, from looking @ JSC changelog:
- Pickup a decent optimization for String indexing (JSC r27218) --
provide an integer path as well...
- Pull in a new Vector version, so I can use uncheckedAppend, not that it makes any difference, but heck, a smaller diff is a smaller diff.

Some baby steps, based on my idea of how instruction selection/encoding/marshalling, etc., should work. Lots of overdesigned code to write before this is anything but a bunch of comments, and I have to touch the existing core before implementing things, too.

If I was smart, I'd probably formulate this as standard DAG (or tree, really) tiling, anyway,but I am too self-confident for that :p

A bit more overdesigned, and likely bloated stream of conscience programming. This has bits of instruction selection, etc., which I thinkI'll throw out anyway for something more efficient and autogen'd

- Skeleton (actually, lexer, parser, and driver, based on blockeridl ones) for the table builder.
- A tiny portion of codes.def

Move the Ctrl-wheel zoom handling to dolphinview.
The specialized views still need to ignore the Ctrl-qualified wheel events, though.

* Lancelot's taking it's shape again... now XML based* Few PUIC improvements

decouple videowidget and video renderer

Smaller minimum size for digital clock so it fits in vertical panels too.

"Part" is a technical term; name it "Dolphin View" for konqueror's view mode menu, more consistent with "File Size View" and "File Replace View"

Close the work/decibel branch. It was moved into playground a while back:-)

Initial commit of KDynamicSettings in playground. The plan is to develop here and let it be reviewed also. When have written a test we could be in position of moving it to kdelibs if everything is OK and nobody objects

don't show the rubber band: it doesn't do anything these days. if/when we get multiple selection, turn it back on.

Better follow kdelibs coding style if we want goya to be at kdelibs

moved luna to kdereview.

If the URL navigator is in the editable mode, let CTRL+Return apply the new URL and switch back to the breadcrumb view. This is related to #157593 and feels quite comfortable from my point of view.

set the threadpool according to the number of processors on the system.

i wonder how well this works in a shared (e.g. thin client) env. perhaps we should have an actual setting somewhere (env var? config file value? what?) that, just as with the global animations control, sets that we are in a thin client env

Add a nice webkit widget to display the definition!

let the world know our matches have changed when they, well, change. always.

(neat when optimizations reveal previously when we were always setting the match lists even when we got empty lists, this was masking the fact that we were never updating the matches when the search context was reset ... so there was always a period of time when there were stale matches pointing off into outerspace in the UI. and of course, if no engines returned anything .. booM! but once we were not responding to empty match lists this problem became very visible.)

Switch to using QWebView. Work in progress

Introduce QGraphicsItem::CacheMode in place of Widget::CachePaintMode.
This move was planned from the beginning; Widget::CachePaintMode was a backport of the same feature in Qt 4.4. OK'ed by aseigo after post on panel-devel. I've left CachePaintMode in there (it simply redirects to CacheMode); I don't know if it's OK to remove these APIs or not (and it's not monday anyway).

* set the relevance of the exact match to 1
* match the Name case insensitively so that we filter out Okular when "okular" is entered
* avoid duplicating storageIds or exec's we've alread listed
* clean up the includes

end result: "oku" now returns exactly two matches on my system: okular and ksodoku. perfect! (previously i was getting half a dozen or so okular entries)

* better sort ordering
* a few minor fixes in the UI logic

but this is just a band-aid, though useful to test how simple i can make the ranking system and have it still be useful. the next step is to have SearchContext export a QAbstractItemModel containing the matches.

Reenable weather applet, we're Qt 4.4 in trunk now. Fix default start size to something reasonable for now.

import a new source for raptor

Branch KDEPrint to experiment with a refactor and port to Qt4.4 for KDE 4.1.

Aims:
1) Re-arrange into sub-folders based on functionality
2) Clearer split between base libraries required solely for printing (kdelibs) and those for management (kdebase)
3) Rename some classes to better reflect what they do
4) Namespace
5) KPrinter to inherit QPrinter
6) Use new QPrinter features where they can replace old KDEPrint code
7) Use Cups 1.2 features where they can replace old KDEPrint code (e.g. n-up)
7) Experiment with adding old KDE3 KPrintDialog features to QPrintDialog versus resurrecting KPrintDialog

This branch is likely to be very broken at any point in time.

let F6 also select the whole text of the URL navigator to stay consistent with Konqueror and Firefox

Bring CIA.vc applet back to life again. Make it use Qt 4.4 layouts, QWebkit goodies. Convert config dialog to a Ui::Dialog

Port to KConfigXT and export settings to D-Bus.

Update kdgantt to version 2.0, kindly provided by KDAB.

Beat Mailody in shape a bit more.
It's almost in a state I could actually start using it.

Remove functions that are no longer needed. Mostly related to the check mail timer, which is handled by akonadi.

Also remove the handling of offline/online, as that's no longer Mailody's bussiness either. At start and after the setup, we trigger a sync of the mailboxes, so the accounts show up in Mailody. No need anymore for akonadiconsole and friends to trigger the stuff.

Also implemented the basic statusbar, showing the status updates as received by Akonadi.

/me is happy.

Delete HeaderItem, HeaderModel and HeaderThreading, all taken care of by Akonadi. Fix the date in MessageData, so replying to a message gives the 'At <date>, you wrote' again correctly.

Tag KOffice 1.9.95.3

sync with official libwpg's wpg2odg (to get, among others, embedded pixmaps conversion)

From the dark and creepy places they came. They brought fear and dread. But we all did know:
Where there is light, there must be shadows. So here they are - shape shadows!

Finally!! I can say that it works, see told you passing a pointer by reference is what i needed!!! <mad_scientist>everybody thought i was crazy, that i didn't know what I was doing *goes into fetal position* </mad_scientist>.

Anyone interested please check:
<a href="http://www.codeguru.com/cpp/cpp/cpp_mfc/pointers/article.php/c4089/">http://www.codeguru.com/cpp/cpp/cpp_mfc/pointers/article.php/c4089/</a>;

Refactor (again).
Let me explain how conversions to/from KS works.
It's all still a work in progress, we have not only one way of transforming to and from rgb, so I need to be flexible in this regard.
For this reason, the current code works this way:
- KisKSColorSpace has two template parameters:
+ int N, represents the number of wavelengths used
+ TYPE, the channel type
- Subclasses of KisKSColorSpace specify the type and the factory, that has to contain the conversion transformations to/from rgb and the conversions between various types of channels for KS.
- rgbToKS and KSToRgb color conversion transformations use the code in KisIlluminantProfile to do the convertion, integrating the mechanism in the great Pigment CMS (thank you Cyrille!).
- KisIlluminantProfile defines the functions needed to convert to/from KS: fromRgb() and toRgb(). These are just wrapper functions around rgbToReflectance and reflectanceToKS ( used in fromRgb ), and KSToReflectance and reflectanceToRgb (in toRgb ). Subclasses of
KisIlluminantProfile can redefine these functions so that the conversion is perfectly costumizable.
- Some works has still to be completed:
+ conversion cache
+ LC profile (faster than QP)
+ KSToKS color conversion transformation (to convert between half and float)

This is my declaration of war on the complete chaos that is our current statusbar code and layout in Amarok 2. We have several different statusbars added to different parts of the app.

This first commit establishes a single statusbar area below the browsers and views. This makes the status bars independent on the relative size of each view, and avaods statusbars being cvompletely hidden if any of the views are minimized

Start turning PopupMessage into something that can be shown on top of multiple widgets and make ToolbarBase use it for long messages.

By no means perfect yet...

merging trunk and iup-isi-group branch

Moving kopete-bonjour to extragear

Added 3.0 branch of ktorrent

Make Auto-connect config easier and more intuitive:
Checkboxes for each account are checked to enable auto-connecting "Exclude from auto-connect" options still exist on editAccountWidget's

Main motivation for this was my frustration of having to go through each account to see which ones were enabled for auto-connect, and I heard a user complain about it also.

There may be a bug report about this, but I cannot find it.

removing calculation and napoleon's tomb - both are too much games of luck with too complex rules

First take on the default theme for KDiamond. Please comment.

tagging KDE 3.5.9