Revision 847525

Go back to digest for 17th August 2008

Features in Multimedia

Casey Link committed changes in /trunk/extragear/multimedia/amarok/src:

This colossal commit enables async trackForUrl support for mp3tunes, however to achieve this MetaProxy was hacked to allow for selective updating of the proxied track.

Due to the inheritance hierarchy in the design a chicken and egg problem developed where MetaProxy::name() would call itself causing infinite recursion.

The solution was to add a "forwardToProxy" flag to MetaBase that by default does nothing, but is implemented in MetaProxy and ServiceMetaBase to allow for selective getting of cached or real metadata.

File Changes

Modified 7 files
  • /trunk/extragear/multimedia/amarok/src
  •   /meta/Meta.h
  •   /browsers/servicebrowser/ServiceMetaBase.cpp
  •   /browsers/servicebrowser/ServiceMetaBase.h
  •   /meta/proxy/MetaProxy.cpp
  •   /meta/proxy/MetaProxy.h
  •   /meta/proxy/MetaProxy_p.h
  •   /browsers/servicebrowser/mp3tunes/Mp3tunesServiceCollection.cpp
7 files changed in total