Revision 848092

Go back to digest for 17th August 2008

Other in Graphics

Percy Camilo Triveño Aucahuasi committed changes in /trunk/extragear/graphics/kcoloredit/src:

Hi there ; ), thanks for your feedback Karl ; )

1) About the use of "Add" and "Insert" buttons:
They have diferent functions. The first, add the main color to end of the palette and the other, insert the main color in the position of the current selected item of the palette.

So, I changed the icons of Add and Insert, I renamed the button Add to "Append" and moreover I will put a tooltip in the Append and Insert buttons ...

However, I don't think that remove the Insert button is a good idea, many users would want put a color in a specific position inside the palette, unfortunately I don't have here the Basket app, but I think that with this changes the issue is solved.

2) About add colors from the tetradic scheme:
This funcion works ok, however I made some improvements, now each color of any scheme (complement or tetradic) has a button with the "plus symbol" to append the color to the palette.

3) About the brief view or palette issue:
I made all the changes that you requested, I think your point was right.

To see the changes of the points 1 and 2 please check this link (also attached to the bugtracker)

<a href="/issues/2008-08-17/files/fixedbugsyy3.png"></a>;

File Changes

Added 2 files
  • /trunk/extragear/graphics/kcoloredit/src/widgets
  •   /colortoolwidget.cpp
  •   /colortoolwidget.h
Modified 15 files
  • /trunk/extragear/graphics/kcoloredit/src
  •   /CMakeLists.txt
  •   /app/kcoloredit.cpp
  •   /app/main.cpp
  •   /itemviews/palettebriefview.cpp
  •   /itemviews/palettebriefview.h
  •   /itemviews/palettedetailview.cpp
  •   /widgets/colorwidget.cpp
  •   /widgets/colorwidget.h
  •   /widgets/kcoloreditwidget.cpp
  •   /widgets/kcoloreditwidget.h
  •   /widgets/multipagewidget.cpp
  •   /widgets/multipagewidget.h
  •   /widgets/colorselectors/blenderselector/blendercolorselector.cpp
  •   /widgets/colorselectors/gtkselector/gtkcolorselector.cpp
  •   /widgets/colorselectors/gtkselector/gtkcolorselector.h
17 files changed in total