Issue 207

Improve the integration of partially formatted text in the editor, make it do "the right thing".

* Now the code explicitly tries to select the portion of the formatted text in a way
that the result resembles the formatted text as closely as possible given the fixed context.
* The code works with inserted/removed newlines now

fix loss of top context due to recursive expressionvisitor::parse calls

wow, this took me long to figure out: the name+type visitors can
trigger a recursive call to ExpressionVisitor::parse and hence
could overwrite m_topContext = 0 on exit...

When exporting, all text is now rendered directly to the painter.
All sizes are referenced to the painter's font size.
Exports to PDF or SVG should now look right in all situations.

Add Pune to the list of cities. This is the result of a discussion
with Pradeepto Bhattacharya, who moved to Pune recently and wanted to
know if the object he was seeing was Jupiter. Upon being advised to
use the KDE application for that purpose, he found that his new home
city was missing. This commit fixes that.

Committing Alexey's fix for 279026 bug.

New code expect astroids.dat and comets.dat in csv format with
23 and 21 columns respectively. But it doesn't check that format
is correct and this results in reading beyond end of array
with results we all were able to observe

Trivial to fix if spotted.

Display selected placemarks labels like highlighted text, add "glowing" labels

Make the satellites placemarks glow by default so that they're visible against
the starry sky.

make pinch gesture more predictable

When performing a zoom-out gesture, it could happen that the view was actually zoomed in (or the other way around).
In any case, pinching was unpredictable at times.

Fix bug 264423: Export to KML drops significant figures in Lat/Long

Patch by Vincent Batts. Thanks!

compute right monochrome gain to preserve luminosity when this one is required

Port code for KDE thumbnails loading from ThumbnailLoadTask to camera controller,
replacing the existing implementation.

Now, a careful extra hash is kept to map a preview job's result to the underlying
Camera item info. Relying on the QCache does not work because it's a cache, which
means entries may get removed anytime.
Apparently fixes the crash.

New tool system: tool widgets stay outside the view

Necessary because of rendering issues

Fixed FileIndexerConfig::shouldBeIndexed for exclude filters.

We did not take one issue into account before: imagine we have an
exclude filter "build" and a folder $HOME/x/build/y/. This folder
should not be indexed. This was not handled before.
By checking each component of a path starting from the include folder
this case is now handled, too.

One problem remains: the IndexCleaner does not take this issue into
account yet. This means it will not cleanup all required entries yet.

Check for the number of forms and number of elements in the forms only once.

This avoids a nasty bug where we start checking for forms on a webpage that has
not yet finished loading.


FIXED: 4.7.4

provide a Url entry in the data which contains the path to the image

REVIEW:102817

If m_request.isKeepAlive flag is false and the request has to be retried, e.g.
in case of HTTP authentication, then make sure the isKeepAlive flag is reset to
true since we have already carried out what the server requested and closed the
previous connection.

Otherwise, proxied connections that rely on authentication scheme that requires
persistent connection such as NTLM will fail.


FIXED-IN: 4.7.3

Fix NTLM authentication yet again, but this time added a unit test to make sure
the regression does not occur again.


FIXED-IN: 4.7.3

Always show layout indicator in screen lock dialog if layout count > 1

FIXED-ON: 4.7.3(cherry picked from commit 461efd11513eacfe1c79149a4bd68b2b3fc6a6f4)

Fix switching to spare keyboard layouts with global shortcut

FIXED-IN: 4.8

When uploading a file to a WebDAV server, regenrate the authentication header
after doing the stat


FIXED-IN: 4.7.3

Fixed FileIndexerConfig::shouldBeIndexed for exclude filters.

We did not take one issue into account before: imagine we have an
exclude filter "build" and a folder $HOME/x/build/y/. This folder
should not be indexed. This was not handled before.
By checking each component of a path starting from the include folder
this case is now handled, too.

One problem remains: the IndexCleaner does not take this issue into
account yet. This means it will not cleanup all required entries yet.

- Add application actions, to be shown at th top of the right-click menu. IconTasks uses this to show recent docuents, dock manager menu items, and unity menu items.
- A ToolTipMenu class is created, so that tooltips may be give for menu items. This is so that IconTasks can display the full path of a document in the Recent Documents menu.

fix name display

patch by Luc Menut
REVIEW:102820

Rewrite speak time config to show a combo box with a sane range of values rather than a spinbox.

Fixes giving a user an opportunity to enter "stupid" values which result in uneven time intervals.
Fixes a UI issue which used to read "every 2th minutes" and aids translation.

REVIEW: 102944

plasma: Fix text overflow in the calendar widget

Use pdftotext to create nie:plainTextContent for PDF files.

Strigi's pdf handling is still a bit problematic. There is a lot of pdf
files out there which it cannot handle. Thus, we now employ a hack and
call pdftotext for each pdf file to extract the plain text. That way
searching by content sould work nicely now.

Backport from nepomuk-core:

Fixed StrigiServiceConfig::shouldBeIndexed for exclude filters.

We did not take one issue into account before: imagine we have an
exclude filter "build" and a folder $HOME/x/build/y/. This folder
should not be indexed. This was not handled before.
By checking each component of a path starting from the include folder
this case is now handled, too.

One problem remains: the IndexCleaner does not take this issue into
account yet. This means it will not cleanup all required entries yet.


FIXED-IN: 4.7.3

Simplify the scrollback setting dialog to avoid potential confusion.

- the change is not saved into profile and only influences current tab
- remove the 'Save to current profile' checkbox
- remove the 'Defaults' button
- change dialog title from "Scrollback Options" to "Adjust Scrollback"
- change action from "Scrollback Options..." to "Adjust Scrollback..."

The new dialog makes the "Adjust Scrollback..." action more consistent with most
of other actions in the context menu, since they only influence or work in the
context of current tab.

The UI change is not quite satisfactory. Feel free to refine the UI part
to make it more clear and elegant.


FIXED-IN : 4.8
REVIEW: 102688

In the Kontact Introduction page fix:
- loading of the icons
- clicking of the links

I can also fix the loading of the stylesheet (solution commented for now)
but something is amiss and the result looks all squished together.

If anyone reading this knows css and wants to help fix, please contact me.

MERGE: 4.7

Start to fix Bug 284673 - Regression: Forwarded messages are not marked as such in the message list not perfect yet.

Fix Bug 284712 - "View Message as Plain Text" dialog should focus on the message box itself by default

FIXED-IN: 4.7.3

Fix Bug 284676 - Dragging messages to collapsed folder with subfolders will expand subfolders even after releasing the mouse button

FIXED-IN: 4.7.3

fix #Bug 256655 - A "save changes?" dialog appears ALWAYS when leaving composer settings, even when unchanged.

FIXED-IN: 4.7.3

Hook ICalTimeZones to Incidence Writers

Hook timezone lists to the calls to incidence writers and print the
list of timezones used.


FIXED-IN: 4.7.3
REVIEW: 102838

Fix Bug 234508 - Add clickable function to icon in New/Unread column

FIXED-IN: 4.8

Update the view when recording an invitation.
Doesn't need manual refresh now.

kolab/issue3724

Add menu "More..." when we have too many entry

Fix Bug 284678 - Dragging messages to folders indicates drop targets *between* folders

FIXED-IN: 4.7.3

Unnumbered list items act like "following lines" in a numbered block


this fixes a regression in the placement of "Two more text" in that bug
That bug itself is still not fixed

: OFX import does not work on UTF-8 encoded files

pptx: Positioning of paragraphs without label definition.

* Let's treat all not empty paragraphs as list-items. The positioning of paragraphs in a text-box by MS PowerPoint
differs from positioning of paragraphs inside text by MS Word. This simple modification does not require any change
in the layout. However we still have to support LO/OOo, who do not use this approach. Kind of strange because
their ppt filters do. The problem is that a paragraph must be positioned inside of the text-box. So the indent > margin
(hanging mode) case has to be handled.

* The logic to position list-items wo a label differs compared to labeled list-items in MS PowerPoint.
I updated the logic and tried to make the logic for labeled list-items more readable.

Don't transform between QPixmap and QImage all of tghe time without any need.
This fixes a crash reported by Thorsten that
was related to QPixmap not being threadsafe
while we are using libkowmf in the threaded
vectorshape.
It also should make WMF parsing slightly
faster cause we don't transform between
QPixmap and QImage all of the time without
any real need for it.
Tested with cstester.

Don't delete widgets that have this as parent - Qt will take care of that
Deleting them just leads to crashes

Fix crash on closing Words.
The bug was introduced ~2 weeks ago with 2fe68748b069
backtrace;
[KCrash Handler]
6 0x00007fedf9e5b12a in KoInlineObject::d_func (this=0x0) at /home/kdab/src/calligra/libs/kotext/KoInlineObject.h:228
7 0x00007fedf9e5afb6 in KoInlineObject::id (this=0x0) at /home/kdab/src/calligra/libs/kotext/KoInlineObject.cpp:85
8 0x00007fedf9e5284a in KoInlineTextObjectManager::removeInlineObject (this=0x9dd260, object=0x0) at /home/kdab/src/calligra/libs/kotext/KoInlineTextObjectManager.cpp:146
9 0x00007fedf9f178b4 in DeleteCommand::~DeleteCommand (this=0x4852dc0, __in_chrg=<value optimized out>) at /home/kdab/src/calligra/libs/kotext/commands/DeleteCommand.cpp:299
10 0x00007fedf9f17b36 in DeleteCommand::~DeleteCommand (this=0x4852dc0, __in_chrg=<value optimized out>) at /home/kdab/src/calligra/libs/kotext/commands/DeleteCommand.cpp:306
11 0x00007fedf953672c in qDeleteAll<QList<KUndo2Command*>::const_iterator> (begin=..., end=...) at /usr/include/QtCore/qalgorithms.h:322
12 0x00007fedf95361e8 in qDeleteAll<QList<KUndo2Command*> > (c=...) at /usr/include/QtCore/qalgorithms.h:330
13 0x00007fedf95349a1 in KUndo2QStack::clear (this=0x9780a0) at /home/kdab/src/calligra/libs/kundo2/kundo2stack.cpp:521
14 0x00007fedfa4ccfdf in KoDocument::clearUndoHistory (this=0x90dac0) at /home/kdab/src/calligra/libs/main/KoDocument.cpp:2747
15 0x00007fedfa4ebfb0 in KoMainWindow::setRootDocument (this=0x8a5620, doc=0x0) at /home/kdab/src/calligra/libs/main/KoMainWindow.cpp:456
16 0x00007fedfa4efd7a in KoMainWindow::closeEvent (this=0x8a5620, e=0x7fffa36d3340) at /home/kdab/src/calligra/libs/main/KoMainWindow.cpp:1027

Add support for enable/disable LT

Amazon store: show only albums we have a price for

Please test!

I thought showing all albums we have internally would be a nice feature.
Well, users usually reacted by yelling "OMG, WHY ARE THERE NO PRICES?!"
and then were falling dead to the floor. ;-)

So, from a usability POV this obviously was not the best design decision.
Also, some people say we should not kill our users.

Hiding those items now took me several days, my desk is full of blood
from all the *HEADDESK*ing it had to endure due to my lack of knowledge
about all that model/view stuff.

Anyway, I should not write novels here: it works now. At least for me.

Mandatory QObject-based memory mngment for all MediaDevice Capabilities

AFAICS, all subclasses of Handler::Capability were only created using
"new" and never deleted, yielding continuous memory leaks. Make it
compulsory for them to pass their parent object (relevant
MediaDeviceHandler) so that they are deleted when their associated
collections (and therefore handlers) disappear.

Added benefit is that it is now guaranteed inside capabilities that
their collection (handler) is valid throughout their lifetime.

All external code that keeps references to such capabilities should do
so only using QWeakPointer (all found places fixed).

Apart from fixing memory leaks, this should definitely fix crash in
bug 245852. Fix also MediaDeviceTrack::inCollection() so that other
crashed are avoided.


FIXED-IN: 2.5

Prevent crash on getting cover from MP4 files. Thanks to Charles Reiss for this patch.

FIXED-IN: 2.5
REVIEW: 102828

MediaDeviceTrack: prevent possible crashes, Handler::Capability fixes

When a media device is removed, its collection and handler are
destroyed, but its tracks, albums are kept as long as they are
referenced. Tracks, albums use QWeakPointer to track deletion of
their handler. Ensure that this pointer is always checked before
use in MediaDeviceTrack.

Also ensure that related Capabilities get destroyed (they should
be alredy tracked using QWeakPointer) when handler gets deleted.
It did not work previously in cases when Capabilities were created
in a thread from handler's. Move them to handler's thread so that
parentship can be established.


FIXED-IN: 2.5

Rework MediaDeviceAlbum cover-related functions, remove "Unset Cover"

There was a logic error in MediaDeviceAlbum::image() method which was
the cause of bug 263268, this is fixed and cover setting functions are
cleaned-up.

The "Unset cover" MediaDeviceAlbum action never worked, so remove it
from GUI and remove related stub methods. I believe the functionality
is so little used on media devices so it is not worth implementing it
(yet).


FIXED-IN: 2.5

iPod connection assistant: rework iPod identification

This should fix remaining bugs where iPod is misidentified as a USB
stick. Long comments are added that clarify interaction of varous
code paths that deal with iPhone-like devices.


REVIEW: 102966
FIXED-IN: 2.5

Convert from percent encoding for navigation url runner filter

Since f718f0173d9823d8b67dfa695232b16a4b0c144c, the strings are escaped
on creation. When used as filters in the browser they need to be changed
back or the filtering wouldn't work.

fixed Choqok will accept any character from any language as tag

Use correct modem identifier when deciding to reset internal pointers
for bluetooth devices.


FIXED-IN: 0.9.0_rc2

Activate 'Now playing...' plugin only when requested from contact list

Reviewed-by: David Edmundson
REVIEW: 102949

Treat a cancellation of the SSL error dialog as a deliberate disconnect.

Improved global presence tooltip layout

Reviewed-by: David Edmundson
REVIEW: 102957

Make sure the spinning wheel is always in the right position

Fill ip parameter of tracker announce with current IPv6 address if not filled in by user in settings

Fix a crash with debug builds (hitting an assert inside Qt)

Reviewed-by: Francesco Nwokeka

FIX empty account facebook bug

This bug let users add a facebook account without "account" and "password" fields

REVIEW: 102972
Reviewed By: David Edmundson

Consistify URL transform behavior between left and middle click open.

Add tooltip explaining how to use wifi security's alternate subject
matches in Plasma NM's wifi edit dialog.

Presence plasmoid toolButton now updates according to global status

Fix Kopete Jabber plugin failing to load
This closes Bug 556

Remove the password from KWallet before removing account

Reviewed-by: Martin Klapetek

Better user-is-typing signaling, now it correctly appends the string "Typing..." to the window title (ie. it only appends it when the current opened tab has a currently typing user)

Reviewed-by: Francesco Nwokeka
REVIEW: 102977

Use special presence in the contact list global-presence-chooser for 'Now playing...' plugin

Reviewed-by: David Edmundson
REVIEW: 102950

Update common repository and use WalletInterface instead of KWallet directly

Reviewed-by: David Edmundson

Fix crash in DHT packet receive code

Ensure that createWidget() always creates a widget, even in buggy situations.



Unfortunately I can not test that this 100% fixes it as I don't have a scanner
with a backend that behaves like this. It seems like option does not exist any
more after the initial checking of the option list...

Please reopen if it does not work with the next release (4.8)

fix crash when generating a key fails before user entered password

If the GnuPG process started to generate a new key failed before the user
entered the password (e.g. because of a broken configuration file) we will use
an already deleted object.

The reason for this was opening a dialog and waiting for its result in a slot,
so the underlying object could have been deleted by the return to the event
loop. Now this is completely handled by signals and slots.


FIXED-IN:4.7.3

fix job status message when key generation fails

If the generation of a key fails for whatever reason we tell the user that
things gone wrong in a messagebox, but the systray message always suggested
that the key was created. Use the same messages for both.


FIXED-IN:4.7.3

When querying for audio files only use the mimetype.

We sadly cannot depend on the nfo:Audio type. That would be the fastest
solution but Strigi still fails to index a lot of audio files. Thus we
depend on the very reliably mimetype from KMimeType.
However, if we do that we already get all the audio files. Thus, there
is no point in adding the additional ResourceTypeTerm which only makes
the query that much slower.


FIXED-IN: 4.7.3

first start to use KBibTeX as library

Replace the status bar with message widget

The status bar has been removed from the main window. It has been
replaced by a message widget that pops up in the viewer. The user
receives now a simple visual feedback when something goes wrong, instead
of a message in the status bar.

Also some useless messages ("Ready", "Configured", ...) have been
removed.

Fix the new note screwing up the model index bug

This is/was a super annoying bug that would cause the wrong index,
to be given after a new note was added. All the model indexes were
off by 1.

I still haven't figured out why this was happening, but I've hacked
around it. This fix is horribly in-efficient and recreates the entire
model each time a new note is added.

use directory of loaded file in saveAs dialog again

(Sorry for having messed this up in 4.7.0)

Make Renderer a pseudo-singleton to avoid crashes on logout.

An in depth description of the issue can be found here:
http://lists.kde.org/?l=kde-games-devel&m=130499552229629

This commit sidesteps the basic issue by avoiding the use of a
K_GLOBAL_STATIC.

Re-implement the puzzle-symmetry feature. Add a status bar with combo boxes for symmetry and difficulty (from KDE Games library). Re-order the types of puzzles in the Welcome screen. Remove the difficulty-slider.

Re-create the repository in case of an un-scheduled shutdown of the DB.

This is a hacky way of ensuring that Nepomuk even works after a crash
or a third-party kill of the Virtuoso instance. "Hacky" because it does
not care about clients which will get some query errors during the
restart.

Run the MetaDataMover with an event loop.

It is using the exact same approach as the file indexer does: a new
thread is created and started and the MetaDataMover is then
QObject::moveToThread'ed to it.

This fixes mem leaks caused by DBus events that are not cleaned up.

Mercurial Plugin for Dolphin merged.

REVIEW: 6816

Committing sky guides feature.

Added classes:
* GuidesDocument
* Guide
* Slide
* Author
* Image
* Link

Added namespace SkyGuides holding this classes. XML Schema Definition file for sky guides feature is skyguides.xsd.

SatellitesPlugin: new config dialog based on a tree model/view

New FlashExport Tool

Add sorting capabilities to the file list in the AdvancedRenameDialog. You can
access the sorting actions by right-clicking on the file list. Right now only
sorting by name and creation date is implemented, but I will add the ability to
sort by file-size and (maybe) rating.

Added option to choose the resolution of the printout (High / Low). Default is
High: QPrinter::HighResolution

support vertical resizing

please test ;)

FEATURE: add Leave and Lock Screen actions

Make the task manager items move in realtime when user manually arranges items.
REVIEW: 102833

Made the progress bar hide when a user paints with a mouse

This is done by controlling the number of "opened" strokes, that
is the strokes which have been started but haven't been ended yet.
So if we see some strokes opened, just hide the progress bar.

Make behaviour of global search box more intuitive
* go back to completing when popup is closed and F4/Down pressed
* hide popup if F4 pressed
* single item on the completion list => select it automatically
* more than one item on completion list=>find exact match, if ok, accept
* there is no matching text => go back to completing

Skip creating a disc entry in albums applet if album only has 1 disc

Improve rekonq WebKit settings

This patch changes WebKit Settings window removing the "unuseful"
stuffs and adding some news like WebGL or Frame Flattening
(probably useful also on netbook).
It also redesign/clean up the settings widget

Let us require QtWebKit 2.2.x, hence Qt 4.8.0 at least until someone
will explain me how I can check QtWebKit version number with cmake...

REVIEW:102920

Add dialog to configure journey searches, quick journey search button

- Store favorite/recent journey searches in StopSettings
as UserSetting. Each stop settings now have their own list of
favorite/recent journey searches.
- Store lists of JourneySearchItem objects in encoded format,
as QByteArray. See SettingsIO::decodeJourneySearchItem() and
SettingsIO::encodeJourneySearchItem()
- Add a configuration dialog for journey searches, showing a custom
QListView with a custom delegate. The list view uses a custom
model (JourneySearchModel)
- Add tool button to TitleWidget for quick journey searches,
if journeys are supported by the current service provider. That new
button gets placed left of FilterWidget. It can be collapsed to icon
only, just like the filter widget
- Show filter menu entry in context menu also if there are color group
settings (not only filter settings)
- Check service provider features on PublicTransport::init(),
eg. check if journeys are supported

Add settings to configure computer engines.

Add "Gold Rush" a new championship-level game with Traditional rules by Gabriel Miltschitzky.

Detect network mounts and skip slow operations while listing them.

On NFS/SMB/SSHFS, KIO no longers counts items in directories (e.g.
for dolphin in detailed view mode), nor does it look at subdir/.directory
files for custom icons or comments.

This commit will improve speed greatly in kdelibs-4.7.4 and later.
There's just one issue remaining, when navigating away from a directory
with many items, but that's a TODO for afiestas -- if he agrees :)

Prevent unnecessary round trips to servers that use HTTP Digest and NTLM
authentications by caching the original authentication header received from
the server.

Tested using both the webdav and http protocols against a demo server provided
by the folks over at sabreDAV: http://demo.sabredav.org/public/

Remove option "Show in Media Sources" for Current Track applet..

As discussed with Sven, this option doesn't really make sense. So we are now
always showing the Media Sources in this applet.

Currently the applet is overcrowded with icons, but I have more ideas in the
pipeline for cleaning this up a bit.

Revert "Don't use QWeakPointer just for the sake of it."

This reverts commit a72943f6ad7a6cc3c0ef227162faf76df146b18e.