Issue 244

Fix behaviour when set the function interval: it should update the data (points/jumps), therefore the model should emit datachanged signal

prevent crashing when selecting invalid unicode character.

Konsole goes into an infinite loop and will eventually crash due to
memory. On an invalid unicode char the width is 0 so the for loop never
exits.
This should prevent the crashes; not sure if there is a better way.

Use the right name when adding a folder to Places with the context menu

Without this patch, the name of the parent folder was used for the entry
in the Places Panel. Will backport to the KDE/4.9 branch when the RC2
freeze is over.

Thanks to Daniel Kreuter for the patch!

fix Battery Monitor widget stops tracking charging state changes after suspend/resume cycle

also fix the description to correctly reflect charging/discharging state

Fix logout effect including port to OpenGL 2

The logout effect was rather broken. First of all it was
excluded from build if OpenGL ES is present at build time. The
reason for this is that the effect did not work with GLES.

In order to fix that the vignetting is ported over to OpenGL 2
by using a dedicated shader. As well the lod based blur is
added through a dedicated shader and uses framebuffer blit to
get the current rendered buffer before rendering the logout
window into a texture.

Last but not least the isActive method was broken and is fixed
by checking whether the logout window is around.


FIXED-IN: 4.9.0
REVIEW: 105459

fix authorization from twitter applet

user in authorize() can be empty when it's already set in d->user,
respect that and successfully authorize.

Thanks to phoenix_fbrd for finding this issue and the patch.

REVIEW:105498


Please reopen the bug report if you still encounter crashes.

Avoid automatic clearing of the ResourceManager cache

The current limit was hard coded and wasn't based on any real world
usage. With the new dolphin features and amarok being ported to Nepomuk,
it is very common to have more than 10k resources.

When one overcomes that number, then for each new Resource the entire
kickoff list is searched in an attempt to find ResourceData* which are
no longer being used.

Instead, now whenever a ResourceData* is no longer being used, it is
simply deleted.

REVIEW: 105516

Delay closing of a window by one event cycle

This is an issue we already had in the past with Aurorae. When
closing a window the graphics scene crashes because the deco
gets destroyed before the code in the graphics scene finished
the execution.

With the port to QML this seemed to be fixed unless as it turns
out it throws an XIO error on closing:
fatal IO error 11 (Resource temporarily unavailable) on X server ":0"

This can be triggered using glxgears. Closing glxgears would
reliable crash Aurorae. To circumvent this issue we have to
delay the close by one event cycle using QMetaObject's
invokeMethod with a Qt::QueuedConnection.

This has also to be done in the useractions menu as the menu
is still open when the window closes causing the same problem
inside Aurorae.


FIXED-IN: 4.9.0
Reviewed-By: Thomas Lüking

prevent calling eject twice, resulting in the tray being retracted on some PCs

Re-implement dropping of files on folders in the Places Panel.

This resolves a regression caused by the Places Panel rewrite. There is
a small glitch left when reordering items (dragging below the last or
above the first item only shows the drop indicator when first dragging
out of the item and then back), but I prefer not to fix this glitch
right now because this would require a more intrusive change, and I do
not want to risk regressions because is not much time left to fix them
before 4.9.0 is released.

Thanks to Peter Penz for providing some advice about this issue.

Don't allow to create group with @ or . in groupname

Fix Bug 258926 - kmail2: Folders are not translated in main view

FIXED-IN: 4.9

queryserviceclient should kill blocking queries when the service crashes.

Otherwise running queries will never return.

OK'ed by Vishesh and Volker.

pptx: fine tuning of paragraph-properties
- Only apply style:font-independent-line-spacing if fo:line-height is relative.
- Save default fo:padding-* values into the default paragraph style according to the spec.
- Handle conversion errors in libmsooxml properly.

improve/fix template generation code

* move code duplication around call of KoTemplateCreateDia::createTemplate(...)
into that method
* remove redundant label "Preview:" from dialog
* change option "Default" to "Preview"
* fix loading of proper high-size icon (Desktop is usually not 128 pixels)
* ensure saving of quadratic icons if preview or custom image is used

REVIEW: 105406

thanks boemann and boud for review

Fixes DateVariable saving to ODF (no "0-00-00T" prefix, use date/time-only or datetime)

REVIEW: 105463

thanks thorsten and pierre for review

moved mirroring code to a node visitor. This fixes mirroring of group layers and local selections.
Also removes duplicated code from layer and mask manager and puts it into the node manager.

Using selections is disabled for now as that produces some problems. Mirroring shape selections still not working.

pptx: fine tuning of paragraph-properties
- Only apply style:font-independent-line-spacing if fo:line-height is relative.
- Save default fo:padding-* values into the default paragraph style according to the spec.
- Handle conversion errors in libmsooxml properly.

Prevent hang in testmetamultitrack.

The class variable mutex had problems in the destructor.
The function static mutex should not have the problem and I also
can't see problems with initialization.

SqlTrack: update uidUrl in db if it changes on metadata change

Following scenario lead to statistics, lyrics and labels loss:
1. make sure a track in local collection is not tagged by
amarok_afttagger or with musicbrainz uid
2. turn off "Watch folders for changes" (or work fast)
3. change title of the track within Amarok
4. move the file within collection folders using Dolphin
5. hit "Update Collection"
6. the stats are lost; normally Amarok should match the track by
uidUrl, but it isn't updated in the db in step 3., so it doesn't
find the old track and removes the entry for it.

[Reporters: ^^^ see a nice example of "steps to reproduce"]

This patch changes step 3 to reread and update uidUrl in the database
if necessary.

BUGFIXES:
* Don't loose statictis, labels and lyrics when changing metadata of a
track (not tagged by afttagger) followed by moving it.


CCMAIL: Ralf Engels
FIXED-IN: 2.6

SqlScanResultProcessor: don't accidentally delete tracks, defensive rewrite

This fixes data-loss that I can trigger every time by toggling "Local
Files & USB Mass Storage Backend" in Config -> Plugins, restarting
Amarok and triggering collection update / rescan.

In theory, more things such as cloning changing disk could trigger this
problem, from SqlScanResultProcessor::deleteDeletedDirectories() comment:

We need to match directories by their (absolute) path, otherwise following
scenario triggers statistics loss (bug 298275):

1. user relocates collection to different filesystem, but clones path structure
or toggles MassStorageDeviceHandler enabled in Config -> plugins.
2. collectionscanner knows nothings about directory ids, so it doesn't detect
any track changes and emits a bunch of skipped (unchanged) dirs with no
tracks.
3. SqlRegistry::getDirectory() called there from returns different directory id
then in past.
4. deleteDeletedDirectories() is called, and if it operates on directory ids,
it happily removes _all_ directories, taking tracks with it.
5. Tracks disappear from the UI until full rescan, stats, lyrics, labels are
lost forever.

Also add a handful of asserts, ScanResultProcessor is very complicated
and small error or corner-case in logic may result in horrible data
losses.

Reporters of linked bugs, please try to reproduce your data-loss with
this patch applied and report back in both cases. In negative case,
please reopen and attach full updated amarok --debug log.

After this patch, only (statistics, lyrics and labels)-loss operations
should be:
a) moving track out of mounted collection folders [by design]
b) changing both metadata and url from outside of a track not tagged
by amarok_afttagger [we can do nothing about this]


FIXED-IN: 2.6

stop scrolling on mouse wheel movement

it is the most annoying thing you can imagine. instead change the
volume, which is 3000x more useful


FIXED-IN: 4.10

Make sure all trackers are used of a magnet link

Fix session restore code

This let bookmark manager code properly load :)

Fix option to save secrets to plain text file. I think I will remove
this option some day.

Don't automatically replace '<' with "<" ('>' with "&gt") any more

QTextEdit now seems to correctly recognize that the overall text is not HTML.

Hack for compiling with clang even on older icecream remotes.

Older icecream versions had /usr/bin/{gcc|g++} hardcoded when
invoking the compiler from the environment on the remote. In order
to build on such remotes, if the environment also contains clang,
include a wrapper around /usr/bin/{gcc|g++} that will either
invoke real gcc or clang, depending on an argument added by icecream.

Not entirely elegant, but it works, and the usual gcc-only case should
be unaffected.

Further improve auto-completion in switch statements.

Only compile-time integral constants are valid in "case ..."
statements, so filter any certainly non-constant completion items.

This has 2 issues:
1) We do not filter type-names since they can be used either as scopes
(SomeType::someConstant) or as ctor-like initializers
(SomeIntegralTypedef(42)).
2) We do not filter integer-returning functions since they
can be constexpr (thus syntactically usable) but we cannot handle
constexpr now.

But, since one rarely would use these items, their match quality
is forced to zero in order to avoid pollution of "best matches".

Signed-off-by: Olivier JG

Store CMake settings per configured build directory.

This addresses the TODO at the beginning of cmakepreferences.cpp,
changing CMake routines to save build system settings (e. g. CMake
executable path, build type and install prefix) separately for each
configured build directory.

REVIEW: 105308

Support both project and class templates in the template preview

Add some methods for further equations analysis in analitzaplot

core: include course IDs in the data index

The import function of the course editor will need this too detect ID
conflicts without opening and parsing each and every course file.

A hacky heuristic to guess the right width of the widest number for very
small scientific notation numbers. This is not exact but seems to work.

Math representation/expression of implicit functions are equations, thus now the user can enter the equation instead of (x,y)-> for implicit curves or (x,y,z)-> for implicit surfaces, eg: y-2=x*x instead of (x,y)->y-2-x*x

Imlemented cometscomponent.cpp with new file parser. Tested.

GreoGraphicsScene: better use of zoom level

* use common zoom level calculus instead of magic numbers
* only paint an item if it is in the current viewport

convert images to ppm stream

Add camera filter

Getter/setters for opacity, saturation and brightness in WindowPaintData

The public member variables for opacity, saturation and brightness
are removed in favor for getter and setters. The variables are
moved into a private class. Those are now qreal instead of double.

To make usage inside the effects easier a multiply method is added
which multiplies the current value with passed in factor and returns
the new value in a functional programming style.

This commit is the top-most of a patch series to refactor
ScreenPaintData and WindowPaintData. Other related commits are:
* 0811772
* ebdc7ec
* 2c8dd8d
* 7699726
* 68e0201
* 611cb09

REVIEW: 105141

FIXED-IN: 4.10

Provide GUI to change line spacing

This provides a profile GUI to change the line spacing (0-5). Due to
the Qt4.8/BIDI issues, allowing the user to change the spacing allows
the user to fix any issues w/ the font they are using.


REVIEW: 105478
FIXED-IN: 4.10

Add history to the token and filter strings.

Now we can import thunderbird addressbook :)

Continue to implement load addressbook

enhance date-time parser to allow formats which were possible in KDE3

Remove close button on Article tab

Completely remove the close button on the Article
tab as it also does nothing after being clicked.


FIXED-IN: 4.8.5
REVIEW: 105504

doc: Added REF field support.

Searching and replacing works, with one button not yet operating.

There currently is no way to select in which entries to search, because
I am not yet sure about the ui for that. Apart from that, searching
seems to be ok.

show progress in pdf filter

Add "Save group layer projections as images" feature for Animtim

Saves the group layers to individual images. Handy for storyboarding :-)

make parsing of fo:clip more strict, but also backward compatible

* detect "auto" values in rect(...)
* check number of values in rect(...)
* workaround values in rect(...) separated by whitespace, not comma

REVIEW: 105528

thanks boemann for review

SqlCollection: introduce generateUidUrl() and use it in ScanResultProcessor

so that the information is not scattered throughout the code-base, next
commit will make use of it.

EngineController: ditch canDecode()

MetaFile::Track::isTrack() is partial replacement. Existing 3 calls to
canDecode() were in fact all related to MetaFile classes, so move the
method there, simplify it not to query phonon at all (and document it
can return false positives).

As a consequence, we show all audio and video files in file browser and
in other places, even if they wouldn't be playable by the current
phonon back-end. This is arguably a cleaner approach and at least lets
users discover where the error is.

Works quite well for me and prevents failures in many tests. This
change is propelled by Bart's and Ralf's legitimate comments on

Improvements in LogViewer

- display entities as a per-account tree view
- try to display contact's real name (or nickname) or fallback to Entity alias
when account is offline
- use QSplitter to make width of the EntityView and MessageView adjustable
- make the window slightly bigger by default

REVIEW: 105450

Save a site snapshot when adding a favorite via the urlbar

Review boomarks management

Maybe this is a bit risky before release, but this lets us adding a
bookmarks shortcut (CTRL+D) as used in the major browsers.
With this commit, rekonq doubles this behavior.

Show external scripts in tabs

- External scripts (included into the main script using include())
use the same tab class as the main script tab, ie. ScriptTab
- Can be opened from the projects dock (context menu of the script item)
- Gets opened automatically when interrupting in external script code
- Each project can open a list of included external scripts in tabs
- Move Project::executionLine to ScriptTab, ie. each script tab gets
it's own execution line, move code for marking the execution line
to ScriptTab::setExecutionLine()
- Add ShowExternalScript project action, can be used with the file path
to the file to open as data or without data to show a file dialog
- Fix const for AbstractTab::fileName()
and AbstractDocumentTab::fileName()

Add a signal that is emitted whenever the backends list has changed

Store breakpoints per file

- Previously the same breakpoints where used for all files
- Test for breakable lines by file
- Store script text for all loaded files in DebuggerAgent

Make it possible to start muon-discover with a category set

Adds a --category argument that will specify what category we start
displaying when the program is started.

Add a loading page to muon

When starting Muon with a defined state (category, mime) add
a page that says it's being loaded. Otherwise it looks misleading.

Add include() script function to include external scripts

- Can only be called from the global context and all include()
calls must be before any other statements
- Can only include files in the same directory as the script itself
- Update ServiceProviderScript::isTestResultUnchanged(),
also test included external script files for changes

The user can now choose slideshow/ community updates. Welcome Dialog Hides

Simplify toolview creation

Instead of creating toolviews in the default position then moving them to
the requested position just create them in the requested position.
This is good because lets us scape the moveToolView method that would remove then
recreate the toolview unnecessarily.

QGLViewer is not more a dependency, this will made the lib more simple, in the same thime thanks to qt3d class we will not require do reinvented-the-wheel work

Cache prepared queries and re-use them whenever possible.

Sergio measured this to save 22% CPU time during creation of new items.
It should also cut down database server roundtrips considerably.

While not being the most efficient way to implement this, adding it to
the query builder instantly accelerates all but just five queries. I'll
convert those to either use the query builder or the cache directly in the
next step.

resource editor: preperations for keyboard layout editor

Move common editor functions from CourseEditor to the new
AbstractEditor.

Testing TLM(True Limiting Magnitude) obtained for optimum magnification on galaxies, nebulae and star-clusters.

resource editor: optimize layout of course editor

Employ a QSplitter between the lessons list and the lesson editor and
give the lesson editor a large stretch factor so it get most of the
space automatically if the window gets enlarged.

new Showfoto 2.8.0 splashscreen from Thomas Rees


M +- -- data/pics/splash-showfoto.png

very important changes here. No need to switch from/to ref to pointer and vis versa. As all is stored as pointer internally, using const pointer as arguments is the best way to optain a clean code to read.
Init all point to 0 when it's possible.
Constify arguments and methods when it's possible.

Remove Tiling support from KWin

As discussed on the mailinglist [1] the tiling support is
removed from KWin. The main reasons for this step are:
* it is unmaintained
* it is a mode not used by any of the core KWin team
* original developer said at Akademy 2012 that he is not
interested in picking up the work again
* tiling has quite some bugs, e.g. multi screen not supported
* is conflicting with other concepts in KWin, e.g. activities

There is ongoing work to get tiling supported through a KWin
script, which is a preferred way as it does not influence the
existing C++ code base.

[1] http://lists.kde.org/?l=kwin&m=133149673110558&w=2

FIXED-IN: 4.10
REVIEW: 105546

emit brightnessChanged on profile changes

fixes the battery monitor popup applet slider not updating after
(un)plugging AC

Remove ordindary smudge paintop

As discussed on the mailing list. Colorsmudge and deform do everything
this one does, and better

Some UI changes

Put the search bar at the top right of the window
Hide toolbars when they're not needed
Use PageStack for changing the top page too, adds some
nice effects