Revision 5227918...

Go back to digest for 12th August 2012

Bug Fixes in Office

Thorsten Zachmann committed changes in [calligra] /:

Fix mixup of canvas and document resource

When investigating the reason for crash for bug 304674 I found out that a very a bug had sneeked in during some refactor of the KoDocumentResourceProvider and KoCanvasResourceProvider. The problem there was that the canvas resource current page had changed and that triggered a repaint which resulted in a crash (Crash fixed by a better fix). However the reason there was a repaint was that the signal for changing the current page resource triggered in KoPathTool::resourceChanged the trigger for HandleRadius as both resource providers did trigger the same slot with oververlapping resources :-(. Seems like this was not the only place where this was done. I have fixed that by adding a second slot for the documentResourceChanged and now the different slots are used for the different resources to no longer mix stuff there. I tried my best to find all occurrences of the problem.

Will wait one week before I backport to 2.5 as asked by boemann.

REVIEW: 105896

File Changes

Modified 11 files
  •   libs/flake/KoToolBase.cpp
  •   libs/flake/KoToolBase.h
  •   libs/flake/KoToolBase_p.h
  •   karbon/plugins/tools/KarbonGradientTool.cpp
  •   karbon/plugins/tools/KarbonGradientTool.h
  •   karbon/plugins/tools/KarbonPatternTool.cpp
  •   karbon/plugins/tools/KarbonPatternTool.h
  •   libs/flake/tools/KoCreatePathTool.cpp
  •   libs/flake/tools/KoCreatePathTool.h
  •   libs/flake/tools/KoPathTool.cpp
  •   libs/flake/tools/KoPathTool.h
11 files changed in total