Revision 58b9bea...

Go back to digest for 12th August 2012

Other in Development Tools

Milian Wolff committed changes in [kdevplatform/1.4] /standardoutputview:

Protect access of QAbstractItemDelegate pointer using a QWeakPointer.

The standard output view allows plugins to provide delegates and
also allows them to keep the ownership of them. While powerful, this
seems to be buggy and can lead to crashes in some cases.

Now we should properly detect the cases where we try to access an
invalid item delegate and output a warning instead of crashing.

It would still be interesting to know which plugin is responsible
for this bug.

File Changes

Modified 3 files
  • /standardoutputview
  •   plugins/outputwidget.cpp
  •   plugins/toolviewdata.cpp
  •   plugins/toolviewdata.h
3 files changed in total