Revision f5e397b...

Go back to digest for 12th August 2012

Other in Development Tools

Milian Wolff committed changes in [kdevplatform] /:

Let the OutputView take ownership of a job's model and delegate.

This is required to ensure proper functionality of the views
when e.g. a plugin gets unloaded. Previously, this would trigger
crashes due to access of invalid model or delegate pointers.

Now the view will stay functioning even if e.g. the MakeBuilder
gets plugin gets unloaded after a project was compiled, or even
if you close a project while it is being built.

It is still safe to access both, the model and the delegate,
from inside a job as long as the job is running. When a view
gets closed, the job gets cancelled anyways.

Sadly, this is an ABI break and thus cannot be backported to
the KDevplatform 1.4 branch...

File Changes

Deleted 2 files
  •   outputview/delegateholder.cpp
  •   outputview/delegateholder.h
Modified 23 files
  •   outputview/CMakeLists.txt
  •   outputview/ioutputview.h
  •   outputview/outputdelegate.h
  •   outputview/outputjob.cpp
  •   outputview/outputjob.h
  •   outputview/outputmodel.h
  •   plugins/execute/nativeappjob.cpp
  •   plugins/executescript/executescriptoutputmodel.h
  •   plugins/executescript/executescriptplugin.cpp
  •   plugins/executescript/executescriptplugin.h
  •   plugins/executescript/scriptappjob.cpp
  •   plugins/executescript/scriptappjob.h
  •   plugins/externalscript/externalscriptjob.cpp
  •   plugins/externalscript/externalscriptplugin.cpp
  •   plugins/externalscript/externalscriptplugin.h
  •   plugins/standardoutputview/outputwidget.cpp
  •   plugins/standardoutputview/standardoutputview.cpp
  •   plugins/standardoutputview/standardoutputview.h
  •   plugins/standardoutputview/toolviewdata.cpp
  •   plugins/standardoutputview/toolviewdata.h
  •   vcs/dvcs/dvcsjob.cpp
  •   plugins/standardoutputview/tests/standardoutputviewtest.cpp
  •   plugins/standardoutputview/tests/standardoutputviewtest.h
25 files changed in total