Issue 250

Invalid indexes shouldn't return the root item

The root item has its own index
This fixes a crash in the execute plugin, when having inexisting
dependencies.

Change from KDirWatch to QFileSystemWatcher

I've been having some problems with KDirWatch lately and I couldn't find
a proper way of fixing it in kdelibs, so I decided to change to
QFileSystemWatcher.
I've been using it for some weeks and it works fine, maybe it should be
put in 4.4?

If there are no test results, do not fail.
Adjustment to RSync procedure, to make it more reliable

Notify when an executable dependency can't be found

Or you could get to the awkward situation that it's not being compiled and
your changes aren't being tested.

Fixed: ensure dependencies between base Kasten libs and OktetaKasten libs (using targetnames, not output names)

As long as the base Kasten libs are part of the build tree of Okteta, the linking lists need to use the
the target names instead of the output names, otherwise the dependency is not known.

Import more concepts related to plots-dictionaries from khipu and gplacs. Minor fixes in spacesdelegate. Create the data folder when we can save the *.plots files that contains plots definitions in analitza syntax

Fixing HFR calculation. Adding a low pass and equalize filters for images

Switch from poster image to video player after video has started playing

If we switch immediately after the play() trigger, a black frame is visible
for a moment, which looks ugly.

Fix crash when changing between memory profiles

Changed when the thumbnail cycler is active
Now it is always active, unless the cursor is over an image that is selected and the control key is pressed down
This allows contrl+plus/minus to work to chaning the current video image, while maximizing the visibility of the thumbnail cyckling

Fix bug of not showing tiles in low profile mode

don't use downscaled image to render preview, it will differs than final rendering

Make --unique also raise the window


FIXED-IN: 4.10.0

extract fractions of seconds when extracting thumbnails for videos
This addresses bug #305328. The problem was that several frames extracted was
the same, and therefore the algorithm for finding the current image was broken, as when I was at image 2,
it found image 1 as being the current, as image 1 and 2 both where the same

format number correctly for mplayer.

Do not show the save changes prompt twice if the main window is closed

Call m_part->closeUrl with promptToSave=false in the Shell dtor, so that
the save changes prompt is not shown again (it's already shown because
of Shell::queryClose)

Fix copying of files with extended ACLs.

The switch to #cmakedefine01 in KDE Frameworks has detected a missing
#include <config-acl.h> in file_unix.cpp ever since it was splitted
out. In case we still had a doubt about how much more superior the
cmakedefine01 (#if instead of #ifdef) solution is...


(not tested, but might help...)

Start building up of ClientModel with the first Client to include

So far the first Client to be shown in the list (that is the
currently active window) was inserted as the last client into
the list by prepending it to the list.

This meant that if another Client actually blocks the inclusion
of the currently selected Client (e.g. only one window per app)
the currently active Client never got included in this list.

This change ensures that the recently used model switching has
the starting Client as the first Client in the list and also
simplifies the code.

Stacking order switching mode is not adjusted as it seems rather
broken, like the comment already says.


FIXED-IN: 4.9.1
REVIEW: 106139

show right completion name

Fix multiple issues in colors KCM

- do not offer "Current" (or "Default") name for saving
- update preview icon when a colors gets changed
- write "Current" as scheme name, when the temporary theme is used
- upon loading the "Current" scheme, mark it as "needs saving"
- update preview icon for "Current" scheme when it is applied

See review description for details.

REVIEW: 106066

FIXED-IN: 4.9.1

- allow plugins to have config dialogs
- add a part to config to list plugins and show info or config dialog
- simple working plugin config dialog for tvdbmal plugin
- minor bugfixes

REVIEW 106169

Do not crash when finishing inline renaming in unusual ways

The crash was caused by a null pointer dereference when, e.g.,
minimizing Dolphin. The root cause was that
KStandardItemListWidget::closeRoleEditor() was called twice: once when
the role editor loses focus, and once again when the window is resized.
After m_roleEditor was set to 0, the second call dereferenced this null
pointer. I think the best solution is to disconnect from the role
editor's signals when the editor is not needed any more by the
KStandardItemListWidget.


(cherry picked from commit a9c2bdc3b53955693e716bbab58c318fe25bdc9b)

Fix KPushButton(QIcon)

Ack'd by tsdgeos

Do not crash when finishing inline renaming in unusual ways

The crash was caused by a null pointer dereference when, e.g.,
minimizing Dolphin. The root cause was that
KStandardItemListWidget::closeRoleEditor() was called twice: once when
the role editor loses focus, and once again when the window is resized.
After m_roleEditor was set to 0, the second call dereferenced this null
pointer. I think the best solution is to disconnect from the role
editor's signals when the editor is not needed any more by the
KStandardItemListWidget.


FIXED-IN: 4.9.1

Delay setting passive status

Set passive status after some delay
to allow users to be notified that it is safe to
remove the device before the applet becomes hidden


FIXED-IN:4.9.1

fix untabbing position

the geometry setting needs to happen out of recursion,
has to be smarter for unmaximizing and also no real
place in TabGroup - the client is no longer tabbed thus
it's not the groups task to manage it's geometry.


REVIEW: 106182
FIXED-IN: 4.9.1

don't crash when PAM prompts at the wrong time

Use correct font for metrics calculation


FIXED-IN: 4.9.1

Fix abort with Qt5

Send DuckDuckGo t=kde rather than t=KDE, at their request.

Whitelist AMD Catalyst for kwin direct rendering


FIXED-IN: 4.10
REVIEW: 106050

Fix crash in avahi DNSSD service

REVIEW: 105613

FIXED-IN: 4.9.1

Show icon tooltips in systray

At last, re-add icon tooltips to the QML version of the
device notifier.
This fixes a long overdue regression introduced in 4.8
We should consider backporting to 4.9. Unfortunately we had to introduce
a new string so I have to think if it is really worth it.

fix flicker with fullscreen effects


FIXED-IN: 4.9.1
REVIEW: 106142

Fix wrong behaviour, when Dolphin is started with --split argument.

Actual Results:
dolphin starts without split view

Expected Results:
dolphin starts with split view

New behaviour:
* no url given - use default url for all two views
* one url given - use given url for all two views
* two urls given - open the first url in the left view and the second url in the right view


REVIEW: 106171

(cherry picked from commit d430a1c3b3c7485149f5486e38f4188074d09c0d)

NTFS doesn't support chmod, so ignore chmod errors when copying files.

FUSE doesn't make it easy to detect NTFS mounts, though...
In this code we have to hardcode "fuseblk" and hope that more recent versions
of FUSE indeed show "fuseblk.ntfs-3g" instead, as a bug report suggested.

But even worse: I want to replace this code with KFileSystemType which
uses statvfs(), which is much faster and less code, but on linux that method
returns the same number (FUSE_SUPER_MAGIC, 0x65735546) for all fuse filesystems :(

Also add SMB/CIFS mounts to the list of filsystems "made by microsoft and therefore
doesn't support chown, chmod, utime, nor proper symlinks".

FIXED-IN: 4.9.1

correctly align tabbing shade mode, including hover

REVIEW: 106258

FIXED-IN: 4.9.2

fix untabbing position

the geometry setting needs to happen out of recursion,
has to be smarter for unmaximizing and also no real
place in TabGroup - the client is no longer tabbed thus
it's not the groups task to manage it's geometry.


REVIEW: 106182
FIXED-IN: 4.9.1

Fix Bug 183448 - not intuitive drop-down filter criteria - add default

text

FIXED-IN: 4.10

Fix contact birthday synchronization

Apparently, QDateTime::isValid() returns false when only
the date is valid, but time not.


FIXED-IN: 0.4.2

In feedListToOPML(), add a crash guard for m_feedList

Should fix the case of even the default feedlist being empty.

FIXED-IN: 4.9.1

Fix Bug 255008 - external editor: string replace for the window id to be

used with xembed

use %w for windows id.

and fix command line parsing when we have "emacs --toto=%w"

FIXED-IN: 4.9.1

Only update the item access time if we actually retrieve payloads.

So far even a simple meta-data listing updated the atime, which includes
syncing resources. This should explain why barely any cache content was
purged (e.g. IMAP syncs list every item, and thus did update their access
time) and it also seems to massively reduce disk I/O during syncing.

Now fix for real the mail loss on spam filtering. The previous fix's idea was good, just that unfortunately the default value is "setCacheOnly(true)" set in AgentBasePrivate, so we have to explicitely set the cacheonly to false, otherwise mail content is not fetched from the mail server when passing through a filter that *needs* a content.

FIXED-IN: 4.10

Fix Bug 264153 - KMail crashes whne using the Prev. Message button

FIXED-IN: 4.9.1

Bug 266082: Fix KAlarm button not highlighting alarm in main window

Clicking the KAlarm icon button in the alarm message window didn't
always highlight that alarm in the main window's alarm list.
Applies to KResources build only.

Fix Bug 97239 - better support for including own vCard into mails

(need kdepim)

FIXED-IN: 4.10

Store gd:fullName as formatted name

Store display format of the name directly in gd:fullName.
Google can apparently deal with it well and KABC can parse
the reply as well.


FIXED-IN: 0.4.2

Fix memory leaks

Re-enable document compatibility with 2.4

But only if there aren't any compositions. Krita 2.4 can only load
documents where there is nothing else but layers in the image; 2.5
adds compositions and master adds assistants.

So, if there are no compositions, don't save an empty composition tag,
then 2.4 can still load the document. If there are compositions or
assistants, it's tant-pis...

Better mouse velocity calculation based on the dynamic brush mouse filter. Impulse and dumping calculation corrected.

Fix crash when merging down the top layer if there is a selection

We shouldn't modify the document on saving, by adding a masterpagename to first paragraph
which is not what the user would expect. Think if the user would later on copy paste this paragraph
to somewhere in the middle of another master page. That would copy the masterpagename to causing an
unwanted pagebreak and masterpage change

This was originally added in 9472dc5b to fix pagestyle not being saved, but a quick check
shows that the original bug https://bugs.kde.org/show_bug.cgi?id=184858 is not reopenend by
removing this code now.

Fix memory leaks

==31293== 1,708 (136 direct, 1,572 indirect) bytes in 1 blocks are definitely lost in loss record 2,039 of 2,111
==31293== at 0x4C2B1C7: operator new(unsigned long) (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==31293== by 0x6B512A1: QObject::QObject(QObject*) (qobject.cpp:721)
==31293== by 0x8767D6D: KoCharacterStyle::KoCharacterStyle(QObject*) (KoCharacterStyle.cpp:343)
==31293== by 0x8773CDF: KoParagraphStyle::KoParagraphStyle(QObject*) (KoParagraphStyle.cpp:97)
==31293== by 0x7F6E40C: KoTextShapeData::loadStyle(KoXmlElement const&, KoShapeLoadingContext&) (KoTextShapeData.cpp:331)
==31293== by 0x8B8EDDD: KoTosContainer::loadText(KoXmlElement const&, KoShapeLoadingContext&) (KoTosContainer.cpp:88)
==31293== by 0x22E762B6: EnhancedPathShape::loadOdf(KoXmlElement const&, KoShapeLoadingContext&) (EnhancedPathShape.cpp:585)
==31293== by 0x8B3C5D0: KoShapeFactoryBase::createShapeFromOdf(KoXmlElement const&, KoShapeLoadingContext&) (KoShapeFactoryBase.cpp:228)
==31293== by 0x8B38735: KoShapeRegistry::Private::createShapeInternal(KoXmlElement const&, KoShapeLoadingContext&, KoXmlElement const&) const (KoShapeRegistry.cpp:313)
==31293== by 0x8B382BB: KoShapeRegistry::createShapeFromOdf(KoXmlElement const&, KoShapeLoadingContext&) const (KoShapeRegistry.cpp:268)
==31293== by 0x1D047D12: KoPAPageBase::loadOdf(KoXmlElement const&, KoShapeLoadingContext&) (KoPAPageBase.cpp:212)
==31293== by 0x1CD5DBEA: KPrPage::loadOdf(KoXmlElement const&, KoShapeLoadingContext&) (KPrPage.cpp:126)

here the default style is not freed as the paragraph styles.

REVIEW: 106154

Fix various typos (mostly found by Krazy2).

Fix repeat playlist with a single track

If there was only one track in the playlist, it would not be repeated
correctly.


FIXED-IN:2.7
REVIEW:106175

make mimetype generation largely done by cmake

pvlc only features static mimetype listing (i.e. even the runtime
function returns a compile-time static list of mime types as VLC plays
all and everything anyway). up until now this list was manually maintained
in both the desktop file *and* the backend.cpp, this is now replaced by
*one* list in cmake which is consequently put into a c-string array for
backend.cpp (accessed via mime.h as generated by cmake) and regular
list form (; del) for the desktop file.

this also addresses the issues raised in
REVIEW: 106075

Fix playlist layout 1% width being treated as auto

Items set with a custom fixed width of 1% were erroneously being treated
as if they were set to automatic width.


FIXED-IN:2.7

fix aboutToFinish thresh calculation

for continuous streams we get a length of 0, so we need to exclude <= 0
from delta calculation, otherwise aboutToFinish gets immediately emitted
for streams triggering a bogus source change in a consumer

Fix typo in generalpref.ui

Do not pass link local IPv6 addresses to ip parameter of tracker

Handle url redirections correctly.

Fix some race conditions, and improve PPD selection when called from the new printer popup

improve nepomuk-tp code

--warnings
don't leak d-pointers

Don't treat MC errors as fatal


Reviewed-by: Martin Klapetek

Fix setting bogus icon theme

If the settings were wrong it would leave the combo box
empty, now it's just using the first theme in the combo.

Improve SourcesPage visualization glitch

When the suites and the repo name overlap, elide the repository
name.
I had to remove the italics because of a QML Text limitation.

Added "Rename" and "Reorder"

Added buttons in the List tab to rename a list item and to reorder the
list in order to be able to check that TableModelChanged event is handled.

Add support for specifying an HTTP proxy to setup script.

A prompt is used to ask if a proxy is required, unless the normal
http_proxy env. variable is set, at which point the proxy URL will be
queried for directly (and the value of http_proxy used as the default).

This should implement wish 305410.


FIXED-IN:1.16

Added color scramble and option

* Added the possibility to play place clicking with scrambled colorset
in order to not let player memory leniently remember country by color
but really by shape and or place.
* Added an option in configuration dialog for setting "scrambled" or not.

apply patch from Marcus Meissner to support libgphoto 2.5.0 API
CC

Allow to search with a different plugin when no search result could be found

This is pach from Yuen Hoe Lim with some modifications to adapt to the latest changes

The first selected plugin is the one configured as favorite plugin in the KConfig file.
Afterwards all available plugins will be used until a some metadata could be found or no plugins are left.

make the client shutdown timeout configurable

sometimes the timeout for applications to shutdown is too short, e.g.
when running on old hardware, having lots of applications open,
browsers with many tabs, etc.
This patch adds two config entries with which you can define the
timeout before ksmserver kills the apps.
In the [General] section of ksmserverrc you can define:
legacySaveTimeoutSecs (default = 4 seconds)
clientShutdownTimeoutSecs (default = 15 seconds; was 10 before)



FIXED-IN: 4.9.1
REVIEW: 106090

Add fade effect to strings change in Now playing plasmoid when in a panel

Reviewed-by: Marco Martin
REVIEW: 106095

Option to disable window close on menu double click in Aurorae

For each theme the setting can be enabled individually with the
default being enabled by default. It is completely handled
inside the MenuButton QML component so each QML theme benefits
from the option automatically, too.


FIXED-IN: 4.10
REVIEW: 106160

Support for Plastik's configuration options

Adding a KConfigXT xml file and an ui file to configure the QML
variant of Plastik.

Currently supported options:
* title alignment
* title shadow
* animation of buttons

Missing option:
* colored borders

Introducing sendiTIPMessage().

Was missing in the API.

Implementation was based on kdepim/calendarsupport/utils.cpp
scheduleITIPMethods(). Has async error handling now.

This is used by korganizer's "schedule" menu.

Recover from lost external payload files.

This will reset part table entries for those, so that we'll re-retrieve
them from the corresponding resource.

Now kmail support attach vcard

Introduce Author into the Calligra family.

REVIEW: 106064

Add support for user data storage and remember column widths in table

Core
*Add support for user data storage


Table View
*Remember column widths in tabular data view


REVIEW:106132
DIGEST:Kexi gets support for user data storage and remembers column widths of table views.

Implemented unmounting from within the browser.

Improve presentation of sub journey and binary data in variable dock

- Show binary data in hexadecimal format, add context menu action
to open binary data in Okteta
- Show deeper levels of results in the variable model for the result
script object, this makes data of RouteSubJourneys vivisble in
the variable dock

Add 'Save', 'Save As' and 'Save Copy As' actions to the tab context menu

show busy cursor while an application launched by krusader starts up

Make the openRecent just be open recent

Stop being too smart for own our good, try to merge open and openRecent actions in just one action
confuses the hell out of people, so let's KISS and just make open recent be open recent


FIXED-IN: 4.10.0

use Plasma::Package for finding files

however they don't have globally installed desktop files, can't be queried by sycoca

Split the User Actions Menu out of Workspace

All methods and variables related to the User Actions Menu
(rmb window deco, Alt+F3) is moved out of the Workspace class
into an own UserActionsMenu class.

The class needs only a very small public interface containing
methods to show the menu for a Client, closing the menu and
discarding the menu. Everything else is actually private to the
implementation which is one of the reasons why it makes sense
to split the functionality out of the Workspace class.

As a result the methods and variables have more sane names and
the variable names are standardized.

REVIEW: 106085

FIXED-IN: 4.10

Merge branch 'mergeQueryService'

Merge the QueryService into the storage service. This allows the query service
to directly access the virtuoso model instead of using the NepomukMainModel
which uses a local socket to communicate with the model in the storage
service.

Results in a big performance boost for queries using the QueryServiceClient

Remove xdgbasedirs copy, replace with a call to QStandardPaths.

Cool, huh? :-)

Merge branch 'storage/mergeBackupService'

The BackupSync service does almost nothing and it doesn't make sense for
it to exist in another process. Combine it with the storage service.

Another reason for doing this is that eventually we will close up the
traditional Soprano interfaces, and the backup service needs special
privileges in order to restore the backup. It can only do so if it
exists in the Storage Service.

Also, I would like to "lock up" the storage service when a backup is
being restored.

Conflicts:
services/backupsync/service/CMakeLists.txt

Remove old metadata created by the extractor before new data is added again

If the old data is not removed, properties with a cardinality > 1 will still have the old and possibly wrong metadata attached to the file
This patch ensures only the newly selected metadata will be used.

All metadata will be attached with the KComponentData("metadataextractor").
This should ensure adding/removing works even if the library is used outside of the extractor

Remove the last mentions of KDEHOME everywhere in kdelibs.

Port tests to QStandardPaths::enableTestMode.

Port kstandarddirstest to its own XDG_*_HOME vars (can't use enableTestMode
there, we need to know expected results). That makes it unix-only, probably.

This also meant getting of lnusertemp, which was creating symlinks inside
KDEHOME.

Support for custom configuration dialogs for QML decorations

If the decoration package contains a ui file in ui/config.ui and
and KConfigXT xml file in config/main.xml the configure dialog
is extended by the custom values.

For this the ui file is loaded and included in the dialog's
layout. To make this possible the AuroraeConfigForm is changed
to a VBoxLayout containing the so far used FormLayout.

The configuration settings are loaded using Plasma's ConfigLoader
and attached to the widget through a KConfigDialogManager.

Marking this commit as the one which implements QML support for
Aurorae themes:

REVIEW: 105751
REVIEW: 105768

FIXED-IN: 4.10

Port KStandardDirs to QStandardPaths for XDG_*_HOME, fixes 2 unittests.

(i.e. with Qt5, this makes kbuildsycoca respect --testmode)

NepomukRunner: Port to NepomukCore

REVIEW: 106117

Allow to use the real Session scheduler when using FakeSession.

This allows easy testing of Akonadi::Job, as well as parts of Session
itself.

wrap the KPasswordDialog in a QPointer to inhibit crashes.

Use a more portable ps(1) call in the clamav script.

-e means all processes are selected on Linux's ps, while on the BSDs
and OS X it means the environment should be printed along with the
commands.

Replacing -e with -a -x should work on all platforms according to the
Linux, OS X, FreeBSD, OpenBSD and NetBSD man pages.

REVIEW: 106111

Set default type as "currency" in "Units" page when primary and secondary units are already defined

implement pausedplay mechanic

phonon's api suggest that pausing before playing is possible (through
naming of the interfaces) however vlc does not provide any such
functionality so once again we do a nasty intercept-hack.

pausedPlay issues a regular play but then intercepts the VLC playing
event and directly switches to paused.
nothing outside MediaPlayer ever knows that VLC actually was in playing
state and a completely transparent switch from non-playing to paused
becomes possible.

please note that this does not in any way guarantee that no audio/video
samples are already sent to the output. it merely tries to reduce the
chance of this happening by calling pause in the event callback, which
is of course threaded from the pipeline so anything can happen between
us getting the signal and asking VLC to pause.

verification for backport pending.

Add RouteSubJourneys and RouteNews

- RouteNews contain information strings about each connection
between two route stops
- RouteSubJourneys contain data about routes between connecting stops
- There are now intermediate stops that are also connecting stops,
ie. intermediate stops in journeys where the vehicle gets changed
- Intermediate (not connecting) stops can be toggled in the applet
with the context menu
- Update DepartureProcessor to load sub journeys into a new
RouteSubJourney struct
- Update JourneyRouteGraphicsItem to show routes with/without
intermediate stops, but always with connecting stops
- Without RouteSubJourneys information from the engine journeys
should be drawn like before
- Add routeNews() and routeSubJourneys() to DepartureInfo
in libpublictransporthelper and add struct RouteSubJourney

TODO: Maybe turn the intermediate stop toggle action into
a StopAction to toggle specific sub journeys and not all at once
TODO: Update providers to provide such information

Delete invalid history items to avoid leaking memory in this case.

Player/Invaders: Use the new components for interface rendering.

Replace custom CMakeLists.txt creation with call to createFile().

REVIEW: 106155

Finish fixing this unittest for Qt5, with the use of more QString::fromLatin1

Merge branch 'plasma/bookmarksrunner-chrome-gulino' of git.kde.org:kde-workspace
Merging Bookmarks runner refactorings, including new support for Chrome/Chromium bookmarks,
and both Chrome and Firefox favicons.

Skeleton for layers model

Added existing Picasa Backend. Need to be modified now to make it working

Increase minimal KDE version to 4.6 because of the use of KDualAction.

Make it possible to detect the disabled sources