Issue 262

Correctly relaying model compilation / adaption cancellation in SPHINX

Bugfixing the calculation of deletion errors

Deletion errors are internally represented as notes that carry the label
of the word that is not present in the result and have the "deletion"
flag set.

While analyzing the a recognition result (in simonmodeltest) these
leaves were inserted at the end of the list of result nodes of the test
sample while processing it. This caused the algorithm to count them
again - this time as insertion errors - when it encountered the new,
trailing nodes.

Example:
Prompt: Foo Bar
Result: Bar
Algorithm:
0. Nodes: {Bar}
1. i = 0; Foo is missing, Bar is okay -> Nodes: {Bar[Okay], Foo[Deletion]}
2. i = 1; Foo at the end is too much -> Nodes {Bar[Okay], Foo[Insertion,
Deletion]}
2. i = 2; Done

After the fix:
0. Nodes: {Bar}
1. i = 0; Foo is missing, Bar is okay -> Nodes: {Foo[Deletion], Bar[Okay]}
i = 2
2. i = 2; Done

Gracefully handle the error case of no job being created

don't crash if no context could be found under cursor

Fix crash in TemplateResolver when encountering invalid type.
Thanks to Kevin Funk and André Stein for investigation.

REVIEW: 107175

Use the proper default font in RichTextToolButton.

This way we have consistent font sizes in our assistant popup when a title is shown.
Note that the default toolbar font is apparently also slightly smaller, thus giving us a bit more space.

Ensure we do not delete the suite that is re-added.

Bug fix - use scene size for wrapping text labels exceeding the scene bounding rect.

Fix problem with device types getting recreated

training screen: fix key event handling wrt to CJK input methods

I must confess that I as an European citizin have only little insights
into the nature of those input methods but at least the behavior of
KTouch is now consistent to the normal Qt input widgets when used with
IBUS: We show the preedit text (which we don't check for errors,
obviously) and the suggestions popup, if there is any, is positioned
right next to the cursor caret there it is supposed to be.


FIXED-IN: 2.0

training screen: fix key event handling wrt dead keys

Turns the event handling in QML is too limited to properly support dead
keys. At least on X11 dead key handling is part of some input method
and one has support for them in QML. Therefore the event handling part
of the training line has been moved to C++.

While I'm at it I also made sure that the training widget acts more line
standard input widget, so Ctrl+Backspace now deletes the last word.


FIXED-IN: 2.0

home screen: fix a bunch issues in the profile selector

Fix automatic profile selection after deletion of a profile and fix
stat display of newly created profiles.

Fixed 2 bugs

Fixed 2 bugs related to the same problem.
Cause: Roles in search page were not updated, I removed them
and use the roles in class CollectionTreeModel

Fix adding bookmarks (regression from fa70f0c)


FIXED-IN: KDE/4.9.4
(cherry picked from commit a84b5638dc6f073570c6189a43effddb9b803040)

Fix export of line pointer attributes for TikZ export.

Fix bug with telescope pointer on skymap when sending new coords

Fix crash when XVidExtWrap is not available

This can happen when run as root

FIXED-IN: 4.10

Don't call updateWebSearchMenu from selectionChanged. The search menu items will
be added before the context menu is displayed.


FIXED-IN: 4.10

support $XDG_CONFIG_HOME/fontconfig/fonts.conf


FIXED-IN: 4.9.4

fontconfig > 2.10.0 supports putting it's user config at
$XDG_CONFIG_HOME/fontconfig/fonts.conf now.

Fix buffer swap prototypes


REVIEW: 107302

Fix kate inputMethod query for Qt:ImCursorPosition and Qt:ImAnchorPosition

Current kate implementation for Qt:ImCursorPosition and Qt:ImAnchorPosition
is not correct. Qt:ImCursorPosition should always return the correct position
of cursor position of Qt::ImSurroundingText. Qt:ImAnchorPosition should return
the anchorPosition of selection, when in different line of cursor or there
is no selection, return the same position of cursor.

REVIEW: 104788

eject the optical drive with the unmount option

fixes #274982 - The 'eject' action only unmounts data CDs rather than
ejecting them

Prevent a Q_ASSERT crash when invoking ftpCreateUDSEntry.


FIXED-IN: 4.9.4

correct the margins

react to scrollbars being visible or invisible
correct margins of the borders

Update 'UrlFilter' regular expression.

Fix issues with URLs that end with ')' and ':'.


FIXED-IN: 4.9.4

REVIEW: 107340

Fix memory leak when connecting signals and slots through the QObject binding.

A char* was used to store the signal name, and another char* was used to
store the slot name. Each name was a deep copy of the data of a
QByteArray, made with qstrdup. The copies were not deleted, and this
caused the memory leak.

However, instead of explicitly deleting the copies, another approach was
taken. As they were copies of the data of a QByteArray, the type of the
signal and slot variables was changed to QByteArray, and the original
QByteArray was assigned without copying. Now, QByteArray will take care
of deallocating the memory when needed.

REVIEW: 107324

Fix initial paint for analog clock

Unconditionally setting repaint mode to RepaintHands will clear
the initially needed RepaintAll mode, causing the background
cache not to be initialized.


FIXED-IN: KDE 4.9.4

Fix sizing of KMessageWidget when shown at startup

Resize the content when the widget width changes so that when a
KMessageWidget is shown at startup its width is correct.

REVIEW: 107336

Fix convoluted crash on deletion of Query::Folder.

Sequence of events seems to be:

1. Folder::~Folder called.
2. SearchRunnable->cancel called => SearchRunnable->m_folder = 0.
3. Deletes all connections.
4. deleteLater called again, during destructor (is this ever safe?)
5. SearchRunnable::run called => since m_folder is zero, returns and
deletes SearchRunnable without setting m_folder -> SearchRunnable to
zero.
6. mutex unlocked at end of destructor
7. Folder::~Folder called again by queued deleteLater (?)
8. SearchRunnable already deleted after step 5. Crash.

Fixed by setting m_currentSearchRunnable = 0 after cancelling the folder
listing.


FIXED-IN: 4.10
REVIEW: 107339

Handle copy destination for storages correctly

Fixes storages not being recognized as valid destinations when copying
to the device. Also added some more sane debug information.

fixed crash in searchView, added brandingButton with status info

change size constraints
no jumping windows anymore

Don't call updateWebSearchMenu from selectionChanged. The search menu items will
be added before the context menu is displayed.


FIXED-IN: 4.10
REVIEW: 107511

(cherry picked from commit 7656ce515ad6676c591dff5a547657c6f57036bb)

Fix Bug 308227 - Changing identities (that have different custom

template) in composer window doesn't take effect for the message body

FIXED-IN: 4.10

Fix Bug 309891 - Filter buttons and context menu option are not shown

FIXED-IN: 4.9.4

Don't allow invalid end and start times.


FIXED-IN: 4.9.4

Remove progress windows when loading kolab

The Progress bar shown when loading the kolab ressources
for calendar and addressbook opened in a new window because
the main windows is blocked in that period.
On modern desktop computers this usually is over before one
could even read what the window was about and just an annoying
filcker changing the window layout. If it takes longer it was
annyoing because the progress window stole the focus and one was
unable to do something else during that time.

Now a busy cursor is used to indicate that loading is still
in progress.

Fixes:
kolab/issue4859

Revert 4fd1a2b2d4.

Fixes double free crash at exit.

We can't use QWidgets as K_GLOBAL_STATICs. QWidget's dtor
dereferences other global pointers (X11 stuff), which might,
or might not already been destroyed.

Works well when K_GLOBAL_STATIC deletes the widget before those
global pointers are destroyed, but we can't control the order.

Till, what about doing the caching inside the dialog's implementation?

Don't show "offline" checkbox for local resources

Fix Bug 276410 - Geometry issue - phone number widget doesn't resize

height
FIXED-IN: 4.10

Bug 306178: sort alarms properly in newly enabled collection

Made the zooming steps consistent in Krita

1) Now the wheel and hotkey zooming in Krita is done using KoZoomAction
instead of hardcoded code
2) The zoom levels are changed to be in consistency with other
applications (checked in Adobe Reader and Adobe Photoshop).
Such change was demanded in bug 302775

Fix the investment accounts handling in the institutions view.
Make the investment accounts the only accounts that are added
to their parent in the institutions view. The rest of the
accounts are added at the first level because they don't inherit
the institution from their parent. Thanks to Allen for working on
this.

Fixed the second half of bug 302758

This patch almost rewrites the KisInputManager to fix the mentioned
bug. Now all the state transitions of the actions are controlled by
a special class KisShorcutMatcher. This class is easily controlled by
a separate unittest. The work of the actions is now can be represented
by a simple state machine with three states (see docs for class
KisStrokeShortcut).

Fix bug in kplato xml loader

Always set parent schedule for all schedules.
Remove schedules wo parent (due to error in xml).
This could lead to crash in scheduling.

Fix another crash

Fixed the second half of bug 302758

This patch almost rewrites the KisInputManager to fix the mentioned
bug. Now all the state transitions of the actions are controlled by
a special class KisShorcutMatcher. This class is easily controlled by
a separate unittest. The work of the actions is now can be represented
by a simple state machine with three states (see docs for class
KisStrokeShortcut).

Fix bug 309109: CWOP: Opening a document sets it to Modified

Fix broken group move when dragging an empty group zone

Fix crash on transition select

EngineController: fall-back to Phonon's equalizer band names on parse error

We used to parse equalizer band names as returned by phonon, but it
seems that at least some phonon backeds now just return "band0",
"band1" etc. Fallback to phonon names to expose the bug and let
Phonomials do something with it.

Note that there's one unrelated bug: Amarok doesn't recognise phonon
equalizer doesn't support pre-amplifier and misaligns labels by one.

Fix volume switch for controls with a virtual/simulated mute switch.
CC

Use AccountsComboBox in AddContactDialog and JoinChatRoomDialog

This removes incorrect usages of ContactModel to create lists of accounts in common internals,
as well as removing some duplicate code.

This patch also fixes the JoinChatRoomDialog not updating as accounts become online/offline.

REVIEW: 107321

Fix switching contacts in global search results

Also fix a potential crash

REVIEW: 107273

When editing an account always unset any password stored by Mission Control

Add an additional guard around EditAccountDialog::accept()

This checks the potentially null pointer d->widget, before trying to use it

Fix black screen on start issue.

QtQuickRenderer should have a higher z depth to always render it on top

Temporary fix to the issue of Z-sorting the GUI with the scene contents.
Later on this should be made configurable.

Prevent tests from hang due to modal widgets.

Under some circumstances (like high system load) the target application
used in the tests may take more time than expected to start. In that
case, the RemoteObjectChooser may show a message box to inform the user
about the problem. If that happens, the test hangs until the message box
is closed.

A system to automatically close an unexpected message box was added. To
ensure that the message box is an unexpected one and thus is hanging the
test, it is closed once the timeouts used to close the expected message
boxes have expired.

Auto-switching recognition backend based on the model type

Implementing scenario configuration from within context ui

Adding locking to sound input client

Add status icons to document list tab bar button.

The status icon of each document in the document list next the tab
bar status label is now shown and updated accordingly. Additionally
the context menu is not built up every time but only if a new
document is added (was updated before with each action: remove,
title change and addition).

REVIEW: 107326

SatellitesPlugin: Show yellow orbits

Remember last used base url, per device

Introduce a new class based on DImgThreadedFilter to run Image contents Analyser
This class is a simpleied wrapper of DImgThreadedFilter. It do not support versionning, parameters registration, and target image.
The goal is to be able to run in a separated thread a computation code to analys image and give suitable information, to adjust filter
settings for ex.
In oposit, this class take benfits of DImgThreadedFilter, as progress, chained thread, etc...
We use this class now in Noise Reduction tool, to run Noise Estimate algorithm.
TODO : Use this class into WB and Levels Tools, which has image analys features.

Display profile graph in information panel
Remove trailing spaces

REVIEW:107309

Add support for music album cover art via http://coverartarchive.org/" target="_blank">http://coverartarchive.org/

The MusicBrainz! plugin can now retrieve cover art for music albums
via its http://coverartarchive.org/" target="_blank">http://coverartarchive.org/ subproject.

The data will be saved in the application folder or next to the file
depending on the system settings and added via nfo:depiction to the
nmm:MusicAlbum.

Make taglibextractor index flac and ogg files.

Currently taglibextractor handles only mp3 files, but there shouldn't be
any reason not to also index flac and ogg files.

REVIEW: 107294

Signed-off-by: Luca Beltrame

Implement color correction (per output)

Add an option to kcmcompositing in the 'Advanced' tab, to enable or
disable color correction. It is specified that it's experimental and it
needs Kolor Manager.

Before painting for a particular screen, ColorCorrection::setupForOutput
should be called.

A screen property is added for WindowPaintData.

In kwinglutils, The fragment shaders are intercepted before being
compiled and they get a couple of lines of code inserted in order to do
the color correction. This happens only when color correction is enabled, of
course.

For D-Bus communication with KolorServer, everything is async.

The implementation basically manages a set of color lookup tables for
different outputs and for different window regions. These are taken via
D-Bus. Each lookup table has around 700 KB.

This commit reintroduces the changes from the former merge with the
"color2" branch. In this form, it can be easily reverted.

REVIEW: 106141

use kwin for dialog shadows if possible

if the dialog svg has a separate element for shadows, use those and tell kwin to draw them
same method already used for panels

Added hidden option to disable extended window borders.

comic plasmoid ported to QML
REVIEW: 107192
FEATURE:

KDE5: enable 3rd party apps to enable/disable swap files

The current DataRecoveryInterface lacks this...

LRU sorted document switching
will keep track on view activation
the CTRL-ALT-O list is LRU sorted, latest used doc first
pre-seletected is the previous used doc
just cursor down to broswe in LRU history order
we can't have CTRL-ALT-LEFT/RIGHT do that without such a dialog, otherwise you just would
swap between the latest 2 documents, as as soon as the next one is activated, the last
used one will be next in lru stack

background frame moves into its own subitem

This way, we can control the opacity of the background independently
of the whole plasmoid, so fade it in and out without changing plasmoid
visibility. We forward the margins for good layout measure

Add new properties to QMLOutput with current output dimensions

For some reason calling output.mode(output.currentMode) from QML
always returned 'undefined' result, even when it should not.

Now this is handled from C++ backend (where it magically works)
and QML accesses these values through currentOutput{Width,Height}
properties of QMLOutput.

Now it works we can show colored quoted text

add supported mimetypes


FIXED-IN: 4.8.4

Multithreading

Adding WMF support to vectorimage library and updating dependent components.

Added the long awaited 'tags' feature

Thanks to the implementation provided by Alessandro Russo, we now have
the long awaited tagging feature.

REVIEW: 106846

DIGEST:

Added discrete rotation and zooming shortcuts

kdenlive looping in jack mode works completely now

implemented looping in jackslave because the consumer-paused event does
not work properly if audio_off property is enabled and seeking is done
with zero speed (best seeking performance and smoothnest).

StatSyncing: ChangeLog and BUG: tags for the final merge

This is a cummulative ChangeLog for my GSoC 2012 project, statistics
synchronization.

Individual commits responsible for the changes are earlier, but under
the same git merge.

FEATURES:
* Track dragging support in Unique Tracks tab of the Synchronize Statistics action;
allows you to do a "diff" between collections and transfer missing tracks.
* Amarok now scrobbles tracks in streams if the stream correctly updates
meta-data.
* When scrobbling to Last.fm, Amarok announces suggested tag corrections.
* Ability to scrobble recently played tracks from iPod (and the like) to Last.fm.
* Synchronization of labels and rating between Last.fm and Amarok collections;
play count can be synchronized one-way from Last.fm to Amarok.
* Statistics synchronization between collections, supports rating, first / last
played time, play count and labels.

CHANGES:
* Configure Amarok dialog gets new Metadata tab to grab some weight from the
Collection tab and to configure statistics synchronization.

BUGFIXES:
* Better Last.fm scrobbling behaviour and error reporting due to rewrite,
should fix long-standing problems.
* Update stream meta-data correctly even with phonon-gstreamer back-end.






FIXED-IN: 2.7
DIGEST: Amarok statistics synchronization GSoC project merged with many features
and improvements, please see http://strohel.blogspot.com/search/label/gsoc
for more info and a bunch of screen shots.
GUI: Added statistics synchronization dialogs, split and one more config dialog tab

Implement optional Pulseaudio volume overdrive (PA_VOLUME_UI_MAX).
CC

System tray volume control can now have its own orientation.

basic jack enabled looping implemented

kdenlive: play zone or loop zone feature

make jack seeking just awesome

Show notification when torrents are opened silently, patch from Maarten De Meyer.


REVIEW: 107094

Add basic proxy model to filter out non-IM contacts

Use a custom AccountsListModel role to show enabled state and not Qt::CheckStateRole which is application specific.

This was causing checkboxes to appear in combo boxes showing a list of accounts
Also remove flags method which no longer has any effect

Add dialog for initial Kopete logs import

On start up logviewer will check for existing Kopete logs
and offer a dialog to import the logs. This will happen
only once.

REVIEW: 107263

Remove the Close button on the plotter and status dialogs to make them more compact

Plotter widgets behave more like those in the KDE System Monitor

Paint multiple presence icons for Person contact

Import Kopete logs when adding a new account in KCM

When there are Kopete logs that seem to belong to the
same account that was just created in KCM, ask user
whether to import them.

When removing an account, user can remove all account
logs from TpLogger.

REVIEW: 107246

Improve GTFS feed import performance, add messages

- Improve performce by completely disabling the SQLite journal
(not needed, on crash the import can be started again)
- Do not use QTextStream to read GTFS files, read QByteArray lines
directly from QFile, only decode strings
- Do not convert values from string to int/Url/Double in
GeneralTransitFeedDatabase::convertFieldValue(), they get returned
as QVariant and then converted back to int/Url/Double in
GeneralTransitFeedImporter::writeGtfsDataToDatabase()
- Add simple "benchmark" using KDebug::Block, results:
Importing the stop_times.txt CSV-file of the GTFS feed at
http://www.datenfragen.de/openvbb/GTF_VBB_BVG_20110530.zip
into the database went from ~120s to ~70s on my system
(the other files are much smaller, resulting database is ~180MB)
- Add logMessage() signal, provides more information
about the import process
- More information for import job through infoMessage(),
show download speed while downloading and show which table
currently gets imported
- Fix wrongly "const KConfig" to "KConfig" for writing in GTFS service

Add a Sprite class to ease the creation of sprites.

Eventually this should do auto-rotation and similar sprite-ey things
but for now it is just an entity with a default Sprite mesh assigned.

flickr works!

i want to download a thumbnail, but the image is pretty large...too
large to use as a thumbnail..

Better handling of default audio devices in Simon

Make the uses widget nicer.

Main changes include:
* Fix contexts not being clickable (they were clickable but didn't work)
* Remove the blue arrows; all widgets are expanded by default and can
be collapsed with a small link in the text instead. This operation is
not common enough to justify such a huge ugly button.
(The main problem with the button was that it looked ugly, tough)
* Contexts without actual uses are always sorted last.
* Add some nice icons to the list.
* Remove all the ugly frames.
* Make text displaying code use a fixed-width font.
* Make the tooltip use a fixed-width font too, make it smaller (just 2
lines of context instead of 3), and highlight the line with the use
by making it bold-face.
* Re-format and rename all the widget headers to be more readable
and look nicer.

REVIEW:107296

Change meaning of Escape key: goes back to Browse mode

Scroll first match into view


FIXED-IN: 4.9.4
REVIEW: 107284

Re-apply minute hand caching optimization

(also re-apply lost commit 1041099dd18cc46d2c801a7b790ce06c6bed9503)

only use WeatherLocation when needed, and get rid of it when it isn't used

this not only is nicer performance-wise, it also prevents showing the
Configure button (and blocking the entire UI!) when we have a perfectly
valid location already set

Fetcherdialog: select first entry and allow to save automatically

In the FetcherDialog select the first entry always automatically,
this saves 1 click.

Also add another button to fetch and save in one go, to reduce the
number of clicks necessary

get rid of totalcount, allowedcategories

makes the cloud query ~500% faster

Prefilter/sort online search results to allow better automatic selection

The returned search results from all plugins will be checked against
the actual search parameter. The Levenshtein distance is used to get
a measure of the similarity of the results.

Returned search results that are not close enough to the actual search
are skipped, othewise the list will be sorted by this distance.

This improves document and music search a lot and makes the automatic
fetcher without suer interaction) a lot less error prone and allow it
to skip obvious wrong results instead of adding it.

improve autoresize image

Improve the performance of viewportMoved

By not constantly creating and copying QImages we can
increase the perfomance quite a bit. Next target is
copyQImage().

Make drawing of the not-editable text caret look much nice and not be clipped

Optimize scheduling speed

With summary task dependnecies it can be so bad that it seems to freeze.

Rework of the All Music view. Next up are proper covers.
Patch by Fabian Riethmayer
REVIEW: 107299

Replace the QHash mess of the old brokenReason API with a new one featuring a nice MarkingInfoError class that replaces the old nightmare.
API change (freeze will come at 2.0 beta), so be sure to do a rebuild if you're working from master.

Prevent a prossible crash in a wrong STRING() call

Treat some arguments as strings instead of expecting a correct input,
this will prevent a crash in case the input was wrong.

automatic fallback for SSL/TLS protocol versions

Unfortunately some servers are to dump to fall back to the highest
supported version when the connection is initiated with e.g. an
TLS 1.2 ClientHello. This happens with openSSL 1.0.1 on the client side.

The server setup dialog is affected as well and will return encryption
unsupported for the server, this is not fixed yet.


REVIEW: 107099
FIXED-IN: 4.9.4
FIXED-IN: 4.10.0

Conflicts:
kimap/sessionthread.cpp

remove search/replace highlights on hiding passive message

This is truly a sad day :)

Rewrite parts of audio thumbnail. We now use square root for better thumbs, now looks much more like Audacity, also fix when zooming.