Issue 301
18th August 2013 by KDE Commit-Digest TeamContributors
Giacomo Barazzetti
This Week...
Contents
Bug Fixes | Features | Optimization | Security | Other | |
---|---|---|---|---|---|
Accessibility | |||||
Development Tools | |||||
Educational | [] | ||||
Graphics | [] | ||||
KDE Base | [] | [] | [] | [] | |
KDE-PIM | [] | [] | |||
Office | [] | [] | |||
Konqueror | |||||
Multimedia | [] | [] | [] | ||
Networking Tools | [] | [] | |||
User Interface | |||||
Utilities | [] | ||||
Games | [] | [] | |||
Other |
There are 74 selections this week
Bug Fixes
Educational
fix some assumptions that qreal=double, should now be buildable on arm.
correctly set up the UI for cache settings
KDE Base
Make sure that the sort order is correct after renaming
KFileItemModel::setData() should not only cause a resorting when the
sort role is changed. The name is always used as a fallback if the sort
role of multiple files is equal, therefore, renaming a file can change
the correct order of the files even if the files are not sorted by
"name".
Unit test included.
FIXED-IN: 4.11.1
REVIEW: 111721
align zero corner placement to client, not deco
FIXED-IN: 4.11.1
REVIEW: 112102
guide partially max'd windows against corner snaps
FIXED-IN: 4.11.1
REVIEW: 112124
when the request theme does not exist, delete all old caches for it and don't crash
Fix detection of lzma and xz tar archives downloaded from kdelook.org
Review: 111952
symbol viewer: fix perl parsing comments
problem was:
my $foo
= 'bar';
Thanks to John Schroeder for the patch!
FIXED-IN: 4.11.1
make stacking_order exclusive during shutdown
Client::releaseClient() deletes all Client objects
referenced by stacking_order, thus those pointers
dangle and everything trying to touch it died an ugly death.
REVIEW: 112020
Fix rare race condition crash.
Plus surrounding code cleanup.
Do not crash while importing/adding bookmarks.
REVIEW: 112042
FIXED-IN: 4.11.1
fix: Background shading settings are not applied
FIXED-IN: 4.11.1
fix LaTeX highlighting error for \lstinline[]{...}
Thanks to Michael for the patch!
FIXED-IN: 4.11.1
Make the setData() accessor take a QVariant as payload.
The implementation now specifically tries to support byte arrays
being passed in, which is what the base class speaks. To try and
retain the previous behavior anything else is attempted to be
converted to a string and failing that, silently dropped.
Backport from plasma-framework f63357bd and reviewed in 111748.
Prevent the dragging of the last tab in a split view.
REVIEW: 107640
FIXED-IN: 4.12
Fix crash when disabling "Show in groups"
The problem was that items are removed from m_visibleGroups while
a QMutableHashIterator iterates over this hash, such that the iterator
can become invalid. The solution is to use a QHashIterator instead,
which takes a copy of the hash. Therefore, it is not affected if
m_visibleGroups is modified in any way.
FIXED-IN: 4.11.1
REVIEW: 111919
Fix crash when failing to get audio CD block device
For the udisks2 backend, this is already worked
around in Solid, but could fail for other reasons.
FIXED-IN: 4.11.1
REVIEW: 111626
Fix rare race condition crash.
Plus surrounding code cleanup.
Use KDBusConnectionPool instead of QDBusConnection
QDBusConnection cannot be used across multiple threads
REVIEW: 112011
: Handle '{{' and '}}' separately to prevent incorrect hihlighting of inner '{}'
fix flickering in symbol viewer
Thanks to John for the patch!
FIXED-IN: 4.11.1
Add back window ids to the drag data payload.
This e.g. makes dropping tasks on the pager work again.
Add back window ids to the drag data payload.
This e.g. makes dropping tasks on the pager work again.
KDE-PIM
Fix Bug 323636 - Save As overwrites file when choosing rename
FIXED-IN: 4.12
We need a debug dialog for search. We have a lot of bug report about it.
=> i create a widget for debugging it.
Fix disabled "To Desktop" menu
FIXED-IN: 4.11.1
REVIEW: 112016
Return correct error now. User is informed about errors now
Change the notifications filter to match the one from Akonadi::Monitor
The reverse filtering (i.e. getting list of sources that accept
given notification) cannot be mapped 1:1 to the original behavior
of Akonadi::Monitor easily while keeping the code readable and
causes various subtle bugs in filtering out (or not filtering)
certain notifications. Therefor we revert to the original approach
of asking each source whether it accepts given notification.
In the end it is probably faster than the previous approach
because it does only simple comparisions instead of uniting sets.
And except for other things it fixes problem with endless item
fetch loop when resource cannot retrieve all requested payload parts
(emails without a body for instance), an example of the subtle bug
mentioned above.
Allow to change icon size in favorite folder
GUI: MessageView: show an indicator whenever the message parts are being loaded
It looks that QWebView does not have support for showing any placeholder
whenever it is loading data from network; instead, a simple empty widget is
shown. This is suboptimal because the user doesn't know that the mail is
currently loading unless they pay close attention to the global
application-level progress indicator in the status bar.
This patch propagates loadingStarted/loadingFinished signals of the enclosed
SimplePartWidget instances to the MessageView which simply shows/hides another
progress indicator.
Another idea was to implement this on the QNAM level, but it turned out that the
same MsgPartNetAccessManager is used also for attachment download which is not
what we are interested in.
REVIEW: 112092
Allow to change type of favorite
Office
fix crash when drawing a loaded perspective assistant
Make the text tool report it being able to work with annotation shapes too
Multimedia
Fix 322220 - Wikipedia applet shouldn't reload content if artist/album hasn't changed
This patch (hopefully) fixes 322220.
This (cut&paste?) error undermined the function of _checkRequireUpdate()
if the artist and the composer are different for a track.
REVIEW: 112044
Make it possible to move to search field in Artist/Album mode
Don't attempt to hide the mediaplayer if its the current page.
Networking Tools
span rekonq menu in the right place
Games
all players in player list can now be used for scoring games
commit 375c76b cleaned the data base structure, removing server name
and password from the player table. Since then, only player id and
name are defined per player, so there is no reason why not all of
them should be usable for scoring games
up to 375c76b, the same player name could appear more than once in the
player table: once for scoring games and once for every game server.
FIXED-IN: 4.11.1
fix finding alternative tiles for saying MJ
FIXED-IN: 4.11
Features
Graphics
Add the clear selection preview window action also as a tool button
FIXED-IN: KDE 4.12
GUI:
MantenanceTool : FingerPrints generator is now able to use Multi-core CPU.
CC
add new option in maintenance dialog to turn on/off multi-core CPU
Maintenance tool : Thumbs Generator now support multi-core CPU
CC
KDE Base
dolphin: Show full KFileItem statusbar text with hovered folders too
This patch changes the status bar text dolphin shows when a folder is
hovered. It now shows full folder info, eg:
"mydir (folder, symlink to /opt/mydir")
instead of:
"mydir"
This is consistent with dolphin's behavior on regular files, and
DolphinPart already does that (DolphinPart::slotRequestItemInfo has no
special cases for folders).
REVIEW: 112106
Correct Solarized Dark colors and add a Light version
I don't recall why the original Solarized had a few colors way off.
These versions appear to match other solarized apps.
https://github.com/phiggins/konsole-colors-solarized
FIXED-IN: 2.12
Support xz and lzma compressed tars in PackageStructure class
New wallet wizard now supports GPG-based wallets
The KWalletWizard class has now been modified to show GPG options
on the systems where QGpgme is present.
Add lockWidgets to containment interface
GPG backend now fully functional, ready for real-life testing
A new wizard now appears when user wants to create a new wallet.
This wiward will invite the user to specifiy if GPG should be used
or the classic blowfish backend. The GPG wallets use a new format
and it's contents are encrypted using GpgME++
The GPG backend will not be available if GpgME++ is not found.
For the moment, GpgME++ is part of kdepimlibs.
Partly working desktop toolbox
We now have add widgets, configure, lock/unlock working. Lockscreen and
logout need a fix probably in the service bindings.
GPG backend now fully functional, ready for real-life testing
A new wizard now appears when user wants to create a new wallet.
This wiward will invite the user to specifiy if GPG should be used
or the classic blowfish backend. The GPG wallets use a new format
and it's contents are encrypted using GpgME++
The GPG backend will not be available if GpgME++ is not found.
For the moment, GpgME++ is part of kdepimlibs.
dolphin: Show full file info in statusbar when only one file is selected
The purpose of this change is to give the user a chance to see hover
file information if it doesn't fit in the status bar, by allowing to
click on the file and hover on the status bar.
As it's now possible to have status bar texts starting with "<qt>",
DolphinPart::updateStatusBar() must escape strings. Otherwise,
filenames such as "<qt>Tes<font color=red>t" would be rendered as HTML
data in konqueror's status bar when selected.
FIXED-IN: 4.12.0
REVIEW: 111934
Behold - Kate Vim macro support! This is just the initial attempt, but it can already handle some sophisticated cases (interplay with mappings; works with emulated command bar; etc). Still need to shunt the actual final storage of macros into KateViGlobal where they can be accessed by all KateViews, and save and load them to/ from the config file, and delete that big blob of keypress-encoding duplication in KateViInputModeManager. Also need to handle capturing of Escapes (currently gobbled up by KateViewInternal before I see them) and also handle auto-completion, which needs to be special-cased with Kate due to its unpredictability.
DIGEST
reset custom cube shaders on screen change
the reset/setup invokes the viewport dimensions...
FIXED-IN: 4.11.1
REVIEW: 112133
Remove color scheme dialog animation
This animation has been in here for ages (2007). I don't actually
see any reason for it.
Thanks to Harald Hvaal
REVIEW: 111764
New wallet wizard now supports GPG-based wallets
The KWalletWizard class has now been modified to show GPG options
on the systems where QGpgme is present.
Activity bar ported in QML
REVIEW: 111992
KDE-PIM
Add support for asking SMTP password when sending email
MSA: AbstractMSA: Add signal passwordRequested() and slot setPassword() for requesting and setting password
MSA: SMTP: Use MSA passwordRequested() and setPassword() for requesting password before sending emails
Composer: Submission: Use MSA API for requesting and setting password, forward it to parent GUI widget
Gui: ComposeWidget: Use Gui::PasswordDialog for password requests from Composer
REVIEW: 112065
New command line tool: kdepim/console/calendarjanitor.
Scans all your calendar data for buggy incidences.
Also prints some useful statistics like total inline attachment size.
In --fix mode, duplicate incidences ( with same payload ) will be deleted,
incidences with empty summary and description (and no attachments) are deleted
If invalid, DTSTART gets the value of DTEND, or current date if DTEND is invalid too.
A very common use case is to fix recurring to-dos that have a DTDUE but no DTSTART,
RFC doesn't allow this.
Scan with:
$ calendarjanitor
Scan and fix incidences:
$ calendarjanitor --fix
Backup your data first:
$ calendarjanitor --backup
**********************************************************************
Processing collection Sergio Martins calendar (id=567) ...
Checking for incidences with empty summary and description... [OK]
Checking for incidences with empty UID... [OK]
Checking for events with invalid DTSTART... [OK]
Checking for recurring to-dos with invalid DTSTART... [OK]
Checking for journal with invalid DTSTART... [OK]
Checking for duplicate UIDs... [OK]
Gathering statistics...
Events : 516
Todos : 52
Journal : 175
Passed events and to-dos (>365 days) : 431
Old incidences with alarms : 259
Inline attachments : 2
Total size of inline attachments (KB) : 61
**********************************************************************
GUI: add support for application icon on Windows
Signed-off-by: Jan Kundrát
Office
Show print properties in Words and Author print dialogs
Make it possible to print current page
Utilities
Use KMessageWidget in the KCM for a better-visible info box
looks cool! :D
Add a dialog to change the password
The one I did that got lost with my laptop was better looking... or so
I remember :/
Will try to make it better once working
Make the "Share" menu action behave more user-friendly
* disable the action if it would show an error before
* ask for saving the document if it's not saved
Games
show final score at end of game
FIXED-IN: 4.11.1
Optimization
KDE Base
Do not store default values in QHash<QByteArray, QVariant>
Storing values which are equivalent to default-constructed QVariants
does not make much sense because QHash::value returns the same value
even if the corresponding key is not found in the hash.
This commit reduces Dolphin's memory consumption in large folders by
up to 7.3% (tested a folder with 100,000 files in Details View) and
reduces the time required for loading a folder.
FIXED-IN: 4.11.1
REVIEW: 111922
enforce reactivation threshold to be 50ms bigger
than actication threshold.
Things don't work otherwise.
FIXED-IN: 4.11.1
REVIEW: 112125
Fix slow scrolling when hidden files or symbolic links are shown
The problem was that we drawed the overlays using KIconLoader, which can
be very slow, every time an item appeared on the screen. This commit
makes sure that not only the icon, but the icon including overlays is
cached in QPixmapCache. Therefore, the overlay drawing is done just once
for each icon+overlays combination.
For previews, the overlay drawing is done in KFileItemModelRolesUpdater
just after the preview is received.
FIXED-IN: 4.11.1
REVIEW: 111956
Multimedia
Cache image thumbnails
Other
KDE Base
Port hotplug dataengine to plasma 2
Update the analog clock to run on plasma 2
Multimedia
Get rid of last traces of Shuffle sort level
Networking Tools
Removal of 'Typing...' in chat window title to avoid confusing UX
When a user is talking to multiple people, it is confusing to have 'Typing... Bob', when it's actually Fred in another tab who is typing.
The presence of the both the chat tab status-icon change combined with the tab name text colour change is sufficient to denote activity and removes this confusion which is exacerbated with the more chat tabs that you have open.