Issue 311
27th October 2013 by KDE Commit-Digest TeamContributors
Alex Fikl
Giacomo Barazzetti
This Week...
Statistics
Commits | 1576 by 156 developers |
Open Bugs | 21261 |
Open Wishes | 15918 |
Bugs Opened | 325 in the last 7 days |
Bugs Closed | 351 in the last 7 days |
Commit Summary
Module | Commits |
/trunk/l10n-kde4 |
178
|
/branches/stable |
67
|
/trunk/l10n-support |
45
|
/akonadi/calendar |
31
|
/server/lib |
26
|
/trunk/www |
18
|
/plugins/knotes |
13
|
/kontact/plugins |
12
|
/generic/applets |
11
|
/plasma/generic |
10
|
Files | Developer | Commits |
432
|
Laurent Montel |
151
|
258
|
Aaron J. Seigo |
88
|
183
|
Marco Martin |
62
|
150
|
Sergio Luis Martins |
50
|
135
|
David Edmundson |
49
|
135
|
Roman Paholík |
45
|
111
|
Pali Rohár |
37
|
99
|
Martin Gräßlin |
33
|
96
|
Dennis Nienhüser |
32
|
96
|
Yuri Chornoivan |
32
|
Internationalization (i18n) Status
Language | Percentage Complete |
Portuguese (pt) |
100%
|
Ukrainian (uk) |
100%
|
Swedish (sv) |
99%
|
German (de) |
98%
|
French (fr) |
98%
|
Polish (pl) |
97%
|
Dutch (nl) |
97%
|
Spanish (es) |
97%
|
Estonian (et) |
93%
|
Italian (it) |
91%
|
Bug Killers
Person | Bugs Closed |
Jekyll Wu |
114
|
Gilles Caulier |
28
|
Volkan Gezer |
12
|
Christoph Feck |
12
|
Aleix Pol Gonzalez |
10
|
Thomas Lübking |
9
|
Boudewijn Rempt |
9
|
C. Boemann |
8
|
David Edmundson |
8
|
Veaceslav Grecea |
7
|
Commit Countries
Commit Demographics
Sex
Age
Contents
Bug Fixes | Features | Optimization | Security | Other | |
---|---|---|---|---|---|
Accessibility | |||||
Development Tools | [] | [] | |||
Educational | [] | ||||
Graphics | [] | [] | |||
KDE Base | [] | [] | [] | [] | |
KDE-PIM | [] | [] | [] | ||
Office | [] | [] | |||
Konqueror | |||||
Multimedia | [] | [] | [] | [] | |
Networking Tools | [] | [] | |||
User Interface | [] | ||||
Utilities | [] | [] | |||
Games | [] | [] | |||
Other | [] |
There are 75 selections this week
Bug Fixes
Development Tools
C++11: Add implicit using directive for inline namespaces.
This fixes association of uses etc. to contents in inline namespaces,
which is the case for e.g. most of the stuff in std::chrono.
Note: Code completion of items in an inline namespace nested in
another namespace (such as is the case for stuff in std::chrono::_V2)
does not show up properly yet.
Educational
show the answers count always in the same place, and with word wrapping
Create an invisible widget with stretch(1) to force the underLeftWidget
to be placed always in the same place. Also, set a maximum width to the
widget so the label uses the wordwrap and the map does not move when
the region name is large.
REVIEW: 113382
Graphics
Fix memory leak with ThumbnailLoadThread instance passed to ThumbnailImageCatcher.
Pass a dedicated instace of thread to cacher, following Marcel tips.
CC
FIXED-IN: 4.0.0
fix for epubs with non-white background color
fix internal links
KDE Base
Fix bug in knewstuff downloadwidget where using search breaks continuous loading.
FIXED-IN: 4.11.3
Fix crash with a single wallpaper "slideshow"
To avoid the last image shown again, it was removed
from the list of next images to show. If, however, it
was the only image, no images were left.
FIXED-IN: 4.11.3
REVIEW: 113368
Do not prompt for password if the only request is for VBE resolutions.
In the above case provide additional buttons that can probe for the VBE
supported resolutions.
If other requests are made along with VBE resolutions (e.g. menu file,
config file, locales etc.) we can't avoid the password dialog so fetch
them all together.
Also if the VBE resolutions are fetched, the helper won't be queried for
them again.
Fix crash.
FIXED-IN: 4.11.3
kcontrol/dateandtime: Propagate NTP clock to hwclock, too
Before, only manual time settings were propagated to the hardware clock.
REVIEW: 113147
CC
Syntax-highlighting fixes for Haskell & Curry
By Bastian Holst.
Syntax-highlighting: names starting with import
In Haskell source files, the prefix 'import' in names has been
highlighted as a keyword. This is hereby fixed by asking for a
whitespace character after the word 'import'.
Syntax-Definitions: Comments in Haskell & Curry
Allow comments in import declarations in Haskell and Curry files.
These look quite similar because both languages share most of their
syntax.
REVIEW: 113363
Restore the tree state in Details View if a folder is re-expanded
This patch actually does two things when collapsing an expanded folder
with expanded children:
(a) It removes all expanded children (which are removed from the model)
from m_expandedDirs.
(b) It remembers the expanded children and restores them if the
top-level folder is re-expanded.
FIXED-IN: 4.12.0
REVIEW: 113293
Use base color for completion list background.
Fixes unreadable text in completion list with certain color schemes.
REVIEW: 113379
Fix broken view state restoration
The fix for bug 161385 (which was about Dolphin still showing an empty
view if a device that had been unmounted earlier was clicked in the
Places Panel) caused a regression: the view state (current item, scroll
position, Details View expansion state) was not restored any more when
going "Back".
The reason is that "m_view->reload()" in
DolphinViewContainer::setUrl(const KUrl& newUrl) was always executed
just after entering a directory, and that command overwrites this
information.
Distinguishing between "change URL" and "reload the view" works better
if it's done in DolphinMainWindow instead of DolphinViewContainer.
FIXED-IN: 4.11.3
REVIEW: 113290
UI work
- start splitting out shown and hidden views
- fixed sizing for now, this needs to be made dynamic
- only the all tasks model works so far, this needs a bit of thinking
how to share the items between the models, needs work on the plugin.
Prevent KCM crash after a context goes bad
If AudioSetup cannot connect to the context at construction the entire tab
will simply not be added, so the KCM cannot crash on nullptr access in
that case. However when a context goes bad after initial connection the KCM
did not try to reconnect which pretty much ensures a crash on s_context=0.
Connection logic was refactored into af function and used to attempt a
reconnect. Additionally when failing to connect to the context the widget
is now disabled, so even if the reconnect fails the user can not crash
AudioSetup (also without a context the widget is useless).
FIXED-IN: 4.11.3
KDE-PIM
Fix possible crash when saving changes to design of table used elsewhere
from Calligra master e410a4f4fc9da2ee37c18263f
Close IMAP mailbox before deleting it
Some IMAP servers don't allow deleting a currently SELECTed
mailbox, so we close it before DELETEing it.
REVIEW: 112786
FIXED-IN: 4.11.3
Don't leak AuthWidget::Private
Do not set the $SubmitPending flag during the initial submission attempt
The $SubmitPending IMAP keywords on its own is meant to indicate that "this
message needs to be sent out" [1]; MUAs are supposed to use both $Submitted and
$SubmitPending when the message is actively submitted, and just $Submitted when
the message was sent.
This is a serious bug -- a reasonable client could very well look at the Sent
mailbox and tell users "Hey, it looks like there's a ton of messages to be sent
in there which were never actually sent. Do you want me to send them now?". We
should have never set this flag without proper support for $Submitted in place,
but this misfeature has been around since mid-2012 :(.
Sorry to all who are affected by this, I haven't realized this implication.
[1] http://tools.ietf.org/html/rfc5550#section-5.10
REVIEW: 113396
Fix 286481 - Unable to open attachments in encrypted messages
The node has to get a correct extra content and the filename must be
correctly point to the attachments inside the encrypted message.
FIXED-IN: 4.11.3
REVIEW: 113361
Don't create MigrationExecutor job if there's no autostart migration to run
Otherwise the KJobTrackerInterface creates a job-in-progress notification,
but will never close it, because there is no migration that would cause
the MigrationExecutor to emitResult(). Very annoying :-)
Support case when a Google calendar and tasklist having the same name
...which is not supported by Akonadi.
We use calendar/tasklist UID instead of the title as collection name.
User-facing name is stored in DisplayAttribute, so the UID should
not leak to users anywhere.
FIXED-IN: 4.11.3
Do not allow overwriting bare jid of myself account in jabber client
Kopete account id and myself contact id cannot be changed. This means that all
jabber code must use bare jid for myself contact specified in account dialog.
Jabber server can change user jid after successfull login, but there is no
way in Kopete to propage it. So allow changing only of resource name and do not
tell other Kopete code about bare jid changes (which is account id and myself
contact id). Chaning resource name is OK. Without this patch it is not possible
to login to jabber servers which chaning bare jid (e.g facebook).
FIXED-IN: 4.12
Fix dereferencing NULL pointer, d->identity can be NULL
FIXED-IN: 4.12
Office
Fix of handling case sensitivity of object names
*A fix for the lowercase fix: keep table names in original format but compare them in case-insensitive way when needed
**This way importing from databases with tables upper-case characters works
from Calligra master 420a12d13746f5d5ce
Check that splits reference the same account before matching them.
This check was present in the old transaction matcher but was lost
during the refactoring done by Łukasz. Strange though in the comment
of the splitsMatch method the condition was still there.
Force lowercase letters for object ids; fix for not-all-lowercase names
from Calligra master 5d39c992354a4eb5b8
Block the clipboard signals while showing the file dialogs
The GTK native file dialogs, when you copy a file name (with ctrl-c)
do something really horrible to the clipboard. This will cause a hang if
the app connects to the QClipBoard signals.
See: https://bugreports.qt-project.org/browse/QTBUG-11187
However, https://bugreports.qt-project.org/browse/QTBUG-32853 might still
occur: that is, if the user tries to copy the filename, there'll be a
delay on closing the app, and an error message on stderr:
QClipboard: Unable to receive an event from the clipboard manager in a reasonable time
Multimedia
BugFix: 317902 - Issue a warning when transcoding is not possible
When ffmpeg is not available, the transcoding dialog will not be skipped;
rather it will add a note for the user to install an encoder.
REVIEW: 113346
FIXED-IN: 2.9
CCMAIL: Jai Luthra
Networking Tools
Fix the icon when you are connected to VPN
Utilities
Clean kwalletrc file by removing entries that correspond to deleted wallets
FIXED-IN: 4.12
Features
Development Tools
Make it possible to debug from external terminals.
Currently supported: konsole, xterm, gnome-terminal and xfce4-terminal.
Graphics
Add support for witting face tags in Windows Live Photo format
MediaWiki: Fix bug, add feature, improve usability
FIXED-IN: 4.0.0
Files could be re-uploaded without notice because of a bug. Fixed.
The plugin now allows the user to remove the metadata and/or the GPS
coordinates before uploading.
Additionally, the interface has been slightly improved (see bug.)
Add an action to toggle Change Colors
This has the exact same behaviour of clicking the toolbox Settigs > Configure Okular > Accessibility > Change colors and then clicking Ok, therefore changing the saved configs.
FIXED-IN: 4.12.0
epub audio support
epub video support
add SVG support
add epub support
KDE Base
Unified password dialog on startup.
Ask for password only once (on startup), not every time a privileged
action is about to run.
Sacrifice fine-tuned privilege escalation for the sake of simplicity.
I doubt any administrator will actually notice, plus the users won't be
confused with all these password dialogs.
We'll see how this idea pans out.
REVIEW: 113411
GUI:
Add an option to split STROUT and STDERR. If there smth in STDOUT, then
a passive error message will arrive w/ a command line end an error output.
When turned OFF, the textfilter plugin works as it was before:
output everything to a document despite of error.
Both options ("copy to clipboard" and "merge output") now are stored
in the configuration file.
If no output produced by the filter, the document remains unchaged.
*ADDED: Translation support for the GRUB menu.
There are two translatable points in GRUB:
1. The GRUB menu which is shown when booting. To be more specific, this
includes /only/ the instructions shown below the rectangular frame
containing the menu. This translation is triggered with a
'set lang=foobar' command in the GRUB menu file (/boot/grub/grub.cfg
by default), where foobar is a translation catalog (*.mo) contained
in the GRUB locale dir (/boot/grub/locale by default). The above
command is usually generated by scripts in the /etc/grub.d/
directory which process the 'LANG' [environment] variable.
2. The strings found in the GRUB menu file. To be more specific, this
includes entries' titles, echo commands etc. These strings are
generated by grub-mkconfig. This translation is triggered with the
'LANGUAGE' [environment] variable.
The above variables can be either set in the environment running
grub-mkconfig or in GRUB's configuration file (/etc/default/grub by
default) for a more permanent effect.
Unfortunately, after extensive testing in various distributions (Debian,
Kubuntu, Fedora, openSUSE) there are some limitations concerning the
use of these variables:
1. LANGUAGE should be set exclusively from the list of translation
catalogs in GRUB's locale dir.
2. LANG should be set exclusively from the list of locales as returned
by 'locale -a'.
If LANG is not an available locale, LANGUAGE will be cancelled out. So,
in order for a full translation of the GRUB boot menu, we set LANGUAGE
to a proper locale, use the user's current locale as LANG (it will be
later manually overwritten so we don't mind; we just want a locale that
truely exists) and finally 'set lang=' with the same locale we used in
LANGUAGE.
This is not a very clean solution, but up to this point this is the best
I could make out from this situation that could work on as many distros
as possible. If anyone has more information on this, please let me know.
Advanced completion list filtering: abbreviation and "contains" matching
When filtering the completion list by typing, instead of just looking at
the start of the word two other types of items can be matched:
- items containing the word, if what is typed is contained in the item
at a sub-word beginning (marked by an underscore or a capital)
- items which could be abbreviated by what was typed, e.g. FooBarBaz
will be matched by "fbb"
The "old" type of match is always sorted first in the completion list,
so no disruption of existing workflows should occur.
REVIEW:112787
DIGEST:
KDE-PIM
IMAP: Implement fetching of raw part data without the CTE decoding
Certain applications, most notably support for signature verification, requires
access to raw, unprocessed part data as returned by the IMAP server. Trojita,
however, is happy to utilize the BINARY extension and stores the data in the
already decoded form.
This patch adds a new special tree item, the OFFSET_RAW_CONTENTS. When accessed,
a request for raw data is made, the result is stored in an appropriate cache
entry and the data are also made available to the "regular" part.
Make merge person job syncronous
REVIEW: 113407
This is a commit series which makes it possible to request raw, unprocessed data
from the IMAP server. It is needed for signature verification, among other
things, and Trojita's automatic CTE processing interfered with this.
Merge branch 'fetching-raw-parts'
REVIEW: 113375
Allow to send note by mails
Show message to user when there's an error accepting invitation.
This never had an error message because it didn't have any error
control in the past.
We now support accepting method=CANCEL with RECURENCE-ID.
Which means if you receive an invitation CANCEL for an individual
recurrence occurrence kontact won't delete your whole recurrence
series.
Unit test following.
Add support for read only notes. Fix mem leak.
Office
FEATURE: Imports (csv, qif) support date format like this: 31Dec2012
Add support for opening hyperlink via a form button
REVIEW: 108677
feature: Import CSV support now "semicolon", "comma" and "tab" as separator
Merging scilab-backend
DIGEST: - Scilab backend returning in Cantor:
* Scilab backend working with Scilab 5.5 series;
* Syntax Highlighting;
* Tab-complete;
* New variable management panel
Merging python-backend
DIGEST: - New Python2 backend for Cantor:
* Python2 backend working with python2.x series;
* Syntax highlighting;
* Tab-complete;
* Help panel;
* Variable management panel;
* Dynamic keywords support;
* Compatible with several(all?) python2 modules;
* Allow appen python2 plot image in Cantor workspace.
- New packaging extension:
* Extension for import library/module for backend
Conflicts:
src/backends/scilab/CMakeLists.txt
Multimedia
Switching between multiple playlist
Adding media into choosen playlist
Fetch name of all available playlist on local disk during PMC start-up
Default will be default playlist in PMC
Networking Tools
Allow adding a Bridge without adding a connection to it
FIXED-IN: 0.9.3.2
[ #31632 ] Fully implement global presence tracking
User Interface
functionality for widget explorer is there
Games
For AI development it is useful to watch the AIs play. This patch adds a
new local human spectator player controller which does not have any
planets and does not count as active player.
In case all selected player controllers are spectators, or only one
non-spectating player controller is set, consider the match as
spectator-only and reject it as there is either no winner at all, or the
winner is known already (the only non-spectating player).
REVIEW:113113
Merge branch 'deniskup/gsoc2013/qtquick'
See more details here: https://git.reviewboard.kde.org/r/112873/
Other
display the ID of the store
rework preview slideshow
merge icons and previews in the same slideshow
unless is a wallpaper
or is a book (and the front cover is available) in this case show only the previews
also ensure the icons are rendered in the 2proper" size
Optimization
KDE Base
Abbreviation matching: performance optimizations to prevent the worst case
This puts two checks in place; one which avoids the worst case from
occuring in certain situations, and one which limits the time the function
may run in the worst case to something small (<1ms), after that it will
just claim there's a mismatch and abort.
Multimedia
revise audiooutput code structure
- less nesting in primary functions (slots and handler still a mess)
- if(interface) rather than if(m_backendObject)
- rename callSetOutputDevice to safeSetOutputDevice to reflect what it does
as to prevent pointless if(interface) before calling the function
- document aforementioned function
- Q_DECL_OVERRIDE/FINAL for Frontend overrides
Utilities
speed up viewing contents of folders containing many files
REVIEW: 111312
Games
rewrite Tile, Meld, UITile, UIMeld for speed and easier usage
Other
KDE Base
Welcome back kfontinst
It's not a 100 % port. The subdirectory dbus is disabled due to not
documented changes in KAuth and some functionality needs adjustments
due to QPA changes in QFont.
Port KSplashQML to Qt5 and remove its XLib code
Martin G. suggested to try if it would simply work without any XLib/XCB
bits at all and it does work in testing mode, I'm unsure if it also
works after actual login, but I don't see why it wouldn't.
KSplash was also receiving the stage messages via XAtoms, which I
replaced with simple DBus interface. That means that all the parts in
the login sequence need to be updated (I'll do it) to call a dbus method
instead of sending X message. Same API is used as the XAtoms were using,
ie. sending strings of component names. In some future I'd probably also
change the stages resolution as it's not too robust and does not help
paralelization much. I have a plan in my head but that's for another
commit.
REVIEW: 113415
Port knewstuff from KImageIO to QImageReader.
Review: 113388
We mourn today the death of krandr
The young lord kscreen supported by General Fiestas and Vrátil started
a revolution. First they took over the independent republic Kubuntu in
the land of Ubuntu and the city where all the gear heads live in the
land where the people wear red fedoras. Over time the young lord
got control over all the gear heads and his people loved him. But still
the old king krandr kept his place in his palace.
Now came the day when the supporters of the young lord finally entered
the palace in the capital and stabbed the old king. With his last words
the king asked "Et tu, Alex?" and Alex cried "but, I love you!".
Immediately kscreen got proclaimed to the new king of screen management.
And the people in the streets celebrated their new ruler:
THE KING IS DEAD, LONG LIVE THE KING!
Remove unnecessary #includes for moc files
These are all of the form #include "foo.moc", which tells automoc to
process foo.cpp, but where there is no class (Q_OBJECT-tagged) in the
.cpp file for moc to process.
This gets rid of nearly all the messages about appropriate files not
being found to process.
REVIEW: 113391
KDE-PIM
Use OpenSSL cmake package from system instead SSL one from kopete tree
Multimedia
rip out pulseaudio integration
most of this relates to device control which ultimately should not be
in phonon5 anymore but instead be provided by the respective platforms
(i.e. kde). there may be some degree of pulseaudio integration but
for the time being having pulseaudio only complicates code.