Revision 3542e67...

Go back to digest for 19th January 2014

Optimization in KDE Base

Emmanuel Pescosta committed changes in [kde-baseapps] /src/views/versioncontrol:

Use the QMap iterator instead of foreach(key, map.keys()) in UpdateItemStatesThread::run()
and in VersionControlObserver::slotThreadFinished().

So we get O(n) complexity instead of O(n*logn), and O(1) memory instead of O(n).
Thanks to Thiago Macieira for providing this information.

FIXED-IN: 4.13
REVIEW: 115018

File Changes

Modified 2 files
  • /src/views/versioncontrol
  •   dolphin/updateitemstatesthread.cpp
  •   dolphin/versioncontrolobserver.cpp
2 files changed in total