Issue 189

fix crash during code completion in keepRemainingWord

- we need to make sure the DeclPointer is still valid
- we need to make sure the Decl has an internal context
- generally, cleanup the whole code and don't call findDeclarations
twice, it is potenially slow

Oops! Don't reload if the file is not loaded...

Tab background brush (color, gradient) is now the property of the tab.
You can now save the color of the background when you save a kst session.
Tab background defaults are now saveable.
Delete a never implemented and unneeded childviewoptions tab.
Delete unused and/or un-needed items from the viewdialog (ie, everything else, which is the property of kst, not the tab)

Add a PGF codec version ID to be able to make rules with clien application accodingly with libpgf API changes.
Raphael, it's not possible to do it with PGFCodecVersion string and preprocessor. Of course both must be updated at each libpgf version.
We use already this way in libraw and libexiv2.

CC

Add root to Tree table and fix some related query

As explained in tree table need a root for sql to work well.
The startup query now insert an element with id = 0

During the cleanup I've decided to get rid of the confusing and mostly
redundant TagsTree table. Only for the mysql database for now, since
sqlite has a different structure and use of the tables

A bug found is that tags query had named parameter :tagID mentioned
multiple times in the query which is forbidden by QT implementation.

TODO:
- DELETE in the tags tree is not managed by triggers anymore, will be
managed by multiple query.
(cherry picked from commit ef9afa84ba358ec335816ed345163de9de884cc4)

Updated NEWS file for #252437

... and also corrected malformed identing.


FIXED-IN: 2.0.0

Tested against gwenview-4.6.80, libkipi-4.6.80,
kipi-plugins-2.0.0_beta6, but using the facebook plugin from the trunk.

fix argment call for PGFImage::write method, which have changed with libpgf 6.11.24
CC

BUGFIX: Do not crash if all images are removed in the viewer

Note : MSVC 2008 patched with SP1 work fine. MSVC 2008 official has a problem with OpenMP.
CC

Main part of recognition is currently disabled for stable release, also disable
updating part which obviously crashes as well sometimes.

Fixed a bug in authentication key conversion

The Facebook service returns to us the time TO expiry, but we actually
need the time OF expiry.

CC

- ensure that the method to apply geometry changes does not re-add deleted faces
- fix warning

Fix null/empty confusion in KUrl::htmlRef() and its unittests.

Patch by Andrea Iacovitti, who wrote:

This aims to be a fix for bug #276204 related to htmlRef(), and the kurl unit
test that return a false positive because of QCOMPARE treating QString("") == QString()
After fixing the unit test related to url reference stuff, 2 of them failed.
One related to htmlRef() (as in #276204),
the other related to setRef() not able to set Empty (but not Null) ref.
-> fixed setRef() too.

Dont spwan a nested QEventLoop - not really required.

no encoding: xxx variable support
it never worked, it cant work given the fact we eval all vars only after load
sorry, but the fixed encoding detection in KDE 4.5/.6 must be enough

Fix toString not matching the implicit stringifier for <a>.

Fixes problem with Flash for Linux download page. Ultimately, we probably
want DOMObject::toString gone and everything done via toString, but that'd
be cleaner in WebIDL land.

mark document as modified if changing the eol mode

close the dbus connection properly


REVIEW:101527

Do not show the spoofed warning box when a username is in the URL, but the
request has already been preemtively authenticated. This should address the
last use case that was not accounted for.



(cherry picked from commit c21ab4d337240dee22dbdc5aad3be038cb01bf15)

fix Makefile syntax

Restore codec to profile setting or previous codec upon reset.

Previously, after typing in 'reset' or using 'Clear Scrollback & Reset',
the current codec is lost.

With this patch, typing in 'reset' will cause the codec to stay what
it was before the reset. Using the 'Clear Scrollback & Reset' will
cause the codec to be set to the Profile setting.

This may get backported to 4.6.x


FIXED-IN: 4.7
REVIEW: 101565

- fixes calculation of WindowMotionManager in case a new destination is set when the window is not at its original position and provide a function to check if windows
are currently moving (by Thomas Lübking)
- make use of new function and bugfix in SlideBack effect

documents tab: show correct icon in list mode

Fixed asynclientapi test.

Due to the changes in DMS the test did not work anymore since it could
not find the fake service and failed to update the class and property
tree. Now we use a different service DBus id for the fake DMS via a env
variable.

cleanup and increase the safety around service creation and tabbar existence

add saved files to recent files

remember show-full-path option

Fixes for disabling of calendars

Fix ability to disable calendars.
Ensure only error messages appropriate to the current alarm type are
shown when disabling calendars with multiple alarm types.

Now filter works when pop3 defines a target folder different as inbox.

Fix bug #276086 crash on exit

: Operations imported in the primary currency unit, not the account unit

Fix crashing bug in CSV importer when changing delimiter

Fix crash in ArtisticTextTool

The tool accesses the shape when the tool is not activated,
hence it crashes if the shape is destroyd.

Fix this as Jan Hambrect proposes, by moveing connect/disconnect
of shapeSelectionChanged() to activate()/deactivate().

CCMAIL: Jan Hambrecht

Fix sometimes text wasn't displayed.
The reason was that the logic introduced in d6e2b408 to support shape
in background in Words didn't took the parent-child relationsships
into account and therefore we could end with a proper z-ordering
just because the shapes had different runThrough-settings.

Fix counter pos if there is a soft-page-break

Fixed bug 276238 - text:soft-page-break not handled correctly in lists
In case there is a text:soft-page-break after in a list:item the content of
the item was moved to the next page but the counter stayed on the current page.
Also the text was moved to the left due to the KoTextSoftPageBreak had a negative
width.

During QIF import of investments, categories of the form "Category:Sub-category" are created as a single category with no hierarchy. In mymoneystatementreader.cpp, the routine
d->interestId(t_in.m_strInterestCategory)) was found not to recognise a
category:sub-category structure already existing, and would create a new
category named like 'category:sub-category' without the hierarchy. When the categoryToAccount() routine was substituted, this recognised and found the correct existing sub-account, but did not create one if none existed. MyMoneyStatementReader::Private::nameToId was rewritten to handle category
sub-accounts, recognising existing ones and otherwise creating them.

Handling of IntInc transactions did not allow for a security to be named, nor for the presence of quantities and prices. Also, it did not allow for a fee to be described as IntInc.

To assist with the handling of 'L' records which were indicating a category,
changes were made to use any existing brokerage account to supply/receive
any monies. If no brokerage account already existed, the record would be
left flagged as missing an assignment. This then highlighted a need for the ability to edit IntInc transactions, in order to specify an appropriate import account, and therefore included adding that action type to the UI.

Fix list item moved to next page

Fix bug that the list item was moved to the next page when the list entry was
split so that it was on 2 pages. In this case the list item was painted on the
second page over list text.
Tested with running against cstester and checking that the list item is fixed.

fix artefacts on qpainter canvas

Fixed wrong text in the Likeback information dialog.

It used to say click on "Send" but there's no such button, because the
"report bug" action starts the b.k.o assistant.

FIXED-IN: 2.4.2

juk: fix crash when adding items to toolbars with RMB.

When adding an item to a toolbar using right-click, the KXMLGUIClient
object of the global action collection is accessed.
(see KMenuMenuHandler::slotAddToToolBar() )
The way the action collection was created meant the object was NULL,
which resulted in crashes.
So, create the action collection with KXMLGUIClient::actionCollection(),
which properly sets the object.

prevent crash with wrong drive permissions

drive need write permissions too?

Make sure the relative checkbox is respected.

The relative check is initialized using the configured setting.

Fix finalization of track copy process.

... to media device collections.

Patch by Tommaso Falchi Delitala.


REVIEW:101652

- Fixed potential crashes when trying to loop through empty lists.
- Removed commented, obsolete code snippets.
- Fixed wrong connections.
- Fixed potential race with QApplication in start() function.

Prevent some crashes caused by array index being out of bounds

Reviewed-by: David Edmundson

adjust update area for menu animations to fix some rendering glitches for notably google chrome.

Fix a crash that occurs when the QApt Worker sends a CacheUpdateFinished signal while
Muon is still starting up.


FIXED-IN:1.1.4, 1.1.85

Conflicts:

muon/MainWindow.cpp
updater/UpdaterWindow.cpp

Send the value of the http_proxy env var to the worker, since it normally runs
in a shell-less environment with no env vars defined.


FIXED-IN: 1.1.85, 1.1.4

Use QQueue for our installation/removal queue. It is much more robust than QList
with homebrewn queue behavior using iterators, and solves several crashes.


FIXED-IN:1.1.85

Correct calculation for shared folder size

Clone dialog designed. Commit dialog new branch dialog implemented

Implemented clone. HTTP repos not working.

* added a check in commit to see if branch was created or not.

Add a kdevelop --ps desktop file

Thanks to Daniel Wehner for the patch

REVIEW: 101503

try handling assignments of identifiers with something else

for example, if "A" is created as a variable delcaration, but then a
function "A" is declared, that needs to be handled correctly, and this
turns out to be very difficult

Re-declaring a function as a non-function is now reported as an error.

We might want to support this later, but it's too difficult for now.

Easy solution for re-assigning declarations

This now just creates a new Declaration in case the previous ones don't fit; this won't handle all the special cases in an optimal way, but should work for most sane code.

Autocompletion for inheritance prototype

this needs to be seriously cleaned up, need to move the baseclass logic
into Helper so it can be reused for highlighting

Finish revamping the view item defaults system. There is now a Settings->Theme dialog
which sets brush, stroke, and font for all view items, optionally applying to all existing
objects, and/or saving as the default for all future objects.

Furthermore, all view objects can save their current status as the default for that
particular type from their own dialogs.

Tabs can now have their own background, on a per tab basis.

It is now easy to change an entire kst session from black on white to white on black.

improve map quality when map width != height

Whenever the width and height of a map differ, choose the smaller one for calculating the visible tile level.
As a result, the tile level is increased earlier, leading to higher-resolution results.

Tested with the schangen1689 map theme.

swap cw/ccw tablet rotation when xRandR detects that the screen was rotated

Add a method to check if changes are done in the image history, even if not recorded as actions.
Needs to be carefully used in the case of RAW import.

add a flag to compile libpgf without openmp support at compilation time.
Raphael, please add this patch to current libpgf implementation

CC

Create four decoration quads for Wayland clients

This really needs to be remerged with the X11 code, quite ugly.

Let Wayland Clients use transparent rect

This puts the decoration behind the window, which makes it look
better. Unfortunately there is a bug somewhere in the compositing
layer causing the quads to be wrongly rendered.

Merge signals clientClosed() and unmanagedClosed() to windowClosed()

This commit merges the two signals clientClosed() and unmanagedClosed() to windowClosed() which
is now provided by Toplevel.
The approriate slots in effects.h and effects.cpp were merges as well, since they did the
same.
The direct method calls of the method windowClosed() in SceneOpenGL and SceneXRender were
removed and are now connected to the appropriate signal in windowAdded().

Make Scene::windowClosed() a Q_SLOT

This commit just makes the declaration of windowClosed() in Class Scene be a Q_SLOT.
The inheriting classes SceneOpenGL and SceneXRender are updated as well.

reintroduce tool tips for tool buttons

Kate will wrap lines longer than 1024 per default on load
that can be configured in open/save
that avoids the crashs on opening degenerated one-liner files like javascript/html messes

Add decoration borders to geometry of Wayland clients

Make Q slots public in class Scene

This commit just makes the slots public that are used in Scene class and its inheriting subclasses.

Render Shadow with only one GL texture

Copies the shadow parts into one image and creates a GLTexture
from the image, so that we can render the complete shadow with
just one texture and one painting pass.

Should remove most of the overhead involved when rendering the new Shadows.

As a side effect this should fix missing shadows with non-NPOT GPUs and
a rendering glitch reported with NVIDIA.

REVIEW: 101742

Pass key events to Wayland clients

We use the decoration to filter for keyPress and keyRelease events and
pass them to the Wayland Client which in turn passes them to the
corresponding Wayland surface.

Port file watch service to Data management API.

This allows us to remove a lot of complicated code since DMS provides
a lot of power around nie:url and friends.

allow user to select other session on startup

In Wayland the window texture size does not include deco

In X11 the actual window is reparented into the decoration frame
causing the overal window pixmap to have the size of the window
plus the decoration.
This is not the case in Wayland where the decoration is completly
different surface. We need to keep this in mind when generating
the window quads and finally the texcoords from them.

Unfortunately this involves code removed in master.

Make mothod windowGeometryShapeChanged() a slot

The method windowGeometryShapeChanged() from the class Scene is now a slot. It is now connected to the signal geometryShapeChanged() which is sent from Toplevel instances Client and Unmanaged.
All direct method calls were deleted.

tree list: honor background shading setting

Wayland Clients can be activated

When setting to active the client gets the Wayland keyboard focus
and the decoration the X keyboard focus.
Currently the Client gets automatically focus when created - this
has to be moved to workspace somehow. Also the client does not lose
focus yet, so it stays in the active state even if another client
(Wayland or X) is the new active one.

default to save BOM for UTF-16/32
fix used MIB numbers

Use the email subject as label for To-do attachment

We have to pass the attachment labels from MailCommon::Util::createIncidenceFromMail
to the IncidenceDefaults::setAttachments(), where the KCal::Attachment is assembled.

Calendar Resource code refactorization + support for creating recurring events

This commit makes some code refactorization of Calendar Resource's code.
The new scheme is similar to that in Contacts Resource - e.g. Event::Event class
was introduced that povides API for conversion to/from JSON.

Additionally, creating recurring events was fixed so that Google now accepts
such events as valid.

Improved child indexing with new method AnalysisResult::finishIndexChild

It is necessary to close the indexing of the child before continuing
with the parent analysis because addTriple does not have a AnalysisResult
parameter. That forces the client to maintain a stack in order to get
information about the depth of the added triple. This stack, however,
can only be correct if the child analysis is properly finished.

Since some plugins add properties to the child closing of the child
result cannot be done automatically but needs to be triggered by the
plugin.

In addition this commit fixes a few of the include paths used
throughout the lib. There are still many issues open where source
files contain global include statements like <strigi/analysisresult.h>
which means that rebuilding with changed public headers will always
fail. The compiler will find the (outdated) installed headers
instead of the local ones in the source tree.
A clean solution would be to change the source tree layout to not have
a dedicated "include" folder and always use local includes.

Also generate ToC entries based on style matching ( supposedly needed for .doc files)

Still haing issues with some .doc files freezing up hile drawing ToC

Add edition of slides names to Stage Slides Sorter

Model of slides sorter view provides now name edition. Shortcuts and
context menu entry has also been added.
REVIEW: 101661
GUI: Stage Slides Sorter context menu lets now rename slides

Pptx filter: Add support for HSL color definition & educated guess for gradient text color case.

Initial work on the advices applet

feature: Properties can be a copy of a file or a link to an existing file

Added ui and implementation for footnotes

DOC: Prepare text-properties for empty paragraphs.

* Add text-properties into the Paragraph style of an empty paragrahs to provide proper
font-size, line-height, color, etc. Those attributes were previously inherited from
the parent Paragraph style.

* Also check if top/bottom margins are set to Auto. Checked only a number of OOo outputs
quickly. More test files are required to figure out the logic.

Add "Merge with Layer Below" menu entry to the LayerBox

Improve text brush

In "Pipe mode" the brush behave like gih brush
from GIMP, every letter is single brush mask
and one letter per dab is painted. Nice effects
can be done e.g. with spray brush where you can
spray the letters and enable sample input layer
to achieve similar output like this

feature: In report page, possibility to hide line by using operator - in "Search" field

Adapt to more flexible Fritz!Box phone books

- Phone book entries with more then one numbers of the same
type (home, mobile, ...) are supported now
- The number columns got more generic names
- The type of a phone number is shown as tooltip

Add support for asking whether or not to install a new version of a config file that has been locally modified.


FIXED-IN:1.1.85

First step towards mimetypeifying component addition (through assets)

Core: Make the Singleton class thread safe and auto-deleting.

This introduces a rather large change in the singleton API.

Store items in QList instead of an ordered QMap. Reason for this is that
while adding items to game list, we need to know which row we are adding so
that we can pass it to beginInsertRows. If we use a QMap, its very cumbersome
to calculate which row the insertion will take place. With a QList, we do insertion
at the end. Another QHash is needed to find out which game is at which index.

Add few convenience functions to the model to accommodate the above change.
Now, the model will NOT reset, instead it updates and inserts Game Items dynamically.
Make it possible for the view to set new rating using setData. Testing pending.
Add new enums to describe the game status in more detail. Upgradable and OwnedByUser
disabled as of now.
Make it possible for the OcsProvider to fetch details about a particular game.
Fix the QML Rating widget to properly update its values.
Fix coding style in OcsProvider.

Multiply changes to user system

keeping tracked of the logged in user is no longer done by the active backend but by oc_user directly instead

multiply backends can be active at the same time, allowing alternative authentication procedures like openid or tokens to be used next to the regular user system

QPlatformDesktopService implementation for Android

Autodetection of language is working now

Speed up the common case where the user has no permission to call `net usershare`

And don't output any warnings in that case, it's nothing the user can fix.

Small Performance improvements in plugins.

DIGEST: 101736

Fairly big speedup and proper forward declaration usage commit - part2

Eliminate the unneccesary commit lines from the previous try.
What is an addition is that I now also fixed the issues related to the #include
lines like:
* Missing line breaks because of the readability
* Proper order
* Once I had to change the function declaration for reference usage because it
made sense anyway and helped the forward declaration usage

All in all, the includes should now be fine inside the header files, but let us
see in the practice.

Fairly big speedup and proper forward declaration usage commit

The other nice outcome of this going through is that there were quite a few
unneccesary include eliminated. Hence not just an include to forward declaration
change in the desired cases.

Not sure about the performance benefits overall, but let us see and at least the
codebase got cleaned up regarding this and another quality level.

Remove password when anonymize a document

notify user that he needs to install Kate for kdevelop to operate properly

new test program to load PGF data from image file and convert it to QImg using PGFUtils::readPGFImageData()
CC

Remove compositing self-check

Removes the last bits of the self-check at compositing startup.
It seems like they were only added to XRender because they were
in OpenGL and there they are not available for quite some time.

Also removes the now obsolete disable functionality checks from UI.

REVIEW: 101756

- Avoid unnecessary emition of the mimetype signal when copying files.
- Instead of duplicating code, call ftpCloseDataConnection from ftpCloseCommand.

Disable PaintRedirector when non-composited

Without Compositing we do not really need the PaintRedirector,
it only adds overhead. This reverts the behavior to how it was before
the PaintRedirector was introduced by just not redirecting the paint
in the event filter when compositing is not active. This should have
the lowest impact on the existing source base.

The change breaks at least oxygen window decoration when compositing
is not active as the decoration is no longer double buffered. But
as written this is exactly the behavior as used before 4.3. Given
the push today there should be enough time for all affected decos
to adjust to the change.

REVIEW: 101413

dcop is dead

Remove references to dcop and scripts that depend on dcop.