Issue 190
3rd July 2011 by KDE Commit-Digest TeamContributors
Vladislav Blanton
Danny Allen
Paulo Dias
Beat Wolf
Alexander van Loon
Marco Krohn
Shafqat Bhuiyan
Dominik Tritscher
This Week...
Statistics
Commits | 1917 by 220 developers |
Open Bugs | 23493 |
Open Wishes | 17490 |
Bugs Opened | 418 in the last 7 days |
Bugs Closed | 381 in the last 7 days |
Commit Summary
Module | Commits |
/trunk/l10n-kde4 |
229
|
/branches/stable |
100
|
/branches/trinity |
55
|
/branches/work |
40
|
/trunk/www |
38
|
/kcontrol/kfontinst |
34
|
/trunk/l10n-support |
32
|
/trunk/kdesupport |
24
|
/trunk/KDE |
24
|
/src/lib |
20
|
Files | Developer | Commits |
90
|
Laurent Montel |
61
|
288
|
Marco Martin |
57
|
7112
|
Timothy Pearson |
55
|
166
|
Khoem Sokhem |
52
|
179
|
Sairan Kikkarin |
50
|
62
|
Craig Drummond |
47
|
143
|
Gilles Caulier |
47
|
354
|
Patrick von Reth |
39
|
173
|
Francesco Riosa |
34
|
332
|
Burkhard Lück |
31
|
Internationalization (i18n) Status
Bug Killers
Person | Bugs Closed |
Martin Koller |
45
|
Gilles Caulier |
30
|
lamarque gmail com |
24
|
Dawit Alemayehu |
20
|
Christoph Feck |
17
|
Myriam Schweingruber |
17
|
Dominik Haumann |
14
|
Eike Hein |
13
|
francesco+kde pnpitalia it |
13
|
Craig Drummond |
11
|
Commit Countries
Commit Demographics
Sex
Age
Contents
Bug Fixes | Features | Optimization | Security | Other | |
---|---|---|---|---|---|
Accessibility | |||||
Development Tools | [] | [] | |||
Educational | [] | [] | [] | ||
Graphics | [] | [] | |||
KDE Base | [] | [] | [] | [] | |
KDE-PIM | [] | [] | [] | [] | |
Office | [] | [] | [] | ||
Konqueror | |||||
Multimedia | [] | [] | |||
Networking Tools | [] | [] | [] | [] | |
User Interface | [] | [] | |||
Utilities | [] | [] | |||
Games | [] | ||||
Other | [] | [] | [] |
There are 125 selections this week
Bug Fixes
Development Tools
Fix inserting breakpoints for remote debugging
the breakpoints are sent on connected_to_program event, which was not
raised when a gdb script was
fix builtin function signature
qcachegrind.pro: Fix for own moc generator
To allow the qmake-only qcachegrind target to share code with
the cmake-driven kcachegrind target, we need to use the same
moc file naming conventions as KDE. For that, we define our
own new_moc compiler, generating moc files with KDE name convention.
The depend_command used to run gcc/sed, but that never worked, as
we do not have the include paths available yet. Only with Qt 4.7,
the errors generated by depend_command are forwarded to the terminal,
and were surpressed before. So this bug never was visible.
The solution is to just print out the file name containing the
QObject subclass definition, as moc output only depends on this (?).
This gets rid of the scary amount of errors running qmake from 4.7.
Educational
fix caching crash
Change the logic to first paint the new pixmap, and
then insert it into the cache, as inserting into the
cache can delete the pixmap, and then it crashes.
Rollback geometry deleting in GeoDataPlacemark and Way->Polygon converting.
Fix issue with tag building=yes and VisualCategory - now all POI has building style for geometry by default.
Parking areas.
This python file extracts the table of data for recent Supernovae Updates.
Website: http://www.cbat.eps.harvard.edu/lists/RecentSupernovae.html
The data file (supernova.dat) is stored in CSV format.
fix caching crash
Change the logic to first paint the new pixmap, and
then insert it into the cache, as inserting into the
cache can delete the pixmap, and then it crashes.
Graphics
add a new cmake option to enable advanced debug statements for all image loaders at compilation time.
Use -DENABLE_ADVANCEDDEBUGMSG=yes with cmake.
Another place where KFileMetaInfo must not be used to prevent crash in strigi.
CC
Add an implementation for PageUp/PageDown which is pretty simple but seems
to work decently. Using QListView's implementation doesnt work because
we do the layouting ourselves, so listview's structures are invalid.
If the image has no alpha channel, we can avoid QPixmap scanning the whole image for
transparent pixels if we specify the correct QImage format.
As a side effect, this fixes bug 276096, but as explained there, there's a libpgf regression as well.
Fix some annoyances and bugs with the Tags shortcuts
- for any new tag, do not add empty shortcut properties
- use TagsCache where possible avoiding database queries
- when editing a shortcut, ensure the relevant action is created.
So far, only the db entry was set and the shortcut worked after a restart
Initialize additional parameters that were added to the structure.
Remove the global shortcut for PageUp/PageDown to be able to reuse these
keys for scrolling the views and to conform with guidelines and general
expectations.
There is still a global action bound to Space/Backspace which can be configured.
Add a local shortcut to the preview view to keep the old behavior in this context.
Remove IMO unnecessary restriction to tags and physical albums for storing scroll position.
Works nicely with searches.
Do not show overlays when Ctrl or Shift are pressed.
This agrees with other behavior, such as disabling the View action.
It makes sense to display the message on the console when an error occurs
and the operation is aborted by longjmp.
KDE Base
Fix global shortcuts that include symbols produced with shift key
KKeySequenceWidget (used to enter shortcuts) removes shift from the
recorded shortcut if the symbol produced from that key is different
when shift is used. kglobalaccel needs to include shift in the grab in
order to be triggered on this class of shortcuts, and then in the
keypress event handler it also needs to strip the shift again before
checking which shortcut was just triggered.
REVIEW: 101520
Fix printing of symbol fonts.
Make global shortcuts involving shift+tab work
When entering (ctrl,alt,meta)+shift+tab as a new shortcut
KKeySequenceWidget gets "backtab" as the key pressed but records "tab".
kglobalaccel gets the keypress event as "backtab" which is correct but
only triggers shortcuts with "backtab" in them and such shortcuts are
not possible for the user to enter.
This commit makes kglobalaccel look for both tab and backtab when
triggered, same as Qt does. By triggering on both it also avoids
breaking peoples alt+shift+tab on upgrade.
REVIEW: 101523
zoom effect: fix xcursor loading, implement cursor scaling for XRender
Support Unicode decomposed characters
Fix position of characters in 'all characters' view.
Fix resolveUrl
UnknownUris should be resolved if the uri already exists in the Nepomuk
repository. This is useful for legacy data.
Fix loading of non-local URLs
Stop singnal handler from being called recursively
Fixed non-web page urls, e.g. images, being opened as html pages when loaded
from external applications.
FIXED-IN: 4.7.0
REVIEW: 101778
(cherry picked from commit 7004ce8496b5c85bac644ef3951a3da8c50be8e1)
this should fix a rare crash
Use KXUtils::createPixmapFromHandle to convert from XImage into QPixmap/QImage
Remove "use external payload" flag
External payload is always necessary as all databases have a size limit
for binary blobs, thus payload parts beyond that need to be stored in
files.
Fixes all sorts of problems users with old config got into because
the value in their config files was "false" from early versions which
had this feature disabled as it wasn't fully developed/tested yet.
See bug 275561 for an instance where switching this value manually
fixed part of the user's problem.
REVIEW: 101703
Use beginInsertRows/endInsertRows and beginRemoveRows/endRemoveRows as detailed in the QAbstractItemModel documentation. Should fix the crashes, which were probbably caused by the model not indicating properly when it changed.
Fix decoration rendering with GL_TEXTURE_RECTANGLE_ARB
When using graphicssystem native the texture may be using
GL_TEXTURE_RECTANGLE_ARB instead of GL_TEXTURE_2D. This
needs to be honoured in order to make KWin work reliable
with e.g. R300 chipsets.
FIXED-IN: 4.7.0
Close on closeEvent, not on hideEvent
(cherry picked from commit 3c51bdc87e1a05560b3a3eb58c8ba909f8a27166)
KDE-PIM
Fix update systemtray when we subscribe/unsubscribe collection
Update systray count when we remove folder (or add folder but perhaps it's not necessary to update it)
There is still a bug when we use local subscription need to look at how it works
and if there is a signal when we hide some collection
Bug 276530: ensure wake-from-suspend is set for correct time
To make wake-from-suspend work at the correct time if the hardware
time is out of sync with the system time, use a time from now
instead of an absolute time.
Fix bug #268986 empty trash when we close kmail.
When we close kmail it deletes foldercollectionmonitor and expunge is async
=> it deleted before to remove mail in trash
=> make it sync so it delete before to close foldercollectionmonitor.
There is still a bug, statistic count is not update when we move mail
in trash don't know why, perhaps it's necessary to update statistic
before to test if we must clean trash
Office
when figuring out the minimum size of a column to fit its contents, take merged cells into account in a slightly better way, by subtracting the width of the additional columns from the size that is needed for the text in a cell.
Duplicate: fix possible crash if image is not set
It's possible to create paintop settings without a valid image, so don't
assume there's an image.
This fixes, or rather makes impossible, the crash in bug 276989, which
cannot have had anything to do with the text tool... I can confirm though
that at some font sizes, the text selection is not shown.
disable the view when there is no section
Fix Calligra Words crashes on opening MS word file
Iterating over a list that changes is never a good idea. That
bug survived for at least 10 years.
Fix infinite loop caused by us trying to add soft-breaks at the beginning of a page.
This fixes the problem that if we had >=2 soft-page-break's on one line then we
only evaluated and applied the last one.
superscript and subscript are different.
I was about to remove a duplicated block when I noticed that
one of them was for subscript but with wrong spelling (super).
Multimedia
juk: fix crash when adding items to toolbars with RMB.
When adding an item to a toolbar using right-click, the KXMLGUIClient
object of the global action collection is accessed.
(see KMenuMenuHandler::slotAddToToolBar() )
The way the action collection was created meant the object was NULL,
which resulted in crashes.
So, create the action collection with KXMLGUIClient::actionCollection(),
which properly sets the object.
This is a backport of r1237516 from trunk to branch 4.6 (KDE SC 4.6.5).
FIXED-IN: 4.6.5
Give already scaled images to mpris.
Add a delay before deleting collection
Correctly show playlist length for playlists > 1d
The limit is now 1 month, which should be enough for day to day usage. ;-)
FIXED-IN:2.4.2
Make the Jamendo database update work on my machines
The popularity field of the SQL query to add Jamendo albums to the db
sometimes doesn't seem to contain a valid number. This results in lots
of errors like:
amarok: [ERROR__] [MySqlStorage] "GREPME MySQLe query failed! (1054) Unknown column 'nan' in 'field list' on INSERT INTO jamendo_albums ( id, name, description, popularity, cover_url, launch_year, genre, artist_id, mp3_torrent_url, ogg_torrent_url ) VALUES ( 7565, 'The Last Wanderer', '', nan, 'http://api.jamendo.com/get2/image/album/redirect/?id=7565&imagesize=100', 2007, 'New Age', 5639, 'http://api.jamendo.com/get2/bittorrent/file/plain/?album_id=7565&type=archive&class=mp32', 'http://api.jamendo.com/get2/bittorrent/file/plain/?album_id=7565&type=archive&class=ogg3' );"
For those cases I set the popularity field (do we use that anyway?) to 0.
Please test.
Networking Tools
Fix group chat crash + debug info for deliveryReport
fixed crash on group chat when joining jabber chatroom.
Added also information telepathy recieves from deliveryReport.
REVIEW: 101822
Reviewed By: David Edmundson
This should fix "border" protocols handling like apt.
And it should also be a nice semplification :)
Fix bg color not following user prefs after disabling wallpaper.
Do not insert wep key incorrectly, instead replace on Edit.
Thanks Rajeesh K Nambiar for this patch.
Prevents signal mPlanComboBox::currentIndexChanged from being emited while
we edit mPlanComboBox's contents.
(cherry picked from commit d2490fda80083aa109dd5ae688e074bdebaef544)
Conflicts:
plasma_nm_version.h
Utilities
Fix route stop actions (context menu), enable/disable filter UI buttons, cleanup
- Route stop actions are handled in a switch, but the break statements were missing
- The stop action to create a new filter missed a line to add the new filter to the filter list
- Add/rename buttons weren't disabled, if all filters were deleted
- Fixed the "No-Items-Text", to give users a hint again, that filters can be disabled to show more departures
- Cleanup: Remove old (commented) code
Games
Fix initial label bug.
(port to trunk)
The initial text was not removed when pausing the game and
then remained in place when unpausing and starting the game.
This should be done cleaner at some point, e.g. by creating
a distinctive state for INITIAL that does not allow pausing.
Other
Fix to make the Unlock mechanism of WebDAV work. Previously when using unlock in cadaver etc was used the lock entry corresponding to the file was not deleted in the sqlite database table oc_locks. The error was because the delete query in the Unlock function was not getting executed :)
Features
Development Tools
Implemented basic DUChain navigation support
Educational
Added 3 more search filter options (expression, prefix and suffix). Applied a fix from the deinflection-system branch caused by empty text when parsing vconj dictionary.
Cleanup of dummy placemark (converted placemarks) -3% of memory amount.
Improved qml 2d plotting integration
Graphics
Improve behavior of timeline to return to the last search
regardless if it is a stored search or the "current" search
Added migration for ImageHistory and ImageRelations
KDE Base
Add plugin for Nepomuk Backup Service
1. Add plugin for Nepomuk Backup Service
2. Add more comments to template files
warn user when changing from separate dashbaord to dashboard follows desktop
Add special development mode for system tray with extra features
When development mode is enabled, system tray allow user to start and
stop services. Plugin developers may export extra actions for their
services in this mode.
To enable this mode you must set devMode=true in config file
nepomuksystray_qtrc
show busywidget when a task is starting
Export the function isShiftAsModifierAllowed()
This function inside KKeySequnceWidgetPrivate is needed by the
kglobalaccel daemon, export here rather than duplicating code and risk
falling out of sync.
Also add Qt::Key_Backtab to the list, this is not needed internally
since there is a special case for Alt+Shift+Tab to not be recorded as
Alt+Backtab but other users of this function will need it.
REVIEW: 101515
Add some D-BUS debug methods for KUiServer.
Finally off my TODO list. But this makes it easier to diagnose some
issues. Otherwise it's just blind fire really. This way you know if
kuiserver has some services registered, as well as which JobViews at
which objectPath(s).
added double buffering to oxygen-client when compositing is off;
force update of buttons in client->paintEvent();
call _client->paint() from Button, instead of parentWidget()->render();
semitrasparent overlay
Make KKeySequenceWidget accept shift modifier with multimedia keys
Assuming that special keys on modern keyboards do not change which
symbol is produced when shift is used, they should all be allowed to be
used with the shift modifier in a shortcut.
REVIEW: 101530
Decision Managemet Services launchs and provides basic functions
1. Implement Decision Management Service that provides some bacis
functionality. Service is compiling, launching and working correctly
( implemented part at least )
2. Provide client library for service. Library compiles, but not tested
KDE-PIM
Implement deleting events from calendar.
The implementation is complete, but it seems to be broken somewhere,
because Akonadi refuses to invokde itemRemoved() signal, therefor
request for deletion is not sent to server.
Show service descripiton when info button is pressed
1. Now when user presses info button, a message box with service
description appears
Implemented manual creation of plain text mails. Removed code duplication.
REVIEW: 101758
Make Time Labels used e.g in KOrganizer translatable
Time Labels used in KOrganizer are untranslatable due to missing i18n() calls
and missing loading of catalog timezones4 with the translations.
REVIEW:101709
Office
Add support for glyph-orientation-vertical in table cell style (and fix the unit test accordingly)
Added CMYK Color Support
Seems like not getting proper channel sequence
rtf filter: port the rtf import filter to Brad Hard's new rtf-qt library
Use the new rtf-qt library to parse rtf. This library parses (for now)
into a plain QTextDocument and I use QTextDocumentWriter's ODF capabilities
to export to ODT.
The filter is more limited than the previous one, perhaps, but has several
important advantages:
* it generates ODT, so it is actually useful
* it is based on nice, clean code that has been touched in the last ten
years
In the future, we need to remove our copy, when rtf-qt gets packaged.
CCMAIL: Brad Hards
Support for all defined BentConnectorN and CurvedConnectorN
Added support for all the connector shapes defined by DrawingML. Only
BentConnector2 and BentConnector3 have been tested.
feature: In all pages, possibility to hide line by using operator - in "Search" field
Rework style thumbnailer.
The style thumbnailer works now with its own internally created QTextDocument.
Further, it is now possible to request a thumbnail of any given size.
The font size will be decreased so that the style name fits the given constraint.
OPENCL WORKING!
greatly simplify the row/column headers code, remove some redundancy in the code and make it work for any DPI. Font size no longer scales with the zoom level, as I think that is more of a mis-feature than really useful. Still todo is maybe scaling down the font if zoomed out and/or a row/column is just too small to fit the normal sized text.
make web widget data-aware, better icon
DIGEST: improvements in Web widget of Kexi Forms
Multimedia
Improve UI for Mac. Remove several outdated workarounds
Make Amarok compile with Clang
It's now possible to build Amarok using the Clang LLVM-frontend. Mostly
trivial fixes were required to achieve this.
Note that Clang > v2.8 (most probably the current trunk version) is
required to build Amarok. On Ubuntu 11.04 you'll still have to fix the
compiler itself to make it work. Have fun.
TODO: Fix compilation of tests/ using Clang.
Networking Tools
Highlight links for ALL supported protocols rather than just http smb
Rekonq version of fancy-bookmarking
User Interface
initial qt mobility stuff
Utilities
Add new appearance setting: colorize by direction groups automatically
- Groups are determined by counting how many departures go over each stop, only the first stop after the selected home stop gets counted
Possibility to highlight a stop + Better space usage
- Add context menu entry in route stop items to highlight a stop (also highlights departures/arrivals via that stop)
- Don't display too many route stop items (omit some if there's not enough space)
- Elide too long filter names when shown in the filter button
- Externalize some drawing code into new class DeparturePainter
- Some whitespace fixes, comments
Other
Seamless Android assets support
Add seamless Android assets support, every time your app will try to
open a file, first Qt will search for that file into android assets and
only if not exists there will try to open it from your local file
system.
Checking if a file exists in andoid assets is very fast (<1ms).
Optimization
Educational
Memory optimization for people using a large number of offline maps.
Country bounding box polygons are rather big for some countries in the
new offline routing maps. When all countries are installed in Marble,
they sum up to ~75 MB which is too much for the mobile version. Discard
those larger than ~40 kB and only store the rectangular bbox as an
approximation. Work around the to be expected false positives by
querying other matching country maps if the first guess was wrong.
KDE Base
Speedup of Remember The Milk dataengine and library
Waste and duplicate HTTP requests removed, gaps between
requests cleared. As a result RTM dataengine and library got
speedup of approx. 2 - 3 times on a plasmoid startup and less
speedup on processing common routines.
More performance optimization.
Basic redesign of the removeDataByApplication method which does not
use nested loops anymore and tries to reduce the number of queries.
DMS optimization round 2:
Much faster query for the metadata graphs to be deleted.
Removed all redundant checks in the indexer.
Now that DMS does perform all the necessary checks and conversions
there is no need for that in the indexer anymore. This makes the code
simpler and easier to maintain.
There is only one thing I had to introduce (not implemented yet though):
the LazyCardinalities flag for the storeResources method which will
make it simply drop and value that would violate a cardinality
restriction.
Remove legacy indexer data in removeDataByApplication.
In KDE < 4.7 the file indexer used adedicated property to mark
index graphs. Now this is done through the standard nao:maintaingApp.
With this patch we add a new special case where old indexer data is
also removed.
Yet another optimization for removeDataForApplication.
Querying the metadata is faster when one query per graph is performed.
I suspect that some expensive join is used to handle both filter(x in ...)
Speedup of Remember The Milk dataengine and library
Waste and duplicate HTTP requests removed, gaps between
requests cleared. As a result RTM dataengine and library got
speedup of approx. 2 - 3 times on a plasmoid startup and less
speedup on processing common routines.
DMS optimization round 1:
Query optimization:
* Do not use an extra count query for the metadata props. Just use the
result.
* Split the main query in two which allows for way more optimization in
Virtuoso resulting in much faster query execution.
KDE-PIM
Only add the mime type filter proxy when we really need it.
More efficient and more importantly makes it work without any filter set,
such as used eg. in akonadiconsole.
Office
smoothing: take time into account
Scale control tangents by the time interval between points
Deprecated KisProjection and satellites
So now the update scheduler is the only possible option. No
alternatives, no options. Sorry.
The complete list of deprecated things:
1) KisProjection
2) KisAbstractUpdateScheduler
3) "useUpdateScheduler" option
Use 32bits/pixel thumbnail preview.
Reducing to 8bpp reduces file sizes quite a lot, but we don't care nowdays we have a lot of hard disk, and high-speed internet, and anyway it is mostly krita which still use that function and the preview is an epsilon of the document size, and artists like to get good quality preview of their awesome work.
And anyway. The oasis thumbnail is 32bits, so lets bring the old format to the modern age.
Pptx filter: More accurate line spacing, fixed a crash related to non defined gradient fill colors.
Correction: Better performance by simulating "materialized views" with tables
Better performance by simulating "materialized views" with tables (used for categories and budgets)
Networking Tools
Move to KMessageWidget
Port rekonq notification bars to KMessageWidget:
walletbar, crash notification bar, set favorite preview bar.
Remove old no more used notification bar.
Other
KDE Base
Remove scissoring code from PaintClipper
Not used any more and means we don't have OpenGL code in kwineffects.
Remove PaintClipper from OpenGL Scene rendering
Construct window quads which will end on the screen instead of
rendering the windows several times and using scissoring to
restrict to the area which will end on screen.
REVIEW: 101765
KDE-PIM
Fix delete message when we select a thread collapsed as in kmail1 we remove all mail in thread
Networking Tools
rekonq 0.7.55, KDE SC 4.7 based
(the KDELIBS version is 4.6.90, to say the truth..)
remove KDE_IS_VERSION checks based on previous versions
fix hold slaves handling
User Interface
New filter storage structure / filter settings UI
- Move departureinfo.h/.cpp, filter.h/.cpp, filterwidget.h/.cpp and some parts of global.h/.cpp from the applet to libpublictransporthelper (because class FilterSettings gets now use in StopSettingsWidget/StopSettingsDialog, instead of only a QString with the name of the filter configuration)
- Ask for a name for new filter configurations
- Possible to choose multiple filter configurations per stop (AND combined)
- Remove "Enable Filters" setting, to disable filters, disable all filter configurations
- Connections between filters and stops get now stored with the filter settings (a list of stops affected by the filter, previously the name of the filter was stored with the stop settings)
- Filters get now stored in config groups named "filterConfig_X", not "filterConfig_[NAME]" (the names get now stored inside the filter config groups)
- New filter configuration UI with better space usage
- Fix alarm settings writing (the number of alarms was stored per applet, but alarm settings globally)
There may be some problems with the new filter system, needs some more testing.