Issue 213

fix crash ;)

thanks for the feedback, Lasse!

fixed "Bug 168752 - Crash on new synchronous message in sequence diagram"

fixed "Bug 268469 - Umbrello crashed when changing the Package of a class"

Put occupants of HOVERS_ABOVE_SURFACE layer into a defined z-order

Both the GeometryLayer and the PlacemarkLayout are rendered in the layer
HOVERS_ABOVE_SURFACE, but neither had a zValue set, so defaulting to 0.0

According to LayerInterface.h:62: "If both have the same z value, their
paint order is undefined." By chance, the PlacemarkLayout was always
drawn above the GeometryLayer and everything worked out just fine.

When the Elevation Profile's "red flag thingy" came along as a third
player on the HOVERS_ABOVE_SURFACE layer, the dice fell the other way
around and suddenly the placemarks were rendered beneath the geometry.

Thanks for the help, Thibaut!

FIXED-IN: 1.3.0

Fix crash with Qt 4.8 qDeleteAll()

For more information, read bug 284989

FIXED-IN: 4.8.0

check for minimum size during dragging

it was done when moving sizing handles, not the offset one

sanitize closed screenshot windows, ignore deleted


REVIEW: 103350

Fix font settings issue

The font settings have been ignored currently because of the transition to the new view-engine.

The patch is based on the work of Janardhan Reddy and has been extended by the helper class ViewModeSettings.


FIXED-IN: 4.8.0

correctly repopulate when sycoca changes

the palette gets updated by all sorts of events on the scene now (incl. reparenting!), so make sure the palette is _really_ changing before marking it as custom

this fixes widget colours not updating with theme changes -> if, for instance, an offscreen widget is created, this results in a reparenting (to null)
and that in turn creates a palette changed event ... which was being intepretted as a custom palette being set and that would disable future updates
due to theme changes.

this also introduces a small helper which computes the palettes once for use by all widgets as a small performance improvement.

issue on update on calculating the size

LogFile - Enable/Disable the Add/Change/Remove filter buttons depending on whether an item is selected etc

This fixes a crash when you click "Change" with nothing selected

if a job is just deleted without a result being set or calling kill, finished is never emited, leaving dangling pointers in the job tracker

only create tabs once

Ignore corrupted XCF images that contain individual tiles whose width
or height is set to a value larger than that of the image itself.


FIXED-IN: 4.8.0

Fix calculation of maximum scroll offset

The maximum scroll offset must be the maximum y-range of the last
row, not only the maximum of the last item.

Thanks to Frank Reininghaus for analysing the root-cause and
for providing the initial patch!


FIXED-IN: 4.8.0

on hover-out, reset the highlight it.

half the fix for 253999

kwin: fixing some blur bugs

This should fix 2 issues with the blur effect:
- It is now sufficient to have a damaged EXPANDED blurArea to trigger
an update of the caching texture.
- No glitches in cases where the taskbarthumbnail effect paints a
thumbnail of a blurred window.

Fix "show hidden files" issues

Use KFileItemModel instead of KDirLister for toggling the whether
hidden files should be shown. This assures that the signal
KFileItemModel::loadingCompleted() will be emitted.

In the longterm Dolphin should only use the KFileItemModel, so that
the KDirLister instance is used only internally as implementation
detail in KFileItemModel. Although there are only a few cases left
where KDirLister is used instead of KFileItemModel this cleanup
will be postponed to after the 4.8 release...



FIXED-IN: 4.8.0

queue aurorae decoration button events to prevent them from
destroying the scene in the same event cycle


REVIEW: 103336

don't read in plasmarc EVERY time a tooltip is shown, and be careful to stop the show timer always

there are still some issues with QGraphicsView not sending hover events in all cases, but this is
as good as it gets if we ignore those bugs in Qt.

Fixing incorrect clipping of sliding popups

Make use of new extension of protocol for magic number -1.
If offset is -1 KWin has to decide the offset. This fixes all the
incorrect animations and allows us to perform clipping again by
filtering out the window quads which should not be visible.

Additionally the effect now sanitizes the offset. That is for e.g.
Yakuake setting an offset of 0, but there is a strut on the top
corner causing Yakuake not to appear on 0, but with an offset of
the strut. Such cases are now considered as well and the animation
is fixed.

REVIEW: 103367



FIXED-IN: 4.8.0

Do not try to load an empty mainImage.source or it will mess up with
mainImage.scale and make the next valid url fail to load.

don't bother newing/deleting the struct, create it on the stack

Fix crash #2 when filtering items

When KFileItems get removed from the model it is temporary possible
that the pending items are still part of the KFileItemModelRolesUpdater
while they have already been removed from the model (this happens
in the context during the signal itemsRemoved() gets emitted).

Fix KCategorizedView race - better :p



REVIEW: 103335

Fix crash if there is bad data

I do not know if this is the cause for , but it can't hurt to have the extra check

guard the task group pointer

the layout may not be in the taskgroup (more likely in the offscreen widget) and may yet get resizes after the group's deletion

set the changed Notes color

sync highlight_windows effect to tabbox usage


REVIEW: 103349

fix KCategorizedView race



REVIEW: 103335

QListView::updateGeometries() has it's own opinion on whether the scrollbars should be visible (valid range) or not
and triggers a (sometimes additionally timered) resize through ::layoutChildren()

Reactivate drop-above-places-panel functionality

Dropping items into the Places panel has been temporary deactivated because
of switching to the new view-engine -> reactivate it again


FIXED-IN: 4.8.0

SensorLogger - Fix actually logging the values to file

Patch by Francesco Lazzarotto - Thank you

Obey forced desktop id on electricborder change


REVIEW: 103376

Fix crash #1 when filtering items

When filtering items it was possible that the current index got
an invalid value which resulted in accessing the URL of a
null-KFileItem.

There is still one (general) open issue in KFileItemModelRolesUpdater
(crash #2) where a KFileItem that is already null gets read.
It is not really related to filtering but can be triggered
quite easy when filtering huge directories with enabled previews.

Fix selection issue for Information Panel

When the selection changes during the Information Panel is
invisible, it still should get applied so that when making the
Information Panel visible again a valid selection is shown.

Thanks to A. Janardhan Reddy for the patch!

(Additionally the obsolete check for an empty selection has
been removed, as this cannot happen anymore with the new view
engine)


FIXED-IN: 4.8.0

Fix sorting of accounts: system folders should be listed first.
For the bug reporters: check https://git.reviewboard.kde.org/r/103317 what you need to do in order to get the sorting right.


REVIEW:103317
FIXED-IN: 4.8.0

in addRecentCollection(), add a crash guard for item's value being 0.
probably fixes the crash reported in 287923


FIXED-IN: 4.8.0
MERGE: could be merged to 4.7 is someone wants it

Allow renaming resources from withing KMail's folder tree (as opposite to renaming only from the account settings or from Akonadiconsole).

in monitoredollectionAdded(), don't attempt to find the ancestors
of a collection that's a root collection -- well, because those
collections don't have any ancestors. This side-steps an assert.


FIXED-IN: 4.8.0

Prevent importing a table if an object by that name already exists and allow the user to specify a new name.

Fix infinite adding of pages cause of merged table-cells.
This fixes a problem visible when loading the exampledocumentrenderingverybadinKword.doc document.
Reviewed and ok'd by Boemann + tested with cstester.

Don't crash when reopening a document

This fixes bug 284047 - Calligra Stage crashes on reopening a odp after closing

Improve width and height of the cells

o use sheetformat properties defaultColWidth and defaultRowHeight
o don't forget to style columns and rows previously without style
o improves readability in documents where height of the
cell was smaller then text in cell.
o improves layout of the documents with shapes anchored to cells

Example of improved height of the rows
www.oasd.k12.wi.us/uploaded/OHS/Guidance_Counseling/11_Plan_Room_Assignments_2_per_page.xlsx

Example of improved width of the columns

Fix Rate function does not work.

Note that the new function is disabled in functions.xml cause of the string-freeze. That means it's not possible to add the function in the UI but loading+saving+displayng works.

Fix spacing between the text in the cells is not retained.
This mades lot of ods, xls and xlsx documents proper line-wrap text in cells now.

When entering schedules at startup if the current schedule was ignored
then we must make sure that the user can still enter the next scheduled
transaction.

Fix the position of the pictures in xlsx documents

o anchor pictures to cell
o end-cell-address, end-x, end-y support
o so far don't anchor pictures in groups
o fix addressing of the cells (row 0, column 0 is A1)
o don't forget to initialize drawingml
it's done in XlsxXmlWorksheetReader, but we
include the MsooXmlCommonReaderDrawingMLImpl.h
also in XlsxXmlDrawingReader



Some other test files with improvements:

docx: table styles - borders inheritance

* The aim was to dislay tables with NO borders correctly. The only regressions
I noticed on tables with borders are caused by incorrect color (#ffffff), so
those are not visible. Also nested tables require more work to figure out
correct borders. On my TODO list.

* Renamed a number of variables in order to improve the readability.

Fix markers for charts

1. In 2007 documents we handled only auto-markers for charts but not symbol-markers like at the series.
2. In 2007 documents we completly ignored any marker defined for a series cause we where checking for the internal used methodname as element-name (c:serMarker rather then c:marker).
3. In 2007 documents we overwrote any explicit to "None" set marker with the global chart marker definition making it impossible to activate globally markers and turning them off per series.
4. The code to handle auto-markers in 2007 documents was completly broken too (the important condition to check if it's the correct element was just commented out resulting in us applying auto-markers to all and everything as soon as there was an element in the hierarchy which had a "val" atribute set to true.

All those cases are fixed with this commit now.

Fix saving of paragraphs missed saving the formatting of framents where
the block have more properties (non style) than the fragment

Took the opotunity to implement autoStyle method in KoCharacterStyle as
a followup on the style inheritance I did a couple of weeks ago

docx: picture bullets - update bulletSizePt in order to have correct picture size.

* In case only bulletRelativeSize is provided then use the default font-size
or the font-size of the text chunk (if provided) to set bulletSizePt.
The absolute font-size specifies fo:width and fo:height for the picture bullet.

Fix all the entries in the pie chart are displaying with the same color.

This fixes;
* All 2000/2003 ring and circle diagrams show proper colors now.
* Formattings given for a DataPoint are not any longer applied to the last used series (what was wrong and resulted in us showing wrong colors, markers where no markers are, etc. pp.) but to the DataPoint.
* DataFormat's is proper evaluated now what is rather important cause it is able to switch the currently used series.
* MarkerFormat's are only applied to series till we proper support data-point markers.
* The auto-fill of AreaFormat's is now also evaluated and applied for the PlotArea and DataPoints

Query Designer: Fix crash when selecting sort order in a query field


Details: Properly update current row pointer after row insert

Use Qt::ToolTip instead of Qt::Tool for KoItemToolTip

This fixes the problem that the tooltips for the document section view
stay visible and hide the menu on OSX.

Patch by Alex Sarmiento

ScanResultProcessor: allow albums with empty name but nonempty artist

This fixes bug 272471, hope it doesn't break anything else. It was an
easy fix, I wonder no-one went for it sooner.


FIXED-IN: 2.5

MediaDeviceCollection: do not cache used capacity w/out update mechanism

Relevant media device handler should do this caching, and even without
it, the calls aren't that expensive. Solves first part of bug 232093,
second part (that deals with track count) will follow shortly.

media device collection: more consistent handling of compilations

This makes handling of compilation albums consistent across:
* Amarok collection
* iPod viewed in Amarok
* iPod viewed on itself

The code used to determine best guess album artist in
ScanResultProcessor was factored into ArtistHelper for reusability,
ArtistHelper is now exported in amaroklib.

This should definitely fix bug 232072. (or better - I'm not able to
reproduce it with this patch applied)


FIXED-IN: 2.6
DIGEST: compilation handling on iPod improved

Fix crash at exit with Qt 4.8


FIXED-IN: 2.5

* Fix crash when deleting clip and audio thumb was being created
* Fix possible crashes in clip transcoding
* Fix user feedback on failed clip transcode

Fix completely bogus MediaDeviceHandler::removeMediaDeviceTrackFromColl

That method did not work _at all_ because it used wrong key in the
trackMap forgot to actually write back other maps. :-)

As a result, dead tracks were never removed from memory collection and
thus the count was not updated, among other (worse) things.


FIXED-IN: 2.5
DIGEST: Capacity gauge is now always updated for iPods & MTP devices

Fix crash due to dangling pointer

Dotted imports for multiple statements.

Remaining major issues I found:
* Highlighting is screwed for all but the first statement
* Declarations are not being removed correctly if the statement
which originally created them is removed

- Add an experimental "Sky" mode (as a planet)
- Handle unknown planets decently

Switch viewport between GL or non-GL widget on the fly

unset/set NETWM shading state around minimizing


REVIEW: 103377

show system settings in app list

it's ostensibly still wrong (it's right there in the System area, after all) but
user expectations are near impossible to reshape in this area. *sigh*

Update to 1.2:
- automatically decide if video should be embedded in dialog when applet height is too low;
- improved video output (at least for GStreamer backend);
- use custom volume and seek sliders:
- change position without dragging;
- show position under mouse cursor;
- allow to embed in systray;
- some other changes.

Use QtWebKit (through kdewebkit) to generate HTML thumbnail images so that
it can be used in mobile builds.

REVIEW: 101365

Handle kext:altUrl in Query::Query include and exclude folders.

The new symlink handling adds symlinks as kext:altUrl properties to the
target files. Thus, whenever we search in a symlink folder we need to
restrict by kext:altUrl instead of nie:url.
TODO: There is still one case not handled though: imagine we are
search recursive in one folder which contains symlinks to other folders.
Then the contents of those other folders are not searched since their
altUrls are not taken into account. This, however, would mean a
considerable overhead which I am not sure how to handle yet.

accept on return pressed

If a QObject property named "DownloadManagerExe" is specified in the
QNetworkReply object parameter of 'downloadResponse' or 'handleReply',
then attempt to use it to download the requested resource.

Support wildcards for the filter

Thanks to Janardhan Reddy for the patch!


FIXED-IN: 4.8.0

Blur behind sliding popups

Finally it is possible :-) If it causes an impact on performance
during the release candidates I'm going to revert.
REVIEW: 103375

FIXED-IN: 4.8.0

clojure highlighting file from C. Hasenclever

Based on lisp.xml by D. Haumann.

implement wheel scrolling between windows

Add search functionality to QML view

A searchbar is added containing icon and search field. When user
starts to type in the SearchView is loaded which conists of the
KRunner model and the view. The search mode is a new state hiding
the tabbar and normal view.

Pressed / Released feedback for icons in the launcher

The lack of feedback on these delegates has been bugging me a bit,
especially as apps do not always provide immediate launch feedback, this
should make the user feel much more confident that she's triggered an
action.

Enable "menu key" functionality

Bring back the functionality that a context-menu is opened if the "menu key" has been pressed. In opposite to Dolphin 1.7 the context-menu is shown above the selected item and not on the (probably unrelated) mouse position.

A new method KItemListView::itemContextRect() has been introduced: The method is now also used as reference for tooltips which fixes the issue that tooltips had a wrong horizontal alignment in the details-view.


FIXED-IN: 4.8.0

Hande kext:altUrl in the query lib.

Now that we store symbolic links in kext:altUrl the easiest way to
search symlinks is to simply always matchin both nie:url and kext:altUrl
whenever a client asks for nie:url.
This is now done in ComparisonTerm making the class even more complicated.
I doubt anyone else besides me will ever manage to find their way through
that class. I really need to find a way to modularize it...

Switch the main calendar item fetching to the new logic. This
should improve resource leakage and also error handling.

The "resolution" process for Attendees has the same concepts
as before, but consistently uses a bigger set of properties
to avoid the dreaded re-resolution if ResolveNames() fails.
In any event, the re-resolution now plays dumb-but-safe - the
older logic seemed to get confused especially by non-people
attendees (i.e. resources). This may need further work.Z

Added support for pie-of-pie and bar-of-pie charts.
We currently do the same OO.org is doing and translate them to simple pie-charts what is better then not displaying anything at all.

feature: Memorize expanded groups in bookmarks

implemented core GUI functionality for pictureshape cropping.

docx: Display inserted/deleted text run content (documents containing change tracking data).

Add the correct OOXML ECMA-specs page-number to the comment.

Support for numbered bibliography entries (Bibliography configuration)

zotero upload/download/sync chain working in a basic version with the nepomuk database

Merge branch 'port-to-0.9'

Merge branch 'port-to-0.9'

Sync improvements, last bunch!

Improved code division (it will be super easy now adding a new handler)
Added a new config UI (QWizard based)

Merge branch 'port-to-0.9'

QWidget based tooltips

This work is based on system settings tooltips and replaces the standard rich-text-qt-tooltips, which gives us better flexibility and control over what's in the tooltip as well as how is it displayed.

The code was adapted by David Edmundson and finished later by Google Code-In student Geoffry Song.

REVIEW: 103297

Merge branch 'port-to-0.9'

Merge branch 'port-to-0.9'

Add an initial implementation of the QALMpg123AudioDecoder class to the project

Better support for things, like sample rate, channels getters, error management

Improve where the streets have no names.

Generate turn instructions when entering an unnamed street. Note that
currently this will generate a number of false positives (instructions
somewhere in the middle of an unnamed street) because monav often
reports waypoints to be intersections when they are not. Using the same
heuristic as the monav client to avoid this (suppress instructions when
going into mostly straight direction). Appararently this is not
perfect.

FIXED-IN: 1.2.90

KColorUtils:
pretty straightforward and small optimization of kde apps startup time:
avoid calculating luma for the same colors multiple times.

callgrind shows it is now called 4503 times
instead of 12087 during startup of kwrite ( 1.5% integral cost).

KStandardDirs:
avoid allocating several temp instances of QByteArray for the same char array

REVIEW: 103348

We don't need to delete all the widgets in a worksheet manually - they are part of the QObject tree

1. Make the new MapiObject and MapiAppointment classes public.

2. Switch mapibrowser to use it. It now shows property names and
binary values etc.

3. Switch MapiConnector2::fetchCalendarData to use it too. That
should get rid of a few resource leaks and error cases!

Switch to optimised version of appointment fetching:

1. Move MapiProperty class into the .cpp file, and make the value()
function inline.

2. Add a compile-time switch to allow the slow/investigative logic
versus the optimised logic.

Preserve a pagebreak before table of contents

Improve layout of option widgets.
Previously the option widgets would be spread out over the modebox or
tool options docker.
Before we couldn't just fix the height because then the tool option docker
tabbed with other dockers would limit the other tabs height.

Solution is adding a QWidget named SpecialSpacer that basically acts as any
other spacer but we can now detect if it is present and act accordingly.

As an option widget designer you should add such a SpecialSpacer at the bottom
of your optionwidget. Unless the widget itself can make use of expanding height
in which case you shouldn't add the SpecialSpacer.

assistants: Cache rendering

This significantly improves performance using the QPainter backend,
as KisPaintingAssistant::drawPath is very expensive.

This also adds some caching to PerspectiveAssistant.

Make sure url is encoded when converting wikipedia click urls

Don't animate when switching view-modes

Currently when switching the view-modes an animation of the items
is done, where the position and size is adjusted for the new
view-mode.

Although this might look nice initially I'd consider this as a
kind of animation that is distracting and hence it has been
turned off.

swap today/selected highlights



M +- -- desktoptheme/air/widgets/calendar.svgz

Account QML widget starting to look good :)