Issue 228

clean paths of target files

this is required for proper functionality of itemsForUrl
since it uses an optimized index-based lookup which
breaks for un-cleaned urls.

Thanks to Ben Wagner for investigating this.


REVIEW: 104339

Fixes: max. size of byte arrays is qint32::max also on 64-bit systems still

Use dot weight attribute for all associations in class diagrams autolayout to improve placements.

Fixed applying of text color changes in diagrams property dialog.

Don't crash when the user clicks the "Edit Vector" button and there is no selected vector.
Barth, please review. Maybe there is a nicer way to do it (like deactivating the button when there is no selection?).
But at least this seems to work well.

fix compilation under ARM device.

qReal translate to different types on different architectures.
Consensus is that the current state of affairs will be kept for qt 5.0
too [1].

Luckily the function affected "SearchFieldRangeInt" is only used to
store exposure times [2] where 6 precision digit suffice.

So we add functions to write <float> and cast to <qReal> where needed
and be done with that.

[1] https://bugreports.qt-project.org/browse/QTBUG-23758
[2] ChangeLog 2008-07-07 For use with the exposuretime field ...


P.S. CustomStepsDoubleSpinBox could be converted to
CustomStepsFloatSpinBox but seem not worth the effort.
Marcel hope you're ok with this

Fix some KCM bugs and make KDED a bit smart in case colord crash

Do not completely fail load() if the file cannot be read: We should still try the sidecar.

In particular, store the file path regardless of success because writing a sidecar may
be possible even for unaccessible files

Key_Slash, Key_Period and Key_Space should never trigger action

Those three keys are essential when using terminal/shell.

The old code exhibit its problem when konsolepart is embedded in a
application where developers or users might have assigned such keys as
shortcut. A good example is the "Find Text as You Type" action in
Konqueror.

Maybe all single keys should be treated specially to avoid triggering
actions.

swap strictGeometry for isFullScreen case in sizeForClientSize

ratio:
it's the same preference in isFullScreenable, allows clients which do not withdraw their
restrictions (like aspect etc.) or get fullscreen artificially (like through kstart) to start in
"real" fullscreen mode.


REVIEW: 104331

Show file name when showing individual image in active-imageviewer.

Bypass crash with Polyester-style

The Polyester style crashes when drawing a header where the
parent widget is 0.


FIXED-IN: 4.8.2

fix crash on ctrl+shift+left / delete word left

part/tests/bug286887.* contains a unit test for this.

Prevent flickering when updating items

When downloading images from e.g. the camera-IO-slave the files
will be downloaded as *.part files and renamed afterwards. The renaming
results in an undetermined mimetype and hence the probably already available
preview or icon gets replaced by a dummy icon. The patch fixes this by
keeping the old values as long until they have been resolved by
KFileItemModelRolesUpdater.

Fix sorting-issue when "Sort folders first" is disabled

The comparison of expanded trees may not assume that directories
are always sorted first and must respect the "Sort folders first"
setting.

The sorting-unittest has been extended by a sub-tree and the usecase
of bug 296437. The already deactivated test for
KFileItemModel::expandedParentsCountCompare() has been completely removed
as it has been replaced by testSorting().


FIXED-IN: 4.8.2

Fix Bug 295615 - kmail crashes trying to edit subject/message body with

some dictionary languages set in identity properties

Patch from Matt Whitlock from https://bugs.gentoo.org/show_bug.cgi?id=407709
it's right timer can be uninitialize when we change language => it will
crash

FIXED-IN: 4.8.2

remove the : on windows to have a valid path name

(cherry picked from commit 0bf2e7c29aced29450a2ecb87a94e2d31b35f320)

fake a move event when dropping out of quick tiling


REVIEW: 104347

only restore state when coming out of being iconified

Make sure SLOT Session::done() is only triggered once.

For some strange reason, that slot might be triggered for the second
time when Session is being destructed. That could introduce crash.

So this is more like a workaround than a perfect fix.


FIXED-IN: 4.8.2

fix crash in sql plugin

FIXED-IN: 4.8.2

Emit signal currentDirectoryChanged(QString) after current directory changes

Note: the signal is not emitted immediately after the current directory
changes. There is noticable delay (usually below 1 second) at the
moment.


REVIEW: 104372
FIXED-IN:4.9.0

Make sure SLOT Session::done() is only triggered once.

For some strange reason, that slot might be triggered for the second
time when Session is being destructed. That could introduce crash.

So this is more like a workaround than a perfect fix.


FIXED-IN: 4.8.2

do not crash if restoring the folding state is impossible


FIXED-IN: 4.8.2

don't hover unshade while moving


REVIEW: 104280

scroll automatically on dragging the rubberband over the view edge


REVIEW:104396

Fix Bug 295868 - next unread navigates into trash

FIXED-IN: 4.8.2

Fix Bug 296246 - When offline (on purpose) and marking a message to

send, kmail asks to go online (and misspells word too). STOP ASKING.

FIXED-IN: 4.8.2

Fix fetching of multi-paged replies in calendar and tasks resource

Fix Bug 295511 - [regression 4.8.0 -> 4.8.1] search function in sieve-filter editor not working anymore

FIXED-IN: 4.9

Add missing setCollectionPropertiesPageNames need to fix bug #296450

docx: tab element processing - sync with DOC

Don't remove to much on removeDuplicates.

When the font-familiy is set after the removing of duplicates also keep the
properties font-pitch, font-family-generic and font-charset as these are only
evaluated if there is a font-family on the same style level.



Please review so I can backport to 2.4 branch.

Roundtrip tested with my odp and odt test set.

Save autostyle in the correct file.

When KoShapeSavingContext::AutoStyleInStyleXml is set styles auto styles needed to be written
to the styles.xml. This fixes the problem that the style in bug 296664 for the list was saved to content.xml
instead styles.xml.



Please review so I can backport to 2.4 branch.

Roundtrip tested with my odp and odt test set.

Tables: Fixed bug: Details of lookup column not visible



FIXED-IN: 2.4.0 (Calligra 2.4.0)

Fix the pressure curve in Configure Krita -> Tablet Settings

o fit the curve to the page size, no need to resize the dialog every time now
o move the setting of the maximum size to TabletSettingsTab for better maintainability

Fix crash on importing csv file with missing column.

REVIEW REQUEST:103622 Some i18n improvements, for csvimport only.

Correctly roundtrip use-window-color.

Before the patch when saving the document attached to bug 296666 additionally to the use-window-color also
a fo:color was saved. However this attributes needs to be stripped when a inherited style sets the use-window-color



Please review so I can backport to 2.4 branch.

Roundtrip tested with my odp and odt test set.

doc: list styles update - a new list style for each paragraph

* I noticed a regression on my lists_support test files. The inheritance of text-properties
in textlayout was broken for a while on DOC files so I did not notice it that time.
The regression was introduced around the text:continue-list support.

* The point is that a new list style must be prepared for each paragraph becasue even a single
text-property might differ. This does not affect text:continue-list support.

Prevent crash on very quick drag and release of tracks


FIXED-IN:2.6
REVIEW:295275

Stabilizing KMix for asynchronous backends (Pulseaudio, MPRIS2), by using shared pointer constructs, Part 1 (MixDevice class).
CC

Fix crash with track effects

Merge branch 'adiumThemeFixes'

Reviewed-by: David Edmundson

REVIEW: 104356

Also update file priorities when normal priority file completes downloading in download order plugin

Always hide password input.

improved, a bit, the rendering of spinboxes for gtk3.

moved style re-attachement from oxygenargbhelper to dedicated menuItem engine.

fixed rendering of sliders for gtk3.3

Don't crash if the jobs cache has been cleared before a review fetch completes.
(More generically, check for a null ptr before using it)


FIXED-IN:1.3.1

Properly reset the UI when a LockError cancels a pending commit.


FIXED-IN:1.3.1

distinguish between key id and fingerprint

fix crash when list of files to decrypt is empty

This happens when the last file in the list would overwrite an existing file and instead of overwriting the decryption of that file was skipped.

FIXED-IN:4.8.2

ubuntu login backend, disconnected signal fixed

Don't crash when there is no selected computer engine.

You can reproduce this crash doing this:
1. Choose in the new game dialog "Computer engine" for player 1 or player 2.
2. Make sure there is no selected item in the combobox; you can do this either
- just not touching that combobox if it's the very first you are running the
program.
- clicking on "Configure Engines" and removing all the selected engines;
thus the combobox will be empty.
3. Click the OK of the new game dialog.

Disable some actions when the program is started.

With this change these actions:
- pause
- propose_draw
- adjourn
- resign
- abort
will be disabled when the program starts, however a subset of them will be
activated when the game starts, depending on what the protocols support.

Whithout this change I could crash the program doing this:
1. Start the program.
2. Click "Cancel" on the new game dialog.
3. Click the button for any action listed above.

Made ActivityWidget, StateWidget and SignalWidget type string
accessable by dot export and layout generator config.

Debugger: Display variable values in tooltips.

Support a simple filtering in the abstractfilemanager API

This is meant to be used for simple cases like VCS-directories or the .kdev4 directory. I didn't add a
default, since the list for that should be assembled by the team to make sure there's not too much in it
and also not too little. Its a rather efficient plain-string-matching using QSet for performance reasons.

Use the new API in AbstractFileManager to filter VCS dirs

Use the new API in kdevplatform to filter out VCS directories. This makes quickopen a lot more useful
especially with file-intensive VCS like git as its not polluted by hundreds of metadata-things.

The list is partially taken from KDevelop3's grep-plugin which had some names for rare VCS.

Debugger: replace the funny command system by a proper queue

Refactor and improve the PGF/TikZ exporter of Kig

Changes:
- Put the TikZ exporter class into its own file (to clean up the long
latexexporter.cc file)
- Checked and rewroked all the visit(*) methods and the TikZ code
generated
- Implemented "point" object sizes
- Fixed arros heads which were wrongly added to all lines/curves
- Fixed too long lines in the output of generic curves
- Probably some more minor things

Note: This is work in progress
- TODO: More finetuning of: linewidth, line styles, point styles

On behalf of Raoul Bourquin


REVIEW: 104270

introduce DialogConfigurationInterface for plugins that wish to provide a QWidget-based configuration dialog

We'll use a qobject_cast now in order to determine whether a plugin offers a configuration dialog or not.
This is more efficient in terms of time and memory than trying to create a dialog and check whether the returned pointer is non-zero.

For QML-based platforms such as Mer or MeeGo, this approach allows to compile the plugins w/o QWidget support.

add XMP sidecar support to RawConverter kipi-plugin
CC

MetadataEdit plugin : IPTC Editor :
- support KIPI lock feature
- support KIPI metadata settings.
- support XMP sidecar.
CC

Allow PDF Generator to handle embedded movies

Sort order in recursive SlideShow

MetadataEdit plugin : Exif Editor :
- support KIPI lock feature
- support KIPI metadata settings.
- support XMP sidecar.
CC

manage XMP sidecar file with DNGConvert kipi-plugin
CC

add public slot FolderView::addUrl(KUrl)

This slot can be used e.g. by Kickoff for the "Add to Desktop" action to add a real link
instead of an Icon applet.

REVIEW:104328

Make printing work (i.e. uncomment the code)


FIXED-IN: 4.8.2
(cherry picked from commit 698d54213d3ecd6b1564e6792f5626442f29c042)

Present Windows like Window Switcher layout

This layout is intended to replace the TabBox mode in Present
Windows effect.
The advantages of a layout over the effect are:
* works without compositing
* supports multi-screen in a better way (windows don't move)
* is an overlay on top of the windows instead of reusing the windows
* is not a hack inside the actual effect
* visually consistent with other layouts

Let additional mouse buttons trigger history navigation

Thanks to Sebastian Dörner for the patch!

REVIEW: 101335

FIXED-IN: 4.9

Details view: Expand the name-column like in Dolphin 1.x

With the new view-engine the name-column always has been expanded
to the maximum width of all available names. But this makes it
impossible to see other columns without scrolling when having long
filenames, so per default the Dolphin 1.x behavior has been applied
to the new view-engine so that the name-column-width gets decreased
to be able to show the other columns.

This patch will be released with KDE applications 4.8.2. For
Dolphin 2.1 (KDE applications 4.9) user-modified widths of the
columns will be remembered per directory also between different
sessions.

Update to 1.1.0 "back in game":
- add per launcher task connecting rules;
- use command name for default launcher matching rules;
- add toggle fullscreen, minimize, maximize etc actions;
- show item tool tip instantly;
- add support for showing tasks from current activity only;
- window context menus for entries of Entries menu also for not grouped tasks;
- add own pin task action;
- preparations for removing use of libtaskmanager;
- lots of other internal (tasks management related) improvements and fixes.

Add proper key navigation to layout based window switchers

The grabbed key events inside TabBox are forwarded to the declarative
view which passes it to the normal keyPressedEvent() method. This
allows the QML files to handle keyboard navigation themselves.

The views support key navigation natively, though this cannot be
used as we need to update the ModelIndex when a new item is selected.
Also there seems to be a problem if the tabbox is shown again, in
that case the focus seems to be somehow lost. Because of that the
navigation is handled in the Item embedding the list.

REVIEW: 104357

FIXED-IN: 4.9.0

Details view: Optionally remember user changed column-widths

If the user changed a column-width in the details-view, up to now
the width got reset when changing a directory or when restarting
Dolphin. Now the column-widths automatically get remembered for each
directory in case if the user has modified the width. The automatic
resizing is still turn on per default. The storing of the custom
column-width can easily be reset by right clicking on the header and
selecting "Automatic Column Widths" from the context-menu.

Some finetuning is still necessary (e.g. the "Adjust View Properties"
dialog currently is not aware about this setting) but this will
be fixed during the next weeks.


FIXED-IN: 4.9.0

Enable HTML 5 local storage functionality. Fixes broken behavior when using
owncloud's services. Need to be made configurable at some point.

Add slot currentWorkingDirectory() for getting the current wokring directory


REVIEW:104362

Add dbus method runCommand(QString) for running command

Although the existing dbus method sendText(QString) can be used to do
the same job, it is not very friendly since users have to deal with the
problem of how to represent and send the final newline.


REVIEW: 104398
FIXED-IN: 4.9.0

Add support for retrieving thumbnails for urls

Synchronise useractions menu with taskmanager

Changes the order of the useractions menu to fit the one of
taskmanager. There are still some differences:
* Taskmanager is missing Activities menu
* Taskmanager is missing Window Tabbing support
* Taskmanager is missing window settings (e.g. shortcut)
* Useractions is missing launcher support

REVIEW: 104374

FIXED-IN: 4.9.0

Add options for agenda widget

Improve import settings.

Add abstract class for addressbook (empty for the moment)

Add color mixing to deform brush

Still WIP. It will be probably
color rate option similar to Color smudge

pdf import: use anti-aliasing

Both for text and graphics

Visual numeric cues during direct table manipulation

Direct manipulation of row minimum height and column or table width

Complete with undo/redo and visual cues. The visual cues consists of both numeric values
as well as instant relayout as you drag the borders.

docx: comments++

MultiThreading

Final touches to direct manipulation of table

yay! keyboard navigation works while browsing any media using arrow keys
enter key to browse into a directory
Escape key to browse back

Effectstack UI update

Enable play/pause

Implement reset effect in new effect stack

Effects can now be dragged from the effect stack to another clip

Implement seek ;D

Displaying mediaController

Implement volume slider
Implement back

Free Music Charts script, Version 1.5.0

The Amazon MP3 Store is now directly integrated into the script, check
the Info applet. This requires at least Amarok 2.5.0 to work.

Btw, the charts will be back in a few weeks with a new moderator.

Make the chat window title show a "John Doe has entered text"

When a remote user has entered a text message but has not sent it,
we should display the correct channel state.

REVIEW: 104348

- Add search line to download order dialog
- Add move top and bottom option to download order dialog
- Make sure that move up and move down in the download order dialog work with multiple items

Add caching to lookup phone books

libktpcall: Add support for plugging video sinks into the pipeline

Add automatic sorting options to download order plugin (name, seasons and episodes, album track number)

Maintain a list of recently used rooms in JoinChatroomDialog

Upon joining a room (more exact upon clicking "Ok") the room is saved in
the recently used list for this account.
ATM it remembers up to 8 rooms and single rooms can be removed as well
as the whole list can be cleared.

The complete list is shown in a new tab and the rooms are used for
completion in the lineEdit.


REVIEW: 104269

Facelift the UI & add a new CallManager class that handles the state of the call.

Introduced QML-based version of KMLDonkey for the N9

This commit introduces a bunch of changes done over the last months to make KMLDonkey proper compile, run and work on the Nokia N9 and gives us yet another KDE-application that got ported to MeeGo.

For that I had to;
* Introduce a QML-based version of KMLDonkey. That gave me a great opportunity to become more familar with QML and the MeeGo components framework.
* Ported libkmldonkey to be optionaly Qt-only what is needed since the QML-version uses Qt-only with qmake.
* Fixes tons of bugs I did run into while writing the new UI and refactoring the lib to be proper usable from the KDE destop-UI and the MeeGo-UI.
* Improved performanced in lot of areas that are bottlenecks if KMLDonkey doesn't run on the same device MLNet is running on. They became rather visible when you use KMLDonkey over a slower internet-connection so I had to fix them :)
* And lot of other things I forgot about already.

KMLDonkey should be available within next days at the MeeGo app-store.
p.s. Qt rocks :)

FEATURE
DIGEST

Merge branch 'adiumxtra-protocol-handler'

Reviewed-by: Dominik Schmidt
Reviewed-by: David Edmundson

REVIEW: 104355

Add a icon representing the IM network along with the user name

If the user has multiple accounts with the same user id on different
networks this feature makes it easier to distinguish between 2 different
IM networks

REVIEWED BY : Martin Klapetek

improvements to monospace, edits to W, r, g

M +- -- Monospace/OxygenMono-Regular.ttf

Keep a local cache of the ratings file for use without internet connections.

Rework the code that deals with grub configuration files and scripts
- No more need to fix permissions
- No password needed for vbetest
- Supports Fedora 17 prefixes
- Works on systems that do not provide update-grub

Multithread Application object creation. With this we can add a progress throbber to the Muon Software Center.
We couldn't do this very well before because Application creation was blocking and would have made any animation freeze.

Add asynchronous debugger using ThreadWeaver, add documentation dock

- Rename old class Debugger to DebuggerAgent and use it in the new
Debugger class, which handles asynchronous commands and provides
signals to inform about results
- Implement asynchronous debugger jobs as derivates of
ThreadWeaver::Job
- Add documentation dock to TimetableMate, shows the HTML
documentation generated by completiongenerator
- Add output directory for the generated HTML documentation with
a CMakeLists.txt and used images
- Fix timetablemate/src/CMakeLists.txt: Use new options of
completiongenerator, add all output files to the list of output

Changes on the SourcesManagement

- Created a sources.list parser
- Improved usability in the Sources UI
- Created a test for the sources.list parser

Improve UI for software sources

allow encryption of multiple folders at once

Since we create an archive anyway there is no reason not to put multiple files or folders into it.

Save FICS settings when the user logs in succesfully.

Support puzzles that contain more than one large NxNxN cube.

Change the colors and sizes used for highlighted, selected and unhighlighted cells.

Rewrite the highlighting and selection mechanism so as to highlight only the large cube or cubes that contain the selected cell, shrinking and darkening the cubes that are outside that region.

Avoid flickering of the picture as the cursor moves around.

Use the SKGraph class to provide all puzzle-layout data. Move internal data items from public to private. Use m_ for data names. Tidy up some of the indentation and parenthesising.

predefined game server kajongg.org

kajongg.org runs a kajongg game server for everyone. Please try it.
You need kajongg version 4.9 which is currently only in trunk.

FEATURE:

Add settings to control the look and feel of a 3-D puzzle.

Add three Roxdoku puzzles, each having more than one 3x3x3 cube.

players can now chat with each other

FEATURE:

prevent UI-lockup when opening huge projects

when adding e.g. the ~180k files in WebKit, our UI used to hang
on my machine for more than a second which felt bad.

now we process events after adding one thousand files to the
background parser, and the UI stays responsive during that - neat

optimize: reduce time required for quickopen (files) to show up

Every time quickopen is shown, we used to compute the ProjectFile
list by iterating over the file sets of each project which among
others was slow due to lots of involved IndexedString and sorting.

Now we keep the (sorted) list, i.e. map, around and listen to
thew new signals in IProject, that notify us about new/removed files.

In my test, this is about one magnitude faster (just around 100ms
on my machine) when dealing with e.g. webkit and it's 180k files.
Before this patch, QuickOpen needed more than a second to show up.

Memory consumption is slightly higher of course, but negleglible.
When you deal with such huge projects, a few mega bytes more or less
don't make a difference imo. We are talking of e.g. ~690MB vs. ~670MB.

add benchmark for background parser

it's pretty slow, 1000 documents takes ~2s even with our dummy language
thats used in the unit tests

one thing thats pretty slow is the iteration over the url sets in m_documentsForPriority.
I've toyed around with it but even replacing it with a QVector wasn't faster (and
made the code much more complicated due to manual set-logics...)

has anyone some ideas on how we could improve this situation?

Rework tabbox compact layout a bit

- only use bold text for selected windows
- all icons are colored
- row for minimized windows are not fully opaque
- text for minimized windows is no longer italic

REVIEW: 104187

Clean up ktimezonedrc properly after each unit test

ktimezonestest_p.h already did try to clean up the config after testing,
but the folder to be removed was hardcoded (~/.kde-unit-test/share).
This does work for ktimezonestest, but not for ktimezonewidget_unittest.
That test uses the same private header, but does not change KDEHOME to
~/.kde-unit-test, such that the user's normal config was modified by the
test, and the changes persisted even after the test. This then caused
applications like, e.g., Dolphin to output lots of unwanted error
messages at runtime.

This commit changes that by determining the full path of ktimezonedrc at
runtime and deleting that file.

Improve contains queries.

If we are searching for 2 characters or less, we assume substring
matches anywhere don't make much sense, so we use whole word matching
via the relatively fast bif:contains. If we are looking for longer
substrings, we can search for the substring anywhere, using a regex
filter, or for the substring at the start of words, using a faster regex
that limits to word boundaries. The later is useful in particul for
address completion, which is a frequent enough special case to warrant
optimizing it a bit.

REVIEW: 104338

Avoid creating extra CalendarResourceManagers.

They create extra kolab resources, which we want to avoid.

Fixes kolab/issue4829

libktpcall: Simplify the controllers API

* Consider all source & sink controllers private classes by themselves
and get rid of the *ControllerPrivate classes.
* Move the sink managers into a separate source file.
* Fix a few things in BaseSinkManager.
* Move some parts of the implementation from Audio/VideoSinkManager
to the Audio/VideoSinkController classes.
* Add subclasses of CallContentHandler that expose the various pipeline
controls that used to be exposed by the source/sink controllers.

Improve startup time

Make the UI much faster to display by making the delayed initialization
inside the ApplicationsList and its proxy model instead of preventing the
whole UI to boot.

Refactored calls belonging to UMLScene related methods.

Merged UMLCanvasView into into UMLscene; it was based on Q3Canvas too.

Detach sub-tasks from a task that is being deleted.

Google automatically deletes task with all it's subtasks. When user wants to delete only the one
specific task, we need to detach all it's subtasks (and re-attach them to the root) and then only
we can send the 'remove' request.

Remove adjourn from the list of the XBoard protocol features.

I'm doing this because the adjourn support for XBoard engines is broken in
Knights for the following reasons:
1. Saving the game isn't done properly; we were using the "save" command,
which is not an XBoard command; it's a custom command of gnuchess and
crafty, which, by the way, behaves different in each one.
2. There isn't any proper way to load the game. Not even typing
"load /file/path" in the console (that doesn't work because the board in
the GUI won't be updated).

We could implement adjourn support properly later using the "setboard" command,
see: