Issue 249

Don't add invalid or null types to tuples, but use mixed instead.

This should finally fix

Delete the ClassGenerator or TemplateRenderer when the assistant is deleted

This fixes a memory leak

Added: option to display all offset values in decimal, not hexadecimal


FIXED-IN:0.10.0 (part of KDE Apps 4.10)

Fix folder doubling upon adding new folders. Use document as parent.

The combo box presents a flattened list of the folder hierarchy. Using
the currently selected folder as the parent of a newly added folder is
little intuitive and prevents to create top level folders. Instead now
top level folders are always created. The user can still create a
hierarchy in the bookmark manager if he wishes (where a tree view is
used, making the tree approach clear).

Fixed a bug that would make Cantor crash when loading some files.

Evaluate additional actions of screen and widget annotations

This fixes the auto-start feature of PDFs generated with the LaTeX movie
package, which uses the additional action of a widget annotation to start
the movie when entering the page.


REVIEW: 106430
FIXED-IN: 4.10

Rewrite negation in CategoryMatchers.

Until now, negation of matchers was coded into the matcher itself,
by the way of a "Matcher sign".
This patch introduces a general "NegationCategoryMatcher", which
simply negates the outcome of a child matcher. This way, matching code
in ImageSearchInfo can be written in a more comprehensible way.

Also, the new Matcher is used to fix the behaviour of matches like "!
None".

bug: 304801

Fix window moving without dragging

A click inside a window rect without dragging was causing the window
to be moved to the first desktop. Now the window is moved only when
a dragging event occurs.

Signed-off-by: Luís Gabriel Lima

kill killhelper in client destructor


FIXED-IN: 4.9.1
REVIEW: 106022

change tmp filename pattern to avoid misinterpretation

In the mentioned bugreport, kio_man is used with the url "man:tar"
firefox, which loads the tmp file kioexec created, seems to have a problem with the filename ending in
.tar as it thinks the file is a TAR file. The problem stems from the fact that kioexec creates the krun tmp filename by the
pattern <pid>.<jobnum>.<filename> and in this case filename == "tar"
A simple solution to not create a tmpfilename which can be misinterpreted is by changing "." -> "_" in the name pattern
so that the created filename does not have an "extension" part.

FIXED-IN: 4.9.1

try to be more flexible in path search

this may be a possible solution to packages not being loaded with non standard install paths

Fix wrong text color in Places Group Header. Use QPalette::Window for base color and QPalette::WindowText for text color. Also changed m_roleColor color mixing to 60% (from 70%) -> Better visible color difference when base color is darker than text color. Also changed styleOption().palette.brush(group, role).color() to styleOption().palette.color(group, role) in KStandardItemListWidget -> should be more efficient.

Fixed favorite view sorting functions aligned context menu to mouse

increase the width of group items in the popup

this patch changes the width of the task group popup to be able
to read the full title of the window.
The minimum width is like it was before, but if the title is wider,
it will increase the width up to 80% of the available corona width.


FIXED-IN: 4.9.1
REVIEW: 105849

Select the correct item in places-panel, when a directory is opened.


REVIEW: 106074

Fix menu items not clickable problem in QML shutdown dialog.


FIXED-IN: 4.9.1

Swap shortcuts of "editable_location" and "replace_location" actions

That makes "Ctrl+L" less surprising to users who use it frequently in
web browsers


FIXED-IN: 4.10.0
REVIEW: 105994

Show the whole picture in shutdown dialog.


FIXED-IN: 4.9.1

Fix amazingly slow kwalletmanager startup.

Every call to setFlags(), on item creation, triggers itemChanged(), which the
code wrongly treated as a renaming, so it would make a dbus call for renaming,
and then process the dbus signal for "this folder has changed" by reloading the
folder and comparing.



I didn't see review 105633 before spending time fixing this :-(

Reset shader state in TrackMouse effect prior to render it

The Shader might have left-overs from last usage which might
cause the effect to not work properly.


FIXED-IN: 4.9.1
Reviewed By: Thomas Lübking

auto-detect encoding of man page source

as man page files do not define in which encoding they are written,
the man-db source of the man commandline tools has a hardcoded list
of languages and their encodings (see its encodings.c file)
As this might change in the future (e.g. distributions move to UTF-8)
the hardcoded values might be wrong.
Therefore I now use KDEs encoding auto-detection mechanism and convert the pages
source always to UTF-8 before processing.


FIXED-IN: 4.9.1

Changed the behaviour when middle clicking folders in places- and folders-dockwidget. Now it opens the folders in a new background tab (General behaviour of Dolphin)


REVIEW: 106069

As noted in bug 256187, the fileWatcher plasmoid can use a lot of
memory, particularly when first reading a file.
This turns out to be because the whole file is added to the
textDocument, instead of just the last few lines.

As a bonus, fix an (unreported) bug where if a line matched two filters,
it could be printed twice.


REVIEW: 105940
FIXED-IN: 4.9.1

Do not trigger krunner when the Space key is pressed


FIXED-IN: 4.9.1
REVIEW: 105989

Right-align the total and unread column counts in the subscriptionmodel.
Also size the columns to the contents as not to waste so much space.
Thanks for the patch Frank!

MERGE: 4.9
FIXED-IN: 4.9.1

Fix Bug 304664 - QR Codes aren't shown anymore

Sorry was my fault. Support for QRcode is not implemented in grantlee
template.
Will fix it soon

FIXED-IN: 4.9.1

fix tokenizing of invalid formulas.

Not all states in the parsing loop have a check to make sure we're not at the end of the string yet, so re-introduce this check as part of the main loop condition. Commit 85efba919173bf8badddae4093f16cbe7b704915 incorrectly removed this check.

Handle expections in KoApplication

If exceptions are thrown by OCIO, they kill the application because
we cannot catch them locally.

Use the same logic for sub-accounts as for main accounts when
they are closed but should be shown in the account selection process.

Fix infinite loop when closing the cell editor while a different sheet is active.

Changing of the active sheet should be done before we end referenceMode, otherwise changing the sheet ends up closing the editor, even if we are already in the process of doing so.

Do not indicate "EffortNotMet" error when estimate type is Duration

FileType: don't translate all file types, just the "Other"

This fixes a bug where tracks cannot be copied to iPods in de locale
because mp3 is apparently translated to MP3 there and IpodCollection
compares it case-sensitively against a list of supported file types,
which fails.

For easier back-portability, this patch includes only the actual fix,
second part with misc changes (like ChangeLog and docstrings) will
follow.


FIXED-IN: 2.7

Don't append when enter in playlist name edit.

I suspect a Qt bug here. Why doesn't the delegate consume the enter press?


FIXED-IN: 2.7

magnatune: ask user to update database

This adds a widget to the Magnatune service pane, that tells the user,
that Amarok needs to download Magnatune database, and that this can also
be performed automatically.

REVIEW: 106071

FileType: document pitiful situation wrt i18n, sketch solution

Also document other Amarok::FileType methods.


CCMAIL: Albert Astals Cid

GPodder Improvements Patch Rev2

GPodder Improvements Patch Rev2

Use Solid::Networking::status() to prevent offline running of any
procedure that requests data from gpodder.net. Fixed some typos in
ChangeLog. Added some extra verifications, to see if suggested podcasts is
ready for use in GpodderServiceModel.

GPodder Improvements Patch Rev1

Put messages to show that gpodder service failed to get data from
gpodder.net. Done some cleanup and added some comments.

GPodder Service improvements

Full status synchronisation implemented. Cleanup and some refactoring.
GPodder Provider saves podcast subscriptions changes if the user closes
amarok before a expected synchronisation to end, so as to synchronize them
in the next start. Forcing GPodderService to verify if the username and
password is not empty before creating a mygpo::ApiRequest. Solved some
problems related to the KWallet use in GPodderService.

Courtesy: Lucas Gomes


FIXED-IN: 2.7

magnatune: flush database after commit

This makes mysql close unused tables and free corresponding caches. In
the case of Magnatune update this amounts to some 300M.

In the future, we would probably like to either limit Mysql memory usage
somehow, or at least ask upstream to implement some sort of adaptive
cache size selection, because users have reported OOM conditions on low
memory systems.


FIXED-IN: 2.7

Get sure rekonq makes use of djvu plugin

Also, clean up mimetype detection, following kdewebkit.

I tried implementing this using the protected excludeMimeType in
kwebpluginfactory, but I fear it has to be declared virtual to let
the trick work. Isn't it?

- Choose the correct MainView in ZoomBar::updateSlider()
It fixes issue for the first tab of new windows in case of a "wheel" zoom.
- Move the zoom bounding logic from WebView::wheelEvent() to ZoomBar::setValue()
It'll avoid Ctrl -/+ to exceed the max value of the slider
- Use the round() method instead of my previous hack to compute zoom ratio for wheel events

Escape ampersands since Plasma::IconWidget::setText() removes
accelerators (ampersands) automatically.


FIXED-IN: 0.9.0.5

Groups expanding/collapsing improvements

Reviewed-by: David Edmundson
REVIEW: 106025

Let the plasmoid appear properly if instanciated from plasma

And without being shown in the Taskbar and Pager

REVIEW: 105997

FIXED: crash when trying to view files with embedded KOrganizer part
Dont't call deprecated KPluginFactory api.
Pass parent widget to factory function - avoids KOrganizer bug 205713.

Fix a regression that caused the category download size to not be bolded.
I forgot to un-hardcode a column number when I added the version column.

Fix a bug where a change to a package in the backend would not update in the view until a manual repaint (e.g. mouse over).

We now respond to packages changing in the backend by emitting the dataChanged signal for all indexes.

- View or edit files doesn't work
If no KParts/ReadWritePart is available, notify the user and sugest installing Kate.
Viewer not working has been fixed by

Improve the committing interface

Change the show button for the update, so that it's still possible to
update the diff from the UI and remove the groupbox with the local files
and known patches when we're not using a local patch.

We should probably move the known patches feature to a different toolview?

Astyle formatter: add support for padding parenthesis headers

The patch adds an option to enable/disable padding parenthesis headers
in the astyle code formatter.

For improved Qt compatibility, "foreach" is added to the list of headers
and it is assured that "&" and "*" are not treated as operators at this point.

The KDELibs and Qt styles are fixed to properly use this new feature.


REVIEW: 106032

Improve the responsiveness of the next and previous hunk buttons

If we're at the patch (Overview) jump to the next or last files.
If it's not a text file, just show it and proceed to the next file.

Finally make it possible to share the project dashboard with your team mates

This was something planned for months but never managed to implement.
I'm putting this to master because I'd like to concentrate in other features for 4.4

Major INDI patch

This is a major INDI patch. The core INDI code was rewritten to
enable more flexibility and scalability in KStars INDI engine.
Changes to the INDI core and FITS Viewer are required for the complex
tasks performed by KStars Ekos tool. KStars can help in focusing
CCD images by measuring Half Flux Radius of stars within an image
and commanding the focuser device until an optimum focus is reached.
Using the device manager, it is now possible to group several
devices under one INDI server. Furthermore, KStars now supports
dynamic renaming of devices at run time.

Added support for scrolling with an active drag.

Moving the mouse cursor close to the top or bottom of the viewport while
a drag is active now scrolls the worksheet.

Kothic Json parser for vector data tiles

During GSoC 2012 for vector tile rendering, Kothic's servers json tiles
(hosted on http://osmosnimki.ru/vtile/ - please don't use it
heavily-loaded projects for now) have been used while OpenStreetMap
finishes building its own data tile server. These Kothic tiles have a
very similar format
(https://github.com/kothic/kothic-js/wiki/Tiles-format) to the ones that
OSM will have.

A problem was found with QScriptValue for multidimensional arrays. When
having for example [[20,10],[20,30].[30,30]] if we extract the property
it will flatten to 20,10,20,30,30,30. This parser doesn't create
separate inner geometries because of this. It will connect the inner
geometry with its outer.

It will set the geometries name and style according to what
OsmVisualCategory generates for the parsed tags.

This parser creates a GeoDataDocument with all the extracted data.
REVIEW: 106008

Create graph file backend manager.

This removes the file plugin mananger part from PluginManager in
favor of a stand alone manager for graph file backends. Refactoring
goes along with a lot of API cleanup/documentation.

NEW Feature: use next/prev video thumbnail

Working save/restore last logged in user

Add a class GreeterWraper that extends the functionality of QLightDM::Greeter to save the last logged in user.
Also simplify the setting the X root image to be automatic by emitting a signal before login occurs

REVIEW: 106019

add basic "Open With" context menu

missing:
- if the tree is from git, add "Launch gitk", "Launch git-cola", "Launch qgit",
depending on whether these applications are installed or not
- if the tree is from svn, add "Launch kdesvn" ?

Is there a good way to get a list of sane applications for git besides hard coding?

Enable basic context menu support and drag 'n' drop in favorites view

Implement buffer-switching commands in KateFileTree

Implement "buffer", "bprevious", "bnext", "bfirst", "blast" and their
aliases in the KateFileTree plugin. Implementing them there ensures
that their behavior is consistent with the sorting mode employed by
KateFileTree's document list, cf. commit 11a34a5.

implement more plugin interfaces to allow plugin to get signals when other plugin views got created/deleted
this will allow plugin to talk to each other more easily ;)
first test will be projectplugin => searchplugin, to allow searches in current active project ;)

Adding a screen menu to the Client's useraction menu

New "Move To Screen" menu is shown after the "Move To Desktop"
menu if there are multiple screens and the window can be moved
to another screen. Menu contains one radio button for each
screen.

Selecting an entry sends the Client to the selected screen.


FIXED-IN: 4.10
REVIEW: 106065

start to let project plugin talk with search plugin ;)

highlight active file in project view ;)

Add class to cut and copy Incidences.

Handles stuff like:
- Groupware scheduling for deleted incidences.
- Optional recursive copy/cut, for to-do trees for example.
- Proper async-ness and error handling that was missing in the old
korganizer code.
- Rollback on error planed.

Start to improve it. Now I know how opera store its addressbook

This is a patch for support foot notes and end notes in epub( we create a special file for end notes)
and also handle tag bookmark.

Add new options to set auto Grow/shrinking and Feathering for Fill Tool

Handle default styles in the epub2 filter.

This is the last item in the TODO for EPUB 2.0.1! This means that the
filter is now officially DONE for that version of EPUB.

FEATURE: EPUB 2.0.1 export filter for Words finished
DIGEST: EPUB 2.0.1 export filter for Words finished

Detect Amazon country automatically.

This uses KDE locale settings and avoids "choose your country" popup at
first startup.

Add composer button to wikipedia applet

Adds a new composer button for the Wikipedia applet.

Courtesy of: Ryan McCoskrie


FIXED-IN: 2.7

Allow to start ktp-dialout-ui with a preset number

This allows to start it from Kontact by setting
Settings > Configure Kontact... > Contacts > Contact Actions > Dial Phone Number

"External Application"
Command "/usr/bin/ktp-dialout-ui %n"

Reviewed-by: George Kiagiadakis
REVIEW: 106061

Add glow effect support

Add ProvidesStopSuggestionsByPosition provider feature

To be used by providers, which can provide stop suggestions
by geological position

Make it possible to provide some ETA from the updater

Every Resources' updater will be able to provide an estimation of the time
that will be taken to commit the updates.
Also implements the backend side for APT and KNS. In the KNS side it's void,
due to KNS limitations.

Port KBounce sounds to the KgSound class of the KDE Games library.

The porting was done by Roney Gomes, Google Summer of Code student, 2012.

Port KBounce graphics to the QGraphicsView classes of the Qt library.

The porting was done by Roney Gomes, Google Summer of Code student, 2012.

Pass lists to Grantlee as QVariantList instead of QVectors of QVariants

Only this way if-statements work correctly. The performance difference should be small, considering templates are rarely used a with large number of class members.

Increase timeout for key events.

With system load it seems possible that this needs
a longer time out to keep working as normal.

Include the area clearing to the HoldUpdates scope

This will prevent the view to be repainted while changing area, between the
clear and the creation of the new area

handle multiple <result> entries for one command

if there is more than one result, concatenate the relative strings to
be able to show them all. This fixes for example multiple commands separated
by semicolon in one WorksheetEntry

avoid that both background processes and thumbnail loading is spending all the core each

run foreground jobs even when the background job manager is paused.

show elapsed time in msecs insted of secs. Most jobs takes less than 1 sec now

Move reinitializeCompositing and restartKWin into the Compositor

The DBus signal which causes KWin to reinitialize the Compositor
is moved into the Compositor as everything can be handled from
there as well. This comes together with moving the restartKWin
functionality into the Compositor as it is only relevant there.
Restart will only happen if the wrong Qt graphicssystem is used
for the chosen compositing backend.

Replace nco:PersonContact with the more generic nco:Contact

This helps to avoid cluttering the database as PersonContact is mostly used to refer to people known to the user.
It is also not clear how to deal with 'artist names' of movie/music stars.

The downside, no property for family/given name or suffix exist for nco:Contact and only the fullname will be saved.
It is questionable if this additional data is used somewhere on the other hand.

Fix "QObject::connect: Connecting from COMPAT signal (QComboBox::textChanged(QString))"

Note that this warning is emitted twice when opening the search bar
(Ctrl-F), both time about the same connect(). Looks like
enterIncrementalMode() is (accidentally?) called twice.

When the user clicks the clear button, this means that he doesn't want
the old output anymore. So don't add the old output in the konsole previewer

Make the Scene owned by the Compositor

The Scene has always been created and destroyed inside what is
now the split out compositor. Which means it is actually owned
by the Compositor. The static pointer has never been needed
inside KWin core. Access to the Scene is not required for the
Window Manager. The only real usage is in the EffectsHandlerImpl
and in utils.h to provide a convenient way to figure out whether
compositing is currently active (scene != NULL).

The EffectsHandlerImpl gets also created by the Compositor after
the Scene is created and gets deleted just before the Scene gets
deleted. This allows to inject the Scene into the EffectsHandlerImpl
to resolve the static access in this class.

The convenient way to access the compositing() in utils.h had
to go. To provide the same feature the Compositor provides a
hasScene() access which has the same behavior as the old method.
In order to keep the code changes small in Workspace and Toplevel
a new method compositing() is defined which properly resolves
the state. A disadvantage is that this can no longer be inlined
and consists of several method calls and pointer checks.

Also regenerate the value pixmap when the height changes

It could generate a visual glitch if the program plays with the bar's height.

Thanks David Edmunson for noticing :)
REVIEW: 105966

it's time to improve backupmail and extend to backup other pim apps

Create the image with the right pixel size depending on resolution and unit.

improve table of content display indent in levels.

Don't remap from rgba to bgra, since the target colorspaces are rgba

lcms2 cannot handle bgra half yet, so the floating point colorspaces are
rgba now, which means the remapping isn't needed anymore.

Refactor Token and DropTarget

Add lots of comments.
Reorder Token constructor according to scope
Get rid of Token.m_textColor and use palette instead of constly html
format.
Change Margins, expanding and spacers so that the drop target is
center aligned in the OrganizeCollection dialog.
Set minimum size to drop target so that an empty drop target
has enough space for the "drop here" text.
Clean up DropTarget

Remove Edit button from Ui

I honestly can't be bothered to implement it.

The user can remove/readd a word, or just add a different value for the
same key.

help the user and show explanation if no device was found


FIXED-IN: 4.10
REVIEW: 105993
GUI:

Add a busy cursor to show when we are working