Issue 294

Fix loading Qt help

Trim the output of qmake
Only check the ./qch suffix optionally, it's not used for Qt5.
Also look for qmake-qt5 to figure out the location of Qt help.

Patch inspired by Vlas Puhov's (see review).

REVIEW: 111194

Fix Debugger-specific action enabled while not debugging

Fix crash / odd behavior in project tree view

This patch fixes:
- Crash when trying to delete project target
- Removes pop-up that appeared when trying to delete
a root item.

Removed the asserts because this function is actually ment to remove *items*,
hence the input is unfiltered and may not contain only files and
folders.


REVIEW: 11107

Printing border fix.

Umbrello prints currently with screen resolution (96 dpi). This has the drawback that
QPrinter::pageRect() returns the same size as paperRect(), which in fact means that
there is no printing border.

To have a minimum border in that case we manually add a page border which is 2,5% of the
page width/height on each side.

Fixed "mouse double click collision."

This patch fixes the 'add point' collision:
- removed 'add point' double click action
- added a new AssociationWidget context menu entry named 'Add Point'
- moved out associaton related context menu setup into
ListPopupMenu::setupAssocationItem()
- use upper case context menu entry text for add/delete point


GUI

update composite blocking from deleted, not client

fixing bug by deferring the deletion and removal of the
deleted to the next event cycle had the side effect that
this now happens in the event cycle of the compositor
restart, which was deferred to avoid precisely that...

so the test is now moved to the removal of the deleted
which got an additional flag wasClient to avoid calling
this action for each and every tooltip (and might be usable
elsewise)


FIXED-IN: 4.11
REVIEW: 111204

Fix memory leak in KFileItemModel

Since m_pendingItemsToInsert is a list of pointers now (and not a list
of KFileItems, as in the 4.10 branch), we have to delete all pointers
when clearing or destroying the model.

I think that no review request is necessary for this small and obvious
change.

do not auto-complete on paste

Neither auto-complete on paste (ctrl+v) nor on middle mouse button.
FIXED-IN: 4.11

delay adding Unmanaged clients by 50ms

This provides some sort of synthetic XSYNC support
for unmanaged clients and allows them to do an initial
update after mapping and before being painted (prevent
flicker)
Also it helps with Unmanaged clients performing quick
map/unmap/map cycles what also seems to induce the black
window issue on the nvidia blob.



FIXED-IN: 4.11
REVIEW: 111292

Correctly handle KDE executables typed into the OpenWith dialog.


REVIEW: 111272
FIXED-IN: 4.11

Don't highlight hoverd window while PW start/stops

Instead have a synthetic motion after the effect started
and explicitly set the selected window on click/drags



FIXED-IN: 4.11

REVIEW: 111276

Fix performance regression when loading folders in Details View

When using Details View, only insert all pending items immediately if
new items are inserted which might be children of a pending item. Fixes
the problem that inserting the items in multiple bunches slows down the
folder loading.

Note that the cause of the slowness when inserting in multiple bunches
is that KItemListSizeHintResolver needs O(N^2) time in the worst case
for inserting N items into a model with N existing ones.

REVIEW: 111226

Figure out how the KSwitchLanguageDialog specifies the startup language

What we did was to port the code in the dialog to read the values from
QLocale, relying on KLocalizedStrings' hook to initialize QLocale properly.
So we added that hook that reads the configuration that knows what language
should be used to override the settings that Qt will use, which is the
LANGUAGE env var.

NOTE: we removed the code that, after saying that the application should be
restarted, tries to change the language on the fly. It didn't work well
(the new things were translated, but not the old things).

For more information see the review request, it has quite some literature.

REVIEW: 111178

Fix many color correction problems with OpenGL ES

On GLES, check for OES_texture_3D extension for color correction

Remove a block of ugly hack code that was supposedly needed to build
with OpenGL ES.

Convert the lookup texture data to uint8 on OpenGL ES before sending it
via glTexImage3D, because uint16 is not supported.

Check if the shaders have been reinitialized successfuly when trying to
activate color correction, prevent black screens when there are issues
with the shaders.


REVIEW: 111225
(cherry picked from commit 68c68ee3c2b54f968c4d8275f1e8a2e0ccc90dd7)

Fix screen brightness not being updated properly.
I moved the updateBrightness function to the logic.js but forgot that the pmSource
will not be available there. Now passing pmSource to the function. Works.

grant minimizability to transient special clients

This will not provide a 100% fix, since at least KMainWindow
toolbars at some point start to behave like override_redirects


REVIEW: 111303
FIXED-IN: 4.11

Prevent possible infinite recursion in ViewProperties

If each directory can have its own view properties, and loadting the
.directory file fails in a directory, we have to load the global view
properties. However, if we try to do this by changing the "global view
properties setting" and loading the view properties for the same
directory again, we might get an infinite recursion if changing the
setting fails.

We now force a loading of the global view properties by constructing a
new ViewProperties object with an empty URL.

Thanks to Kurt Hindenburg for helping to debug this issue (which was
only reproducible on MacOS).


FIXED-IN: 4.10.5
REVIEW: 111182

Make the notes plasmoid change the background color according to the
current plasma theme's text color

The notes plasmoid by default takes the text color from the current
plasma theme but has "yellow" hardcoded as default background color.
This can lead to unreadable notes by default with certain plasma themes,
e.g. Produkt.
It's especially annoying if you're using such a theme because you can't
globally change the default notes colors but have to do it for each note
on its own (f.e. every time after pasting text to the desktop by
pressing the middle mouse button).

This patch changes the default background color to black if the text
color is brighter than a certain threshold.
Also the background color is re-read from the config on plasma theme
change to make it change as well if necessary.


FIXED-IN: 4.10.5
REVIEW: 110701

Fix many color correction problems with OpenGL ES

On GLES, check for OES_texture_3D extension for color correction

Remove a block of ugly hack code that was supposedly needed to build
with OpenGL ES.

Convert the lookup texture data to uint8 on OpenGL ES before sending it
via glTexImage3D, because uint16 is not supported.

Check if the shaders have been reinitialized successfuly when trying to
activate color correction, prevent black screens when there are issues
with the shaders.


REVIEW: 111225

Visually change the text color when plasma theme changes

Patch by Anne-Marie Mahfouf

For theme text color, the code was Plasma::Theme::ButtonTextColor
instead of Plasma::Theme::TextColor in 2 places. When the theme changes,
make the text change color.


FIXED-IN: 4.10.5
REVIEW: 110716

Ignore the desktop on smart placement

The desktop usually intersects all windows and
by this pollutes the heuristics with its punishment

Repair alarms part 1

We need to make sure all the collections are enabled, otherwise we'll
never get to see any item in the calendar. I wonder if that ever worked,
to me it looks like korgac could have been broken since the introduction
of the KCheckableProxyModel.

It is a rather crude implementation as we blindly enable all the
available collections here. We might want to improve that later by
enabling only a subset based on some settings (either specific to korgac
or in sync with korganizer). That's to open up that path that I didn't
simply use setCollectionFilteringEnabled(false) on purpose.

Cancel session request if the task is deleted early.

E.g. due to losing the connection to the server.
Otherwise the request is processed later on, with no task to use that
session, and we end up with a session in m_reservedSession for ever, and
soon afterwards an infinite stream of
"Cancelling this request. Probably there is no more session available."

Might be related to:
, 316541
(but for lack of debug output in these reports, I can't tell for sure)

FIXED-IN: 4.10.5
Reviewed-by: Kévin Ottens

Fix Bug 320172 - Hacking kmail

FIXED-IN: 4.11

Fix support for RSS feeds whose item links are not complete urls

Happens with some links from http://www.penny-arcade.com. I added the feed
to the test suite.

This change also changes the result of parsing the zeit.de.xml feed, which
as I understand it, was suffering from the same problem.

REVIEW: 111289

Repair alarms part 2

Callers might need to know to which incidence the returned alarms are
associated... Unfortunately incidence gets deleted so parentUid() will
return an empty string. So avoid this information being lost, pre-tag
all the alarms with the corresponding uid using a custom property.

Fixed a "screwed" lines bug

It turned out that our "bended lines" bug consists from two different bugs.
1) Lack of tablet events (only in openGL mode)
2) A bug in Basic Smoothing algorithm (some whirls
appeared even in QPainter canvas mode).

This patch fixes the second one. The bug was related to the fact that
the size of the control points for the bezier curves was *not limited*.
It resulted in lines bending, screwing and whirling effect. Now the size
of the control lines is always bounded, so the lines became much smoother.

But the first part of the "bended lines" bug is still not fixed, so openGL
mode will produce bends in lines.




The first one is the lack of tablet events in openGL mode, and the second
one was related to the

Fix anchoring of images before a ToC

When there was an image before a ToC it was added starting at the place from the ToC.

The test document
c3ld.vn.refer.org%2Fdocproject%2Fmigration%2F%306%306MG-DifferencesInUseCalcExcel.odt

shows the problem.

The reason for the problem was that the wrong document was used when desiding where to
put the anchor.

[FEATURE] Added enchanced weighted smoothing algorithm with tail configuration

Now when you lift up the stylus the line hurries to the tip of the pen
so that the line ends right at the position of the pen, not delayed.

There is a configuration option for this feature: "Tail Aggressiveness"
(probably, some other name would be better ;) )

1) Tail Aggressiveness == 0: There is no tail at all. The line ends where it was.
2) Tail Aggressiveness == 0.15: The tail ends with the very thin tip.
3) Tail Aggressiveness > 0.15: The tail ends with bolder tip.

Fixed a pressure bug in Wash-mode of painting

When the pressure drops, the opacity drops as well. In this moment, to
avoid the artifacts while painting the ALPHA_DARKEN op should work in a
reversed way. That is the contents of the layer should be painted on the
top of the brush dab. To allow this, we now keep the average value of the
opacity of several last dabs to be able to reverse the composite op.

This is tested to work best with spacings 0.1-0.2. With other spacing
values, probably, one needs to correct exponent value in
ParameterInfo::updateOpacityAndAverage().

Fix bug 184237: JJ: indentation not saved (or not restored)

The bug was that the cell indentation was searched in
table-cell-properties but it is found in the paragraph-properties.
Saving always worked.

rename all filter modules to calligra_filter_formatx2formaty

REVIEW: 111031

thanks boemann for review

Check whether the index into m_ranges is valid

mpris2: Move DBus adapter creation until after GUI setup.

This helps a little bit with JuK freezing Plasma due to DBus deadlocks
from synchronous calls being made between KStatusNotifierItem, its
Plasma notification area counterpart, and the MPRIS2 adapter and its
Plasma counterpart(s).

Proper fix is async everywhere as far as I can tell.

ScanManagers, ScanResultProcessors: don't call non-thread-safe code from a thread

Excessive usage of direct Qt connections lead to a large amount of code
in various ScanResultProcessors being called from a non-main thread, but
the result processors didn't expected it, weren't thread-safe, which
lead to data races.

This fixes one confirmed crash and may fix more seemingly random Local
Collection updating behaviour.


FIXED-IN: 2.8

lyrics: Don't make network requests when lyrics are invisible.

[Single]CollectionTreeItemModel[Base]: first look at cleanups/corrections

This is the first part of much-needed revisiting of the Collection Browser
and associated models. The final goal is to get rid of the unfortunate
expanding/scrolling behaviour and of the caching bug. That will involve
more code floating around this commit just brings some fixes,
deduplications and corrections.

This should fix bug 262504, but needs confirmation from folks that were
able to reproduce this bug. Reporters, please reopen if you can reproduce
this with recent git or 2.8 Beta (to be released really soon)


FIXED-IN: 2.8

mpris2: Make some adapter methods async.

This is another attempt to work around JuK <=> Plasma DBus deadlocks,
but making some of the DBus methods that Plasma would call into via the
MPRIS2 interface be async.

delete animation data directly rather than using deleteLater, which results in all objects being deleted at exit, thus effectively appearing as a memory leak

Add back a few MIME types to ArchiveModel::mimeTypes().

Fix a regression introduced in commit c79d8db2: some of the MIME types which
got removed were not bogus at all. While they are not used for _dropping_,
they are used for _dragging_.

This should make dragging single or multiple files/folders from, say,
Dolphin to Ark work again.



FIXED-IN: 4.10.5

Set path when creating course.

This solves the directly visible problem, but it is not yet complete,
since we require a feedback mechanism that only allows creation of
a course when repository is set.

full view on desktop and icon in panel ;)

Make "Prompt on access" kwalletd setting apply in more situations

Only the correct bits this time; see the already-closed REVIEW 110330.

Added support for lists within templates.

For example:
{{TemplateWithList
|
* item 1
* item 2
}}

Add 'Always Ask' option for filetransfer destination directory

When enabled in KCM, the IncommingFileTransferHandler will always ask for
destination directory and filename. When the feature is disabled, the
handler will always use the download directory as set in KCM.

REVIEW: 111091

FIXED-IN: 0.7.0

Import the KPeople KTP integration plugins

There are two plugins, one for the datasource which provides
IM data in real time.

The other is an actions plugin which provides actions that can be started on a PersonsData.

REVIEW: 111256

Add pring preview. And sync menu between mainwindows and readmainwin

Select highlight colours depending on the view's background colour.

Todo: what about multiple views with different colour schemes?

IMAP: Parser: allow for servers denying the synchronized literals

The IMAP server has a right to deny receiving the synchronized literals; in such
case, the correct thing for a parser is to report the failure immediately and to
resume sending any other queued commands.

Previously, Trojita would wait for the continuation request indefinitely, but
this commit changes this and lets it report the failure early and to carry on
with the subsequent commands.

Please note that there is no special error reporting. If there was something
like that, any place sending commands would have to be adapted to listen for
these asynchronous events. Instead of that, we rely on the IMAP server to do the
reasonable thing and send either NO or BAD when rejecting literals, and on the
existing logic handling the "a command has failed" case. If the server is broken
enough to "reject" the literal with something different, like an OK, the code
simply logs a warning.

akregator: Support nested xml:base attributes

Feed from tbray.org has such nested xml:base attributes. Added it to the
test suite.

The change also slightly changes the output of bug-190068.xml.


FIXED-IN: 4.11.0
REVIEW: 111288

[FEATURE] Add an option to smooth the pressure in Weighted Smoothing mode

This feature makes the shape of the line be more stable, but still there
is one drawback:

When the option is active you almost cannot control the shape of the
beginning of the line, it is always very thin.

Use relative paths for file layers

force sinknode global code execution

using a similar approach as with vmem we are now forcing the global
function execution of sinknode handles such that a derived class doesn't
need to manually call the sinknode's implementation.

instead the sinknode's public add/connect/disconnect functions are now
non-virtual and host the global code for node configuration and then
call protected virtual handles that can be reimplemented in the derived
class.

so, executionwise we now always have
SN::connecToMediaObject
-> VW::handleConnectToMediaObject
and
-> VW::handleDisconnectFromMediaObject
SN::disconnectFromMediaObject

any future sinknode implementation will need to drive the handles rather
than the public functions and they get called indirectly through the
public function. add/connect gets called after global setup and, whereas
disconnect is called before global teardown.

Add support for Microsoft Standard Time Zones

Because one incompatible timezone format would be to simple, Microsoft
has invented yet another one. Some invitations generated by Exchange 2010
(and maybe others) use "X Y Standard Time" as a TZID string. This commit
adds mapping between these strings and Olzon timezones that are accepted
by Google Calendar API


FIXED-IN: 2.0.2

Handle media keys

Collection Browser: replace "Artist" by "Album Artist" by default

CHANGES:
* Collection Browser: Artist level was renamed to Track Artist and replaced by Album
Artist by default. Various Artists item is no longer shown under Track Artist level.

Following was done:
a) shop showing "Various Artists" under "Artist" level and therefore
stop showing some tracks twice. Show "Various Artists" only under the
"Album Artist" level where it logically belongs
b) tweak the default presets to use "Album Artist" where they previously
used "Arist", except for "Album / Artist" where it doesn't make sense
c) adapt user configs treat "artist" as "album artist" for users migrating
from older Amarok releases
d) rename "Artist" level to "Track Artist" make the distinction more clear
e) use current "Artist" icon even for Album Artist level, Sentynel and
Mamarok finds the current one way too fugly

^^^ I think that the points above combined would mean nearly no
disruption in user experience and would make the interface more logical
and correct.

GUI: A set of changes to Collection Browser levels, "Artist" level was
renamed to "Track Artist", its behaviour was changed and it was replaced
by "Album Artist" by default.

MemoryMeta: make tracks editable ... again!

The tracks on iPods, MTP ones, USB Mass Storage ones ceased to be
editable since my refactorings of Meta::Track and Meta::TrackEditor.

How could that live so long without anyone noticing?

Control volume using up/down arrow keys and cleaner way to read/write settings.

Finally harmonize the double-click and other playlist-related actions

CHANGES:
* Playlist-related actions were harmonized, double-clicking or pressing enter will
append tracks to playlist, middle-clicking or using any "play media" action will
prepend tracks to queue and immediately start playing; append or replace actions will
no longer start playback.

Funnily enough, this is exactly what Myriam suggested from the start, but
wasn't understood by me, because her Amarok behaved differently than mine
(how so?) and we both referred to that behaviour.

The CHANGES above are current state vs. Amarok 2.7.1 and ignore any
intermediate steps.




FIXED-IN: 2.8
GUI: revisit playlist-related actions, the changes are more subtle now, see CHANGES

[ #26313 ] Sync the daemon dbus .xml and implement the new record API

add mark timeline as read context menu item to tabs.
rename actions to differentiate mark timeline as read and mark all timelines as read.
don't show mark timeline read action if timeline already marked read.


REVIEW: 111181

VPN secrets compatibility with networkmanagement

a message processor

it listens to notify events from the database and schedules a
message processing run. it processes then N messages at a time
until the queue is drained.

it is multi-process safe, so running multiple bodegas on different
machines should not result in missed or duplicated messages

the message type causes processing by a similarly named file in
lib/messengers which can do whatever they need to / want.

currently only sendEmail is supported and just one basic messenger
is implemented.

TODOs left:
* additional message-type-specific information with message request
* a more flexible way to connect a messenger to a given message type
* HTML email (if really wanted?)
* a way to unit test this

export create, delete and update tags functions

PopplerExtractor: Trim the guessed title to the first 50 characters

Sometimes the guessed title is just too long, in those cases we try to
trim it to the first 50 characters.

Save as much as 60MB of heap space.

This patch clears the query cache if it's unused for more than 30 seconds.

Tested with two clients connected (korg and korgac).
Massif pointed out 60MB of heap allocated to the QueryCache,
massive blobs in libmysql.

The QueryCache was created to speed up mass operations,
like deleting all items from a collection, after that,
there's no use in keeping it around.

Even if another mass operation arrives, it's just a few milliseconds
to prepare the first query so it can be used for all following queries
of this new mass-operation.

My akonadiserver is now running at 17MB when using jemalloc.

( with glibc malloc it's a bit more random, due to glibc's
complicated policies to return memory to OS, sometimes it goes
down to 17MB too, other times stays at 80MB ).

REVIEW: 111203

Use a singleton for ETMCalendar. Massive memory savings.

Each kontact plugin was using their own ETM which is unecessary.

Tested on kontact with most plugins loaded, and a 30k event calendar.

Unpatched:
glibc : 600 MB
jemalloc: 500 MB

Patched:
glibc : 415 MB
jemalloc: 360 MB

Reduce duplicate code. Export/import notify file

Use the singleton, saves memory when ran in kontact.

singleton is shared by the summary view plugins.

removed unnecessary searching for new parent account id

code removed for two reasons:
1. the 'new' parent id wasn't set/used anyway
2. the dialog box restricts changing account type to the same group,
meaning the parent won't change

Revamped the filesystem browser
REVIEW: 111263

startup: Async-ify cached item loading on startup, add timers.

In an attempt to get rid of processEvents() (related to several existing
crash bugs) I am trying to port the startup code towards more
async-friendly schemes.

There's no threading but we at least get back to the event loop much
more frequently while loading files.

Additionally I have added debug output with instrumentation to show how
long it takes to advance through each step of the startup (I think this
might be the first time anyone has understood JuK startup sequence in
years).

This leaves some essentially dead code with Cache (which no longer
acts as a container), which I will try to cleanup in later commits.

message queueing now uses an hstore for key/value data

this eliminates the problem of having just a single text chunk for
the message; used in publisher/distributor requests, for instance,
to also note the partner id

not 100% happy with having to process the hstore results into an
associative array ourselves, but there you go

Add an ecliptic - equatorial conversion and a unit test

Add a quaternion-based conversion from B1950 to Galatic coordinates.

Implement correct precession calculation.

Improvements for the event "Enter to create function"
Now, expression-edit will also sense Enter key and create the function

Using KActions instead of Tool buttons and drop-down buttons for menu options

Do not show "Move To Trash" action in context menu for remote URLs.


REVIEW: 111206
FIXED-IN: 4.11

Use the KDE SC version also as the Dolphin versions

This has some advantages:

(a) The version actually changes for every bug fix release, making it
easier to find out which version a bug reporter has used.

(b) No changes in Dolphin's source code are required to keep the version
always up to date.

(c) It is more transparent for users because there are not two different
versions any more.

Initial rewrite of KCM, mostly based on existing code from kcm-newui branch

Move KUrl to KDE4Support

And yet another one bites the dust... bye bye KUrl!

Merge remote-tracking branch 'parser/master' into gsoc2013

The new Nepomuk query parser now lives in a branch of nepomuk-core and can
be used like the old parser. The new parser is source and binary
compatible with the old one.

Respect property ranges

The property ranges are hard-coded. Respecting them avoids wrongly accepting
ambiguous queries, like when two patterns match but only one has a valid
meaning (we do not send mails to date-times nor do we look for files greater
than "cat").

Merge branch 'mklapetek/refactor'

REVIEW: 111096

Conflicts:
src/CMakeLists.txt
src/contactitem.cpp
src/examples/CMakeLists.txt
src/examples/personwidget.cpp
src/ktptranslationproxy.cpp
src/ktptranslationproxy.h
src/persondata.cpp
src/personitem.cpp
src/personsmodel.cpp
src/personsmodel.h
src/personsmodelfeature.cpp
src/plugins/core/email_kpeople_plugin.desktop
src/plugins/ktp-plugin/CMakeLists.txt
src/plugins/ktp-plugin/im_persons_data_source_plugin.desktop
src/plugins/ktp-plugin/impersonsdatasource.cpp
src/plugins/ktp-plugin/impersonsdatasource.h
src/plugins/ktp-plugin/ktp_kpeople_plugin.desktop
src/resourcewatcherservice.cpp
src/tests/duplicatestest.cpp
src/widgets/CMakeLists.txt
src/widgets/abstractpersondetailswidget.cpp
src/widgets/abstractpersondetailswidget.h
src/widgets/persondetailsview.cpp
src/widgets/persondetailsview.h

Renamed "Tail Aggressiveness" option "Stroke Ending"

Other nice variants we considered:

-"Tail Aggressiveness"
-"Tail Chasing"
-"Goofiness"

:)

Improvements in PlotsDictionary feature
This commit adds the feature of connecting the space and the dictionary-plots sothat user can add the plots from the dictionary in the space.