Issue 319

Init sessionString plasma datasource val properly

Kdevelop sessionrc content is changed and SessionPrettyContents contains
both seesion name and session content now. Update sessionString value
initialization and remove outdated code in the plasma applet datasource.

REVIEW: 114535

Adding support to online plate solving using astrometry.net web services API. Users can now use the online service without having to download gigabytes of catalogs
to perform offline solving. This required JSON processing and therefore I had to include an optional dependency on QJSON for the time being until KStars moves to Qt5
which has native JSON parser.

odt: Seems styles.xml and meta.xml are not mandatory

At least libreoffice opens the file from bug 324241 that has neither of them.
With this change we open it too, it looks crap when compared to libreoffice,
but that's just because our ooo generator needs to die in favour of a calligra one.


FIXED-IN: 4.11.5

Make Labels keyboard shorcuts configurable by end user into KDE config panel of each root digiKam window.
This include Rating, Color, and Pick Labels.
Unlike tag action shortcuts which are stored in digiKam DB, Labels action shortcuts are stored in each
XML GUI config file of each root digiKam window.
Because each root window manage shortcut individually for relevant GUI, you need to apply a keyboard shortcut
change in each root window setup, to be homogenous everywhere.

FIXED-IN: 4.0.0

When a user creates a new bookmark folder make that the current item.


REVIEW: 114479
FIXED-IN: 4.12.1

[Kickoff] Fix breadcrumb navigation

Workaround for ListModel not being able to store QVariant(QModelIndex)
values. Now it's stored in another model property. Makes the breadcrumb
navigation work again.

fix crashes in KateDocument::defStyleNum() by adding if-guards.


REVIEW: 114586
FIXED-IN: 4.12.1

@font-face rule: fix overriding of src property declarations.


FIXED-IN: 4.11.5

do not word wrap when removing trailing spaces

Thanks to Gerald for the detailed report!

FIXED-IN: 4.11.5

Changed OpenWith dialog from Qt::ApplicationModal to Qt::WindowModal.


REVIEW: 114473
FIXED-IN: 4.12.1

Fix Bug 329068 - Birthday fields are empty when export to csv-file

FIXED-IN: 4.12.1

Don't scroll if we don't change paintops and reset the view settings
of the strip when we do change paintops.

This fixes the weirdness when you select a preset and scroll to the start
as well as the weirdness when you select a paintop without presets and
then select one with, and the preset icons are shown half-height.

Fix pressure sensitivity in the Scratch Pad

fix problem with saving thickness in hatching brush after an old preset was loaded and then saved

Update the channel docker when changing image colorspace

Select the right Ocio display

Fix crash on loading a file layer

KisClipboard::clip can return an invalid paint device

When nothing can be used to create the paintdevice, KisClipboard will
return an empty paint device, so check for that.

Fixed a concurrent File Layer source image change

Now when the source image is changed we use an iterational algorithm
which is usually applied to a SeqLock problem:

1) Save the size and lastModified tag of the image
2) Copy the image to the temporary directory
3) Check whether the image has changed during the copy operation
4) If everything is ok load the image from a temporary copy. If not,
restart.

Fix the Color-Picking after a system shortcut

Configuration menu is now using Tabs to provide a more standard,
convenient and pleasing layout
Sound Menu: Play button reflects playback status and shows either
"Play" or "Pause"
Bugfixes and Features (CCBUGS, as most bugs are already closed). Hint: Some
bugs might have actually been alreay fixed ibn KDE4.11 or KDE4.12.

Bug ID Severity Summary
CC critical kmix start delayed on 20 seconds
CC normal mpris volume/play status not in sync with app in kmix
applet
CC normal KMix Does Not Unmute Master Audio Channel
CC normal Tray popup obscures vertical panel
CC normal KMix does not distinguish separate channels on one
volume control
CC normal Tray plasmoid scroll/hiding issues [read description]
CC crash Kmix crashed after selecting Amarok as master
CC normal kmix size is not restored by session management, only
position.
CC major KMix volume icon is unstale during playback

playback: fix crash on quit in the middle of a fadeout

My assumption was incorrect, a child must still track its parent using
QWeakPointer to be safe.

Thanks for investigation from Harald Sitter, you were absolutely
correct, our lord-president. :)


FIXED-IN: 2.9
BACKPORT

Implement configuration of backends in SoundMenu
CC

Fix all focus related bugs

REVIEW: 114487

load translation catalog with the library

Implement duplication of diagrams

The popup menu of diagram list view items now contain the standard cut/copy
menu entries. A new entry 'Duplicate' allows duplicating a diagram and all
widgets, but not the underlying UML representations.



GUI

Added support for showing journey duration for other routng backends.
GCI task #5530796219695104
REVIEW: 114469

Added option in oxygenrc to disable window background:

[Common]
UseBackgroundGradient=true

Option is hidden (no UI element) because of string freeze
Also removed decoration blend style option.
Background gradient is now always decided based on window flag.

[ksplash] Add --window option which prevents any special flags

I'm adding a new argument instead of re-using --test because
it is useful to be able to test themes with the real flags, but
it is also useful to be able to test KSplash without having
a "Full window always on top" covering your terminal.

[ksplash] Add a --nofork option useful for testing

Create a new application: SieveEditor

It's necessary because some guys doesn't want to install all imap resource
in akonadi to edit server script.

Smoothscale the thumbnail for .kra files

Show newly created tags in the context menus

There's still a bit of a mess, in that deleted unused tags aren't cleaned
up, so we'll need a cleanup feature for that.

Add qimageio plugins for kra and ora files

- CSV importer may import certain investment transactions
without assigning a brokerage or checking account.
Also, improve wording of heading label of symboltabledlg.ui.
- Fix matching problem on import when securities have different names but same symbol.

Fetch cover picture from METADATA_BLOCK_PICTURE tag.

With this patch, covers from Ogg files (for example Vorbis and Opus)
using the recommended METADATA_BLOCK_PICTURE tag will be displayed.


FIXED-IN: 2.9
REVIEW: 114406

Make nick completion style configurable

added UI option for UseBackgroundGradient

Instead of reinventing the wheel, reuse QThreadStorage.

While at it, speed-up DUChainItemFactory::copy by only accessing
the TLS once, then operate on a bool& afterwards.

Now all cases are equally fast, independently of the value of what
constant value is currently set or requested.

Optimize: Don't call gettimeofday/timersub if its not required.

Most calls which lock the DUChainLock do not use a timeout value.
In such cases we can be faster by not reading any time data.

Refactor IncludePath{Computer,Resolver} interaction.

We now still call the resolver's includeResolver.resolveIncludePath
as that is required to support custom include paths in the hidden
.kdev_include_paths files.

Instead, we disable the make-resolution when we get any paths from
the build manager.

Also get rid of the code which tries to be faster by looking at
the DUChain to find include paths. It's not faster. Also note how
the IncludePathResolver has a cache internally.

Save 16 bytes per sky object.

In practice, the `long double` type has 16 byte size and alignment.
We can inspect the memory layout of some class inheriting SkyPoint using
clang [1]:

*** Dumping AST Record Layout
0 | class StarObject
0 | class SkyObject (primary base)
0 | class SkyPoint (primary base)
0 | (SkyPoint vtable pointer)
0 | (SkyPoint vftable pointer)
16 | long double lastPrecessJD
32 | class dms RA0
32 | double D
| [sizeof=8, dsize=8, align=8
| nvsize=8, nvalign=8]
...(snipped)...
184 | float B
188 | float V
| [sizeof=192, dsize=192, align=16
| nvsize=192, nvalign=16]

The vtable takes up only 8 bytes (on 64-bit), but we waste 8 bytes on
padding. Moreover, we then take up 16 bytes to store lastPrecessJD.
Using a program like the following:

#include <stdio.h>
#include <math.h>

int main()
{
double jd2000 = 2451545.0;
double delta = nextafter(jd2000,jd2000+1) - jd2000;
printf("delta: %.30f\n", delta);
return 0;
}

we can compute that at J2000, the minimum time step at double precision
is approximately 40 microseconds, so it's not clear that we gain
anything by using 80-bit long doubles instead of 64-bit doubles.
Changing the `long double` to `double` (and placing it last) results in
memory layout like so:

*** Dumping AST Record Layout
0 | class SkyPoint
0 | (SkyPoint vtable pointer)
0 | (SkyPoint vftable pointer)
8 | class dms RA0
8 | double D
| [sizeof=8, dsize=8, align=8
| nvsize=8, nvalign=8]

16 | class dms Dec0
16 | double D
| [sizeof=8, dsize=8, align=8
| nvsize=8, nvalign=8]

24 | class dms RA
24 | double D
| [sizeof=8, dsize=8, align=8
| nvsize=8, nvalign=8]

32 | class dms Dec
32 | double D
| [sizeof=8, dsize=8, align=8
| nvsize=8, nvalign=8]

40 | class dms Alt
40 | double D
| [sizeof=8, dsize=8, align=8
| nvsize=8, nvalign=8]

48 | class dms Az
48 | double D
| [sizeof=8, dsize=8, align=8
| nvsize=8, nvalign=8]

56 | double lastPrecessJD
| [sizeof=64, dsize=64, align=8
| nvsize=64, nvalign=8]

This also has the benefit that the SkyPoint data fits in a single cache
line, though I don't think this really makes a difference given the
inefficiencies in the rest of the code. A before/after test showed a
drop in memory usage of about 6%.

[1]: http://eli.thegreenplace.net/2012/12/17/dumping-a-c-objects-memory-layout-with-clang/

Remove all traces of Nepomuk and Soprano

Port Dolphin search to Baloo

AddresseeLineEdit: Remove Nepomuk fallback logic

When the user types something for auto-completion an
AkonadiContactSearchJob was sent and if Nepomuk was not running, the
entire contact list was loaded into memory and then queried.

With Baloo, all of that logic can be removed as it does a better job and
does not require any service to be running.

Do not convert empty paint devices, but convert their default pixel