Issue 115

Fixing crash when closing the toolbar config dialog. I had been invoking KEditToolbar directly, but the API docs clued me in to the fact that this is not necessary. As long as I have an action named "options_configure_toolbars" in my XMLGUI file, then I don't need to do anything else. Apparently doing it manually is a bit worse than unnecessary, because the mysterious crash I had doing it manually is gone now.

Actually, there's one more detail I needed to make the auto-code work.
By looking at the code of other apps, I learned that I need to have setXMLFile("kstarsui.rc") and setupGUI().

It sure would be nice if we had some up to date documentation on how this XMLGUI stuff is supposed to work...

Fixing a trivial bug in starblocklist.cpp that was preventing markNext() from being called. This was causing blocks to never be inserted into the LRU Cache, and thus, cached blocks were never reused.

With this fix, we achieve a 2x drop in memory usage when limiting magnitudes at zoom in and zoom out are 10.0 and 6.2!

Leaving the debug statements till we are sure of the code quality.

Also fix the dir select dialog if the combobox wants to be very big. Now the size of both windows are saved when pressing cancel too. If the user modified the size of the window was to see better, independently of clicking Cancel because the file wasn't found or whatever.

Fixed issue that the text inside the "host" widget might get clipped.

TODO for KDE 4.2: Check with Aaron and Urs whether the "host" widget makes sense in this way at all (having an editable widget in the breadcrumb when having a sub path seems to generate some usability problems).

Update the breadcrumb content, when the places model has changed the data or items have been removed/added.

fix GTK icons are painted bigger than KDE icons in the systemtray.

various fixes, including updating the ruler buttons on resize move, differentiating horizontal from vertical ... should be fairly solid now.

Fix bugs of various kickoff searches not returning anything when using syntaxes like %U.
Patch by Alessandro Diaferia. Welcome to KDE development!! =)

Fix the small issue of being able to clear the selection on a KPageView, if it is on list or tree view mode.
I reported a bug to TT, but it seems the fix was done on the docs QAbstractItemView::SingleSelection (check between 4.4.0 and 4.4.1).

Now that there is no hope that this will be done into Qt, I create our own selection model that will reject to clear the current selection if there is no other item going to be selected.

Fix conversion of fontconfig's UTF-8 strings into QStrings.
(The fonts:// ioslave code was assuming fontconfig's strings were all ASCII - even though there were other places in kfontinst's code doing a proper conversion!)

This fixes a bit tricky bug. The default places are not "system" ones.
I cannot find that on the spec, and that leads to a problem following the next steps:

- Open kwrite, the open/save dialog. You have the default places.
- Add a new place to them (it will be added to ~/.local/share/user-places.xbel) - only that new place, not Home, Root or others, only that one.
- Remove ~/.kde or ~/.kde4, your local KDE 4 folder information.
- Open kwrite, the open/save dialog now only contains your own places.

This is a consequence of adding them as system ones, which makes sense for devices, but not for this places. Now they are all written to ~/.local/share/user-places.xbel.

Not having suddenly Home, Root & friends on the places view is bad, and you also get a very ugly "Custom Path > Home > Foo" on the top of the dialog, not even "Root > Home > Foo", since not even root exists on the places view.

Thanks to annma for spotting the bug and for ana` for helping out me for reproducing it.

This fixes the problem described before (as well as on the comment on the code).
Sharing the model prevents the bookmarks from being added twice to the places view (since we are less restrictive with the if() condition now).

This fixes the bug in KDE, while the file ~/.local/share/user-places.xbel only contains the important bits (the places that the user actually added).

Don't assert when the password entered is empty.

The password dialog is still shown too many times, but at least it doesn't crash anymore.

The sidebar needed lots of intrinsec logic for working properly.
This fixes the problem of a huge sidebar when the environment is clean (aka. "new user" test).

This also fixes some problems with layouts. Now the sidebar will automagically adopt the needed size, and the only thing one can do with the slider is to hide or show it.

I have double reviewed it is correct with the kde pim coding style, but if something is wrong, please tell me.

Fix Amarok's nasty evil habit of overwriting plasmarc.
This should make a lot of people happy, myself included! :-)

Thanks to Alessandro Diaferia for pointing us in the right direction!

Make the Mp3tunes service not crash when loading tracks. There is a fix here that really should be applied to all the workers.

The main issue though, seemed to be something deep in QString messing up if Amarok::extension( track.trackFileName() ) was passed directly as a function parameter, instead of loaded into an intermediate QString. Strange stuff....

Fix the integration of Singmaster moves with other kinds of move.

Make the debug options for the C++ language support configurable at cmake time

This means that rather than having to go open a file, comment or uncomment the 'make edit_cache' and get everything reconfigured.

You will need to include cppdebughelper.h into the file though but that's easy. :)

Large refactoring to allow running state of plugins to be shown to the user, and jobs to be killed...:

Change IRunController to allow it to manage KJobs. You can now register (and start) a new job by calling registerJob().

Change IRunProvider to work with KJobs instead of serial numbers (much better design :)

Add a menu option for selecting which project should be run, so the run configuration works again (but not the add target feature, will work on that later)

Created new KJob subclass that handles the creation of an output view to correspond to that KJob (in the utils module, OutputJob)

Added feature to output interface/plugin to allow the plugin to take ownership of a model (so that jobs which are deleted can still show their output)

Port to KJob
- cvs plugin
- svn plugin (could only find one place that jobs are started, is that correct??)
- execute (run) plugin

Start making a fully functional, background threading code completion easier to implement for all languages - i.e. abstract the c++ code completion.

Not compiling yet, committing so I can move back to my desktop from my laptop for development.

Obey KDE wide single/double click setting.

This poses a bit of a problem though, its now kind of hard to only select one file in the tree without opening it. The workaround that dolphin uses isn't going to work as we have too few space.

OTOH forcing double-click is also bad because then we need to disable editing of items via double clicking as it gets in the way otherwise.

Anybody with bright ideas how to solve this dilemma?

Kickass kdevelop feature of the day...:

Sync project view with the location of the currently edited document

Presenting (drum roll....)

Code completion support for Java!!

Ok, only basic global completion, but it's a great start...

This May Break Marble, it's rough preview of panoramio integration

Plugin Options added in Settings

Now uses KGameTheme and desktop files to load themes. Loading themes works.
A few other changes to improve theming support.

Current task: make it use the loaded svg correctly ;)

added script manager on edit menu

Copy and paste word types.

digiKam from trunk : worldmap widget based on Marble : add support of more than one items to import via KML interface.

digiKam from trunk : Fuzzy Search tool : Sketch widget :
- Start to implement drawing history.
- new method to store history as XML data (to be stored in DB)
TODO: undo/redo history managament

digiKam from trunk : Fuzzy Search : added Undo/Redo functions to Sketch widget

digiKam from trunk : Fuzzy Search : Sketch Widget : setSketchImageFromXML method is now implemented (not yet tested)

Marcel, this code can be used to import sketch XML data from dataabse to the widget.

Store sketch image XML description inside the XML describing the search, and fully restore the sketch when loading the stored search from the database

Support rebuilding the Duplicate search albums from the ioslave.

Necessary information is passed via KIO metadata.

Complete the implementation of the IPV4Config accessor.

It is now possible to get the configured IP details of an active device

Add the context menu for the icons in the folder view, and add the "Create New", "Undo" and "Paste" actions to the applet's context menu.

chdir to the user's "Documents" path before launching an application; this makes non-kde apps honour the kde document directory, (e.g. gEdit, gimp, openoffice...)

added quite a few features:
* joining of lines
* go to column motion
* open new line over/under cursor
* fixed delete commands
* delete char command

Implemented Context Menu to *Add Files/Directories, *Delete Items

Implemented Drag and Drop Support

First version of CommandWatch plasmoid.

It displays the output of an arbitrary command, with a customizable label.

Nice for showing your daily fortune, your uptime, kernel version, anything.

More improvements to the animated logo (with some ideas from JRT, and some from fredrikh):
use standard icon size to avoid rescaling of the icon; force icon size to be as big as we can, otherwise the style padding makes it too small -> the style just has to cope with the iconsize being quite big for the given widget size.

But if this gives too much trouble, we'll just have to skip the style altogether and draw this thing ourselves...

* Add support for 'Allow 132 columns' mode (set with \E?40h , reset with \E?40l) which controls whether selecting 80/132 column mode with DECCOLM (\E?3h,\E?3l) has any effect. Defaults to disabled as in xterm.

* Avoid triggering a terminal size update if the new and current terminal image sizes are the same.

Hacking Glib eventloop integration. Not everybody has Qt with glib support, and new Flash doesn't work without it.

- initial support for SVG styles
- support for svg fill attribute as part of style
- small improvements with WC/KHTML names compat problems
- after this commit khtml passes one more test for mobile browsers :-)

* improved searchbar (inline). parts of code have been taken from arora.
* make ESC key working to hide searchbar
* refactor: WebKitSearchBar -> SearchBar

create an example showing off the filters

Implement three different transaction modes for ItemSync: single transaction (that's what we had until now), block-wise transactions (only available when using item streaming) and no transactions at all.

Since these basically represent tradeoffs between quick UI updates, runtime costs and to some extend data consistency we probably need this choice to select the best one for every usage of ItemSync.

This also uncovered a race in sub-job scheduling which could cause deadlocks.

First experiments for the new MessageListView.
Exploring the View+Delegate+Model approach.

Hook up the new cert wizard (doesn't do anything yet).

More work on MessageListView. Doesn't it look cool? :)

Pimp up the viewer a bit. It can become handy when testing syncing.
I'm working towards a full featured keyring database editor.

This commit includes:

* Opening a existing database
* Creating a new database
* GUI pimp up so that you don't have to pass all sort of command line paramaters anymore.

We can now change (and actually save that change) the name of a keyring record through the viewer.

Other editing actions should be easy now.

Account and password of records can be changed also now by the viewer.

Yet more work on MessageListView. We have threading, first sample view configurations, nice graphics, basic selection of items etc...

* added event action plugin.
It already contains an empty implementation of the sound event.

Table tool
Base the table tool on KoInteractionTool and start implementing a fully functional cell selection.

Table tool
Implement autofill and merge strategies.

* Deleting rows WORKS!

Start to replace the formula bar.

Smooth the path while drawing.
This is needed also for the algorithm I have in mind to simplify the path.

Another step towards a working cell tool's content editor.

Introduce KoShapeBackground, KoColorBackground, KoGradientBackground and KoPatternBackground which replace QBrush as the background of KoShapes.

This will make it possible to implement background features not possible with QBrush, e.g. advanced background image options as defined in the ODF spec 15.14.9.

A test 'shape' object (in development)
A html export optionSelective compilation of the kspread export

more work on footnotes, headers/footers, and lists. the wonderbaar document still crashes, and I think it's because Word makes headings like lists, and I haven't processed those yet.

I'll be working on that, as well as cleaning up more bugs with the conversions

Add a shortcut key to refresh the canvas completely so I can determine whether errors in rendering happen in krita/image or krita/ui.

Improve calendar editor. Mainly layout, and the odd bug.

* Updating rows now work
* Introduced handler classes
* Various code clean-ups
* Adapted various CRUD callback functions to use the new Handler class

Wu Lines, first version.
Horizontal, Vertical lines works.
Color is supported.
Standalone application (stroke.cpp)

Add feature that clicking on an existing tab will change the tab type.
Remove strict tab-selection code to make it much easier to hit a tab.

allow more flexible handling of collections in collectionmanager.
allow code to set the status of collections which determines where the collections are shown or whether they take part in global queries.

CollectionManager handles persistence for that information.
now we just need a nice gui to set the status for all collections centrally

@Nikolaj: you can add all services as unmanaged collections now, they default to disabled

Implements cover art retrieval from the file system during a media scan. This creates a new database table `images` and augments the `albums` table to add a new column `image`.

Images are stored in the database but not yet retrieved by the Meta internals.

Max: is my implementation in line with how you imagined it would be done?

It is time to introduce SqlPlaylist and friends to the world!

The SqlPlaylist is currently a very simple playlist that stores itself in the Amarok database.
It can currently store and load tracks from the database but not much else.

In support of the SqlPlaylist, a basic playlist browser has been implemented. This browser supports an unlimited number of playlist grouped in an arbitrary hirachy of grups ( or virtual folders ).

Support for the groups has not been exported to the gui layer yet though.

The old save_playlist action has been renamed to export_playlist, and save_playlist is not used for storing a playlist in the database.

An action for this has been added below the playlist browser, and using this actually works :-)

What currently does not work, however, is readding a stores SqlPlaylist to the playlist as that crashes

Make adding SqlPlaylist's from the playlist browser to the playlist actually work!

Now we only need a dialog for naming playlists when they are saved, as well as perhaps an interface for deleting playlists from the browser, and we would actually have something quite useful!

Initial progress of work to databasify album artwork.
Can use some serious query optimisation through caching but I'll get to that later.

Artist filtering now works for mp3tunes.
Necessary wrapper changes are included.

first nepomukcollection with some real function (ok most still missing)

You can play songs out of it. It doesn't scan though, so you need strigi with some music indexed.
Added it to CMakeLists.txt files (builds when Nepomuk is available)

Add a context menu to the playlistbrowser.
Only supports deletion of playlists currently.
Right now it is not possible to actually add any playlists to the main Playlist however.

This will be fixed

allow groups to be added using the right click menu.
Now we basically just need drag and drop organization of playlist items ( all the beackend stuff for this is in place ) and we have ourselves a nice playlist browser

Drag and drop organization of items in the playlist browser now works.
Dragging a playlist to The Playlist also works... except that it crashes...

Autogenerate systray icon from the kopete icon in the theme instead of using the now outdated icons from KDE 3.5.

Grayed for offline, overlays in the bottom right corner for invisible and away.

Outbound Queueing; Channel URL support; minor fix.

It's official, server requests are now split into three queues to increase performance on connection and other times when Konversation is gathering background information.

If you find information is coming in too slowly, or that you are getting disconnected unexpectedly on connection, open the queue tuning widget with /queuetuner to change the sending rates.

If you've already been testing it, you may wish to reset to default values from the queuetuner's context menu as the default rates have doubled.

I'm still looking for feedback, let me know if these values flood you off somewhere reliably.

Channel URL support (328 numeric): Channel URLs provided by some networks will now appear in the proper view, with a translatable message.

Minor Fix: Channel mode +c is no longer considered to be +m in the GUI.

add configuration option for stripes

sync current state:
- added keyboard grabbing
- cube is now more or less calculated (still some issues)

Sounds for the default_theme by Thorsteinn Malmjursson

I'm commiting this as I do not consider it a new feature but a "translation" just that english translation goes with the game itself

Added a Hessenberg decomposition class for both real and complex matrices.
This is the first step towards a non-selfadjoint eigen solver.

Notes:
- We might consider merging Tridiagonalization and Hessenberg toghether ?
- Or we could factorize some code into a Householder class (could also be shared with QR)

qtestrunner gui test.
incremental result parsing, yields a significant performance boost [WIP].

- Completely rewrite the set-repository algorithms, leveraging the fixed split-hierarchy.

Now we don't create redundant nodes any more, and the algorithms work a lot faster.
Reduced memory-usage with more speed and more scalability, nice. :)

Also includes many general speed optimizations in the iterator etc. from valgrinding.

Losslessly optimized PNG and SVGZ files with "optipng -o5" and "advdef -z -4".

Reduced disk space: 5128KB (5MB)

* keep track in what desktop a window was moved and repaint only that desktop
* raise the update interval to half a second

these two things save a lot of cpu

Improve the performance of the code part which checks which items are visible.

Although the code is less readable now, it requires only 0,5 seconds for 2500 items instead of 2 seconds.

Remove all the MD5 handling and generate MD5 hashes only on saving (from now on kwallet won't use them at all).

For fast lookup use a QHash instead of a QMap of MD5 hashes.
It should be faster like that.

Runtime optimization for preview sorting: Use 2 different algorithms dependent on the relation between model-rows and preview items. One algorithm is faster when e. g. inserting 10 items into a directory of 2000 items, while the other algorithm is faster when initially loading the directory.

Revert my last change, unfortunately its even worse if you use singleClick mode in KDE.
Because QAbstractItemView::clicked() signal gets emitted no matter which button is pressed.
So to handle this properly we need so implement one of the event handlers and I don't have time right now to do that, thus bring back context menu by reverting the last commit

* Completely auto-generate the Kimono C# bindings - amazing! We've finally got there...
* Fix problem where C++ classes weren't implementing all the pure virtual methods they inherit by adding dummy methods to the C# classes with a warning not to call them.

Update some of the kdesvn-build module lists.

In addition special case a module name of phonon's branch handling.

Doing

module phonon
  branch 4.2
end module

Will do the "right thing" now.

Add programmer documentation.

First chapter is done (how to use MarbleWidget), the rest is yet to be done.

- Shashank: breaking compilation is not allowed at this stage of KDE 4.1 ...
- Quick fixing it ...

Moving it to playground for now because I lack time for discussion and coding.

Filter settings are stored in the database, with a list of default formats, and a list on top of that that can be configured by the user.

Adapt the setup page to this situation, inform the user that most common formats are already supported and he need not usually do anything here.

Display a warning if core formats are removed.

Storing currently causes a crash, which I need to investigate.
Storing is thererfore currently disabled.

finalise port to KDE4
- fixed help dialog
- add picsplugin is now built by default

kipi-plugins from trunk : start to port FlickrExport to KDE4/Qt4

Laurent, can you apply your magic convert scripts to this code.
Thanks in advance...

initial commit

Move the folderview applet to kdebase/apps, so we can add a dependency on libkonq.

The phonon situation is a real mess.
Now this crashed because Qt's phonon headers were found instead of those from phonon-4.2-branch (while linking was fine).

Changing the order of the include paths fixed it, but god knows how many more places have this (well I have #error in my qt-phonon-headers now to find out...)

New background for the default splash.
Also make 'DefaultFullscreen' only an alias for 'Default', as this makes the splash to be fullscreen.

4.1 splash icons.

make folderview a containment as well so people can start playing with it as they seem to not be able to comprehend the idea

paging mostly working; tomorrow will convert the nasty labels to something nicer that doesn't involve text; 4.2 will be more like nuno's rather awesome mockup.

Move code for disabling the paste action into DolphinView::pasteInfo() -> Dolphin KPart now also is aware about the disabled paste action.

Konqueror hides the paste action in the context menu now, but still the action in the edit menu stays enabled

When creating previews, thumbnails, etc. fill the pixmap with a 100% transparent background, and then draw on with the text colour.

Previously, the transparency was added after the text was drawn - and this just wasn't working for dark colour schemes.

Move Nuno's Raptor icons ({application,menu}-{add,delete}) from the core Oxygen set to the Raptor directory itself, as they're too specific.

But apart from that, I also feel that they're not consistent with other icons that handle this kind of stuff.
Short reasoning follows, as suggestion to the Raptor devs.
(No, I won't subscribe to any mailing lists just for this.)

With existing KDE icons, there are two kinds of pairs:
- list-add/list-remove: for adding stuff to any listing that already existed before (i.e. nothing is created, only added to the list as reference), and likewise removing it without destroying any real data.
- *-new: for creating new stuff that didn't exist before.
- edit-delete: for deleting real data, which means, stuff that has probably been created with *-new.

So add/delete is kinda weird - it should either be list-add[-stuff]/list-remove[-stuff] or stuff-new/edit-delete.

As far as I can see, the menu categories are not references to anything else but data that is managed by Raptor only.

Applications are a bit more ambiguous, but in the end it is the link that you manipulate, and that could probably also be considered a real object managed by Raptor.

Therefore, I would propose using *-new icons for adding application links and menus, and replacing the *-delete icons with just the single edit-delete, which makes sense for either of them anyways.
menu-add is really just a category, and can just as well be replaced by folder-new.

So this would leave us with one remaining icon, application-new, which should get the *-new plus sign instead of the "list-add" plus sign, for consistency.

The core Oxygen set provides everything else.

Create branch for adding a 'Leave Message' option to krunner_lock.

enable animations in the taskbar again, this time they are very subtle (50 ms fade in 100 fade out) and the pixmap used for alpha blending is one and shared among all task items, that makes the thing a bit faster.

also adjust the pager anim timing to match the taskbar timing

Feature branch for new scripting functionality in kate

since Solid may throw stuff at us that we aren't prep'd for, let's just handle it gracefully rather than take down all of plasma, m'kay?

Work directory for updating Konsole's Handbook for 4.x

Do not gray out icons of unloaded plugins, this can suggest one that the plugin cannot be enabled, when is not the case.

Reinstate the integrity() function from mailody3, ported to Akonadi.

This should make the resource fetch the mail based on uidnext and uidvalidity checks.
Basically means that it can now do the 'checkmail' properly and efficiently.

Too bad Akonadi does not seem to call retrieveItems( const Akonadi::Collection & col ) on the intervals.
I might be missing something.

Put phone number widgets into a scrollarea and make sure the area can display the initial three without scrollbar.

Fixes an issue discovered during Krush day 2 (widgets being reduced in height when new phone numbers are added)

I wrote code in this file in 2004 -> start solving the "(C) 2004 KMail Authors" mess, as requested by Allen.

Rearranged the POP account dialog to unclutter and fit smaller resolutions.
Also changed the inputbox to enter the port to be a KNumInputBox.

Use "Popup Notes" instead of "Notes" in some places to avoid confusion when knotes and kjots are both loaded Kontact components.

There were no objections from kde-doc-english or kde-pim.

Moved the "Check what server supports" button to below the options.
Reordered the "Account Name", "Host", ... fields.

Now the pop/imap dialogs look more like the SMTP one and have a more natural order (at least I think so)

Lets see if we can convince some plasma developers to work on Mailody now that the doxygen documentation is complete again.

Remove the document-related KoPart embedding logic; except the bits for loading and saving KSpread's old native file format.

Get started with testing saving of odf.
Saving seems to be in a pretty miserable state.

For saving ODF documents, we check: save_document(load_document(testfile)) == script

adding a new file stylesFilterkpr2odf.cpp it's just to avoid cluttering the other .cpp file.
I'm not totally sure if it's done right so please comment on it.

Added the page style creator, almost done.
Next style: gradient.

Drop caps: Need to remove any existing drop-caps related formatting if it's not on now.

(Like when the drop-caps is turned off using a future ui, for example.)

Refactor out TimedMrl base class

Towards a better scheduler, change the timing stuff from a base class to a role that can be queried w/o using rtti.

some work on transparencyfying the playlist browser.

If anyone has any bright ideas about how to remove the border from a QToolBox I would very much like to hear them, as neither setting the frame style or messing around with stylesheets seem to make the slightest difference.

Also, setting the background color of the QToolBox to transparent seems to kill the nice tab divider lines o.O

work branch for implementations of Phonon::Experimental that may not go into frozen trunk

Cloning ipodcollection to create generic mediadevicecollection skeleton for media device collections to inherit from.

Converted Ipod stuff to MediaDevice stuff, started to make generics but a long way to go.

Give last.fm streams a default cover instead of using the no-cover.
Also use "Last.fm" is there is no artist yet.

This makes freshly added Last.fm streams look much better in the playlist

Complete overhaul of the current track applet.
Move away from aligning items to svg defined areas completley as this proved wildly inaccurate for some reason.

It now resizes much better and properly elides text if it gets too long.

Make the base color of tree views complelte transparent, and use a semi transparent alternate base color.

This makes views that are not completely full look much better as they don't have a large, empty semi transparent area anymore.

To make this look really good requires some adjustments to the SVG theme.

Don't add the old media device tab.

The browser is old, broken, kde3support based and will likely get completely rewritten anyway as the new media device stuff is based on the collection framework

Initial import of cube effect.
Actual state is proof of concept.

The cube can be activated by ctrl+F11, but only exactly four desktops are supported.

Add a new Oxygen-style application icon made by Nuno Pinheiro.

In addition to fitting much better into KDE 4 visually, it's now also available in all standard sizes up to 128px plus as SVG (whereas the old icon was only available in 16px and 32px), meaning you won't see a blurry Yakuake icon in various places in KDE 4 anymore as you did before.

Display a message box when a new rule set has been selected asking if the user wishes to continue with the game in progress or start a new game with the new rule set.

If the game in progress had never actually started, a new game is started automatically.