Issue 196
14th August 2011 by KDE Commit-Digest TeamContributors
Marta Rybczynska
Danny Allen
Alexander van Loon
Vladislav Blanton
Jaka Kranjc
This Week...
Statistics
Commits | 3304 by 214 developers |
Open Bugs | 23291 |
Open Wishes | 17344 |
Bugs Opened | 432 in the last 7 days |
Bugs Closed | 478 in the last 7 days |
Commit Summary
Module | Commits |
/trunk/l10n-kde4 |
235
|
/branches/stable |
177
|
/trunk/KDE |
108
|
/branches/work |
66
|
/trunk/www |
36
|
/branches/trinity |
29
|
/trunk/l10n-support |
25
|
/part/syntax |
24
|
/branches/KDE |
19
|
/krita/plugins |
18
|
Files | Developer | Commits |
318
|
Iñigo Salvador Azurmendi |
106
|
252
|
Jan-Christoph Borchardt |
84
|
207
|
Burkhard Lück |
70
|
201
|
Allen Winter |
67
|
147
|
Srikanth Tiyyagura |
51
|
147
|
Gilles Caulier |
51
|
141
|
Dominik Haumann |
48
|
138
|
David Faure |
46
|
120
|
Christoph Cullmann |
44
|
126
|
Albert Astals Cid |
42
|
Internationalization (i18n) Status
Language | Percentage Complete |
Ukrainian (uk) |
100%
|
Portuguese (pt) |
100%
|
Swedish (sv) |
99%
|
Spanish (es) |
95%
|
Estonian (et) |
95%
|
Dutch (nl) |
94%
|
German (de) |
93%
|
Italian (it) |
90%
|
British English (en_GB) |
90%
|
French (fr) |
89%
|
Bug Killers
Person | Bugs Closed |
Christoph Cullmann |
83
|
Dominik Haumann |
75
|
Christoph Feck |
67
|
Tom Hughes |
44
|
Myriam Schweingruber |
37
|
Gilles Caulier |
25
|
Christian Esken |
13
|
Jekyll Wu |
12
|
Harald Sitter |
12
|
Thomas Lübking |
11
|
Commit Countries
Commit Demographics
Sex
Age
Contents
Bug Fixes | Features | Optimization | Security | Other | |
---|---|---|---|---|---|
Accessibility | |||||
Development Tools | [] | [] | |||
Educational | |||||
Graphics | [] | [] | [] | ||
KDE Base | [] | [] | [] | ||
KDE-PIM | [] | [] | |||
Office | [] | [] | [] | ||
Konqueror | |||||
Multimedia | [] | [] | [] | ||
Networking Tools | [] | [] | |||
User Interface | [] | ||||
Utilities | [] | [] | [] | ||
Games | [] | ||||
Other | [] | [] | [] |
There are 129 selections this week
Bug Fixes
Development Tools
Make the document controller to listen to the project's so that whenever
an open file is renamed, that file should be closed and reopened with the new name.
Properly check if files are present before creating a file.
Thanks to Albert Astals to looking through this bug :)
Fixed Dynamic arrays always having the length of the first matching element
Now the parent is searched first instead of starting at the highest level
Graphics
Stat the file before switching to it
This way if the document does not exist at least we do not loose the current file
FIXED-IN: 4.8.0
Fix the crash while clicking on the in-game ui without playing the game
Do not rely on extension but on output format for conversion
KDE Base
fix opening of files like "\"
Fix threading in IndexScheduler
Protect a ton of variables with Mutexes.
REVIEW: 102251
Conflicts:
nepomuk/services/strigi/indexscheduler.cpp
fix selection after search
remove \r and \n from visible file names
QRect::right() + 1 == QRect::x() + QRect::width()
Also to catch inner split for sure the calculation needs to be accurate.
REVIEW: 102292
supports renaming profile in the ManageProfilesDialog.
FIXED-IN: 4.8
fix spelling of unit to make clear this is Kilobyte
undo: do not merge separate replace actions
add fix for comments from user
highlight #!/... in 1st line correctly
fix xsync protocol
REVIEW: 102311
fix ambiguous shortcuts after session restore
Reduce the number of file ioslaves that can be spawned per app to a reasonable
value. This was changed in rev 1eef3d0 and was forgotten to be reverted back
once the new scheduler landed in KDE 4.5.
fix ambiguous shortcuts with file browser
fix movable maximized behaviour, allow maximizing clients with limited max size
REVIEW: 102237
(cherry picked from commit 3700951ab33933c707da2e50b0561bf3ee9812c4)
fix crash with symbolsviewer if multiple main windows are used
it crashed after closing a main window and then reconfiguring it
do not remove-trailing-spaces during paste
fix awk patatern highlighting
dd: if does not need extra space before [
REVIEW: 102318
Fix kompmgr in the following ways:
1. Repair spurious crash dialog
2. Make kompmgr start if enabled when Apply is clicked in KCM
3. Fix flickering and general graphical ickiness on desktop switch
4. Fix flickering on root pixmap change
Make the destruction of expanded widgets in the completion-list safter by using deleteLater
Reduce the number of file ioslaves that can be spawned per app to a reasonable
value. This was changed in rev 1eef3d0 and was forgotten to be reverted back
once the new scheduler landed in KDE 4.5.
Disable the delete button when selected profile is undeletable.
This is to avoid the confusion users might have: "Why can't I delete
the 'Shell' profile when the UI implies I can ?". Users tend to think
konsole is broken in that situation.
Current implementation follows a stupid logic:
1). When multiple profiles are selecte, always enable the delete button.
2). When single profile is selected, disable it if user has no
permission to delete that profile.
Don't enable the search panel per default
Assure that the search panel also stays disabled when updating
from an older Dolphin version.
FIXED-IN: 4.7.1
Update the anchor item when items are added or removed
If items are added or removed in the model, not only the
current item, but also the anchor item, which is the
starting point for any selections via Shift+Click or
Shift+Key, needs to be updated.
FIXED-IN: 4.8.0
Added ::findParent method to check if a widget has a parent of a given type.
Do not drag from a menubar embedded into an Mdi Subwindow.
Office
Fix crash on File->New in words
The RDF docker causes a crash on File->New because it doesn't clean
up correctly when the canvas disappear.
REVIEW: 102240
Fix Crash when previewing .ods document
Be sure to proper convert from chart*/QByteArray to QString.
and finally fix Crash when previewing .ods document
regression was introduced with 8cf2d2874
Fix crash on opening template in words
The crash occurs due to tool options docker trying to access
widgets that's already been deleted. To avoid this I reset the
widgets in the tool options dialog when a new document is loaded.
REVIEW: 102242
Disable "Save Record Changes" action when user cancels editing
General
*Cleanups in API of the data-aware view
*Disable "Save Record Changes" action when user cancels editing or reverts edited text to the original value.
"Cancel Record Changes" action is not disabled though, so user is still able to exit from record editing mode.
fit to page after crop
Consider the adjusted dates (both start and end) of a schedule when computing the payment dates in a given period.
Disable "Save Record Changes" action when user cancels editing
General
*Cleanups in API of the data-aware view
*Disable "Save Record Changes" action when user cancels editing or reverts edited text to the original value.
"Cancel Record Changes" action is not disabled though, so user is still able to exit from record editing mode.
Add support for duotone effect, recolor feature
o fixes the color of the pictures
o wmf, emf formats are unsupported
fit to page after crop
Multimedia
juk: Style fix and filter fix
If artist was empty and you clicked on the album name
of the now playing track you did get an empty list
instead of a list of the album's songs.
Fix wrong volume in KMix Dock Widget
Too short track info dataLen returned at least on HL-DT-ST BH10LS30
Workaround the structure len like other drives but extend from 4
to 6 bytes minimum check.
This avoids a 0 byte BR-R capacity bug with this drive
Use QGraphicsScene::NoIndex instead of QGraphicsScene::BspTreeIndex (avoid Qt bug crashing amarok)
FIXED-IN: 2.4.4
Networking Tools
Make WEP key validation work.
Thanks Rajeesh K Nambiar for this patch.
REVIEW: 102157
Fix file rename leading to file being placed in the toplevel directory
Fixed two crashes and and improved the "Back" and "Forward" actions.
Automatically adds logged username to connection's permissions when
changing connection from system scope to user scope. Without this change
users would have to add the login name manually. If they forget to do
that then the connection will not change from system to user scope and
there will be no warning or error message too.
User Interface
Added checks on Screen, Display, and Visual before allocating the pixmaps needed for
shadows.
Utilities
Don't divide by zero. Fixes a crash exposed by the latest APT update.
use normal indentation per default
fix page count in printing
preselect selection if selection is around
Fix logic inversion in the keyboard input toggle action.
Plus some more session/terminal property D-Bus scaffolding - I think
for 3.0 I'll move to exposing them as objects on D-Bus rather than
the flat API approach. Flat used to be nice and simple, but that was
before they grew all these properties. OTOH, while it's more work
from my end this way, the API is mostly used by shell scripters,
and a flat API is definitely easier to use from shell script than
enumerating objects.
Account for the case when the only selected file is a directory.
So far we were only calling QFileInfo::baseName(), which returned an
empty string for directories.
FIXED-IN: 4.7.1
Features
Development Tools
Basic variable declaration handling
Graphics
CameraGUI: Implement a way to customize target album creation by date. It use QDate::toString() syntax.
Add GUI option to switch off showing the document title
Pleasing users is not so bad
Camera interface is now able to sort item taken quicly (less than 1 second) using millisecond time stamp from Exif metadata.
Start to implement fullscreen mode for thumbnail view
"Save in high resolution" upload option
When the user clicks in the AssignNameOverlay line edit, enter persistent mode
That means that the line edit is fixed on the item and is not easily hidden.
This may introduce new cases where the overlay is too persistent, these
need to be reported and fixed then.
Implement album editing
Fast one click button to Download New items from Camera interface is implemented.
Panorama Preview
Working preview for the panorama plugin.
For documents with page label, make the lower bar lineedit be the page label instead of number
We show the actual number in a separate qlabel too
Based on a patch by Daniel Oberländer
FIXED-IN: 4.8.0
digiKam Camera Interface: to speed-up downloading from camera device, a new settings
have been implemented to configure a default target album for downloading from camera.
If this option is turned off, digiKam will ask where you want to download items.
If this option is turned on, nothing will be ask to user, and download can be processed as well very quickly...
A screenshot : http://www.flickr.com/photos/digikam/6028399563/sizes/o/in/photostream/
KDE Base
add Stata xml file
removed *.log/*.LOG suffix, that is no real good idea to use
Make the service work, so it actually loads sessions now.
I'm not entirely sure about the difference between name and
pretty/niceName. I'm going to continue to assume that I should be
displaying prettyName and operating on regular name. Obviously using the
wrong one could make things not work at all.
Implement basic keyboard navigation in Icons and Compact View
Things that are still missing:
1. Moving to the previous/next row with Up/Down in Icons View,
moving to the previous/next columns in Compact View.
2. Navigation in Details View.
Note that scrolling to the current item doesn't work yet, and
that the view does not have keyboard focus initially, so one has
to click the view before keyboard navigation and seleciton works.
add new hl for gdf
sorry for the long wait :/
Allow an image to be set as the background in the terminal.
Restore the KDE3 option to have a background image in each session.
Patch by Alexandre Becoulet
FIXED-IN: 4.8
allow working with activities even when widgets are locked
now that activities are about windows, documents, etc. this makes sense
Allow logout screen to use compositing for fadeout in background if available
import jam hl from kde-files.org
license allows that, will notify author
Improvements for selections, smooth scrolling, tooltips and info-panel
push new verilog hl
too long been only in bugzilla
add new lisp indenter, feel free to mail further improvements
Works nicely. Displays the konsole profiles.
There's a working highlight in the delegate as well. A few more
improvements needed still...especially since right now I believe the
font is hard-coded. Gonna have to make it use the Plasma.Theme goodie
bag.
If the mime-type is the default one (application/octet-stream), use the
suggested file name to determine the content's mime-type.
REVIEW: 102256
add Maya MEL hl
thanks for contribution
Add a new libkdbus
Create a new library named libkdbus. It will contain utility classes for
D-Bus. In this first commit it contains only KDBusService which allows
to expose a service on the bus and implement unique applications.
REVIEW: 101902
R +0 -0 tier1/libkdbus/kdbusconnectionpool.h [from: nepomuk/core/dbusconnectionpool.h - 100% similarity]
print: add placeholders in context menu of header & footer
Now, there are several ways to know that placeholders are available:
1. use What's This on the line edits
2. use context menu > Add Separator...
That should be enough.
Introducing libinqt5 for the stuff that will be in Qt5.
(For cases where it helps reducing dependencies)
QCoreDesktopServices is "kstandarddirs-light", with only XDG paths.
Overwrite folder data instead of removing and adding.
This is required for a very simple reason: removeDataByApplication
would also remove the nie:isPartOf relations from the files which we
certainly do not want. And since folders only have a fixed set of
metadata properties overwriting does not pose any problems.
add support for SCONS files
allow drag & drop of text -> opens new document
add MSDOS BAT hl
even if not fully working, better than nothing
add new hl for RelaxNG compact
use single line comments whenever possible
Implement first "KDE5 TODO" (BIC change) - return bool in init/terminate
KDE-PIM
Allow to search by date
Use alternate row colors for the todo tree view.
Add new kmknotify which allows to configurate notify for kmail and akonadi_maildispacher otherwises users don't understand how to change it they don't want to use akonadiconsole -> maildisplacher -> config. (I can't backport it because I add new i18n)
Office
Initial implementation of edit protection
for now only table cell protection
sections will come later but code is already designed for it (see TODOs)
Initial implementation of edit protection
for now only table cell protection
sections will come later but code is already designed for it (see TODOs)
Add support for duotone effect, recolor feature
o fixes the color of the pictures
o wmf, emf formats are unsupported
feature: Properties associated by drag & drop can be copied or linked (ALT+)
M +- -- tests/input/all_plugins.skg
Visualize the edit protection to the user by drawing a forbidden sign on top of the
caret.
Improve drag & drop of pages on KoDocumentSectionView on Thumbnails mode
Draw a line in the place where the page or pages will be dropped.
Fix a bug when dropping on the middle of two pages and no index were detected.
REVIEW: 102186
Allow statement download from one bank accont into two different KMyMoney files. This supports the following use case: I have two different KMyMoney files and in both I created an account (and KMyMoney assigned different IDs each time) which I map to one HBCI online account. This is the classic "me and my spouse monitor the common household checking account" use case.
Add basic class for shadow support.
REVIEW: 102241
Recreate curve brush
o drop old algorithms for distorted curves
o create brush engine that allows effects like
curvy, recurvy and smoothe that can
be found in extended version of harmony tool
o add sensors for opacity, line width
Add a tabbar to Stage on top of views, to switch between normal, notes
and slides sorter view.
REVIEW: 102198
Re-enable artistic color selector
feature: CTRL+C enables copying of selected cells of tables
Multimedia
Elegant unute handling: Automatic unmuting on volume increase
Correct WhatsThisToolip's text of the guesser configuration
dialog to reflect the UI.
Networking Tools
Add Open With option to FileView context menu
Utilities
Improving Session Interface, it nows displays the Application information when removing pkg by file
Games
Implement Undo/Redo operations for Assets (ie.: Material, etc)
Implement a project dock specific newCreateScene() method
It fixes the situation when you try to add a new scene from the project dock,
but the new scene is actually added to the gameproject and not the folder that
you selected. The benefit is very vivid: if you create a new game project and
you would like to add a scene to the scene folder directly, it works. I think it
is a nice feature. :)
I left the objectmanager specific newCreateScene() method there since that way,
it is still possible to create scene independently from the project dock, for
instance from the menu later.
Testing: It has been tested and works as expected. I also tried out the
undo/redo operation and that also seemed to work.
Other
Add Xorg composition support to kdm
KDM composition can be enabled in the control center
When enabled, it provides seamless composited logins to Trinity sessions
It also gets rid of the remaining artifacts in the themed kdm login screen
start scanning music automatically when in Music
Optimization
Graphics
optimizing performance: avoid deep copies (use at() instead of [] whenever
possible)
In general: use const functions
See http://www.slideshare.net/qtbynokia/optimizing-performance-in-qtbased-applications for details.
KDE-PIM
Identified the cause for slowness when marking 8000 emails as read.
Multimedia
Save battery power and CPU cycles by adaptive polling (500ms normally. And 50ms during changes).
Utilities
Improve drawing performance alot
- Don't draw a complete background gradient for departure items;
draw solid color background(s) and then draw fade out gradients at the left/right
- Hide route items if the containing departure item isn't expanded
- Store a pointer to the DepartureModel in RouteStopTextGraphicsItem,
to get it's RouteStopFlags (used for drawing)
- Still TODO: Background drawing for Journeys (just like it's done here for departures)
Other
wayyy better position for file upload and new folder
Other
KDE Base
attempt to work around Qt printing bugs
NOTE: Saving & loading the margins works around QPrinter/QPrintDialog bugs:
- https://bugreports.qt.nokia.com/browse/QTBUG-15351
- https://bugs.kde.org/show_bug.cgi?id=205802
- https://bugs.kde.org/show_bug.cgi?id=180051
Changing the margins now works. However, when you reopen the print dialog
later, the WRONG margins are displayed. The correct ones are still used.
This is a critical bug in Qt.
The real issue is Qt. And it's a critical one. But since it wasn't fixed for
years, it probably will never get fixed. That's why this workaround is better
than nothing...
Remove KGlobal::locale warning for pure Qt applications
Pure Qt applications get KDE dialogs through the various KFileDialogQtOverride members, these functions instantiate a KFileDialog that inherits from KDialog so on KFileDialog construction we end up in KDialogPrivate::init that calls KDialog::setButtons that uses KStandardGuiItem::ok() that has a i18n call. Since there is no valid main component at this stage yet once we get to the fileModule() call and it creates a proper main component we will get the KGlobal::locale warning.
By invoking fileModule() before creating the KFileDialog we avoid this issue.
Acked by dfaure
REVIEW: 102188
(cherry picked from commit 6f710688154d4c9914a62f5265de09bc85e08eac)
Office
A rewrite for the scratchpad
1) Now it shares all the code with the freehand tool completely. No
duplication.
2) Threading for stroke is possible even here.
3) Airbrushing works.
4) The scratchpad has the same zoom-level as the image
The bug can be closed when the branch is merged to master
Rename karbon to artwork.