Issue 236

Fix begin-lookup for auto-type deduction in range-based for loops.

First up, ensure we pick the proper list type by introducing a
virtual ContextBuilder::handleRangeBasedFor that is then overwritten
in the DeclarationBuilder. This way we can ensure that lastType()
actually returns the type we want.

Then, when we don't find a viable begin function in the current
namespace via ADL, fallback to ::std::begin (in accordance to the
spec) and repeat.

Fix the "no completion triggers if previous lines contained a misquoted string literal in a comment" issue

Proper fix for the "the python parser has no information about where a node ends" problem.

This adds a visitor which recursively fixes the missing ranges.
Hopefully also fixes

(my tests work)

Fix generator variables from not being handled correctly

This was a "regression" caused by a kdevplatform change (bfb0b798)
Static names must not be used for context identifiers, that will
cause confusion (all the generator contexts were named "<generator>").

Retrieve new directions after changing the transport type.

Fix bounds calculation

Rearrange progress item operations from FileActionMgr to perform safe operations.

The call to ProgressItem::advance should now return true once and only once
with last item, so an (still unsafe) pointer check should not be needed.

Fallback behavior for documents whose generator provides native annotation editing support without saveAs support

The only affected generator is poppler. Note that:
Document has /Encrypt <=iff=> SaveInterface supportsOption(SaveChanges) is false

This patch enforces the following behavior (and warns the user the first time
he edits an annotation).

- If the document has /Encrypt, warn that "Save as" is not available, but it's
possible to export as okular archive. New annotations will be automatically
saved to XML as usual.
Note that the previous patch already made all existing annotations uneditable,
because there's no way to save them.

- If the document has no /Encrypt and there are existing external annotations,
warn that changes won't be saved automatically. The user needs to "Save as" or
changes will be lost.

- If the document has no /Encrypt and there aren't existing external
annotations, don't show any warning. New annotations will be automatically saved
to XML as usual and to file if "Save as" is pressed.

Finish fixing compilation with Qt4.

Ported KUrlRequester away from KHBox, which was polluting its API.

When saving profile, always use its untranslated name as filename

An internal property is introduced to record the untranslated name.
When saving profile into disk, always refer to that untranslated name
to get the filename.

This extra consideration is intended to deal with the situation when the
profile's contents are i18nized. The typical example is the "Shell" profile
shipped by default.


FIXED-IN: 4.9.0

A number of adaptations for Qt5's QUrl.

Some of these are actual bugfixes compared to Qt4's QUrl,
others are just "equivalent, both results are correct" (less escaping in Qt5).
A number of issues remain, though, in particular path() being encoded,
in discussion with Thiago.

Escape HTML tags in window caption in Aurorae and Killer

The unescaped tags are interpreted as HTML by Aurorae decorations
and the KWin killer. Escaping the tags ensures that the text is not
rendered incorrectly.


FIXED-IN: 4.9.0
REVIEW: 104989

Make loadMore() work

- remember oldest and newest id for timelines
- wire up loadMore() operation
- add a few d-pointers
- do not removeAllData(), this will need to be fixed for switching
timelines, based on heuristics of serviceUrl user and type.

Make geolocation engine use hostip.info

HostIP is a Free, community-based service offering a REST API.

This fixes the geolocation engine not working, after iplocationtools
became unsuitable for our usecase (and broken the engine).

- Fixed SSL negotiation failure when connecting secure sites that do not support
SSL compression, e.g. https://tim.rz.rwth-aachen.de/mail-lifecycle/.

- Use KTcpSocket::SecureProtocols instead of KTcpSocket:TlsV1 as the default SSL
protocol. This fixes very slow connections to certain sites, e.g. "Search for Jobs"
button @ http://www.suse.com/company/careers/.

- Improve the speed of SSL negotiation by caching and sharing the previous
settings amongst ioslaves when those settings are not the default ones.
That way any ioslave that connects to the same host afterwards does not
have to perform the same expensive SSL negotiation process all over again.


FIXED-IN: 4.8.4
REVIEW: 103610

Do not use doxygen's deprecated installdox anymore.

Instead we use TAGFILES the correct way. This fixes docs generation
with doxygen 1.8.0 and links to Qt docs.

Show video previews according to file content instead of the mimetype-string

Show a video widget depending on the video content instead of the mimetype
string: There are container formats which can be either audios or videos.
Besides, the rmvb video files have a mimetype of
"application/vnd.rn-realmedia", and these files can be recognized as videos
correctly now.

The patch has been provided by Hui Ni.

REVIEW: 104988
FIXED-IN: 4.9

Make the bell code really work.

_bellMasked is mistakenly set as true initially, which make it stay as
true forever. So bell never happens .

This is a follow up of commit 67e0e16e8f5b953203adb33818110ef50f439f21

Fix several bookmark synchronization issues

Remove trailing whitspace on saving.

Iterate through text buffer whenever the save function is called and
remove all trailing spaces.

Thanks to Davorin Učakar for this patch!

Fix Bug 300013 - "Delete Folder" request is ignored

FIXED-IN: 4.8.4

Fix hanging test

Fix Bug 298985 - Log size limit "unlimited" is too small

FIXED-IN: 4.8.4

(cherry picked from commit 801013e0867d7bf3f27ddac8203b4b4eb7232486)

Conflicts:

mailfilteragent/filterlogdialog.cpp

Fix infinite loop occuring on saving the ODF 1.2 spec document.

Do not try saving the headings and numbered paragraphs in this section. This section is for nested lists and lists at same
levels.

Fix Bug 286564 - plan do not update the resources allocation number when selected

Add tooltips/whatsthis and show more info to make the dialog more userfriendly
Fix bug in dynamic allocation

Wrap the metadata in a lock just in case different gst plugins update metadata at the same time in different threads.


FIXED-IN:4.6.1

Fix / improve detection of locale conflicts:

pulse: More fixes relating to volume restoration via kmixctrl.

When we fail to read the values from a config file, do not attempt to then write them
to the sinks and sources anyway.

Fix metadata emission for http urls.

REVIEWBOARD:101595

FIXED-IN:4.6.1

DB: change lyrics table: text url -> integer url pointing to the urls table

I believe that the old lyrics table structure was more or less a mistake:
TABLE lyrics (
id INTEGER PRIMARY KEY, -- actually never used in code
url VARBINARY(324), -- actually a rpath from urls table
lyrics TEXT
)

Apart from data duplication and non-conformity to the "update anomaly"
requirement of the database design, there was additional problem that rpath
itself is not unique. The (deviceId, rpath) is.

This change makes the lyrics table look more sane:
TABLE lyrics (
url INTEGER PRIMARY KEY, -- points to url.id column
lyrics TEXT
)

with an effort to transition existing entries. The transition of 5000
lyrics entries takes 16s on my 2.5 GHz Core i5 (one core used), so it
should be acceptable.

This is the first time I'm changing db structure, I'd be glad to
receive thorough review, namely of the update13to14() method and
especially the duplicate-removing query. This is critical because
database-corrupting fault would leave many Amarok users in a state
where they would need to drop their database to make Amarok working
again.

ChangeLog of the unrelated iPod fix is updated because DB_VERSION bump
triggers full collection rescan as far as it is documented.


FIXED-IN: 2.6
REVIEW: 104966

Fix bug in which passwords would only be used if save password was checked

Reviewed-by: Martin Klapetek

Fix sending notifications when a delivery report is recieved.

Fix a crash that happens when trying to log in when no top-level QWidget (window) has focus.

demo mode: fix duplicate code execution

AI was asked twice which tile to discard. This only matters since recently
because since then the random generator is used when two tiles have the same
uselessness. But we want the random generator to be called exactly with the
same order/frequency for all modes (nogui, gui, autoplay) so we can
easier reproduce bugs.

TileAI: fix/optimization for border tiles

this unintentionally fixes a bug: tiles like 2 or 8 were sometimes kept
even if there was no chance to ever form a meld with them
(reproducable with game 1185, BMJA, no boni)

Android Bluetooth partial support. Socket client and Device discovery.

Socket in client mode and device discovery is implemented.
Server socket is feasible and can be added later.
Some of the Qt Bluetooth API's cannot be ported because
Android Bluetooth API is a subset.
Other parts (Service discovery, L2CAP, Channel number, etc) are not
available on Android.

Kudos goes to Lauri Laanmets

Add KDE pairs.

Make common tasks easier/possible in the user interface.

Adds buttons to open a route (from .kml), clear the current one,
reverse it, add a via point and save it.
GUI:
REVIEW: 102539



FIXED-IN: KDE-4.9.0

A +- -- src/icons/16x16/configure.png
A +- -- src/icons/16x16/document-open.png
A +- -- src/icons/16x16/document-save.png

Added folderview option to show files related to the current activity

Enable basic drag and drop support for the Places Panel

The dropping has not been implemented yet, however in the context of
this step the creating of the drag-pixmap is now forwarded to
the item-widgets. This allows creating some optimized dragging-pixmaps
e.g. for the details-view, where only the name and icon should
be provided as drag-pixmap.

Support dragging tab out of current window and into its own window

Thanks to makis marimpis for the patch!

REVIEW: 104933

FIXED-IN: 4.9.0

Implement bookmark synchronization

Whenever the bookmarks are changed by another application, the
state must be synchronized within the model.

kshareddatacache: Add "corrupt cache" exception.

The new exception is not actually thrown yet, but this commit provides
support for handling such an exception, using the following guideline:

* Any exceptions used never cross the API. i.e. client code can be
assured that the underlying library code will not throw any exceptions
when called through the public API. It is simply an implementation
aid.
* If Private::CacheLocker succeeds, it means both d and d->shm are
valid.
* The d-pointer is not necessarily set now, as constructing Private and
mapping shared memory will involve sanity checking the cache as it is
loaded. This affects code using the d-pointer or d->shm without the
CacheLocker.
* Private::CacheLocker itself must still be usable if the d-pointer is
not set, in addition to its existing ability to handle d->shm not
being set.

For just evaluating code changes it might be easiest to use "git diff
-b", which ignores whitespace (there are significant whitespace changes
from adding try{}/catch{} blocks).

Implement the curve options for scale and strength for texturing

The effect isn't quite right, though, I guess some of the maths is
off a bit.

Add setter for mask selection to the indirect painting support

This will be used for texturing the whole stroke.

Install mypaint brushes to mypaintbrushes

This separates the mypaint brush preview png images from the krita
brushes.

loading of the assistant - just started

Load and save the contour-polygon and contour-path elements.
They are stored as KoClipPath in the engine. Previously the engine only
had support for loading and saving KoClipPath in svg

Load and save the style frame style attributes that turn contoured text run around
(wrapping) on and off. wrap-contour and wrap-contour-mode

Use this new technology to do tight run around (simple change only requesting what we already had)

This commit also adds a method to pictureshape to create a tightfitting outline path of the image.
It's tested and works, but is not used yet to create a KoClipPath out of it.

REVIEW: 104873

Add fullscreen mode for Kexi main window

Kexi fullscreen is implemented for Mainwindow, serving better
manipulation in small factor screens (eg netbooks). Feature is
accessible both using shortcuts and at launch from console.


REVIEW:105105
DIGEST:Kexi offers fullscreen mode

Offer move operation only if Shift is pressed.

Reasons:
- Limit number of context menu actions to keep it usuable.
- Copy is probably used 9 times out of 10.
- Move is destructive operation.

If discoverability is an issue we can add "(+Shift to move)" tooltip to the QAction.

GUI: Needs to be mentioned in the manual.

Change colorizer name again to stop confusing Perl.

Perl seems to assume that a lowercase function name that is not *known*
to be a function defined in the current package might be a filehandle or
some kind of other future reserved word.

e.g. with "print foo ($message)"

Perl thinks you're trying to send $message to the filehandle foo if foo
wasn't defined in the current package (even if it's imported from
another module).

To fix this we make the function start with a capital letter (to fix the
potential reserved word warning from the last commit changing colorizer
name), and always reference the full package when using the subroutine
from outside of ksb::Debug.

core: DataAccess refactoring

Now the methods of DataAccess operate on entity classes instead of
creating new ones. Object creation is handled in QML now. This fixes
also various memory leaks, for instance, if the keyboard layout did
change, the old Course objects didn't get deleted. This now handled
automatically by the garbage collection of QML.

In an equation, first simplify all the parts

Helps solve more equations.

Changes: Allows to replace linestrings in PNT files with polylines in SVG
files.

-Don't crash when including a shared axis box in a shared axis box.
-Abort the command when including a sharedd axis box in a shared axis box.

make the crosshair cursor more visible by using a black crosshair with white outline.

Make it more compatible with the Gnome version

poppler gen: don't lie ;) We can't save changes if the document has /Encrypt

Added support for copying the link text without having to select it first.


FIXED-IN: future release

Increase version number in runtime services, to avoid mixups.

Executable names:
kdeinit4 -> kdeinit5
kded4 -> kded

DBus service names:
org.kde.kded -> org.kde.kded5
org.kde.klauncher -> org.kde.klauncher5

This fixes jobtest with Qt5 (difference in QDateTime serialization), but
more generally it will allow BIC changes in SlaveBase, as well as
not crashing due to kdeinit4 or kded4 loading KF5/Qt5 modules, etc.

Rewrite KProtocolInfo to extract it from ksycoca.

Ported KProtocolInfoTest to qtestlib.

Places Panel: Prepare code to save state of bookmarks

The saving is still disabled currently until 100 % backward
compatibility with KFilePlacesView has been reached.

Use the Block interface even if its not existing on windows

Instead StorageAccess.filePath shoul be used but existing applications
like Amarok Expect a Block devicey

PlacesItemModel: Automatically save bookmarks

Prevent that a manual call to save changed bookmarks is
necessary.

Continue to implement backup/restore

Make KMail2.desktop preferred above kmailservice.desktop, for mailto urls.

Faster, and this also makes things more reliable for the KProtocolInfo unittest.

make it clear that our use of a graphics style to store more fill options than odf supports is not actually odf by using a calligra-namespaced attribute to store the style name reference

Clarify text for dropshadow plugin

Add configuration dialog for Words
-autosave
-create backupfiles
-units
-grid

Will probably refactor some of this ui but that happens in calligra libs, so not for now

Also a bit of code cleanup in KoView

Set the right filtering modes for rendered textures when using OpenGL.

Now use nearest for near filtering and trilinear filtering for fa
filtering. This prevents aliassing issues at low zoom levels and still
gives the right behaviour at high zoom levels.

Don't fill layers that cannot be edited



I'm sure there are more issues like this...

png filter: let the user choose a color to fill transparent parts with

By default it's white.

Follow the coding standards

This is the start of an effort to make all of the test code of the
chart shape follow the Calligra coding standards. A similar effort
for the main code was finished before the start of the GSoC period.

Use the ZoomController instead of the zoom handler for resetting zoom.

The zoom actions and combobox are all based on the controller, hence
bypassing the controller to set the zoom makes those actions behave in
strange ways.

Clarify the meaning of "use the same curve" checkbox

11:07:19 < deevad> Hey, I polishing my brush presets, and I figure I never really understand what stand for 'use curve' or 'use same curve' ( 'use curve = ok it's obvious' ) but ...'use same curves' ... same as what ? thanks for
answer :)
11:09:24 < boud> deevad: iirc, plassy added those options
11:09:50 < boud> I need to check the commit log to see what they are supposed to do :-)
11:10:11 < boud> use the same curve, I think means, use this curve for both opacity and flow
11:10:40 < boud> oh, wait - no
11:11:14 < boud> it means do you want to use one curve for all dynamics sensors, or different curves for different sensors
11:11:32 < deevad> oohohhhh ; now it makes sens
11:11:52 < deevad> thanks boud. Cool, more complex possiblities :)
11:12:09 * deevad back tweaking for the perfect brush
11:12:39 < boud> i'll add a tooltip
11:13:08 < deevad> good idea if it's not a big job to do :)

don't save 0 width or height shapes as "nanpt". Somehow the xls filter sometimes (incorrectly) generates empty path shapes with zero size, and while that is of course meaningless it shouldn't result in invalid odf.

Lyrics applet scrolls more intelligently

Aim to keep the current position in the lyrics centred, rather than
directly moving the scroll bar based on the position in the song.
Patch by Alexander Potashev.


FIXED-IN:2.6
REVIEW:104935

New Bookmarks page

Load the words according to the system language initially

The words are loaded in English, if there is nothing set yet. This is suboptimal
for a non-English speaker since the user needs to change the language manually
at least once, even if the information can be get from the system language. If
the words are not translated (kvtml files) in the system language, English is
used as a fallback.

Use SharedKvtmlFiles::languages() for getting the language codes

set FPS from 40 to 60 -> much smoother movements

Import project archive files.