Issue 268

Fixing deadlock

When aborting the compilation from within the context adapter, the model
compilation lock could potentially deadlock

send command as utf8, as the communication charset is utf8

fixes non-ascii file paths.

run-tests: Give full path to test results log.

Turns out the Module class already has a getter for the log directory.


FIXED-IN:1.16

Fix filtered output item classification when multiple keywords are in the same line.

Currently, "warning" and "info"/"note" keywords, if found, override any
error keywords matched so far.

Fix this by scanning for all keywords in a consistent manner
(ERROR_INDICATORS => INDICATORS), and using the _first_ indicator in
line to classify the line.
This is somewhat empirical, but well: message type is usually put before
the message itself.

REVIEW: 107904

Close the outline menu in case the parent moves

Also works in case the outline toolbar is detached.


REVIEW: 107882

Several EBN Krazy fixes

Fixing various issues found by the EnglishBreakfastNetwork's
code checker Krazy.

Submitted by Mohammed Nafees, completing
a Google Code-in task.


REVIEW: 107980
DIGEST: Google Code-in contribution

fix appearance of application with light-on-dark themes

In the most cases relying on theme colors instead of
fixed colors was enough, and in a few more cases for
elements with fixed background the opposite was right way
to achieve a good-looking result.

Most tricky proved to be the application background. I didn't
want to give up the Oxygen-provided background to ensure visual
consistency with the window decoration. Therefore I use Plasma's
background color but set the alpha accoardingly to the difference
between the two, if the colors are pretty similar the alpha is
zero.


FIXED-IN: 4.10 RC 2

Fix for bug 304451 - Gwenview error while watching photos:
Don't show next frame when there are none.


REVIEW: 107932
FIXED-IN: 2.9.5

Moved all private items from ActionThread to Task and hence stopped sharing ActionThread::Private with Task.
Separated ActionThread and Task for better visibility

Fix for bug 256841 - Crashes when trying to open certain jpg images


REVIEW: 107891
FIXED-IN: 2.9.5

Fix for bug 307007 - Gwenview hangs and/or freezes my Xorg when
"Show videos" is enabled


REVIEW: 107962
FIXED-IN: 4.10.0

fix regression of bash version 2.15

Thanks to Luiz Angelo De Luca for the fix!
Does this also fix 312121 and 312274 ?



FIXED-IN: 4.10

NepomukIndexer: Save the plain text content separately

The plain text content is often quite large, and it doesn't make sense
transporting it over dbus. Also, virtuoso crashes if the plain text is
too large.

Experimentation shows that it crashes for values over 3 * 1024 * 1024.
We trim the plain text to this length as to avoid crashes.

Implement Shift+click to extend selection

Add ability to press Shift+Click to extend the mouse selection. In
KDE3 there was the menu option to 'Set Selection End' which this mimics.

REVIEW: 107566
FIXED-IN: 4.11

fix regression of bash version 2.15

Thanks to Luiz Angelo De Luca for the fix!
Does this also fix 312121 and 312274 ?



FIXED-IN: 4.10

use synthetic configure notifies when needed

the patch omit them while the user just moves around a window
and adds one that got lost with the deferred XMoveResize patch, causing


FIXED-IN: 4.10
REVIEW: 108013

Added Generator::displaySwitch(int iteration)

Laptop usually have a button used to switch between configurations for
example: extend, clone, etc...

In our case, this is the sequence of configurations we generate:

Clone
Extend to left
Turn off embedded (laptop)
Turn off external and turn on embedded
Extend to right

Extend to the right is the last option since we are defaulting to it when
a new output gets connected. Then we offer clone because of projectors.

FileIndexer: Do not run the IndexCleaner and IndexingQueues in parallel

The IndexCleaner and IndexingQueues now no longer run in parallel, the
queues only run once the cleaner has finished. This is important cause
we now have a two stage indexing, so the fileIQ could continue to index
files whose contents will soon be cleared, or once they are cleared, or
worse while a file is being cleared (We do not have transaction support,
so this could end very badly)

This also solves the bug where the indexer wouldn't immediately abandon
indexing of a particular directory when the config file changed.

fix tooltip shadow problem.

avoid confusations between the deleted window size and the "dirty" area.


REVIEW: 107905

Remove the workaround for bug 275033 now that khtml has been fixed
(This revert kdelibs commit 86e07ecd)

NULL Compositor global static on deletion

what moc can do any time for the Workspace deconstructor

FIXED-IN: 4.10
REVIEW: 108007

Fix title extraction for the popplerextraction

Extend popplerextractor with firstpage parsing

Often the pdf metadata is not available or wrong data is added
to the title field (pdf exporter names instead of title).

This patch adds the possibility to parse the first page for a possible
title. A possibel title is determined by the connected text with the
biggest font that was more than one character.

REVIEW: 107870

skip reset states if client untabbed for release


FIXED-IN: 4.10
REVIEW: 108003

Utils::formatPropertyValue: Add the resource query term when constructing the query

Add a &resource="nepomuk:/res/some-uuid" in the query url. This allows us
to use the resource uri to show custom metadata in the kioslave and do
other cool things like show a custom image.

REVIEW: 102283

finish / sync screenshot before calling ksnapshot


FIXED-IN: 4.10
REVIEW: 107981

fix crash: delete the Dialog and its child ListView in the applet dtor

The ListView object ownership is transferred to Dialog upon creation, so
not deleting the Dialog object in the applet dtor results in a leaked
ListView. However, when the leaked ListView receives a repaint signal on
plasma theme change, the model pointer in that view is already invalid,
which leads to the crash in m_model->rowCount().


FIXED-IN:4.9.5

disconnect all client signals when it's closed

the client can still live on and emit stuff, but the
compositing has been fininshed for it, so the effect window is NULL


FIXED-IN: 4.10
REVIEW: 108008

Fix Bug 223616 - Add option to disable formatting in plain-text messages

FIXED-IN: 4.10


Don't add new options. Just don't remove markup as in thunderbird.
so we can copy/paste with loosing infos, and we are sure that
we show exact string.

Fix use of deprecated CalendarSupport API

Use the non-deprecated variant of CalendarSupport::displayName
instead

Fix Bug 308706 - kmail reset selection of massages when extract a

grouping

FIXED-IN: 4.10

Set collection rights when importing from OPML

monthview: Fix items jumping around each time the view is refreshed.

sorting was being done with pointer comparison, that's useless
since it's random. Sometimes holidays were displayed before events
other times they were displayed after.

Now holidays are always displayed before incidences.

Fix Bug 311994 - IMAP quota isn't displayed in some cases

FIXED-IN: 4.10

Fix Bug 311994 - IMAP quota isn't displayed in some cases

FIXED-IN: 4.10

Several API docs fixes

Fixing various API docs issues found by the EnglishBreakfastNetwork's
code checker Krazy.

Submitted by Kyle Morris, completing
a Google Code-in task.


REVIEW: 107991
DIGEST: Google Code-in contribution

don't crash if the navigatorToolBar can't be found in the kontactui.rc
(probably because kontactui.rc can't be located.)
instead, print a kError() and just continue without a toolbar.


FIXED-IN: 4.9.5
MERGE: 4.10, master

Load passwords async on startup, rather than sync

(which was giving 4 nested event loops, with 4 transports, on kmail startup)
This fixes the password dialog appearing when sending the first email.


FIXED-IN: 4.10

Fix clicking in a selection does not update the caret.

Initialize m_drag in the TextTool solves the problem somehow.

REVIEW: 107849

Main Window: View switching uses modern group button

REVIEW:107856

Fill is now working.

Fix clips sometimes dropped outside of tracks: http://www.kdenlive.org/mantis/view.php?id=2905

The correct edit() was not called, lacked polymorphism.

KNotificationBackend: rework to make notifications instant and more reliable

BUGFIXES:
* Make track announcements via KDE Notifications instant.


FIXED-IN: 2.7

Fix View menu not updated when closing a dock: http://kdenlive.org/mantis/view.php?id=2907

Re-enable audio dubbing: http://kdenlive.org/mantis/view.php?id=2910

Fix Last played bias is ignored or doesn't work

The query maker results are now valid only for three minutes.
That means that not only a collection changed signal will trigger
the querymaker.


FIXED-IN: 2.7

Fix KMix crash after closing Clementine

amarok dynamic play list with biases EchoNest similar artist gives no results

Fix several issues:
- not telling echonest that we want xml instead of json
- fixing handling of invalid responses
- updating decoding of results
- get rid of unneeded artist id queries
- add required echonest web address


FIXED-IN: 2.7

Fix SqlTrack::updatePlaylistToDb(): we need to update url too

This fixes all the remaining problems originally reported in bug 308371.
I've confirmed it works both then the track uid change is triggered from
within Amarok and from external tool when Amarok is not running.

BUGFIXES:
* Fix updating of Amarok database playlists then track uid changes.



FIXED-IN: 2.7

Fix dynamic playlist by Last.fm similar songs creation takes a lot time

Fix buffering of similar artists.
Fix faulty reply handling


FIXED-IN: 2.7

Configure how many lines of history to load

Add option to text-ui configuration to set how many lines
of previous conversation should be loaded.

REVIEW: 107968

FIXED-IN: 0.6.0

Add action to clear current chat tab

REVIEW: 107967

FIXED-IN: 0.6.0

Add FeatureAvatar to Account factory

Logviewer now correctly displays account avatars for all
accounts.


FIXED-IN: 0.5.3

Fix crash, data source connections, cache cleanup

Always publish data for "ServiceProvider <id>" sources, also if no
provider with the given <id> can be found. Never delete service provider
or timetable data sources, expect when they are no longer connected with
any visualization. This way connections to the engine stay alive when
(un)installing or updating providers.

Detect uninstalled providers, no matter if the engine was running or not
while the provider was uninstalled. Cleanup the cache from data for
uninstalled providers.

Publish timetable data sources under all using data source names.
Cache all additional timetable data and remove it after a timeout
when it is no longer used. Do not mark the whole timetable data source
as erroneous when a request for additional data has failed.

Fix random crashes by using a shared pointer for the QScriptProgram
used by script providers. If an instance of QScriptProgram gets
destroyed while a copy of it is used by another QScriptEngine in another
thread it crashes. There were many crashes when the applet was
configured to directly request additional timetable data for all items.

Do not lock ScriptJob while it executes an event loop,
eg. in ScriptJob::requestAbort().

Improve layout, snap scrolling to timetable items

Snap scrolling at the top of departure/arrival/journey items.
Make the height of the expand areas of items multiples of their
unexpanded height to not confuse the scroll snap.
Remove margins in the PublicTransportWidget layout.
Clip items to the shape of the scroll widgets content.
Also clip some more pixels at top/bottom for overflow borders.

Use KMessageWidget for asking the Mark All question

This way we get rid of the annoying messagebox when the muon-updater
is opened.
Also slightly improve the text asking for marking them all.

REVIEW: 107943

Fix journey search widget not being removed

The journey search suggestion widget was not removed
when the journey search was aborted.

IMAP: don't assert crash on unexpected SEARCH responses

Thanks to Jacopo De Simoi (wilder on IRC) for a bugreport and the error log.

Reworking and restructuring active- and base model information

Both the base model configuration and the modelmanager themselves
announce model changes complete with all relevant information.
This streamlines the process of updating the model information on the
welcome page and improves performance by not having to unpack the
model(s) twice.

kde-projects: Expand dependency-data support.

We now read in and should be able to handle branch-specific dependencies
and module dependency exclusions.

For full support we still need to find a way to properly handle Qt vs.
Qt5 modules (e.g. for phonon Five and automoc).

Added migration for users from old format

Add fast access hash to access data elements by identifier.

The hash has low memory consumption (linear in number of nodes) and
only stores identifier and shared pointer (~8 bytes), but increases
identifier access from O(n) to amortized O(1).

It's allowed to print the contents of the Webkit View in WebPopup

REVIEW: 107993

Add type selection to generate graph widget.

Allow to select data and pointer types for newly created graphs at
the graph generator UI.

Thanks to andromeda-galaxy who created this as part of his GCI task.

More constellations and deep sky objects.

REVIEW: 107893

"Show File View" action have been added into menu of KDE version of Marble

REVIEW: 107982

update RawSpeed to svn rev.504
update libraw to last 0.15-beta3. New camera supported:
Canon : G15, S110, SX50, 6D and EOS M
Casio : EX-ZR100
Fujifilm : F800EXR, XF1, X-E1
Leica : D-LUX6 and V-LUX4
Nikon : 1 J2, 1 V2, D600, P7700
Olympus : E-PL5, E-PM2, XZ-2
Panasonic: FZ200, GH3, LX7, G5
Pentax : K-5 II, K-5 IIs, K-30, Q10
Samsung : EX2F
Sony : SLT-A99, NEX-5R, NEX-6, RX-1

Add queue and job classes for the webminer

This commit adds the queue and job classes to the indexscheduler.
Whenever a file file is indexed and as soon as the fileinder did its
job (kext:indexinglevel == 2) the webimer in called on the resource.

Everytime the webminer was called on a resource the indexinglevel 3 will
be set and the resource will not be requested again.

This initial commit needs the latest nepomuk-webminer from extragear to
be installed, as this executable will be called in the webminerjob via
QProcess.

The idea behind this approach is to replace the current Nepomuk2:Service
with the structure used by the indexer /suspend/resume on low battery
and such) idially the webminer should only be called on supported
mimetypes instead of every resource on the system.

Automatically set url location bar to non-editable when focus out


REVIEW: 107748

Stop generating org.freedesktop.UPower use QDBusConnection instead

We were only connecting to one signal (and only generating it) so it was
kind of a waste generating a cpp just for it.

Extended Border support in Aurorae

Aurorae Themes can make use of the extended borders feature to allow
resizing outside the window decoration area. So far only Plastik makes
use of it in the Tiny border case.

This should be extended in future by adding generic NoSideBorders and
NoBorders sizes as used by Oxygen.


FIXED-IN: 4.11
REVIEW: 107936

Port to Plasma::Package for themes.

Update metadata.desktop files to follow normal metadata.desktop spec
Use Plasma::PackageMetaData instead of manual config parsing for metadata

Create a PlasmaPackageStructure plugin for plasmapkg to work.
In theory this allows a user to install packages.

Create a kcm group for the nepomuk desktop search

In order to be able to add the nepomuk webminer configuration
to the nepomuk 'Desktop Search' category in the kcm. This category must
be created first.

This patch adds a new systemsettings category with the name
'Desktop Search' and adds the Nepomuk configuration with the name
'Nepomuk Server'.

REVIEW: 107884

Add a Okular extractor plugin that uses Okular API to index files

Indexer: Extract better contacts from a string

"and" "&" are not good terms to use for fetching contacts from a string
since a lot of popular bands have "and" in their name eg - "Tegan and
Sara".

Also, using "feat." to split.

add summary back to last notification, with fixing some layout bug


REVIEW: 107743

Support for Application Menu in Aurorae

Aurorae supports in general the Aurorae button. So far themes are not
able to style the button, instead the window's icon is used.

Add queue and job classes for the webminer

This commit adds the queue and job classes to the indexscheduler.
Whenever a file file is indexed and as soon as the fileinder did its
job (kext:indexinglevel == 2) the webimer in called on the resource.

Everytime the webminer was called on a resource the indexinglevel 3 will
be set and the resource will not be requested again.

This initial commit needs the latest nepomuk-webminer from extragear to
be installed, as this executable will be called in the webminerjob via
QProcess.

The idea behind this approach is to replace the current Nepomuk2:Service
with the structure used by the indexer /suspend/resume on low battery
and such) idially the webminer should only be called on supported
mimetypes instead of every resource on the system.

Extend popplerextractor with firstpage parsing

Often the pdf metadata is not available or wrong data is added
to the title field (pdf exporter names instead of title).

This patch adds the possibility to parse the first page for a possible
title. A possibel title is determined by the connected text with the
biggest font that was more than one character.

collect shadows of existing clients when toggling the compositor

REVIEW: 107965

Nepomuk KCM: Add a button to check for new files and changes

Add a new button in the Nepomuk KCM's Advanced Settings tab. When
clicked, the button forces the indexer to check for new files in the
folders marked for indexing. This adds a greater sense of control to the
user. A new QGroupBox was added as well, with the title "Actions". In
the future, there will be more commands like this available there.


REVIEW: 107553
GUI: New button and button group in the Nepomuk KCM

Add option to disable ctrl+<mouse-wheel> zooming

The built-in behavior of Ctrl+<Mouse Wheel> to zoom in/out the terminal
can not be disabled. This patch adds an option to disable this
behavior. (Default to the original behavior).

Original patch by Yichao Yu
I made some changes - bugs are mine as usual
REVIEW: 107281
FIXED-IN: 4.11
GUI:

Enable parallel installation of pykdeuic4.

Currently pykdeuic4 is installed to BINDIR indepdendently from the
Python version used for building, potentially overwriting an existing
install with a different version (think Python 2 and Python 3) and
preventing multiple installs.

This patch introduces the following changes:

- Generate a symlink from pykdeuic4.py (hosted in the site-packages dir)
to BINDIR/pykdeuic4-VERSION_MAJOR.VERSION_MINOR, where VERSION_MAJOR
and VERSION_MINOR are the Python major and minor version,
respectively
- If the PYKDEUIC4_ALTINSTALL parameter is FALSE (the default) this
symlink is further symlinked to BINDIR/pykdeuic4
- If PYKDEUIC4_ALTINSTALL is TRUE, the second symlink is not generated

Fundamentally, this is analogous to Python's own "make altinstall"

This change also allows distributions to enable parallel installs and
potentially handle the final symlink on their own (e.g. with Debian's
update-alternatives).

As PYKDEUIC4_ALTINSTALL is by default FALSE, the current behavior (prior
to this change) is preserved.

IndexedDataRetriever: Try to retrieve a string from the blank nodes

This works quite well, and allows us to show the name/title even when
Nepomuk is not running.

Add support for disabling collection filtering.

If you disable it, you won't be able to filter through the
kSelectionProxyModel, all items from all collections will
be displayed.

This is useful for the plasma-calendar, which doesn't have UI
yet to select collections.

Force editability of playlist folders.

it's now possible to assign workflow to a queue through drag and drop between control panel and queue pool

Allow recording audio even if no video capture device is detected

Dont goto the next music if user pressed Stop

Cycle through tabs with next/prev tabs


FIXED-IN: 0.5.3
Reviewed-by: Martin Klapetek

Add setting to size RDP view fitting into current KRDC size.

Work is based on a patch by deadeyes.

Port KRDC RDP plugin to Freerdp (xfreerdp).

- freerdp is a fork of rdesktop which fixes many bugs and adds support for newer OS (e.g. Windows 2008 R2)
- requires Freerdp 1.0.2 (RC2 is out already; final will be out for sure at KDE SC 4.11 release) because of a bug in 1.0.1 (window embedding)

Work is based on a patch by AceLan Kao.

cmake: improve okular search to require viewerinterface.h

when okular has been found, try to look for the viewerinterface.h header;
if not found, consider okular as not found altogether

improve the log feature message accordingly

new Batch Queue Manager to crop image.

Improved panning of zoomed images:
- Panning in images is faster now
- When panning, the mouse pointer becomes invisible. After panning
it reappears at the position where panning started.
- Don't switch to panning mode when whole image is visible. Instead
the image could be dragged and dropped somewhere (not implemented
yet).

See review request for remaining issues.

REVIEW: 107985

* Refactored code a bit, extract more fields such as title, copyright, etc

* Use QScopedPointer for pointers that are discared instead of manually deleting them

* Documentation++

* Remove more mimetypes that are indexed by other plugins

monthview: Use nice undo/redo descriptions, instead of generic ones.

Improved the new group button's look and feel

This closes the 107530 review too.

REVIEW:107530

Implement handling of mathematical formulas in the EPUB filter.

This version handles formulas formulas saved as embedded
documents. This is the way that formulas are saved by OOo, LO and
AOO. The next version will also implement support for formulas that
are inline XML which is the way that Calligra saves them.

Change incremental save shortcut to ctrl-alt-s

Because it conflicts with the standard F2 shortcut for renaming layers.

Use the document name for the filename when creating a named document

better integration of pencil tool into Krita, moves pencil tool to basicflakes
REVIEW:107996

Compile libs with dbus disabled.

This applies the same logic that is already present
in libs/main/KoPart.cpp for the KoPartAdaptor also
to the ApplicationAdaptor and the ViewAdaptor.

Long story behind this patch.
1) Mek did spend time on that particular problem when
porting to Android.
2) Then I spend time on that bringing it back to
master. See https://git.reviewboard.kde.org/r/104021/
3) Then boud made a similar patch at
http://permalink.gmane.org/gmane.comp.kde.cvs/1154693
4) I had to spend time again on that already solved
problem during my Sheets@Android port.
5) I ported my latest patch again(!) to master. Note
that I did not start with a cherry-pick one of the
patches of <= 3) cause my patch from 4) was already
newer (against master).
6) Now it finally lands into master. No more time waste
caused by *this* particular problem. Hallelujah! :)

Remotion of unneeded multiple inheritance in the board class.

A multiple inheritance case in KBounceBoard has been eliminated. The
class was being derived from QGraphicsItemGroup and from QObject.

QGraphicsObject provides the functionality present in both classes and
is the class we're gonna use from now on.

Hide/remove sensitive information from anon file

GeoData based Colorization

Pn2 file format is introduced to store vector data.
Use of GeoData layers with styling color for vector drawing.
TextureColorizer uses this GeoData to paint base map.

Work done by Cezar Mocan during GSOC 2012

Add icon-print from font awesome, CC BY 3.0

A +- -- src/plugins/render/webpopup/font-awesome-icon-print-16x16.png

Prepare license choice GCI task.

By happy coincidence this fixes

Several compiler warningy fixes

Submitted by Geoffrey Mon, completing
a Google Code-in task.


REVIEW: 107959
DIGEST: Google Code-in contribution

Introduce helper classes to perform common xcb requests

Two helper classes WindowGeometry and WindowAttributes which can be
used to request the geometry and attributes more easily. This is based on
a templated class, taking cookieType, replyType and function pointers to
the request and reply functions as template parameters.

The ctor performs the async request and the reply is stored in a
QSharedPointer. Whenever the reply is needed it is checked whether it
has already been retrieved and if not will block by calling the reply
method. The class provides operator bool() to check whether the reply
succeeded (pointer is not null) and operator->() to directly access the
reply pointer.

Add a timer of 300msec to launch displayButton

If we call setConfig too fast my Xorg gets screwed up but just as they
get screwed up by calling xrandr too fast.

Just to be sure (and to prevent user mistakes) I have added a small timer
to avoid this.

Set a timeout for waiting remaning Dr.Konqi

If the timeout is reach, just ask remainging Dr.Konqis to die.
The timeout is now hardcoded as 15 minutes.


REVIEW: 107657

Port Logout Effect to KConfigXT

REVIEW: 107935

Return if nothing to do (for not hitting setScreenSize

If there is no output to disable/enable/change there is no need to
change the screenSize (which makes the screen flicker on comopsite).

Remove gesture factilities from KAction

The gesture facilities are now found in the KGestureMap class. Some
new methods have been added to this class to let it handle information
about each action's active and default gesture. See KDE5PORTING.html
for more information about this

I'm not sure the implementation of these methods is very efficient, as it
uses QList's searching. If that proves to slowdown shortcut editing, it
may be rewritten, but the KGestureMap class is actually not used, as one
can see in it's eventFilter method which starts with 'return false' so
this should be let as a TODO for further KF5 releases.

REVIEW: 107973

Compile on Android.

The class has no Q_OBJECT macro but defines
a slot which breaks compile for Android. The
slot has actually no implementation.

Unlock the image after saving a multilayer tiff file

Give guidance about the scaling filters to be selected

Port the setting of env variables on windows to krita (from sketch)

This makes sure that krita can start, even without the .bat file, but
it shouldn't hamper using the .bat file in the shared calligra windows
package.

Port Muon Discover to the new Transactions API.
I've re-added a barebones TransactionListener which fulfills Discover's usage needs. The new API did mean that I could strip away a bunch of the code that had been in TransactionListener, which it now obtains via the Transaction object and the model. :)

Add "Printers" KCM to Plasmoid's settings and set sane default dialog size for the dialog

Move KChat to kbackgammon that is the only one that uses it

And libkdegamesprivate is deprecated/unmaintained code