Issue 220

fix memory leak

when creating raw type pointers and not storing them in one of the
smart pointer classes, they will be leaked. so: always use
smart pointers

queued-connection for statusbar slots

otherwise we can deadlock the ui, e.g. when triggering
a showProgress from a background thread, esp. from
the background parser which holds its internal mutex
when emitting the signal

Fix handling of return values of methods called by
QtApplication.invokeDelegate

A big thanks to Marijn Kruisselbrink for
initial patch !

Encode special characters in XML attribute names

Special characters that are not allowed by XML spec in attribute name
are encoded in hex using following notation _.XX

Crash when images moved and scanning for new

If images are moved e.g. from command line while KPhotoAlbum is running
a crash occurs when scanning for new images. This patch seems to fix the
issue as described in bug report's case nro 2.

Fixed Bug 286735 - Custom paper size isn't retained
Now also captions and page layout is kept if back from crop page

Correct issue of triple clicking and scrolling up.

Fixes selecting text by triple click and scrolling up causes only the
visible contents to be selected.

Thanks to Shlomi Fish () for research and patch.


REVIEW: 103724
FIXED-IN: 4.9

fix painting issues

M +- -- desktoptheme/air/widgets/tasks.svgz

Fix regression: Respect "natural sorting" setting


FIXED-IN: 4.8.1

Fixed property watching by type.

This commit combines two things as they were too connected to be splitted:
- The ResourceWatcherManager now queries the types of the resources if
there are connections which watch by type.
- The changeProperty method now also takes care of emitting the added
and removed signals which avoids a lot of code duplication and simply
makes sense.

make the history sidebar work for years

Fix saving/loading of 'Show recent documents' setting.

Terminal: only consider process IDs > 0

Thanks to Jekyll Wu for the analyses.

Don't crash when opening a tab with enabled split view


FIXED-IN: 4.8.1

Handle folder names containing spaces correctly in the Folders Panel

The problem was that KFileItemModel::setExpanded() used KUrl::url()
to determine the names of the subfolders. This method encodes special
characters, such that comparing the folder names with the unencoded URLs
stored in the model fails.
Using KUrl::path(), which does not encode special characters, fixes the
problem.


FIXED-IN: 4.8.1

Moving tabs causes wrong tab to be highlighted upon reload.


FIXED-IN: 4.8.1
REVIEW: 103740

Check the modification time before reindexing files

The modification time was always checked, but only when a directory
was sent for indexing. The analyzeDir function would check for files
as well. This worked fine the cases where the Indexer would routinely
check and re-index files.

It however didn't work so well in the cases where the file watcher
told the indexer to reindex a file cause of a inotify event. Specifically
CloseOnWrite event, which are emmited when a file opened with "r" mode
is closed. Even if modifications aren't made.

Applications like Amarok and KTorrent routinely open files in "rw" mode
even when they don't have to make changes. Those files used to get
re-indexed.

REVIEW: 103794

Fix regression: Allow dragging items on a tab


FIXED-IN: 4.8.1

Select right profile name in saveFavorites()

Do not use "profile->name()" for retrieve profile name, but take it
from profile path.

When a profile name is changed (ex. test -> test2):
profile->path() (/home/xxxx/.../test.profile)
profile->name() (test2.profile)

Thanks to Francesco Cecconi ( ) for patch


REVIEW: 103807
FIXED-IN: 4.9

Assure to mark an item as unhovered on a drag-leave event


FIXED-IN: 4.8.1

Proper activity switching considering encryption

Moving tabs causes wrong tab to be highlighted upon reload.


FIXED-IN: 4.8.1
REVIEW: 103740
(cherry picked from commit 349264ee404c8a6b3d4cba4ee5c67df0982e97e0)

lots of little improvements to the listview widget which makes the
view and the search dialog more pleasant to use. including the
ability to sort columns (which started me on this in the first place).

includes new strings which are commented-out for now so this can
be backported to 4.8

MERGE: 4.8
(cherry picked from commit 71babc8014bd00b5a650de69fd72ae4c0d53d262)

Fix Bug 278708 - kmail, account creating assistant creates only imap4

account
Now we can select imap or pop3 account.

FIXED-IN: 4.9

Reduce conflict dialogs when dragging fast multiple times.

Don't send updates to kmail when kmail isn't completely done with
the previous update ( i.e msg->transferInProgress() is true ).

Part of kolab/issue4811.

Fix Bug 291010 - Folders in favourites (list mode) are shortenend

without need

FIXED-IN: 4.8.1

Comment this dialogbox. I am tired to click on ok all the time when I get 3000 mails.

This messagebox doesn't info about item etc.
=> not necessary

in mimeTypesMonitored() and itemsMonitored() don't call toList() on
empty QSets. Since QSets are QHashes and performing operations on
empty QHashes is crashy.


MERGE: 4.8
FIXED-IN: 4.8.1

Resume handling pending requests after coming online again.

Patch by Kévin based on an earlier patch by myself.
(cherry picked from commit 0524e6d1420873f8df3727a3cf2f4edd966e9e0a)

Start to fix Bug 292188 - Font size of favourite folder list can not be

changed
(now we load font from config but it doesn't react to
kglobalsetting::fontchanged... don't know why)

Correct mathematical error in Phong Bumpmap

o The error prevented inclination from going above 45º even if the GUI said 90º
o The error also caused inclination to be calculated in reversal direction

Fix Calligra Words crashes on opening a particular file.
Be sure we do not end with a negative value for right.

doc: Updated processing of text-boxes.

Seems that textId == 0 is a valid index. According to test files prepared in MS Office 2003/2007,
the smallest index used == 1 (For whatever reason).

Fix loading of the text shape

Manifest file was not parsed. Mimetype from manifest
is used for determining the correct shape factory.
As this information was not present, the shape could
not be identified and sometimes it was UnavailShape
or nothing.

This could possibly fix loading of ODG files in Krita too.

Create a default config factory for Phong Bumpmap

Make KisDropButton inherit KisToolButton instead of QToolButton

o This returns our add layer button its compatibility with tablets
o Also increase the width of the button by 9 pixels, now it looks the right size
o Celebrate with champagne coming back to contribute in Krita :)
o Couldn't find if there was a bug reported for this so I didn't close any

Fix crash for animated image pipe brushes

Global selection was made to be a mask.
The code expected that the first child
was a layer, but it was a mask.

Thanks to Dmitry with help regarding the
iteration over layers.

trying to fix visio filter

doc: Added support for Bullet Pictures.

fixed color schemes in preset chooser

cleanup shortcuts, avoid collision with selection tools

use palette colors, works with dark color schemes too

Don't load a playlist if it's already found by folder scan.

The way file scanning is performed, it's possible for a playlist that is stored
with a .m3u file to be found and loaded before JuK has finished loading its
cached playlists.

There's a few ways to fix this, but the most conservative (especially for those
dealing with this bug for awhile) is to filter playlists as they are being
loaded from the cache and remove any that have already been loaded. This also does not
require a change to the QDataStream binary format used for saving playlists.

This should fix a bug that's been open for more than five years now... by the
way, anyone want to help with finding/fixing more JuK bugs? :D

Prevent crash when uninitialized.


FIXED_In:2.6

Fix crash when remounting UMS.

Fix crash when a device holding a UmsCollection is mounted again after an unmount without removing the device in between.
The crash occours because the QSharedPointer m_mc is cleared during an unmount but not initialized when mounted again. I fixed this issue by initializing m_mc in the init-method and not in the constructor.

Patch by Volker Christian


FIXED-IN:2.6

REVIEW:103774

Use asynchronous DBus API in plasmoid and kded module communication.

Check for contact manager being null and don't crash if it is.

I had a contact request, killed mc, accepted it and the whole kded didn't crash and the contact was still added. Double win.

Reviewed-by: David Edmundson

Fix and workaround graphical artifacts.

- Make kio-magnet optional
- Improve handing magnet uris in search plugin
- Fix bug causing kio-magnet to deselect all files

When updates are not marked due to the updates requiring the installation or removal of
other packages, inform the user and ask them if they wish to mark these updates.

queries: Consider an empty password as a request cancellation.

Empty passwords do not make sense as valid passwords (infozip, rar and
the 7-Zip on Windows do not create archives with empty passwords, for
example).

Calling Query::setResponse(false) when an empty password is passed
makes the code in CliInterface consider the current action has been
canceled, as if the user has pressed the Cancel button in the password
query dialog, and not pass a single newline in password queries.

Even though the related bug report can also be considered to be caused
by PasswordPromptPattern not being defined for the clizip plugin and
CliInterface::handleLine() not checking for password prompts in Copy
mode, this commit has the advantage that the user is not prompted twice
for zip files if she enters an empty password the first time.

The user should be informed that the action has been canceled, but
this can be done in a separate commit.


FIXED-IN: 4.8.1

A robot player should never claim a tile if that leads to dangerous game

when resizing the main window, the action buttons should
not shrink in height

backported from trunk r1273158


FIXED-IN: KDE 4.8.1

after I discard a tile, hide my yellow popups like "Pung"

backport from trunk


FIXED-IN: KDE 4.8.1

Fix several aspects of C++11 decltype support, and add tests.

Build uses within the parens, properly build postfix-expressions, etc.

add debugger option to choose which tool view should be opened on debug start

This option already existed in KDevelop 3.5

Can't be in 4.3 because of new strings and a bugfix I applied to
kdevplatform master only.


FIXED-IN: 4.4

Improve parsing of enum values from JavaScript
Now not only uint32 literals are possible, but larger values too.

However you have to ensure that the value is written as a string instead
of a number literal for values greater than 9007199254740992 as JS
stores numbers a a double internally and after that value it is not
possible to represent every integer value.

Also it is no longer possible to have doubles/floats as enum constants
If there is one, it is silently converted to an integer.

hide vi-swap files in qmakemanager

implement type support for ternary operators

foo = 3 if False else "str" # <- foo:unsure(int,str)

Support bicycle and pedestrian routing types.

Offline data model to manage offline routing and offline search data.

Introducing Ekos, a new tool for KStars that will empower amateur astronomers to utilize INDI based devices to perform essential functions in astrophotography:

+ Alignment: Facilitates polar alignment procedure.
+ Focus: Manual and Auto Focusing algorithms.
+ Guide: Guide the mount for accurate tracking for extended periods of time.
+ Capture: Capture CCDs images individually or in batch along with filter selection support.

This is a very early release and only basic functionality is provided. The above features will be added with time.

use ProgressManager to displatch progress event from face pipe line manager

Add environment variable $KONSOLE_PROFILE_NAME

It records the name of the profile used in current tab/session.


FIXED-IN:4.9

embed a QScrollArea into it to preview the svg in.

unsure about dialog sizing, but atm it's pretty terrible.

also, svg natural size seems to be static 48x48. this isn't want i
expected, so hardcoded (hack of course) to 1024x1024 for now.

support filter by rating

a fancy timeline widget in the test

add MetadataTimelineModel

this model groups and counts the results by date, with a configurable level of detail year, month, day.
easy to build timelines with it

Create a TagWidget

It contains a line edit for entering tags + a list view which shows
all the tags present.

This looks a lot better than the simple TagEditor

Implement a NoteInformation widget

This shows very rudimentary information about the note in the side
bar. Ideally, it should show the tags and so on, but for now I've
just hooked it up.

It only shows the nao:lastModified and nao:created, and that too
horribly.

support filter by rating

Support withdrawal of shadows

The Oxygen deco uses this to remove built-in shadows from decorated windows when adding (legacy...) decoration shadows


REVIEW: 103751

condense read and write plots into 1 visualization

we sort of have to "trick" the base class a bit to do this, so it's not
100% clean. but afik, it's only needed in our particular situation

next up would have to be getting the config dialog to only display the
disk name, so the user doesn't need to think about checking rblk and
wblk

kindof working filtering and zooming

make tags filtering work

The New Event/Todo/Journal actions are always enabled now.

When the new event dialog was implemented, the resource view
stopped influencing the destination calendar, you can choose
any calendar in the dialog's collection selection combo.

This commit removes some leftovers that weren't ported to the new
way of creating events.

Add attribute-based logic for continuing the fetch of the GAL
and re-fetching it. Neither actually works at present, but
we now have coded up:

- The ability to seek into the GAL.

- An attribute in the collection which stares the state.

- Start/restart algorithm coded.

Re-enable DnD between different calendars.

Ready for testing.

Option to export the KAddressBook display name in the vCard's full name
(N) field. Allows the name to display properly in GMail and Android
(which don't appear to take any notice of the FN field).

REVIEW:103760
I18N:
GUI:

implement support for the MAPI PT_UNICODE property data type.

MERGE: 4.8

support zotero downlaod of more than 50 items

Implement undo of Style changes

Two new methods are introduced: beginEdit() and endEdit() to mark
when the editing happens. At endEdit() the collected changes
are applied to any attached documents like before.

The difference is that it now happens through ChangeStylesMacroCommand
Which in turn uses ChangeStylesCommand

The role of ChangeStylesMacroCommand is to act as a macro plus to
make sure the styles within the stylemanager itself are updated.

The role of ChangeStylesCommand is to update the qtextdocuments.

REVIEW: 103779

Implement support for reversed chart axes in the MSOffice 2000/2003/2007 filters.
This also adds support for logaritimic axes but seems with my test-documents I hit a bug in our used version of kdchart. So, the logarithmic code-path is disabled for now.

support for zotero child note downloads

implemented more features in script engine

* if the script equals runTests, tests will be run. this works only in debug mode.
* evaluate && in bool() clauses
* allow float(some + computation) in bool() and if() clauses
* letter[something] = 30; works now, if there is no cast to bool or float, variant is used.
*

all zotero project sync to add the pimo:isRelated property

Use a PinchArea to support preliminary pinch zoom.
Force input focus on Find toolbar.
Return the document size, dont calculate with zoom again as
its already taken into account.

doc: Added support of the "Symbol" special character.

Add slideshow feature

doc: Added paragraph padding support.

The following LO/OOo config item must be supported by textlayout in order
to display files exactly like Lo/OOo/MSOffice does.

<config:config-item config:name="InvertBorderSpacing" config:type="boolean">true</config:config-item>

Make it possible to toggle toolbars

Implement new toolbar system

MLT now supports rendering to another framerate, so allow it in render dialog

Open links in new tabs with CTRL + ENTER

Play a chalk sound effect for the next tool image action

Add wav files - SoundEffect supports only that format, plus pulse policy file

A +- -- sounds/chalk.wav
A +- -- sounds/right.wav
A +- -- sounds/wrong.wav

new config parameter "Propose what to do"

with this one enabled, the program proposes the human player what to
do like claiming a tile or selecting a tile for discard. Some of the
more rare actions are never proposed yet, like original call

Fix memory leak -> pypy (1e6 LOC) can again be parsed with 4GiB memory

ElevationProfile: Refactoring

Refactoring of the ElevationProfile plugin code.
* axis handling moved to a dedicated class,
no more double-code for X and Y scale calculation
* try to generate 'nicer' interval ticks, e.g. 42.5 instead of 42.444
* "double click -> jump to location" now works in zoom mode, too
* minor optical changes
* shortened the "Elevation difference" text to not get cropped in
Marble Touch
REVIEW: 103793

Make antialiasing optional: there are serios performance issues with
antialiasing on some systems.

Load the popup dialog dynamically and on demand only.

Improve generation of previews code

The layout text is only required for native decorations.

Delay added signal and other signal bindings for synced windows until the window is actually visually shown

Makes animations of showing windows run completely and thus appear smoother

REVIEW: 103742

paintoppresets speedup

disabled spacing on some presets that didn't really need it to get them more reactive

M +- -- krita/data/paintoppresets/Basic_Airbrush.kpp
M +- -- krita/data/paintoppresets/Basic_erase.kpp
M +- -- krita/data/paintoppresets/Basic_erase_soft.kpp
M +- -- krita/data/paintoppresets/Basic_ink_10.kpp
M +- -- krita/data/paintoppresets/Basic_ink_ballpen.kpp
M +- -- krita/data/paintoppresets/Basic_ink_tilt_10.kpp
M +- -- krita/data/paintoppresets/Basic_ink_tilt_20.kpp
M +- -- krita/data/paintoppresets/Basic_mix.kpp
M +- -- krita/data/paintoppresets/Basic_mix_oil_over.kpp
M +- -- krita/data/paintoppresets/Basic_mix_over.kpp
M +- -- krita/data/paintoppresets/Basic_mix_over_wet.kpp
M +- -- krita/data/paintoppresets/Basic_paint_05.kpp
M +- -- krita/data/paintoppresets/Basic_paint_25.kpp
M +- -- krita/data/paintoppresets/Basic_paint_fill.kpp
M +- -- krita/data/paintoppresets/Block_paint.kpp
M +- -- krita/data/paintoppresets/FX-explode.kpp
M +- -- krita/data/paintoppresets/FX_color_HSY.kpp
M +- -- krita/data/paintoppresets/FX_decrease-saturation.kpp
M +- -- krita/data/paintoppresets/FX_glow_add.kpp
M +- -- krita/data/paintoppresets/FX_glow_screen.kpp
M +- -- krita/data/paintoppresets/FX_overlay.kpp

krita-paintoppresets-update

Better selection and name organisation for paintoppresets

D +- -- krita/data/paintoppresets/Airbrush_300.kpp
D +- -- krita/data/paintoppresets/Airbrush_600.kpp
D +- -- krita/data/paintoppresets/Aquarelle_paint.kpp
D +- -- krita/data/paintoppresets/Aquarelle_smudge_water.kpp
A +- -- krita/data/paintoppresets/Basic_Airbrush.kpp
A +- -- krita/data/paintoppresets/Basic_erase.kpp
A +- -- krita/data/paintoppresets/Basic_erase_soft.kpp
A +- -- krita/data/paintoppresets/Basic_ink_05.kpp
A +- -- krita/data/paintoppresets/Basic_ink_10.kpp
A +- -- krita/data/paintoppresets/Basic_ink_ballpen.kpp
A +- -- krita/data/paintoppresets/Basic_ink_tilt_10.kpp
A +- -- krita/data/paintoppresets/Basic_ink_tilt_20.kpp
A +- -- krita/data/paintoppresets/Basic_mix.kpp
A +- -- krita/data/paintoppresets/Basic_mix_oil_over.kpp
A +- -- krita/data/paintoppresets/Basic_mix_over.kpp
A +- -- krita/data/paintoppresets/Basic_mix_over_wet.kpp
A +- -- krita/data/paintoppresets/Basic_mix_small.kpp
A +- -- krita/data/paintoppresets/Basic_mix_soft.kpp
R +- -- krita/data/paintoppresets/Basic_paint_05.kpp [from: krita/data/paintoppresets/Paint_circle_05.kpp - 090% similarity]
R +- -- krita/data/paintoppresets/Basic_paint_25.kpp [from: krita/data/paintoppresets/Paint_circle_25.kpp - 094% similarity]
R +- -- krita/data/paintoppresets/Basic_paint_fill.kpp [from: krita/data/paintoppresets/Paint_circle_fill.kpp - 090% similarity]
R +- -- krita/data/paintoppresets/Basic_paint_shade.kpp [from: krita/data/paintoppresets/Paint_circle_50.kpp - 092% similarity]
A +- -- krita/data/paintoppresets/Basic_smudge_detail.kpp
A +- -- krita/data/paintoppresets/Basic_smudge_hard.kpp
A +- -- krita/data/paintoppresets/Basic_smudge_hard_grain.kpp
A +- -- krita/data/paintoppresets/Basic_smudge_oil.kpp
A +- -- krita/data/paintoppresets/Basic_smudge_over.kpp
A +- -- krita/data/paintoppresets/Basic_smudge_soft.kpp
A +- -- krita/data/paintoppresets/Block_mix_tilt.kpp
R +- -- krita/data/paintoppresets/Block_paint.kpp [from: krita/data/paintoppresets/Paint_block.kpp - 094% similarity]
R +- -- krita/data/paintoppresets/Block_paint_dirty_square.kpp [from: krita/data/paintoppresets/Paint_texture_dirty_square.kpp - 095% similarity]
R +- -- krita/data/paintoppresets/Block_paint_squary.kpp [from: krita/data/paintoppresets/Paint_squary.kpp - 092% similarity]
R +- -- krita/data/paintoppresets/Block_paint_tilt.kpp [from: krita/data/paintoppresets/Paint_block_tilt.kpp - 094% similarity]
A +- -- krita/data/paintoppresets/Block_smudge_tilt.kpp
D +- -- krita/data/paintoppresets/Block_tilt_paint.kpp
D +- -- krita/data/paintoppresets/Block_tilt_paint_smudge.kpp
D +- -- krita/data/paintoppresets/Block_tilt_smudge.kpp

add an option to make opengtl plugins use threads (opt out by default, until it is fully tested)

cleanup ui

- put buttons below tree
- reduce double-margins

Some minor changes and cleanup of Backward textfind

Increase poppler required version to 0.12.1

Released Sun Oct 18, 2009, if you want to build this new Okular with that old poppler version you should really think updating it too, there's been lots of fixes since then

New theme for HTML export by Steffen Jost

The theme is just a variation Miika's first dark theme. The most
important of my changes is that the description texts are now above the
image, which was important to me in order to make sure the descriptions
are not missed any more.

added 35x45mm photo template for UK passports

Prepare 1.7.0 release.

Added descriptions for the DECIMAL, COUPDAYS, COUPDAYBS, QUARTILE and NUMBERVALUE OpenFormula functions.

more improved icons

monospace edits

M +- -- Monospace/OxygenMono-Regular.otf
M +- -- Monospace/OxygenMono-Regular.ttf

disabled xfrun4.

make tooltips about dangerous game more specific

exactly say why doing something is Dangerous Game or would lead to it