Issue 246

Fixing simoncv and removing global varaibles in the face analyzer

Fix downstream builds (thanks apaku).

Initialize all the members

Otherwise valgrind reports problems when printing the debug information.

Set base directory of the CVS diff job properly.

This fixes behavior of "Show differences..." command with CVS:
the changed files are properly displayed in the toolview.

Separate "directory valid" and "file is known" conditions in CVS plugin.

This fixes behavior of "Add"/"Revert" actions, allowing to add new files
to the CVS index.

REVIEW: 105795

Fix the EOF flag not being unset after a new read in structures tool

Got the "Go Back" button working, allowing smooth migration between the category selection, skyobject list and skyobject details views.

Fix crash in rooted tree

This fix is a workaround to avoid a crash in Rooted tree plugin.

This commit should not be applied to master, we need to find
a better fix.

PositionTracking: store current track to file, and reload on next launch

User will not lose his data as it is saved on closing the application
and reopened at startup.
Applications which want to benefit this need to call:
marbleModel()->positionTracking()->readSettings() and writeSettings()

resource editor: fix a subtle bug in the key resizing code

There was a circular binding in the QML code handling changed
coordinated of the grips ultimately corrupting the undo stack.

resource editor: fix spontaneous key resizing bug

Sometimes when selecting a new key in the keyboard layout editor its
size would change for no apparent reason. This is fixed now.

Moved m_findBar->resetSearch() from closeUrl() to notifySetup()

As a side effect, this change fixes bug 303998, that caused a crash if
the part's widget was destroyed before the part itself, because
m_findBar had already been destroyed.


FIXED-IN: 4.9.0

Fix build with qt4, moc is too stupid to parse Qt version checks...

Fix compilation with Qt5

Fix issue where new profiles are not saved correctly

Due to new code untranslatedName, the saving of the profile was not
correct. This patch fixes that.


REVIEW: 105648
FIXED-IN: 4.9.0

Fix on demand plugin loading on reloads

Honor Konqueror's on demand plugin loading and per host plugin configuration.


FIXED-IN: 1.3.0

un-Q'tile partially max'd clients on startMoveResize


REVIEW: 105699

last minute fix for KDE 4.9: hard code search&replace colors

workaround, until we have a better solution

ResourceMerger: Fix equalGraphs check

This fixes the failing storeResources unit tests in the DMM.

I cannot seem to find who wrote the earlier code, but it was clearly
wrong. Git blame doesn't give me much information.

REVIEW: 105714

Fix DMMTest::removeDataByApplication10 - FileIndexer case

When the nie:url is saved, if the scheme is not specified, it gets the
'file' scheme, which is the correct behavior.

This test issues a sparql query without the 'file:/' in the url.

REVIEW: 105716

Fix regression in QML shutdown menu. Ampersands should be removed from
menu entries' text by default.

Fix KInofyTests

* testRenameFolder
* testMoveFolder

It turns out that there is nothing wrong with the tests, just the wrong
signal name.

Fix issue where new profiles are not saved correctly

Due to new code untranslatedName, the saving of the profile was not
correct. This patch fixes that.

Patch by Francesco Cecconi

Francesco, please commit to trunk when you have time. I'm committing
this to make sure it goes in 4.9

Fix regression in QML shutdown menu. Ampersands should be removed from
menu entries' text by default.

Fix crash due to other threads using the model at the time it gets deleted.

Patch by David Faure
Ported from nepomuk-core - 9bd45eea17deb4a93c774697550238251b048f07

Fix mem leak. Sonnet dialog box was never deleted

Make the Nepomuk runner forward all the nie:urls

Not just the ones that are local files. This fixes opening of emails,
and other akonadi resources directly from the runner.

REVIEW: 105738

FIXED-IN: 4.9.1

Cherry-picked from edd4ee05f50eb84d6ed3eb87696fb9350d2b6b37

Hook Activity Manager Icons Config to Nepomuk and Write Icons

These changes were missing from the set of changes that introduced
icons config in 4.8


FIXED-IN: 4.8.5

SimpleResource: Avoid duplicates when adding another PropertyHash

We need to add each (key, value) pair separately, so as to avoid
duplicates. A QMultiHash can contain the same (key, value) pair
multiples times.

This fixes SimpleResourceSubsystemTest::testSimpleResourceGraphAdd

REVIEW: 105718

ResourceWatcher: Send the values as QVariants not QDBusVariants

I have no idea why we chose to send them as QDBusVariants, but it causes
problems in extracting the data at the other end.

Also pass resources as strings, and not QUrls. DBus does not natively
support QUrls and passes them as -

struct { string nepomuk:/res/.. }

instead of just 'string nepomuk:/res/..'

Fix build with Qt4 (for real this time)

Expand %# %w in the "Copy Input To" dialog session list.

Duplicate the code in SessionController.cpp to expand %# %w in the
copy input dialog. This is not the ideal solution but it not trivial
to fix w/ all the tab/window titles issues in Konsole.


FIXED-IN: 4.10

Merge branch 'KDE/4.9'

* Fix Resource tests
* Other miscelanous fixes

Full change log -

414fd4c Introduce fall-back indexing
75723eb ResourceWatcher: Convert uris to QUrls
64890e1 Move the SimpleResource tests to libnepomukcore
979f656 Report the Indexer error
be31679 ClassAndPropertyTree - Always make sure a url has a scheme
41c1e33 ResourceWatcher: Send the values as QVariants not QDBusVariants
64ccfe1 Fix ResourceTests: the nie:url will have a file protocol
5f5291f Fix ResourceTests - typeTopMost and resourceDeletion
825ea14 Fix DMMTest::removeDataByApplication10 - FileIndexer case
c42e7eb Loose ResourceManager::clearCache
a28d758 ResourceData::store - Give the correct type to createResource()
93d0c6b DescribeResources: Do not use inferencing when listing properties
b20140f Fix ResourceTests:newFolder
c0365a8 ResourceData: Connect the watcher for new resources
cea8e6f ResourceMerger: Fix equalGraphs check
14e67cf DMMTest: Fix testRemoveResources_invalid_args
4cb118c SimpleResource: Avoid duplicates when adding another PropertyHash
027e57d DMS: RemoveAllResources - Emit propertyRemoved for object resources
4325b20 DataManagementModel: Do not add type nfo:FileDataObject if it already exists
8a1ceb4 Ractor ResourceData and ResourceManager

SimpleResource: Avoid duplicates when adding another PropertyHash

We need to add each (key, value) pair separately, so as to avoid
duplicates. A QMultiHash can contain the same (key, value) pair
multiples times.

This fixes SimpleResourceSubsystemTest::testSimpleResourceGraphAdd

Fix deletion of preferred application launchers

In default panel config the host of that magic preferred app url is used
as the key. So lets use that key to delete the launchers, too.


FIXED-IN: 4.9.1
REVIEW: 105374

Honor the start and end time range when printing filofax.
This is a partial fix for bug 251710


MERGE: 4.8, 4.9
(cherry picked from commit 2dac6e943fa6cc295e7aa6bb9d5ef49ef8158c01)

Fix the "Extend time range to include all events" option
in day timetable print mode.

also fix a bug where the footer was misplaced in this print mode.


FIXED-IN: 4.8.5
MERGE: 4.8,4.9

Honor the start and end time range when printing filofax.
This is a partial fix for bug 251710


MERGE: 4.8, 4.9
(cherry picked from commit 2dac6e943fa6cc295e7aa6bb9d5ef49ef8158c01)

Fix Bug 302108 - do not include folder name in taskbar entry of a message

Change order of caption => "name - folder name"
FIXED-IN: 4.8.5

Hide nepomuk checkbox (not implemented). Will implement in 4.10

Fix Bug 303841 - message list does not remember its size

FIXED-IN: 4.9

Fix Bug 302108 - do not include folder name in taskbar entry of a message

Change order of caption => "name - folder name"
FIXED-IN: 4.8.5

(cherry picked from commit 201032304d721bbb8558104dd0c01d5c4cbd8476)

Fix display of recurring multiday events

If an event did not recurrOn a day in the currently selected
date range but recurred before that and was "still happening"
it was not painted.
Now we check for all recurrences that "still happen" on the
first day of the selected monthview.

Make MailScheduler fully async, with proper error handling.

Now MailScheduler will only report success/error when
MailClient finishes sending the e-mail.

Will fix cases where no invitation was sent and no error was shown
to the user.

Store Password option was removed in 4.8

Fix wrong column types used in older instances for n:m helper tables.

Now that we use the same column types as in the corresponding parent
tables, automatically adding the missing foreign key constraints actually
works.

Fix display of recurring multiday events

If an event did not recurrOn a day in the currently selected
date range but recurred before that and was "still happening"
it was not painted.
Now we check for all recurrences that "still happen" on the
first day of the selected monthview.


(cherry picked from commit 99f24760b2d30a8abbf63f0a7247415578f32deb)

Compare referential actions as well when checking existing foreign keys.

Ugly, but does the job for now.

Fix impotrt ldap in thunderbird. And start to support import ldap in

evolution

Give more details in the LRCONFLICT error message.

Fixes to make the printing inside dayboxes (esp month prints) look nicer
and fit better.
Includes a patch from Fred Feuerstein, Thanks!

REVIEW: 105609
,237292,251681,263442
FIXED-IN: 4.8.5
MERGE: 4.8,4.9

Fixed two bugs in the interface

- Fixed a bug where an entry would evaluate multiple times, if the
previous entry received multiple statusChanged(Done) signals.
- Fixed a bug where a child item was not deleted by fadeOutItem() when
there already was an animation.

remove icons from "Add Slide/Page or Layer" menu (missing layer-new icon)

REVIEW: 105687

thanks thorsten for review

Write recent file list when it is cleared

When the recent file list is cleared it is not saved to the config file and therefore
the files reappear on the next opening of the document.

fix missing icons "edit-duplicate" & "edit-merge" with "edit-copy" & no icon (Krita context menu on layers)

REVIEW: 105692

thanks boudewijn for review

Fixed some bugs in the ui

- Removed the option for inline completion, because the new interface
only has popup completion.
- Changed the cursor to an IBeamCursor for editable TextItems
- Pressing Shift+Del repeatedly does not remove the last entry anymore,
it should not be possible to get a worksheet without any entry.
- Entries that are wider than the window now make the horizontal
scrollbar appear, and the scroll width is adjusted appropriately
when new items are created or existing items are destroyed.

: Crash when removing transaction number of transactions with duplicate account numbers

fix text input

REVIEW:105625

Avoid crash - check if dialog pointer is still valid

EngineController: don't do serious work in slotAboutToFinish()

...because slotAboutToFinish() may be called twice (or not at all) per
track by some Phonon backends (hi, vlc) - increase play count rather in
slotNewTrackPlaying() or in slotFinished(). This also needs to change
how m_currentTrack is handled, because slotNewTrackPlaying() needs to
have the old one in m_currentTrack.

Also, PlaylistActions::requestNextTrack() is changed to be a read-only
method that shouldn't change playlist state especially when there is no
next track. PlaylistActions::reflectPlaybackFinished() is introduced to
do the thing and is called from EngineController::slotFinished(), which
is a much better place for it than slotAboutToFinish().

Reporters of CCed bugs, please re-test your bug with this commit
applied, it is possible it has been resolved by this patch.







FIXED-IN: 2.6

Correct Icon call

There is no KIcon called "bookmark", it should read "bookmarks"

EngineController: if supportedMimeTypes contains x-m4a, add mp4 too

So that we announce correct mimetypes in MPRIS2. Patch from Andrea on
CCed bug.

Fix search engine(s) for KDE 4.9

This is basically Johannes patch with checks added for kde version and
with code duplicated for kwebapp.

PS: I tried using KUriFilterData API to do it, without positive results.
Postponing a code review here for KDE 5, hoping variables won't change
another time name...



REVIEW: 303872

"Combine Files" overwrites existing target file without confirmation
and general cleanup of Combiner

Adding lip analyzer

Adding Simon computer vision library

Add a new templated class extending PrimitiveDataInformation

This reduces code duplication and will hopefully increase maintainability

Simplified value reading code for structures tool

Also probably slightly optimized it since it uses the builtin bswap

Added: version check for the bytearray viewprofile files

If you already added some viewprofiles because you have been running previous
development versions, open all the files in .../share/apps/okteta/viewprofiles/,
add the lines
--- 8< ---
[OBAVP]
Version=1.0
--- 8< ---
and save. The viewprofiles should now automagically reappear also in running Okteta instances.

DGML Maps improvement. Added more possible
formats and customizable ground layers.

Better code for drawPolar and Cartesian coords, this comes from GPLACS: improvements like limits on zoom (on mouse scroll event) and more configurable grid.

resource editor: make keyboard layout properties editable

Not the title, name and size of an keyboard layout can be viewed and
edited using the property panel.

Introducing another user interface for "What's Interesting" feature. Took some risk and decided to go for an unconventional design.

Accessibility feature, the text of grid's ticks/scale now follow the pallete of text group. Also, the behaviour of zommig is even better now, avoiding the user see many grid divisions and text when scroll the mouse #accessibility

support both libgphoto2 2.5.0 and 2.4.0

I also rewrote findConnectedUSBCamera to work with both 2.4 and 2.5,
also to be a bit more simple and less quadratic or O(n^3)

Added support for Video metadata in Image Properties Sidebar

Though the entries are visible in the sidebar, the values are not being read properly. Needs revision.

Record color profile and metadata in undo history in editor.

So far only the history was recorded. Add a container to store history and icc profile.
Undo/redo now works cleanly when a plugin changes the color profile.
DMetadata is currently not kept in undo because either an imageplugin (only two atm, noncritical)
or a concurrent user metadata editing operation can change the metadata; essentially,
all critical metadata editing would need to be applied before saving.
In ImageWindow, we re-write from the database to metadata before saving, so probably all will work.

Made all text entries in video metadata database

Changed all entries to text in datbase. Improved data reading functionality.

Store color profile in Exif as a workaround for missing support in the PGF format.

Attempt to do the same for JP2K, but that does not work: When reading, the library successfully
returns an sRGB profile, while we cannot change this when creating a file.

Add keyboard navigation to konsoleprofiles widget


FIXED-IN: 4.9.0
REVIEW: 105765

Port of Plastik decoration to QML

The Plastik decoration buttons are provided by a declarative
extension plugin as the canvas drawing API would be needed to
draw these buttons. This should be changed with Qt 5.

But it's also a nice example to show how a QML based decoration
can have an extension in C++.

Make 'Find' action consistent with other KDE applications

When search bar is visible, pressing the shortcut/menu item for the second
time give focus to the search lineEdit. This patch remove toggleable property
from the action.


REVIEW: 105723
FIXED-IN: 4.10.0

Multi monitor support in Userbar theme


Reviewed-by: David Edmundson

Align about to be tabbed window before adding it


REVIEW: 105702

new components: drawers

Declarative extension plugin for window decorations

The generic QML components from Aurorae are split out into an
own declarative plugin. In addition two new helper classes are
added to this plugin:
* A ColorHelper to map a few function of KColorSheme and making
it possible to actually work with colors in QML. The need
emerged from trying to port Plastik to QML which makes strong
use of color shading.
* A DecorationOptions class which is a wrapper around KWin's
KDecorationOptions but in a more useable way for QML. The
various options are provided as properties and the value of
the properties changes automatically depending on whether the
decoration is active or inactive.

Aurorae itself is not yet adjusted to these changes, but it
should also be adjusted as some of the options are currently
exported in the factory and the factory is injected into the
Aurorae QML decoration.

Port to Qt5 new native event filter API

(which makes the whole class obsolete though)

Not tested, for lack of unittests in this framework...

Improve table support

Enable table support

Allow to define table alignment

import ldap settings

Add API to DbIntrospector to query for existing foreign keys.

So far only implemented for MySQL, and going to be used to add missing
foreign key constraints.

Add a task module docker to make it easier to add tasks in task editor

initial code for connection control point handlers, still buggy

Improve operation, layout of section editor dockers

better solution for the paintop settings widget size

Global search in LogViewer

REVIEW: 105586

Simplify color groups, only use the Target

- After some more commits additional data can be added to existing
data sources, therefore it's better to use data that is always
there (required), so that the group of a departure never changes

Add Unicode representation for the provided symbols

Thanks to Olivier Delaune for providing the extended symbol files!
In case no Unicode representation is available, the regular LaTeX markup representation
is inserted.

Use timetable service in the applet, expand items to request more data

- Add expadedStateChanged() signal to departure items and connect it
to the applet to request additional data for the item
- Add data source name and index to DepartureInfo to identify the
item to update at the timetable service
- Fade in the route item if it was added later using the service
- Do not use "auto update" setting anymore in the applet, disable
polling (see last commit)
TODO: Remove setting completely and from the GUI

Adding a final state to the slideshow. Enable load/play of games again.

Pass the new signals on from Picmi

Nice to see that connecting signals to signals is also possible.

KUrl: remove encode_string and friends, deprecated since KDE-4.0 (2005)

Do no depend on kdelibs Nepomuk

* Removed find_package(Nepomuk REQUIRED), and other unnecessary commands
* We do not need to include NEPOMUK_INCLUDE_DIR in the list of includes

REVIEW: 105766

Improve Folder listing in nepomuksearch kioslave

Set the UDS_TARGET_URL for directories.

Patch by Simeon Bird (sbird)

REVIEW: 105158

Avoid a whole bunch of queries in cleanupCollection().

If we have working foreign key constraints, the database will automatically
clean up all child tables for us. The only thing we have to handle manually
is deleting external parts.

Remove load/saving of assistants if dbus isn't present

Because that kills the job class as well.

resource editor: give additional space to the editor widget

And not to the resource list when the window size increases.

acquire documentation

Manage m_preview::deco pointers on plugin juggling


REVIEW: 105721

Focus password input on wrong password in userbar theme

DMS: RemoveAllResources - Emit propertyRemoved for object resources

If a tag is deleted, then all the resources which are connected, to the
tag should be informed that the nao:hasTag relation has been removed.

Split the HTTPFilter tests out of karchive's kfiltertest

They belong with HTTPFilter itself, no point in duplicating that code
into karchive autotests just to test it...

Port the native event filtering to XCB, to fix compilation with Qt5.

Started to port the rest of the code to XCB too, but found a bug in
xcb_sync_systemcounter_name()...

Idle detection doesn't fully work, maybe due to another bug, or maybe
due to the X11/XCB mix in here.

Extend the unit test to also cover removal of wrong foreign keys.

Prepare Akonadi 1.8.0 release.

Don't double-check the mimetype for raw files

Raw files like CR2 and NEF are actually a weird kind of file, NEF for
instance identifies as TIFF, but isn't. So if people rename their NEF
file to PNG, they are screwed, we cannot check the actual file contents
to determine the mimetype.

Link krita.exe only to komain

This is neater, though it doesn't solve the linker issue with icl.exe,
for that everything needs to be compiled with /bigobj anyway.

remove unneeded margin around slideshow toolbar at bottom of slide sort view

more vertical pixels for content :)

REVIEW: 105684

thanks thorsten for review

port to libgphoto2 2.5

Hi,

This ports kamera ioslave to be able to use either libgphoto2 2.4 or libgphoto2 2.5.

Improve comments on the desktop files

Let the comments say what the kcm and the plugin are being used for
instead of just referring the plugin name. Thanks to Ivan Shapovalov for
stirring up the discussion about this and making me think about better
texts.

update CHANGELOG

DIGEST: Predicate library received massive improvements in parsing and stability