Issue 211

fix crash when files are added/removed by external program

This could 'easily' reproduced by opening a large git-based project in
kdevelop with one of the AbstractFileManager-inheriting project
manager. Then switching between branches resulted in a crash sooner or later.

The main culprit was that FileManagerListJob::slotResult was sometimes
called after a the job was killed. KJob::kill apparently does *not*
kill the job directly, hence we need some additional safeguard here.

Furthermore this patch adds some more safety measures against invalid
item pointers in the FileManagerListJob's m_listQueue.

Please test!

fix code completion after multiple occurrences of public,private or protected

this was especially noteable after Q_OBJECT public: since the
Q_OBJECT macro ends with a private:

the reason is that our poor-mans tokenizer got confused by the
colon in PARENT_ACCESS_STRINGS, returning it directly even though
if the colon is preceded by public, private or protected we
don't actually have the single-colon case.

so now we check the full list and then double-check
that we actually have a access string

Set a variable to clear the link interface libraries.

This will only have an effect in CMake 2.8.7, but is harmless until
then.

don't crash on shutdown if debug session is active

Remove duplicated include-directories.

Calling the includeDirectories() member on the parent folder causes a
recursion that goes up until no formerParent is available anymore. Hence
looping over the formerParent's duplicates all include-dirs set in
parent directories.

Its probably not making a difference anywhere, but still seems like a waste
of time.

add a check for cases when markup elemets in TM suggestion and <source> differ.

thank you for reporting the crash, Andrew!
Please fell free to reopen this bug or fill another ones if new issues are coming ;)

Weed out some of the inaccurate duplicate entries in ngcic.dat. Make
some other minor fixes.

This needs to be done programmatically at some point of time. The
matching algorithm seems to have failed to distinguish between certain
different galaxies.

Prevent shortly cancelled loading operation in editor

Due to asynchronous loading, sometimes a picture was loaded in editor, then picture
at index 0 was loaded, then again the desired picture.
Prevent this by disabling the thumbbar until initially loaded.
This bug was probably never user-visible.

Don't crash when showing a slideshow.
REVIEW: 103208

Unbreak svg and video thumbnails

Avoid extra trailing whitespace when copying text

A new 'isRealCharacter' flag is added into the 'Character' class
to distinguish real characters and charaters used as place holders.

The code is a bit ugly now. Should improve it later when the idea and
implementation are proven to be feasible and cause no regression.

Ignore existing resources without any information to be added.

If a resource exists and we do not have any data to add we simply
ignore it. This fixes file indexing if the parent folder resource
already exists.

update the past action only when showing it

fix search in the various pieces

knowledgebase will be installed only if attica is already installed
The author of the commit is Andreas K. Hüttel.
You can find the patch here,bugs.gentoo.org/show_bug.cgi?id=391019

Signed-off-by: Giorgos Tsiapaliwkas

Don't try to divide by zero.

Fixes a crash in Dolphin when pressing a key so quickly after a url
change that there are no items in the file item model yet.

* [core]: remove double filenameTagLabel from kminfo

Use a direct connection for the job's result signal.

This prevents a crash after accessing the deleted job in a slot
connected to a queued signal.

Fix shortcut issue with panels

The KAction instance of the panels is added to the menu instance
now instead of the QDock-actions. It is assured that the state
between the actions gets synchronized. Now it's possible for
the user to apply custom shortcuts and the shortcuts are also
shown in the menu as expected.

Fix restoring expanded URLs

When navigating back or forward in history, DolphinView tells the
KFileItemModel about the expanded URLs which should be restored before
the folder is entered. In this case, the algorithm in the new function
KFileItemModel::setExpanded(const QSet<KUrl>&) does not work. To fix
this, the old function
KFileItemModel::restoreExpandedUrls(const QSet<KUrl>&) is restored.

Unit test included.

make epod work with the new api

turns out the date stuff was not even used at all anyways in this provider!

Just like the password dialog, associate the cookie configuration dialog with
the correct parent window.



FIXED-IN: 4.7.4

Drop InvisibleCollectionFetch in Favor of KDescendantsProxyModel

As the InvisibleCollectionFetch fetch strategy is currently broken, I
implemented a suggestion by Christian Mollekopf of working around the
issues by flatting the model through a KDescendantsProxyModel to fix
crashes in Plasma related to calendars.


FIXED-IN: 4.7.4


REVIEW: 103088

fix shadow quad update, allows to change shadow size with property update
(been OpenGL issue only)
fix TopLevel::visibleRect, broke shaded windows with empty (too big) shadows

REVIEW: 103231

Always use Left-To-Right as the "document layout" in the terminal area

REVIEW:102976

FIXED-IN:4.8

passwordless clock configuration

Use correct selection color for inactive windows

KFileMetaDataReaderProcess: Use a QCoreApplication

Thanks to Patrick Spendrin for the hint. Strange that without the
patch this did result in a crash only with MS Windows and not
with Linux...


FIXED-IN: 4.7.4

Workaround for the DBus type registration problem.

We still need to fix this properly though and determine why registration
in the lib is not enough.

Don't crash on exit.

REVIEW:103202

Merge branch 'keyboardlayouts'

Conflicts:
virtualkeyboard/keyboardshell/keyboarddialog.cpp

make the time setting work

Polish kmsettings.ui

* remove superfluous attributes
* replace HTML texts with Qt rich texts for easier translation and to respect user's fonts
* remove hard-coded font size in policy label
* fix some spelling (don't -> do not, selet -> select)

REVIEW: 103234

Finally fixed bug where kmail lose config.

It's not a bug in template not in kconfig not in ....
It's tab which uses kcfg, widget is not updated to config before we show tab (call a showevent)
So if we show just a tab (for example account change a item and save we will save status
from widget not updated => config will not good)

Perhaps it's a bug in kcfg but this workaround will fix all pb with template/editor config

in findArticle(), add a crash guard in case the articles map is empty.
MERGE: 4.7

Fix regression on number of column display on Inbox and No Context

- We have reverted the change in columnCount introduced by the
modelReset handling and now we return the sourceModel columCount when
the parent is not valid. This change was here only to satisfy the test
but introduced a regression. Turns out it was a behavior mismatch
between QStandardItemModel and our own models regarding columnCount,
so to compensate that we introduce MockModel in this patch.

- MockModel return the correct number of column after clearData was
called. QStandardItemModel recreate the root node when clear
is called. The number of column on this root node is 0 by default. To
fix that we added clearData to clear the model, set the column number
and after that send the signal resetModel.

Fix action which works with uniq item

Force use of Calendar API version 2 (bug #287549)

We don't support the new version 3 yet

Synchronize properly contacts' birthday (bug #287552)

Ensure that audio thread is deleted after playback completes

Forward port of 4.7 branch 35f2f2ab913c3ce8792f3ddb0086c16140f9d5f4

ppt: Fixed a crash in setEnhancedGeometry - complex data related.

TODO: There's something wrong with complex properties, because the test file
was crashing only sometimes. Another workaround might be needed because some
of the old MS Office versions is messing up the complex data.

fix bugs in right-to-left mode where if the master cell of a merged area is outside the paint area, the cell contents get drawn at an incorrect position

Fix x-value for OOXML charts if the x-value wasn't provided from a sheet-reference but from the internal cache.
Before in such cases we set the m_countXValues to the correct value but still added the empty value to our m_domainValuesCellRangeAddress list and later wrote two chart:domain's for the x-value where the first one was empty.
That doesn't only violate the standard but also lead to wrong (aka empty) values for the x-dataregion in such cases what lead to all kind of interesting side-effects.

Fixed updates of the outline of the duplicate paintop

We do not paint outline when it is disabled in the config

Don't add the same markers to the collection

This fix makes sure that markers that have the same content are not added to the
collection it it already contains a marker like that. Instead use the exiting.
marker. This fixes the problem that copying did create multiple markers with the
same content.

Fix displaying of axis-labels if they would overlap.
Looks as that fix for bug 4179 was wrong and should never have been landed cause it completely breaks displaying of labels and ticks on the axis if the labels would overlap. In such cases we only displayed the first label+tick but completely ignored all following ones. Now we only skip the label that would overlap and then display only each e.g. 2th label while still drawing all ticks as expected. The proper fix for bug 4179 was landed later. So, no new regressions :)

Fix hang in scratchpad

Use QObject to do the memory management of the KisDefaultBounds object,
this time. We cannot use pass-by-value because we have a subclass for
KisDefaultBounds after all.

Fix crash due to uninitialized value

In case there was not fontRef it was uninitialized which could
result into a crash depending on what the value was e.g. a negative number

Fix missing images in groups

o use libmso to handle pictures
o fixes missing borders around pictures
o adds features from libmso like black and white mode

Known regressions: exposing more issues with z-index similar to bug 286607,
as z-index is not handled at all in the excel filter.

Fix position and size for to-cell-anchored charts in 2000/2003/2007 Excel documents.
This changes de-facto all Excel-documents that displayed charts before.

Show planned start/finish by default

Fix use left- rather then hcenter-alignment of the legend labels just like OO.org and MSOffice do.

Correction: Avoid suboperations pointing on unused category when all categories are deleted

Fix the case that only the first series defines a chart:domain.
ODF specifies that in such cases we have to take over the defined x- and y-dataRegions to all following series which don't specify an own chart:domain. This fixes some more 2000/2003 bubble and scatter chart documents.

Allow selecting no country in the Amazon store

This makes the service stop popping up on startup, asking for the
users location. That issue has been reported several times since
our beta release, so adding two more strings late is hopefully
justified.

Fix volume control not working.

QA fail: should have been spotted in review and integration testing.

Fix playlist import bug because of one stupid char

Visual changes to bottom toolbars.

Changes:
- Align the dockwindow toolbars in all situations.
- Make all bottom toolbars 36 px high.
- Refactor MessageArea.
- Put a border around the bottom toolbars. Using QPalette::Shadow for border color.


FIXED-IN:2.5

Try to prevent gsm connection access technology change from freezing
plasma-desktop for a few seconds.
There are some other changes for wifi connections as well.

Same for denying the request

Use explicit constructors
krazy: Make all C++ class constructors that can be used with only one
required argument 'explicit' to minimize wrong use of the class.

Refuses to create VPNC connections without user or group info.
vpnc-0.5.3 refuses to connect without those info:

https://bugzilla.redhat.com/show_bug.cgi?id=531876

When it supports that configuration we can remove this validation check.

Fix contact accept request

Don't export private methods publicly

Use title instead of URL when adding application shortcuts

REVIEW: 103086
REVIEWED-BY: adjam,fritz_van_tom

Add the correct title to the item

prevent KGpg to endlessly loop while trying to decrypt a detached signature

This can't work, so there is no value in trying it.

Fix the progress widget hiding immediately after being shown, the second time it is shown.

KCrash must be initialized after KUniqueApplication is started, to avoid KCmdLine to parse its arguments before that.

P.S.: While I do appreciate the contribution and I think the patch was really useful,
it would be awesome if those changes went through review first. If they went through and I forgot
about it and didn't spot the problem earlier, feel free to hit me with a stick instead.

Fix the unfortunate warning in the think() method of the btcharacter class


Fix the "qt4/QtCore/qvector.h:339:3: warning: assuming signed overflow does not
occur when assuming that (X - c) > X is always false" warning by using the gcc
Diagnostic Pragma

It was important to address because otherwise cdash keeps spamming with this
every single build (currently every single day) which is not nice. On the other
hand, if we filter these emails out, we lose the main purpose of cdash which is
being able to catch the build errors and warnings as soon as possible even
before the users start reporting those. Say, we lose the quality to a certain
excent. Hence, fixing.

Please read the following report for further details:
https://bugreports.qt.nokia.com/browse/QTBUG-5915

Use the hash of the filename instead of just the filename so invalid characters don't cause it to error out

Sanitize QGitRepository cleanup semantics

Before, various things would cause the pointer to become dangling
and git_repository_free to be called multiple times, such as:

* Using the copy constructor
* Using the functions that return a repository reference,
like QGitObject::owner()

Now we use a smart pointer to handle the cleanup, and unless we
explicitly tell it to, QGitRepository will not take ownership
of a pointer passed to the constructor.

c++2011 support: proper type deduction in auto range-based-for

for c-arrays we take the element type
for all other types we look via ADL for begin(listType)
and then dereference the return type of that function

See 6.5.4 in the C++2011 spec

implement parsing heartrate data from gpx files recorded using garmin device

Restore the last used activity.

Also improves initialization: When no activity is to be restored,
the loading of the marble widget starts soon after the activity view
is displayed (and not when activating an activity as before).

Track opening (kml/gpx) in the tracking activity.

Improve histogram painting with single color mode (L or R or G or b or A) to render pixmap content by the same way than All Colors mode, to be homogenous.
It's more beautifull like this no?
Contify, polish, fix coding style, as usual...

update the plasmoid slider when the brightness changes (eg. via keyboard shortcut)

Move edit bubble into its own file

Also make the sizing fully dynamix, just set editBubble.iconSize, this
works fine with minimal 24px. Below that value, it will be too hard to
hit anyway.

Folders Panel fixes

The following functionality from Dolphin 1.x has
been ported to the new view-engine:
- Allow expanding/collapsing of items
- Automatically select the current item
- Context menu for items

Related improvements to the view-engine:
- Make the expanding/collapsing interface already accessible
in the base classes KItemModelBase and KItemListView. If
no expanding/collapsing is supported at all by derived models
(which is usually the default case) simply not reimplementing
those 3 methods is sufficient and it does not introduce an
additional complexity like in QAbstractItemModel/QModelIndex.

- Automatically handle the expanding/collapsing in KItemListController.
This also includes the key-handling, which is quite special for
expandable items.

- Don't let KItemListView automatically scroll to the current item
if the current item got changed. The automatic scrolling should
only be done if the current item has been changed by the user.
Hence this functionality has been moved to the KItemListController
which currently only triggers the automatic scrolling if the current
item has been changed by the keyboard (we might extend the usecases
later if required).

* In KIO::Scheduler attempt to find and use the window-id from the top most
level window so that the ids used will not be from temporary short lived
windows such as file dialogs.

* Set the window widget when calling KIO functions in KFileDialog and related
classes so that password information is preserved for the entire life of the
application from which the file dialog is launched instead of a short duration.


FIXED-IN: 4.7.4
REVIEW: 103226

Do not block requests for a password prompt from two different windows unless
the request is for the same key (read: host and port#).

REVIEW: 103245

(cherry picked from commit d82c98d103ec909a6ad4a1cc8673c58a26a853c1)

- Save and restore invalid host name enties for manual proxy configuration.
- Properly save and restore the display flag state for showing protocol
in the manual proxy configuration edits.

docx: List style - Inherit selected text-properties of the paragraph mark.

* The text-properties of the paragraph mark are below text-properties
of the list style in the hierarchy tree. Apply them properly before
removal. We can not save them as text-properties of the paragraph
style because they don't alter formatting of text chunks.

* Initialize the ParagraphBulletProperties instance properly.

* A numbered list in MSWord inherits both Boldness and Italics.

Consider this patch as addition to the following commit, where the
inheritance tree was broken:
docx: Write text-properties only in case of empty paragraphs.
commit 04e59e47bb8d67188078946877edb0d5bd3d9ef3

Made bubble and scatter charts working in the 2000/2003 filter.
Currently we only support formula references and not chart data caches (same like OO.org/LO) but this commit includes the code for making chart data caches working. It's deactivated for now till more testing shows it works as expected.

docx: Automatic numbering support.

* Using the combination of text:continue-numbering and text:start-value, which is fine for
simple docx files. To support interferrence of numbered list at the same level with
separate numbering the text:continue-list support is required.

* Stopped using the KoGenStyles::AllowDuplicates parameter when inserting a list style into
the styles collection.

* Added support for the w:lvlOverride element.

TODO: Numbered lists inside tables. In MSWord, the automatic numbering is applied in a
table column. Each column has a separate numbered lists. The filter is OK, waiting the
layout part to test.

PlanWork needs to get at the default schedule

allow adding the tags for read only files

initial zotero support

pptx: Workaround for text colors inheritance before proper color scheme support.

There's a lot of slides where the text is not visible because text color equals
the background color.

* Ignore text colors set by slideMaster/slideLayout in case the color scheme
changed in slideLayout/slide respectively. Always use the color scheme defined
by slideLayout when dealing with defaults because there's a better chance the
text is going to be visible.

FIXME: Update fo:color in styles prepared while processing the p:txStyles
(Slide Master Text Styles) element when a color scheme override is detected.

Make rdf configurable

Some apps, like Krita, are KoDocument-based but don't have any use for
rdf, so make it configurable. This uses a config key which is set to
true for Words only (since only Words supports rdf in its gui for now).

Should save some startup/document creation time as well as memory, by not
having to create all the soprano model stuff.

Fully rework the income & expenses widget

Allow going back and forward in Amazon store.

Thanks to Google Code In student Nikola Miljkovic.

A patch with some cleanups from me follows shortly.

Give the Amazon store navigation the same design as in the file browser

consistency++;

Make adding a presence message easy

Clicking the combobox will turn it into a KLineEdit (indicated by a "typing" cursor), losing focus will turn it back to combobox. The user can still open the combobox dropdown by clicking the down arrow.

Reviewed-by: David Edmundson & Dario Freddi
REVIEW: 103170

here we are, rekonq ftp remote sync done!

With this commit, I think we reached the "sync" status with remote ftp
sites.
This means we basically have a first sync feature and we can heavily
test it to eventually add more options in the future (webdav?
ownCloud? firefox Sync? etc...)

Merge branch 'add-contact'

REVIEW:103203


Signed-off-by: Dario Freddi

Handle multi-account requests with the same contact Id as if they were one, and authorize them altogether

Report error message on VPN activation failure.

here we are, rekonq ftp remote sync done!

With this commit, I think we reached the "sync" status with remote ftp
sites.
This means we basically have a first sync feature and we can heavily
test it to eventually add more options in the future (webdav?
ownCloud? firefox Sync? etc...)

Share URL by mail action

This is heavily based on Andrea Di Menna's patch on reviewboard.
Thanks :)

REVIEW: 102674

Show user and group names in vpnc authentication dialog. This dialog is
used when NM asks for secrets.

GCI Task: Middle Click a Bookmark Folder to Open Folder in New Tabs
Made by Hüseyin Zengin, GCI student. Thanks !

REVIEW: 103206
REVIEWED-BY: me

option to filter for events and/or todos

Apparently, desktop computers report having no A/C plug at all. (Maybe it doesn't count
power supplies). At any rate, don't show the plug message if the list of plugs is empty.

Add a function for getting the time of the last cache update.

Instead of just showing a blank view when no updates are available, show a little
message in the window saying that the computer is either up to date, or has not been
checked for updates in a while, and advise accordingly.

Add version tag rules for kpat.

Old cvs2svn tags still need work,
but I will probably do it as postprocessing.

Add rules for kpat documentation.

Implement a mechanism that allows a proper matching of the imported transactions.

It's the same mechanism that is used by the QIF importer. The bank id is composed from the transaction date, a hash that is generated based on the
contents of the csv line and an index to avoid generating the same id twice during the same import.

Allow QGitCommit to pass as QGitObject

Implements the relationship "a Commit *is* an Object".

QGitCommit inherits from QGitObject, in the same way that git_commit
conceptually inherits from git_object in C.

Because QGitObject stores a pointer to a git_object, reinterpret_cast
is needed to convert between the two.

A function is added to turn a QGitObject into a QGitCommit, if the
object is a commit, otherwise a null object is returned (analog to
dynamic_cast).

optimize: take min to prevent useless repeated iteration

TileLoader: don't load all available map themes into memory; don't reload changing map themes on own behalf

Currently, a TileLoader instance loads *all* available map themes into memory.
Besides consuming memory needlessly, this leads to slow startup times due to e.g. parsing and to some test cases being slow.
However, a GeoSceneDocument gets already loaded by MarbleMap/MarbleModel.
Therefore, the TileLoader in the TextureLayer could get its GeoSceneTextures from the currently loaded GeoSceneDocument instead of keeping private copies around.
This patch does exacly that.
As a result, the map appears much earlier than before, and some test cases execute virtually instantaniously.

Moreover, when the TileLoader replaced its private copies when the map themes changed on disk, it used to crash Marble, e.g. when deleting a map theme.
Therefore, this feature is now removed from the TileLoader.
It should be implemented in MarbleModel such that the whole dataset gets reloaded.

The ElevationModel now passes its GeoSceneTexture to its TileLoader instance.

Apply no-flicker hack to all our apps

This avoids painting the background before the declarative UI is
rendered on top of that, saves painting cycles on startup and removes
initial flicker when the View is shown, but before the QML UI is loaded
and painted.

See Robin's blog for an explanation:

Performance optimization in resource identification.

In case only a single identifying property exists we get a much much
much much faster query when avoiding all the optional and filter
terms.
Since this is the case for email identification this optimization
does actually make a difference in email indexing.

Ignore existing resources without any information to be added.

If a resource exists and we do not have any data to add we simply
ignore it. This fixes file indexing if the parent folder resource
already exists.

make the calls to ksmserver async. dbus will queue other calls while ksmserver is budy for us.

this way window management doesn't stutter when stopping/starting activities.

Performance optimization in resource identification.

In case only a single identifying property exists we get a much much
much much faster query when avoiding all the optional and filter
terms.
Since this is the case for email identification this optimization
does actually make a difference in email indexing.

Replace generic payload UID by UID recevied from Google when a new object is created.

When a new object is created, commit changes and then start an Akonadi::ItemModifyJob
to update the newly created item's payload (not possible via changeComitted()).

This way UID of the Item is in sync with the one on Google immidiatelly after the Item
is created.

improve split the taglist when search, not also works if there are no or many spaces after the comma

BUG: Better performances during import of multi files by applying "search & process" rules only at the end

Swap planned effort up till now with more useful total planned effort

Stop polling like a nutter, also fix presence message updating.

Optimize recursion rules for version branches/tags.

Now I include /KDE_\d and /KDE/\d in the regex, so it doesn't try matching
work branches, which are either irrelevant or already recursed-into
by other rules.

Avoid crash from a poorly phrased reply from a server.

Some "servers" send a 353 with no nicks, which causes an attempt
to add an empty nick to the channel. This inverts the logic to avoid
complex fallthrough with an empty nickname.

Add some checks to prevent crash when PolicyKit denied connection
editing.


(cherry picked from commit c5beec96d986d5bc3eb40766594cbc1ec5bd68e5)

new Icon for words and improuvement on others

simplify histogram type handling to compute on region or full image data form image editor :
no need extra button to switch from region to full image. This break gui layout on right sidebar when a region is selection from canvas.
In fact histogram switch automatically when user set/unset a region.

Colors tab from right sidebar : display RGB histograms in 3 separate diagrams for better comparison, channel by channel.

general cleanup of the codefolding code

- const& where applicable
- const methods where applicable
- less copies where needed, foreach e.g. does an implicit copy already
- pass const& instead of pointers where applicable
- reuse existing code, esp. for the decrement/incrementBy1
- less copies by using foo& = bla[x];
- introduce temporaries instead of repetitive calls to bla[]
also makes the code nicer to read
- give saner name to some temporaries, instead of 'tempFoo'
- some more assertions to make sure our assumptions on non-empty lists holds
- probably more

Added a small test which exposes a bug in storeResources.

The patch which added a return value to storeResources completely broke
indexing. I did not find the actual bug yet but this test at least
exposes the buggyness of the result propagation through DBus.

Without this additional test one had to look at the test output to see
that something is wrong (hint, hint). Now it actually fails.

simplify opengl shadow building code

REVIEW: 103236
(cherry picked from commit 9ff807b192313c01d2e4d77a2db791bd7b53b680)

Now we change color text when resource is offline => red or broken =>gray

I can't make it configurable in 4.8 because we are in string freeze.
Will do in 4.9

Added the KoXmlWriter::toString() method to enable printing the content of the writer for debugging purposes.

That is a rather useful thing to have at least for the xls-filter which writes direct to the Tables API. This makes it easy to have a look at the generated XML without going through the saving-code (which is rather broken for charts and therefore not that useful when debugging what XML was generated when reading a xls document).

Refactor NAMES processing in Channel.

This gets rid of the convoluted list-of-lists approach to
handling NAMES messages and the associated state tracking
members, and instead processes a single list in FIFO mode.

The processing code has also been optimized for the common
case of the nick queue being empty and to avoid requesting
unnecessary nicklist resports, which occurs e.g. on every
nick change or part when processing is kicked off to make
sure the channel is up to date.

Add kde4 and kpat_solvers work branches to kpat.git.

kpat: move documentation rules before work branch rules.

Just for readability; no semantic change.

ktuberling: add version branches and documentation.