Issue 267

Fix double deletion in hideFunction.

Never ever 'cache' the end iterator, as it might get invalidated
after a call to erase.

Improve the heuristic in framePerIndex to work better with BLAST
dirfiles.

instantiate runners in the GUI thread

This should finally privide a workaround for QTBUG-15004.
Networked plugins seem to work on the desktop under Qt 4.8.4, under Harmattan with Qt 4.7.4(?) and on Maemo 5 with the buggy Qt 4.7.0.

Fix collision detection and visibility check.

Visibility must take size into account, not just the center point.
Reusing the calculated positions for that (invisible = no positions)
Collision detection must work on uptodate item positions.

To preserve re-entrancy with RawDecodingIface, move all private items from ActionThread to Task. Do not share ActionThread::Private with Task.
Code is very similar than digiKam BQM core, and same fixes must be applied to DNGConverter.
CC

Don't ignore mouse movements on the annotator when not on the locked item

REVIEW: 107726

Dont crash trying to add an empty list:
Filtering for mimetype is not appropriate in the core of the model.
As this seems to be about filtering out invalid entries, move it to the Controller.

Fix numbering issue with BQM tab ID when one queue is removed
CC

apply patch #75892 from Johannes Zarl

FIXED-IN: 3.0.0

Fix "tagspath" handling for kipi-plugins.

E.g. a kipi-plugin can now set a tagspath "Places/USA/New York",
and kpa will correctly add the places "USA", and "New York", make
"New York" a sub-category of "USA" and set the tag "New York" on the
image.

Fix crash if asked to index invalid pdf document. Fix is
as suggested in the poppler-qt4 example.

fix kimpanel shadow, use kwin shadow if possible

here we copy the dialogshadows from kdelibs since it's private.
maybe replace it in the future.

Added setIgnoreExplictFocusRequests to correctly fix bug# 306714.
See https://git.reviewboard.kde.org/r/107048/.


REVIEW: 108017

Fix infinite recursion from resizeEvent

Calling QWidget::render() from resizeEvent() was a bad idea:
QWidget::render() activates all layouts of the window owning the widget
to paint, causing KMessageWidget::resizeEvent() to be called again,
starting an infinite recursion.


REVIEW: 107835
FIXED-IN: 4.9.5

KSNI: fix IconThemePath support

IconThemePath is used by a Canonical Patch to enable all Qt apps using
QSystemTrayIcon to transparently provide a SNI with icons exported into
a temporary path. Hence the lack of support breaks icons for all Qt apps
on Ubuntu.

Fix:
- in the dataengine export IconThemePath
- in the systray protocol pick up the value and forward to QML
- in QML set the themePath accordingly on the IconItem
(requires changes in runtime)

https://bugs.launchpad.net/ubuntu/+source/kde-workspace/+bug/1088772


REVIEW: 107702

OptimizedByteArray: Ignore the empty parts when the bytearray is split

Not ignoring the empty parts resulted in an extra '\' at the start of
the string when converting it back to one byte array. This completely
screwed up the real time indexing.


FIXED-IN: 4.10

Fix KDirLister's rootItem not being updated when renaming the directory.

The root item kept having the old URL.

Thanks to Emmanuel for the bug investigation, and to Frank for the unittest!


FIXED-IN: 4.9.5

Do not block OpenGL 2 when build for gles due to driver recommendation

Let's assume a user knows what she is doing when she selects kwin_gles
instead of kwin. Also in gles there is no fallback to OpenGL 1 possible
so blocking is not the proper solution in the first place.


FIXED-IN: 4.10 RC 2
REVIEW: 107824

Fix setting url userinfo in xmlhttprequest.


FIXED-IN: 4.9.5

Do not clear UserActionMenu's Client after the menu closed

The Client is still needed as the invoked action might be delayed by one
event cycle to work around a crash if the operation causes the deco to
close.


FIXED-IN: 4.10 RC 2
REVIEW: 107823

Fix Bug 287829 - inline rename multiple files does not honour
sort order


FIXED-IN: 4.9.5
REVIEW: 107718

Fix handling of disconnected outputs in updateOutput()

When an output is disconnected, we receive RRScreenChageNotify and
RRNotify_OutputChanged events, both causing the config to be updated.
There was an issue with currentMode being still set in RRScreenChangeNotify,
however isConnected being false, thus we had currentMode pointing to an
invalid mode. This is no fixed by not updating currentMode of disconnected
output.

Together with previous commit, this should eliminate unnecessary property
change notifications from KScreen::Output.

Fix pager window dragging and icon

the draggable region calculate for X and Y axis should use the same
algorithm. width +/- rectwidth/2


REVIEW: 107828

activate layout, no idea why doesn't happen implicitly


FIXED-IN: 4.10
REVIEW: 107851

Add Dialog warning when huge amounts of text is about to be pasted

Currently there is no way to stop an accidently paste into the terminal.
This patch adds a dialog when 8000+ characters are pasted asking if
the user really wants to do this. At most the user will see this once
as there is a "Don't show again" box.


REVIEW: 107570
FIXED-IN: 4.11
GUI:

todoview: Make deleting of incidences work

Start to fix Bug 311994 - IMAP quota isn't displayed in some cases

Fix when it's overquota

Correctly count items flags in virtual collections

REVIEW: 107715

in createCompleteThread(), add a crash guard in the case there is no
displayReference, like when the server connection is lost.


FIXED-IN: 4.9.5
MERGE: 4.10, master

in showHdrs(), consider the case where f_older is 0.
prevents a crash.


FIXED-IN: 4.9.5
MERGE: 4.10, master

Fix initialization of PostgreSQL database

REVIEW: 107776

Several compiler warningy fixes

Submitted by Mohammed Nafees, completing
a Google Code-in task.


REVIEW: 107825
DIGEST: Google Code-in contribution

Fix Bug 311534 - "Serverside subscription" dialog is always opened in

the background

FIXED-IN: 4.10

Fix saving of png's containing annotations

For some weird reason, the iterator was never increased.

fix resizing columns when grapping in header rows giving weird results

Fix saving of png's containing annotations

For some weird reason, the iterator was never increased.

add functionality to remove blacklisted resources

Workaround bug 311940: Plan crashes when typing a text in the filter textbox before the textbook is fully loaded when selecting a contact from the adressbook

Disable function to select a person from the kde address book. Seems to be an akonadi crash.

fix resizing columns when grapping in header rows giving weird results

MetaProxy::Track::playableUrl(): don't return uid url

...when the underlying track is not loaded (yet). We return false to
isPlayable(), so we shouldn't be returning anything either.

URL may be something like amarok-sqltrackuid://2f9277bb7e49962c1c4c5612811807a1
and Phonon may choke on such urls trying to find a codec and causing
a hang.

BUGFIXES:
* Fix hangs and inappropriate messages when trying to play a track from
a saved playlist that has been deleted in the mean time.


FIXED-IN: 2.7

Fix 1 frame offset in image / color clips, fix changing duration of image/color clips

LastFmService: fix track recreation on startup

...and add a warning to ServiceBase so that we know quicker next time.

BUGFIXES:
* Fix Last.fm streams not being correctly recreated on startup.


FIXED-IN: 2.7

Fix crash when opening project with missing clips that had markers

initial port to libkipi-2.x

Initial libkipi-2.x support courtesy of Sando Mani

use camera-web icon instead of webcamreceive



webcamreceive is (only?) provided by kopete, so we can't assume it
is present at runtime, so use camera-web instead.

Fix DVD wizard producing broken menu in 16:9 format: http://kdenlive.org/mantis/view.php?id=2884

NetworkAccessViewer::requestFinished(): prevent crash

Let's hope it won't crash somewhere else..

BUGFIXES:
* Fix crash in Network Requests Viewer.


FIXED-IN: 2.7

SqlCollectionLocation: do not stop transfer when some files are already at destination

This happens when you want to import a big tree of tracks at once and some
tracks are already present in the destination collection. In this case
TransferJob's copy subjob fails with KIO::ERR_FILE_ALEADY_EXIST and causes
entire transfer to complete prematurely.

BUGFIXES:
* Fix existing files preventing complete transfer of tracks to collection


REVIEW: 107841
FIXED-IN: 2.7

Fix moving of splitted clips when using CTRL + A: http://www.kdenlive.org/mantis/view.php?id=2830

Fix crash in torrent loading code under some circumstances

Fix queue order not reflecting reality in some circumstances

Disable notifications in Busy status

This patch disable all visible KNotification for accounts in Busy status.
So now Busy status in Kopete is real Do not Disturb / Busy status without any notifications.

handle known GnuPG hints for all transactions

Otherwise e.g. changing the ownertrust of a nearly expired key will fail.

FIXED-IN:4.9.5

fix changing passphrase when GnuPG agent is not running

The password would only have been accepted if "cancel" on the dialog was
clicked.

FIXED-IN:4.9.5

rework the parenting of the transactions in the key info dialog

Otherwise the passphrase dialog that those transactions may show will be locked
by the key info dialog which is modal itself.

FIXED-IN:4.9.5

Fix a few application-launcher related crashes.

fix a crash in box2d (that also crashes kolf)

with some data extracted from a kolf course, box2d calculates a
negative area, that is not possible in Real*Real vector space.

fixed using the abs area of each triangle.

Also filled a bug in box2d (I have had to use okteta to bypass their
captcha).


FIXED-IN: 4.10
REVIEW: 107739

fix a crash in box2d (that also crashes kolf)

with some data extracted from a kolf course, box2d calculates a
negative area, that is not possible in Real*Real vector space.

fixed using the abs area of each triangle.

Also filled a bug in box2d (I have had to use okteta to bypass their
captcha).


FIXED-IN: 4.10
REVIEW: 107739

kde-projects: Improve error message somewhat.

This improves the error message encountered with mal-formed XML in the
kde-projects database, at least a little bit.


FIXED-IN:1.16

Split up stopAction into a menu and an action

This allows to configure the shortcut for the stop-all-jobs action while
keeping the menu to stop individual jobs. Unfortunately it seems like
the KDE shortcut config dialog does not support shortcuts on KActionMenu.

Adjusted the texts where necessary, possibly a new icon for either of the
two would be good for the toolbar.

The main reason for making the shortcut configurable is that the current
default is somewhat annoying since many other things in the IDE use Escape
to exit some popup or so (find in kate for example) and thus it often
happens that one tabs Escape once too often and aborts a build etc.

- Add new popup graphics to the web popup

training screen: remove the dedicated pause button

Explicetly pausing the training session is almost never necessary since
the application handles that pretty much automatically. In the rare
case the user wants to do so anyway he still can use the menu button,
the only button remaining now, which also interrupts the session.

The message label indicating a paused session now has a pause icon to
be more visual distinctive.

Add feature to copy parts of the window status bar:
X copies the X coordinate into the system clipboard
Y copies the Y coordinate into the system clipboard
^c copies the window statusMessage into the system clipboard.

Add setter/getter for visibility of pointer and data types.

This resolves the ugly deprecated solution where each data structure
took care of the visibility itself and conforms with the recent changes
to set type information globally for the document.

Planet order in MapViewWidget has been fixed. Now it's language-independent

Batch Queue Manager improvement : add Queue settings included Assigned Batch Tools list save and restore feature. Concept is named Workflow in GUI.
By this way, end users is able to apply prefered and fully customized settings already used in previous queues processed in BQM. A control panel dedicated
to manage worflow list have been add to main BQM window. Workflow settings are saved in dedicated xml files from your home directory (into KDE config dir)

FIXED-IN: 3.0.0

nepomukindexer: Add a --data option

This mode extracts the SimpleResourceGraph and prints it to the stdout.
It is useful in the cases when Nepomuk is not running and one wishes to
view the indexing results.

Added Elarun kdm theme.

FFmpegExtractor should index mp4 files, instead of TagLibExtractor

https://git.reviewboard.kde.org/r/107806/diff/3/

Use Elarun as default KDM theme.

Add mapping for networkmanagement_configshell

FileIndexer: Give plugins better control over indexing

Plugins could initially only supply a list of mimetypes which they
support, and they would then be called when a file of that mimetype was
found.

Now, they can implement a function shouldIndex which allows them to
control exactly when they should be called. Both the old and the new
mechanism are supported. Plugins need to report which mechanism they are
using.

Also implemented an ExtractorPluginMangager to handle getting the list
of plugins to call for a particular url and mimetype.

Port Input Window handling for Effects to XCB

REVIEW: 107817

Make the distribution list a little more user friendly

* Sort Linux Distributions by name alphabetically
* Make some displayed names simpler

No changed is made to the actual values, so this commit should
be regression free.

REVIEW: 107655

Rework applethandle

- moves to the right
- gets a set of buttons
- grows out of the frame

Also:
- quicker syncing of new position
- less visible placement indicator
- applets are fully visible when unlocked
- renaming of categoryTitle to appletHandle

Show a live preview in the KCM

don't register the icon as a dragable with the applet

this causes events to be intercepted which prevent launching when
the applet is movable.

close the connection as soon the app is closing

if the connection is closing on thread deletion, the sql plugin is already unloaded, resulting in a crash

support brightness > 1 for XRender backend

REVIEW: 107854

FileIndexer: Support filtering based on mime type

The option to do this has been implemented in the KCM for some time now,
it has however not implemented in the file indexer itself.

Define icon for attachmentMenu action

This avoids having an "Attach" button in KMail composer toolbar which
looks smaller than the other buttons.

Start to implement insert cell before/after

trojita have addressbook

Notify parent virtual collections about item changes

When an items is modified, notify it's real parent collection
as well as all virtual collections the item is linked to.

REVIEW: 107722

Don't display two dialog when an error happens.

Incidence changer supports error dialogs.

todoview: Honour the ctrl modifier when adding new to-dos.

Back in 4.4 this worked, it makes the new to-do be a child of the
selected to-do.

todoview: Don't crash if the modelindex points to a collection.

The underlying model can have collections. I could just filter them
with another proxy model, but my current solution is more performant
since it avoids that.

Introduce kowidgetutils library and put KoGroupButton in it

The KoGroupButton's code is untouched (except for the EXPORT name) and comes from Jean-Nicolas Artaud - see https://git.reviewboard.kde.org/r/107530 so please do not report issues related to it here. In that patch KoGroupButton was put into kowidgets library what's suboptimal because of dependencies - no point to depend on kotext, etc. to use one unrelated widget.

This change is s small step to increase modularity.

More classes to come here, including improvements to KoGroupButton.

REVIEW:107842
DIGEST:Calligra increases modularity step by step

Port KoProperty editors for Date, Time & DateTime away from Q3 and enable again

REVIEW: 107792

thanks to jarosław for review

Make it possible to move through favourite presets with the keyboard

Default shortcuts: left and right.

(Because the number shortcuts are taken by the blender-type canvas
manipulation, zoom, rotate etc.)

This patch, Add "Book-->Insert cover image" to menu and lets users to select an image
as their cover ebook. This image saves in document at Picture directory as coverImage.* .
This path is approved by ingwa.

Added "Opened Tags" and "Closed Tags" as filters

>From Alessandro Russos patch description:

Marko () asked me if I could extend the filter in the
tag view. In the old implementation the filter had 3 option: All, Used
tags, Unused Tags. With this patch I added two other option: Opened Tags
and Closed Tags.

REVIEW: 107827

Make it possible to move through favourite presets with the keyboard

Default shortcuts: left and right.

(Because the number shortcuts are taken by the blender-type canvas
manipulation, zoom, rotate etc.)

add functionality to remove blacklisted resources

Introduce kowidgetutils library and put KoGroupButton in it

The KoGroupButton's code is untouched (except for the EXPORT name) and comes from Jean-Nicolas Artaud - see https://git.reviewboard.kde.org/r/107530 so please do not report issues related to it here. In that patch KoGroupButton was put into kowidgets library what's suboptimal because of dependencies - no point to depend on kotext, etc. to use one unrelated widget.

This change is s small step to increase modularity.

More classes to come here, including improvements to KoGroupButton.

REVIEW:107842
DIGEST:Calligra increases modularity step by step

Dialog window improvement - 'Enter scheduled transaction?'

The dialog window which pops up when an imported transaction matches a
schedule now contains additional information helpful to the user: payee
information and transaction amount. This helps the user to identify if
the transaction and schedule should really be matched.

REVIEW: 107758

Partial revert "Stub for TranscodeDialog"

This reverts commit 4717541746803cba65685016f7c7384cf7fdc55b.


FIXED-IN: 2.7

When opening project, do not load unused producers at startup, only on demand (when clip is selected), makes project opening much faster

Nick completion in MUC

Add Konversation-like nick completion on Tab keypress


REVIEW: 107773

Revamp syndication plugin interface and add support for torrent elements from namespace (http://xmlns.ezrss.it/0.1/) within the rss item element

"Workaround" cookie management in private browsing mode

>From the note in webpage file:
I'm sorry I really cannot let KIO work as needed in private browsing
mode. The problem is basically cookie related. This way we lose some
features in private browsing mode, but we ensure PRIVACY!

This change cannot be reverted until a proper fix for KIO
(or the right workaround for rekonq) will be found.

Implement the case of a laptop with the lid open and an external screen

Implement the case for a laptop with lid closed and external screen

in progress on light weight

M +- -- in-progress/Extra-Light/src/OxygenSans-Extra-light.otf
D +- -- in-progress/Extra-Light/src/OxygenSans-Extra-light.ttf
C +0 -0 in-progress/Extra-Light/src/OxygenSans-Extra-light.ufo/features.fea [from: in-progress/Extra-Light/src/OxygenSans-Thin.ufo/features.fea - 100% similarity]

Global QML dashboard, improved plugin creation

Add global TimetableMate QML dashboard,
shown if no tabs are opened. Make TimetableMate actions
available to QML, add some other functions, eg.
showDock() to show a dock by name.
Add AbstractDockWidget::mainWidget() to get the widget
which should get focus when showing the dock.

Have the provider type for new plugins chosen before
creating it, in a dialog with some explanations.
Remove provider type combo box from ProjectSettingsDialog.
Autofill user name and email in ProjectSettingsDialog,
if available from KUser, KEMailSettings.

Reload provider after saving a provider project with a
new provider ID, to fix install/preview/GTFS actions, etc.

Tell the user that the provider must be installed,
before using some actions.

Fix GTFS tab restoration after restart by implementing
missing parts in Project.

Make sure we don't screw users system by updating packages without simulate

Use PlasmaComponents.Label rather than Text component.
This will ensure it uses theme font colors and works properly with dark themes

Make Distro upgrade popups don't spam the user and respect the Settings,
and add initial code to check if there is a plasmoid in the tray displaying
updates.

Compile with Qt5.

At least up to the point needed by Akonadi.

Add Feature to automatically download updates (without installing), and make the update logic much simpler

fundamental changes to the responsive design
media statements now go into the main css file

Further speedup IndexedStringNG by using a non-recursive mutex.

Generally, a recursive mutex is always an indication for bad API
design. IndexedString e.g. does lots of obsolete, duplicated recursive
mutex locking which is now streamlined. This gives another 20% speedup
in the index benchmark!

RESULT : BenchIndexedStringNG::index():
11.59 msecs per iteration (total: 1,160, iterations: 100)
RESULT : BenchIndexedStringNG::length():
3.60 msecs per iteration (total: 360, iterations: 100)
RESULT : BenchIndexedStringNG::qstring():
12.94 msecs per iteration (total: 1,295, iterations: 100)
RESULT : BenchIndexedStringNG::kurl():
91.34 msecs per iteration (total: 9,134, iterations: 100)
RESULT : BenchIndexedStringNG::hashString():
2.99 msecs per iteration (total: 299, iterations: 100)
RESULT : BenchIndexedStringNG::hashIndexed():
0.67 msecs per iteration (total: 67, iterations: 100)
RESULT : BenchIndexedStringNG::qSet():
2.41 msecs per iteration (total: 242, iterations: 100)

new exit and logic icons for pairs

Delayed (grouped) repaints after up to 500 ms.

Items downloading e.g. images each trigger many repaints otherwise.

BasicIndexingQueue: Never reindex directories

The directory metadata never really changes. The only thing that changes
is the mtime of the directory. As an optimization we do not re-index a
directory after it has been indexed once.

This also helps us by not removing any nie:isPartOf relations that may
be present in the folder.

Improve the accelerators in the confirmation dilaog

Note, KStandardGuiItem::closeWindow and KStandardGuiItem::close uses the
same accelerator, so here I use a variant of KStandardGuiItem::closeWindow
insteand of itself.

Don't emit property change notification when value did not change

Slightly improves performance on the KCM and fixes potential issues
in the KDED module.

added retina compatible icon support for osx
REVIEW: 107753

A +- -- braindump/data/icons/hi1024-app-braindump.png
A +- -- braindump/data/icons/hi128-app-braindump.png
A +- -- braindump/data/icons/hi256-app-braindump.png
A +- -- braindump/data/icons/hi512-app-braindump.png
A +- -- braindump/data/icons/hi64-app-braindump.png

threading: use raw pointer access when applying sort order

This saves roughly 18% of time in the testSortingPerformance benchmark.

lots of code clean up, somre desktop moves, and a few fixes

More efficient hash erase, since we don't ever have duplicate copies of the hash key. (Meaning we don't have to keep looking for things to remove after we've encountered the first key)

Improve the algorithm to detect font strings

Don't check for bold or italic, consider it the style name. This makes it
a bit more difficult to be able to find what's style name and what's font
family.
Loop words checking where the font family ends and assume the stylename is
the rest until the font size

PS: Why wouldn't they split the fields using ','? :/

Add a test for ItemRepositoryRegistry disk-storage management.

Features tested:
- automatic deletion of item-repository directory for active temporary
sessions
- immediate deletion of item-repository directory for non-locked foreign
sessions
- deferred deletion of item-repository directory for active persistent
sessions

Batch Queue Manager : new Queue Settings option to put processed target files in file source folders.

When configuration change, save it so we can restore it

For now ignore large plain text temporarily for full content index

Unfortunately, there is no easy way to do full content index, and such
large text is not very regular, ignore large file for now. Using readAll
on unknown size file is dangerous for both indexer and virtuso.

REVIEW: 107767

new monitor

M +- -- desktoptheme/air/widgets/monitor.svgz

New wallpapers!